From 99c2355e85dfb7823f0aff50f1d6490d7f9d7ade Mon Sep 17 00:00:00 2001 From: Ankush Mitra Date: Thu, 27 Jul 2023 17:23:23 +0530 Subject: [PATCH] video: driver: remove dead code of uneccessary setting VPP delay In driver num_comv value is coming more than expected due to assumtion of default VPP delay as 2, which is not needed now. Change-Id: Ie24b5b30034cbc465aaa5952d80b6c0811cfe1a2 Signed-off-by: Ankush Mitra --- driver/variant/iris3/src/msm_vidc_buffer_iris3.c | 15 ++++++++++----- .../variant/iris33/src/msm_vidc_buffer_iris33.c | 15 ++++++++++----- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/driver/variant/iris3/src/msm_vidc_buffer_iris3.c b/driver/variant/iris3/src/msm_vidc_buffer_iris3.c index be045c692d..14f4589799 100644 --- a/driver/variant/iris3/src/msm_vidc_buffer_iris3.c +++ b/driver/variant/iris3/src/msm_vidc_buffer_iris3.c @@ -82,12 +82,17 @@ static u32 msm_vidc_decoder_comv_size_iris3(struct msm_vidc_inst *inst) } msm_vidc_update_cap_value(inst, NUM_COMV, num_comv, __func__); - if (inst->decode_vpp_delay.enable) - vpp_delay = inst->decode_vpp_delay.size; - else - vpp_delay = DEFAULT_BSE_VPP_DELAY; - num_comv = max(vpp_delay + 1, num_comv); + if (inst->codec == MSM_VIDC_HEIC + && is_thumbnail_session(inst)) { + vpp_delay = 0; + } else { + if (inst->decode_vpp_delay.enable) + vpp_delay = inst->decode_vpp_delay.size; + else + vpp_delay = DEFAULT_BSE_VPP_DELAY; + } + num_comv = max(vpp_delay + 1, num_comv); if (inst->codec == MSM_VIDC_H264) { HFI_BUFFER_COMV_H264D(size, width, height, num_comv); } else if (inst->codec == MSM_VIDC_HEVC || inst->codec == MSM_VIDC_HEIC) { diff --git a/driver/variant/iris33/src/msm_vidc_buffer_iris33.c b/driver/variant/iris33/src/msm_vidc_buffer_iris33.c index 542ff1c092..a5a8e600ba 100644 --- a/driver/variant/iris33/src/msm_vidc_buffer_iris33.c +++ b/driver/variant/iris33/src/msm_vidc_buffer_iris33.c @@ -84,12 +84,17 @@ static u32 msm_vidc_decoder_comv_size_iris33(struct msm_vidc_inst *inst) } msm_vidc_update_cap_value(inst, NUM_COMV, num_comv, __func__); - if (inst->decode_vpp_delay.enable) - vpp_delay = inst->decode_vpp_delay.size; - else - vpp_delay = DEFAULT_BSE_VPP_DELAY; - num_comv = max(vpp_delay + 1, num_comv); + if (inst->codec == MSM_VIDC_HEIC + && is_thumbnail_session(inst)) { + vpp_delay = 0; + } else { + if (inst->decode_vpp_delay.enable) + vpp_delay = inst->decode_vpp_delay.size; + else + vpp_delay = DEFAULT_BSE_VPP_DELAY; + } + num_comv = max(vpp_delay + 1, num_comv); if (inst->codec == MSM_VIDC_H264) { HFI_BUFFER_COMV_H264D(size, width, height, num_comv); } else if (inst->codec == MSM_VIDC_HEVC || inst->codec == MSM_VIDC_HEIC) {