samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Use hal_verbose_debug() to print msgs which come excessively

Browse Source 
Some of the print messages in HAL module come very excessively.
Use hal_verbose_debug() API to print them.

CRs-fixed: 2405028
Change-Id: I4b4754af65c00edb571de898527026b6183ef15f
This commit is contained in:
Krunal Soni
2019-02-22 15:39:03 -08:00
committed by nshrivas
parent c96a1167f8
commit 9911b44343
7 changed files with 429 additions and 397 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
dp/wifi3.0/dp_main.c
View File

@@ -2609,6 +2609,11 @@ static void dp_enable_verbose_debug(struct dp_soc *soc)
if (soc_cfg_ctx->per_pkt_trace & dp_verbose_debug_mask) if (soc_cfg_ctx->per_pkt_trace & dp_verbose_debug_mask)
is_dp_verbose_debug_enabled = true; is_dp_verbose_debug_enabled = true;
if (soc_cfg_ctx->per_pkt_trace & hal_verbose_debug_mask)
hal_set_verbose_debug(true);
else
hal_set_verbose_debug(false);
} }
#else #else
static void dp_enable_verbose_debug(struct dp_soc *soc) static void dp_enable_verbose_debug(struct dp_soc *soc)

8
hal/wifi3.0/hal_api.h
View File

@@ -43,6 +43,14 @@
#define FORCE_WAKE_DELAY_TIMEOUT 50 #define FORCE_WAKE_DELAY_TIMEOUT 50
#define FORCE_WAKE_DELAY_MS 5 #define FORCE_WAKE_DELAY_MS 5
#ifdef ENABLE_VERBOSE_DEBUG
static inline void
hal_set_verbose_debug(bool flag)
{
is_hal_verbose_debug_enabled = flag;
}
#endif
#ifndef QCA_WIFI_QCA6390 #ifndef QCA_WIFI_QCA6390
static inline int hal_force_wake_request(struct hal_soc *soc) static inline int hal_force_wake_request(struct hal_soc *soc)
{ {

10
hal/wifi3.0/hal_generic_api.h
View File

@@ -1734,7 +1734,7 @@ static inline void hal_rx_dump_mpdu_start_tlv_generic(void *mpdustart,
struct rx_mpdu_info *mpdu_info = struct rx_mpdu_info *mpdu_info =
(struct rx_mpdu_info *)&mpdu_start->rx_mpdu_info_details; (struct rx_mpdu_info *)&mpdu_start->rx_mpdu_info_details;
QDF_TRACE(QDF_MODULE_ID_DP, dbg_level, hal_verbose_debug(
"rx_mpdu_start tlv (1/5) - " "rx_mpdu_start tlv (1/5) - "
"rxpcu_mpdu_filter_in_category: %x " "rxpcu_mpdu_filter_in_category: %x "
"sw_frame_group_id: %x " "sw_frame_group_id: %x "
@@ -1777,7 +1777,7 @@ static inline void hal_rx_dump_mpdu_start_tlv_generic(void *mpdustart,
mpdu_info->mpdu_ht_control_valid, mpdu_info->mpdu_ht_control_valid,
mpdu_info->frame_encryption_info_valid); mpdu_info->frame_encryption_info_valid);
QDF_TRACE(QDF_MODULE_ID_DP, dbg_level, hal_verbose_debug(
"rx_mpdu_start tlv (2/5) - " "rx_mpdu_start tlv (2/5) - "
"fr_ds: %x " "fr_ds: %x "
"to_ds: %x " "to_ds: %x "
@@ -1820,7 +1820,7 @@ static inline void hal_rx_dump_mpdu_start_tlv_generic(void *mpdustart,
mpdu_info->rxpt_classify_info_details.use_flow_id_toeplitz_clfy, mpdu_info->rxpt_classify_info_details.use_flow_id_toeplitz_clfy,
mpdu_info->rx_reo_queue_desc_addr_31_0); mpdu_info->rx_reo_queue_desc_addr_31_0);
QDF_TRACE(QDF_MODULE_ID_DP, dbg_level, hal_verbose_debug(
"rx_mpdu_start tlv (3/5) - " "rx_mpdu_start tlv (3/5) - "
"rx_reo_queue_desc_addr_39_32: %x " "rx_reo_queue_desc_addr_39_32: %x "
"receive_queue_number: %x " "receive_queue_number: %x "
@@ -1863,7 +1863,7 @@ static inline void hal_rx_dump_mpdu_start_tlv_generic(void *mpdustart,
mpdu_info->ast_index_not_found, mpdu_info->ast_index_not_found,
mpdu_info->ast_index_timeout); mpdu_info->ast_index_timeout);
QDF_TRACE(QDF_MODULE_ID_DP, dbg_level, hal_verbose_debug(
"rx_mpdu_start tlv (4/5) - " "rx_mpdu_start tlv (4/5) - "
"power_mgmt: %x " "power_mgmt: %x "
"non_qos: %x " "non_qos: %x "
@@ -1906,7 +1906,7 @@ static inline void hal_rx_dump_mpdu_start_tlv_generic(void *mpdustart,
mpdu_info->mac_addr_ad3_31_0, mpdu_info->mac_addr_ad3_31_0,
mpdu_info->mac_addr_ad3_47_32); mpdu_info->mac_addr_ad3_47_32);
QDF_TRACE(QDF_MODULE_ID_DP, dbg_level, hal_verbose_debug(
"rx_mpdu_start tlv (5/5) - " "rx_mpdu_start tlv (5/5) - "
"mpdu_sequence_control_field: %x " "mpdu_sequence_control_field: %x "
"mac_addr_ad4_31_0: %x " "mac_addr_ad4_31_0: %x "

22
hal/wifi3.0/hal_internal.h
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2016-2018 The Linux Foundation. All rights reserved. * Copyright (c) 2016-2019 The Linux Foundation. All rights reserved.
* *
* Permission to use, copy, modify, and/or distribute this software for * Permission to use, copy, modify, and/or distribute this software for
* any purpose with or without fee is hereby granted, provided that the * any purpose with or without fee is hereby granted, provided that the
@@ -30,6 +30,26 @@
#define hal_warn(params...) QDF_TRACE_WARN(QDF_MODULE_ID_TXRX, params) #define hal_warn(params...) QDF_TRACE_WARN(QDF_MODULE_ID_TXRX, params)
#define hal_info(params...) QDF_TRACE_INFO(QDF_MODULE_ID_TXRX, params) #define hal_info(params...) QDF_TRACE_INFO(QDF_MODULE_ID_TXRX, params)
#define hal_debug(params...) QDF_TRACE_DEBUG(QDF_MODULE_ID_TXRX, params) #define hal_debug(params...) QDF_TRACE_DEBUG(QDF_MODULE_ID_TXRX, params)
#ifdef ENABLE_VERBOSE_DEBUG
extern bool is_hal_verbose_debug_enabled;
#define hal_verbose_debug(params...) \
if (unlikely(is_hal_verbose_debug_enabled)) \
do {\
QDF_TRACE_DEBUG(QDF_MODULE_ID_TXRX, params); \
} while (0)
#define hal_verbose_hex_dump(params...) \
if (unlikely(is_hal_verbose_debug_enabled)) \
do {\
QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_TXRX, \
QDF_TRACE_LEVEL_DEBUG, \
params); \
} while (0)
#else
#define hal_verbose_debug(params...) QDF_TRACE_DEBUG(QDF_MODULE_ID_TXRX, params)
#define hal_verbose_hex_dump(params...) \
QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_TXRX, QDF_TRACE_LEVEL_DEBUG, \
params)
#endif
/* TBD: This should be movded to shared HW header file */ /* TBD: This should be movded to shared HW header file */

11
hal/wifi3.0/hal_rx.h
View File

@@ -2380,7 +2380,7 @@ enum hal_rx_wbm_rxdma_push_reason {
static inline void hal_rx_dump_rx_attention_tlv(struct rx_attention *rx_attn, static inline void hal_rx_dump_rx_attention_tlv(struct rx_attention *rx_attn,
uint8_t dbg_level) uint8_t dbg_level)
{ {
QDF_TRACE(QDF_MODULE_ID_DP, dbg_level, hal_verbose_debug(
"rx_attention tlv (1/2) - " "rx_attention tlv (1/2) - "
"rxpcu_mpdu_filter_in_category: %x " "rxpcu_mpdu_filter_in_category: %x "
"sw_frame_group_id: %x " "sw_frame_group_id: %x "
@@ -2439,7 +2439,7 @@ static inline void hal_rx_dump_rx_attention_tlv(struct rx_attention *rx_attn,
rx_attn->reserved_1b, rx_attn->reserved_1b,
rx_attn->rx_in_tx_decrypt_byp); rx_attn->rx_in_tx_decrypt_byp);
QDF_TRACE(QDF_MODULE_ID_DP, dbg_level, hal_verbose_debug(
"rx_attention tlv (2/2) - " "rx_attention tlv (2/2) - "
"encrypt_required: %x " "encrypt_required: %x "
"directed: %x " "directed: %x "
@@ -2520,7 +2520,7 @@ static inline void hal_rx_dump_msdu_end_tlv(struct hal_soc *hal_soc,
static inline void hal_rx_dump_mpdu_end_tlv(struct rx_mpdu_end *mpdu_end, static inline void hal_rx_dump_mpdu_end_tlv(struct rx_mpdu_end *mpdu_end,
uint8_t dbg_level) uint8_t dbg_level)
{ {
QDF_TRACE(QDF_MODULE_ID_DP, dbg_level, hal_verbose_debug(
"rx_mpdu_end tlv - " "rx_mpdu_end tlv - "
"rxpcu_mpdu_filter_in_category: %x " "rxpcu_mpdu_filter_in_category: %x "
"sw_frame_group_id: %x " "sw_frame_group_id: %x "
@@ -2568,15 +2568,14 @@ static inline void hal_rx_dump_mpdu_end_tlv(struct rx_mpdu_end *mpdu_end,
static inline void hal_rx_dump_pkt_hdr_tlv(struct rx_pkt_hdr_tlv *pkt_hdr_tlv, static inline void hal_rx_dump_pkt_hdr_tlv(struct rx_pkt_hdr_tlv *pkt_hdr_tlv,
uint8_t dbg_level) uint8_t dbg_level)
{ {
QDF_TRACE(QDF_MODULE_ID_DP, dbg_level, hal_verbose_debug(
"\n---------------\n" "\n---------------\n"
"rx_pkt_hdr_tlv \n" "rx_pkt_hdr_tlv \n"
"---------------\n" "---------------\n"
"phy_ppdu_id %d ", "phy_ppdu_id %d ",
pkt_hdr_tlv->phy_ppdu_id); pkt_hdr_tlv->phy_ppdu_id);
QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_DP, dbg_level, hal_verbose_hex_dump(pkt_hdr_tlv->rx_pkt_hdr, 128);
pkt_hdr_tlv->rx_pkt_hdr, 128);
} }
/** /**

12
hal/wifi3.0/hal_srng.c
View File

@@ -37,6 +37,10 @@ void hal_qca6390_attach(struct hal_soc *hal);
void hal_qca6018_attach(struct hal_soc *hal); void hal_qca6018_attach(struct hal_soc *hal);
#endif #endif
#ifdef ENABLE_VERBOSE_DEBUG
bool is_hal_verbose_debug_enabled;
#endif
/** /**
* hal_get_srng_ring_id() - get the ring id of a descriped ring * hal_get_srng_ring_id() - get the ring id of a descriped ring
* @hal: hal_soc data structure * @hal: hal_soc data structure
@@ -529,16 +533,12 @@ void *hal_srng_setup(void *hal_soc, int ring_type, int ring_num,
if (ring_id < 0) if (ring_id < 0)
return NULL; return NULL;
QDF_TRACE(QDF_MODULE_ID_TXRX, QDF_TRACE_LEVEL_INFO, hal_verbose_debug("mac_id %d ring_id %d", mac_id, ring_id);
"%s: mac_id %d ring_id %d",
__func__, mac_id, ring_id);
srng = hal_get_srng(hal_soc, ring_id); srng = hal_get_srng(hal_soc, ring_id);
if (srng->initialized) { if (srng->initialized) {
QDF_TRACE(QDF_MODULE_ID_TXRX, QDF_TRACE_LEVEL_ERROR, hal_verbose_debug("Ring (ring_type, ring_num) already initialized");
"%s: Ring (ring_type, ring_num) already initialized",
__func__);
return NULL; return NULL;
} }

4
hal/wifi3.0/qca6390/hal_6390_rx.h
View File

@@ -172,7 +172,7 @@ static void hal_rx_dump_msdu_start_tlv_6390(void *msdustart, uint8_t dbg_level)
{ {
struct rx_msdu_start *msdu_start = (struct rx_msdu_start *)msdustart; struct rx_msdu_start *msdu_start = (struct rx_msdu_start *)msdustart;
QDF_TRACE(QDF_MODULE_ID_DP, dbg_level, hal_verbose_debug(
"rx_msdu_start tlv (1/2) - " "rx_msdu_start tlv (1/2) - "
"rxpcu_mpdu_filter_in_category: %x " "rxpcu_mpdu_filter_in_category: %x "
"sw_frame_group_id: %x " "sw_frame_group_id: %x "
@@ -231,7 +231,7 @@ static void hal_rx_dump_msdu_start_tlv_6390(void *msdustart, uint8_t dbg_level)
msdu_start->reception_type, msdu_start->reception_type,
msdu_start->ppdu_start_timestamp); msdu_start->ppdu_start_timestamp);
QDF_TRACE(QDF_MODULE_ID_DP, dbg_level, hal_verbose_debug(
"rx_msdu_start tlv (2/2) - " "rx_msdu_start tlv (2/2) - "
"sw_phy_meta_data: %x ", "sw_phy_meta_data: %x ",
msdu_start->sw_phy_meta_data); msdu_start->sw_phy_meta_data);