1
0

disp: msm: sde: prevent custom ioctls from accessing unowned HW

Early wakeup ioctls from perf HAL driver can access display HW
registers and come as a sideband to atomic commits. Since the
atomic validate checks are not part of this code path it's
possible for HW access to occur during a trusted UI session.
Prevent this whenever the HW is not under this VM's ownership.
Also, move the VM ownership check for the register/deregister
event ioctl to cover both the CRTC and connector events since
new connector events are being added which can access HW.

Change-Id: I39660ae60e7e8f8a405e819c43ec42fbac3f492a
Signed-off-by: Steve Cohen <cohens@codeaurora.org>
Este cometimento está contido em:
Steve Cohen
2021-08-10 17:15:02 -04:00
ascendente 6bf96605eb
cometimento 9690b545df
3 ficheiros modificados com 22 adições e 17 eliminações

Ver ficheiro

@@ -1627,6 +1627,7 @@ int msm_ioctl_display_hint_ops(struct drm_device *dev, void *data,
SDE_EVT32(display_hint->hint_flags);
/* Any new hint added will require a check for VM ownership before HW is accessed */
if (display_hint->hint_flags == DRM_MSM_DISPLAY_EARLY_WAKEUP_HINT) {
if (!display_hint->data) {
DRM_ERROR("early_wakeup: wrong parameter\n");