samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: avoid access sm before NULL check

Browse Source 
This change moves accessing sm after NULL check performed

Change-Id: Iad1c0d9ea9c8bb6e79338259ab93f685b78ad26f
CRs-Fixed: 2407091
This commit is contained in:
Srinivas Pitla
2019-02-28 15:51:49 +05:30
committed by nshrivas
parent 09444a10ed
commit 9527e111d0
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
umac/cmn_services/sm_engine/src/wlan_sm_engine.c
View File

@@ -79,7 +79,7 @@ qdf_export_symbol(wlan_sm_dispatch);
void wlan_sm_transition_to(struct wlan_sm *sm, uint8_t state) void wlan_sm_transition_to(struct wlan_sm *sm, uint8_t state)
{ {
const struct wlan_sm_state_info *state_info = sm->state_info; struct wlan_sm_state_info *state_info;
uint8_t new_state; uint8_t new_state;
uint8_t old_state; uint8_t old_state;
uint8_t new_sub_st; uint8_t new_sub_st;
@@ -91,6 +91,7 @@ void wlan_sm_transition_to(struct wlan_sm *sm, uint8_t state)
return; return;
} }
state_info = sm->state_info;
cur_state = sm->cur_state; cur_state = sm->cur_state;
/* cannot change state from state entry/exit routines */ /* cannot change state from state entry/exit routines */

2
umac/mlme/vdev_mgr/core/src/vdev_mlme_sm.h
View File

@@ -54,7 +54,7 @@ void mlme_vdev_sm_print_state_event(struct vdev_mlme_obj *vdev_mlme,
enum wlan_vdev_sm_evt event); enum wlan_vdev_sm_evt event);
/** /**
* mlme_vdev_sm_print_state_event() - Prints the state/substate * mlme_vdev_sm_print_state() - Prints the state/substate
* @vdev_mlme: MLME VDEV comp object * @vdev_mlme: MLME VDEV comp object
* *
* API to print current state/substate * API to print current state/substate