samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Set nbuf to NULL in error handling of wma_tx_packet

Browse Source 
The caller of wma_tx_packet does not need to check if nbuf becomes
to NULL to decide if the nbuf free is needed. It is the designing
job of wma_tx_packet to free it if there is something wrong. Fix
one of the double free issue in ADDBA response transmission.

CRs-Fixed: 2379912
Change-Id: I944dea72a72cf9d937a72a3e0a31bbad88c8694d
This commit is contained in:
chenguo
2019-01-24 18:27:01 +08:00
committed by nshrivas
parent 434fd3d02d
commit 90c6846477
1 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/mac/src/pe/lim/lim_send_management_frames.c
View File

@@ -4728,14 +4728,7 @@ QDF_STATUS lim_send_addba_response_frame(struct mac_context *mac_ctx,
if (QDF_STATUS_SUCCESS != qdf_status) { if (QDF_STATUS_SUCCESS != qdf_status) {
pe_err("wma_tx_frame FAILED! Status [%d]", pe_err("wma_tx_frame FAILED! Status [%d]",
qdf_status); qdf_status);
qdf_status = QDF_STATUS_E_FAILURE; return QDF_STATUS_E_FAILURE;
/*
* wma_tx_frame free memory in certain cases, free pkt_ptr
* only if not freed already.
*/
if (pkt_ptr)
cds_packet_free((void *)pkt_ptr);
return qdf_status;
} else { } else {
return QDF_STATUS_SUCCESS; return QDF_STATUS_SUCCESS;
} }