msm: ipa: fix p1 compile errors

Fixing compile errors on LA.VENDOR.1.0

Change-Id: I81410f22a6031f3be5d031449c6749dbb0722b77
Signed-off-by: Michael Adisumarta <[email protected]>

drivers/platform/msm/ipa/ipa_clients/ipa_eth.c

@@ -134,7 +134,6 @@ static int ipa_eth_init_internal(void)
 	ipa_eth_ctx->wq = alloc_workqueue(buff,
 		WQ_MEM_RECLAIM | WQ_UNBOUND | WQ_SYSFS, 1);
 	if (!ipa_eth_ctx->wq) {
-		kfree(ipa_eth_ctx);
 		goto wq_err;
 	}
 	mutex_init(&ipa_eth_ctx->lock);
@@ -199,11 +198,15 @@ static void ipa_eth_ready_notify_work(struct work_struct *work)
 	ipa_eth_ctx->is_eth_ready = true;
 	list_for_each_entry_safe(entry, next,
 		&ipa_eth_ctx->ready_cb_list, link) {
-		if (entry && entry->info && entry->info->notify)
+		if (!entry)
+			break;
+		if (entry->info && entry->info->notify) {
 			entry->info->notify(entry->info->userdata);
-		/* remove from list once notify is done */
-		list_del(&entry->link);
-		kfree(entry);
+			/* remove from list once notify is done */
+			list_del(&entry->link);
+			kfree(entry);
+			break;
+		}
 	}
 	mutex_unlock(&ipa_eth_ctx->lock);
 }
@@ -232,8 +235,8 @@ static int ipa_eth_register_ready_cb_internal(struct ipa_eth_ready *ready_info)
 			GFP_KERNEL);
 		if (!ready_cb) {
 			mutex_unlock(&ipa_eth_ctx->lock);
-			rc = -ENOMEM;
-			goto err_uc;
+			ipa_eth_cleanup_internal();
+			return -ENOMEM;
 		}
 		ready_cb->info = ready_info;
 		list_add_tail(&ready_cb->link, &ipa_eth_ctx->ready_cb_list);
@@ -294,7 +297,9 @@ static int ipa_eth_unregister_ready_cb_internal(struct ipa_eth_ready *ready_info
 	mutex_lock(&ipa_eth_ctx->lock);
 	list_for_each_entry(entry, &ipa_eth_ctx->ready_cb_list,
 		link) {
-		if (entry && entry->info == ready_info) {
+		if (!entry)
+			break;
+		if (entry->info == ready_info) {
 			list_del(&entry->link);
 			find_ready_info = true;
 			break;
@@ -936,13 +941,14 @@ static int ipa_eth_client_set_perf_profile_internal(struct ipa_eth_client *clien
 {
 	int client_type, inst_id;
 
-	client_type = client->client_type;
-	inst_id = client->inst_id;
 	if ((!profile) || (!client) || (client->client_type >= IPA_ETH_CLIENT_MAX)) {
 		IPA_ETH_ERR("Invalid input\n");
 		return -EINVAL;
 	}
 
+	client_type = client->client_type;
+	inst_id = client->inst_id;
+
 	if (ipa_pm_set_throughput(
 		ipa_eth_ctx->client[client_type][inst_id].pm_hdl,
 		profile->max_supported_bw_mbps)) {

drivers/platform/msm/ipa/ipa_v3/ipa_debugfs.c

@@ -3300,6 +3300,9 @@ static ssize_t ipa3_eth_read_err_status(struct file *file,
 	struct ipa3_eth_error_stats tx_stats;
 	struct ipa3_eth_error_stats rx_stats;
 
+	memset(&tx_stats, 0, sizeof(struct ipa3_eth_error_stats));
+	memset(&rx_stats, 0, sizeof(struct ipa3_eth_error_stats));
+
 	if (ipa3_ctx->ipa_hw_type < IPA_HW_v4_5
 		&& (ipa3_ctx->ipa_hw_type != IPA_HW_v4_1
 		|| ipa3_ctx->platform_type != IPA_PLAT_TYPE_APQ)) {
@@ -3365,7 +3368,7 @@ static const struct file_operations fops_ipa_eth_client_status = {
 };
 void ipa3_eth_debugfs_add_node(struct ipa_eth_client *client)
 {
-	struct dentry *file;
+	struct dentry *file = NULL;
 	int type, inst_id;
 	char name[IPA_RESOURCE_NAME_MAX];
 
@@ -3381,18 +3384,22 @@ void ipa3_eth_debugfs_add_node(struct ipa_eth_client *client)
 
 	type = client->client_type;
 	inst_id = client->inst_id;
-	snprintf(name, IPA_RESOURCE_NAME_MAX,
-		"%s_%d_stats", ipa_eth_clients_strings[type], inst_id);
-	file = debugfs_create_file(name, IPA_READ_ONLY_MODE,
-		dent_eth, (void *)client, &fops_ipa_eth_stats);
+	if (type < IPA_ETH_CLIENT_MAX) {
+		snprintf(name, IPA_RESOURCE_NAME_MAX,
+			"%s_%d_stats", ipa_eth_clients_strings[type], inst_id);
+		file = debugfs_create_file(name, IPA_READ_ONLY_MODE,
+			dent_eth, (void *)client, &fops_ipa_eth_stats);
+	}
 	if (!file) {
 		IPAERR("could not create hw_type file\n");
 		return;
 	}
-	snprintf(name, IPA_RESOURCE_NAME_MAX,
-		"%s_%d_status", ipa_eth_clients_strings[type], inst_id);
-	file = debugfs_create_file(name, IPA_READ_ONLY_MODE,
-		dent_eth, (void *)client, &fops_ipa_eth_client_status);
+	if (type < IPA_ETH_CLIENT_MAX) {
+		snprintf(name, IPA_RESOURCE_NAME_MAX,
+			"%s_%d_status", ipa_eth_clients_strings[type], inst_id);
+		file = debugfs_create_file(name, IPA_READ_ONLY_MODE,
+			dent_eth, (void *)client, &fops_ipa_eth_client_status);
+	}
 	if (!file) {
 		IPAERR("could not create hw_type file\n");
 		goto fail;

drivers/platform/msm/ipa/ipa_v3/ipa_eth_i.c

@@ -480,7 +480,7 @@ static int ipa3_smmu_map_eth_pipes(struct ipa_eth_client_pipe_info *pipe,
 	enum ipa_client_type client_type, bool map)
 {
 	struct iommu_domain *smmu_domain;
-	int result;
+	int result = -EINVAL;
 	int i;
 	u64 iova;
 	phys_addr_t pa;