samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: cmn_services: Replace explicit comparison to NULL

Browse Source 
Per the Linux Kernel coding style, as enforced by the kernel
checkpatch script, pointers should not be explicitly compared to
NULL. Therefore within cmn_services replace any such comparisons with
logical operations performed on the pointer itself.

Change-Id: I7141cd900916bd4bbab1bc8c7a1b90589286582b
CRs-Fixed: 2418402
This commit is contained in:
Jeff Johnson
2019-03-18 14:03:23 -07:00
committed by nshrivas
parent cd2eb89e8e
commit 9004de88d9
2 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cmn_services/policy_mgr/src/wlan_policy_mgr_core.c
View File

@@ -1591,7 +1591,7 @@ static QDF_STATUS policy_mgr_get_sbs_channels(uint8_t *channels,
uint32_t remaining_channel_index = 0;
uint32_t j = 0, i = 0, weight1, weight2;
if ((NULL == channels) || (NULL == len)) {
if ((!channels) || (!len)) {
policy_mgr_err("channels or len is NULL");
status = QDF_STATUS_E_FAILURE;
return status;
@@ -1710,7 +1710,7 @@ QDF_STATUS policy_mgr_get_connection_channels(struct wlan_objmgr_psoc *psoc,
return status;
}
if ((NULL == channels) || (NULL == len)) {
if ((!channels) || (!len)) {
policy_mgr_err("channels or len is NULL");
status = QDF_STATUS_E_FAILURE;
return status;
@@ -1927,7 +1927,7 @@ QDF_STATUS policy_mgr_get_channel_list(struct wlan_objmgr_psoc *psoc,
return status;
}
if ((NULL == pcl_channels) || (NULL == len)) {
if ((!pcl_channels) || (!len)) {
policy_mgr_err("pcl_channels or len is NULL");
return status;
}

20
cmn_services/policy_mgr/src/wlan_policy_mgr_get_set_utils.c
View File

@@ -1185,7 +1185,7 @@ uint32_t policy_mgr_mode_specific_connection_count(
conn_index++) {
if ((pm_conc_connection_list[conn_index].mode == mode) &&
pm_conc_connection_list[conn_index].in_use) {
if (list != NULL)
if (list)
list[count] = conn_index;
count++;
}
@@ -1502,14 +1502,14 @@ void policy_mgr_incr_active_session(struct wlan_objmgr_psoc *psoc,
0) ||
(policy_mgr_mode_specific_connection_count(psoc, PM_P2P_GO_MODE, NULL) > 0) ||
(policy_mgr_mode_specific_connection_count(psoc, PM_IBSS_MODE, NULL) > 0)) {
if (pm_ctx->dp_cbacks.hdd_disable_rx_ol_in_concurrency != NULL)
if (pm_ctx->dp_cbacks.hdd_disable_rx_ol_in_concurrency)
pm_ctx->dp_cbacks.hdd_disable_rx_ol_in_concurrency(true);
};
/* Enable RPS if SAP interface has come up */
if (policy_mgr_mode_specific_connection_count(psoc, PM_SAP_MODE, NULL)
== 1) {
if (pm_ctx->dp_cbacks.hdd_set_rx_mode_rps_cb != NULL)
if (pm_ctx->dp_cbacks.hdd_set_rx_mode_rps_cb)
pm_ctx->dp_cbacks.hdd_set_rx_mode_rps_cb(true);
}
@@ -1575,14 +1575,14 @@ QDF_STATUS policy_mgr_decr_active_session(struct wlan_objmgr_psoc *psoc,
0) &&
(policy_mgr_mode_specific_connection_count(psoc, PM_P2P_GO_MODE, NULL) == 0) &&
(policy_mgr_mode_specific_connection_count(psoc, PM_IBSS_MODE, NULL) == 0)) {
if (pm_ctx->dp_cbacks.hdd_disable_rx_ol_in_concurrency != NULL)
if (pm_ctx->dp_cbacks.hdd_disable_rx_ol_in_concurrency)
pm_ctx->dp_cbacks.hdd_disable_rx_ol_in_concurrency(false);
};
/* Disable RPS if SAP interface has come up */
if (policy_mgr_mode_specific_connection_count(psoc, PM_SAP_MODE, NULL)
== 0) {
if (pm_ctx->dp_cbacks.hdd_set_rx_mode_rps_cb != NULL)
if (pm_ctx->dp_cbacks.hdd_set_rx_mode_rps_cb)
pm_ctx->dp_cbacks.hdd_set_rx_mode_rps_cb(false);
}
@@ -1792,7 +1792,7 @@ bool policy_mgr_is_ibss_conn_exist(struct wlan_objmgr_psoc *psoc,
policy_mgr_err("Invalid Context");
return status;
}
if (NULL == ibss_channel) {
if (!ibss_channel) {
policy_mgr_err("Null pointer error");
return false;
}
@@ -1829,7 +1829,7 @@ uint32_t policy_mgr_get_mode_specific_conn_info(struct wlan_objmgr_psoc *psoc,
policy_mgr_err("Invalid Context");
return count;
}
if (NULL == channel || NULL == vdev_id) {
if (!channel || !vdev_id) {
policy_mgr_err("Null pointer error");
return count;
}
@@ -1865,7 +1865,7 @@ bool policy_mgr_max_concurrent_connections_reached(
struct policy_mgr_psoc_priv_obj *pm_ctx;
pm_ctx = policy_mgr_get_context(psoc);
if (NULL != pm_ctx) {
if (pm_ctx) {
for (i = 0; i < QDF_MAX_NO_OF_MODE; i++)
j += pm_ctx->no_of_active_sessions[i];
return j >
@@ -2245,7 +2245,7 @@ QDF_STATUS policy_mgr_set_user_cfg(struct wlan_objmgr_psoc *psoc,
policy_mgr_err("Invalid context");
return QDF_STATUS_E_FAILURE;
}
if (NULL == user_cfg) {
if (!user_cfg) {
policy_mgr_err("Invalid User Config");
return QDF_STATUS_E_FAILURE;
}
@@ -2628,7 +2628,7 @@ void policy_mgr_clear_concurrent_session_count(struct wlan_objmgr_psoc *psoc)
struct policy_mgr_psoc_priv_obj *pm_ctx;
pm_ctx = policy_mgr_get_context(psoc);
if (NULL != pm_ctx) {
if (pm_ctx) {
for (i = 0; i < QDF_MAX_NO_OF_MODE; i++)
pm_ctx->no_of_active_sessions[i] = 0;
}