Explorar el Código

qcacld-3.0: Remove lim_send_sme_deauth_ntf() serdes logic

An ancestor of the current driver used mailboxes for communication
between SME and LIM, and serialization/deserialization routines were
used to encode and decode the mailbox messages. This mechanism is no
longer in use, but there are remnants still present.

One such remnant is in lim_send_sme_deauth_ntf(). The logic for
creating the Deauth Indication uses a combination of direct structure
writes and serialized buffer writes. Bring this logic up to date by
removing all serialized buffer writes and exclusively use direct
structure writes.

Change-Id: I2d300e9a1f3b859b98455eb838f2bc9da93731dd
CRs-Fixed: 2402464
Jeff Johnson hace 6 años
padre
commit
8ee46efbdd
Se han modificado 1 ficheros con 5 adiciones y 18 borrados
  1. 5 18
      core/mac/src/pe/lim/lim_send_sme_rsp_messages.c

+ 5 - 18
core/mac/src/pe/lim/lim_send_sme_rsp_messages.c

@@ -1218,24 +1218,11 @@ lim_send_sme_deauth_ntf(struct mac_context *mac, tSirMacAddr peerMacAddr,
 		pSirSmeDeauthInd->messageType = eWNI_SME_DEAUTH_IND;
 		pSirSmeDeauthInd->length = sizeof(*pSirSmeDeauthInd);
 		pSirSmeDeauthInd->reasonCode = eSIR_MAC_UNSPEC_FAILURE_REASON;
-
-		/* sessionId */
-		pBuf = (uint8_t *) &pSirSmeDeauthInd->sessionId;
-		*pBuf++ = smesessionId;
-
-		/* transaction ID */
-		lim_copy_u16(pBuf, smetransactionId);
-		pBuf += sizeof(uint16_t);
-
-		/* status code */
-		lim_copy_u32(pBuf, reasonCode);
-		pBuf += sizeof(tSirResultCodes);
-
-		/* bssId */
-		qdf_mem_copy(pBuf, pe_session->bssId, sizeof(tSirMacAddr));
-		pBuf += sizeof(tSirMacAddr);
-
-		/* peerMacAddr */
+		pSirSmeDeauthInd->sessionId = smesessionId;
+		pSirSmeDeauthInd->transactionId = smetransactionId;
+		pSirSmeDeauthInd->statusCode = reasonCode;
+		qdf_mem_copy(pSirSmeDeauthInd->bssid.bytes, pe_session->bssId,
+			     sizeof(tSirMacAddr));
 		qdf_mem_copy(pSirSmeDeauthInd->peer_macaddr.bytes, peerMacAddr,
 			     QDF_MAC_ADDR_SIZE);