samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Fix memory leak on reo_cmd_list

Browse Source 
When removing entries on reo_cmd_list, TAILQ_FOREACH used
instead of TAILQ_FOREACH_SAFE, that will only remove the first entry
and leak the others.

CRs-Fixed: 2184882
Change-Id: Ica2677925af34e62f98f4a8d2044c9c3feb69ba9
This commit is contained in:
Lin Bai
2018-02-08 17:13:59 +08:00
committed by snandini
parent 469d3f59d9
commit 8dc369bdba
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
dp/wifi3.0/dp_reo.c
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2016-2017 The Linux Foundation. All rights reserved. * Copyright (c) 2016-2018 The Linux Foundation. All rights reserved.
* *
* Permission to use, copy, modify, and/or distribute this software for * Permission to use, copy, modify, and/or distribute this software for
* any purpose with or without fee is hereby granted, provided that the * any purpose with or without fee is hereby granted, provided that the
@@ -177,21 +177,20 @@ next:
void dp_reo_cmdlist_destroy(struct dp_soc *soc) void dp_reo_cmdlist_destroy(struct dp_soc *soc)
{ {
struct dp_reo_cmd_info *reo_cmd = NULL; struct dp_reo_cmd_info *reo_cmd = NULL;
struct dp_reo_cmd_info *tmp_cmd = NULL;
union hal_reo_status reo_status; union hal_reo_status reo_status;
reo_status.queue_status.header.status = reo_status.queue_status.header.status =
HAL_REO_CMD_FAILED; HAL_REO_CMD_FAILED;
qdf_spin_lock_bh(&soc->rx.reo_cmd_lock); qdf_spin_lock_bh(&soc->rx.reo_cmd_lock);
TAILQ_FOREACH(reo_cmd, &soc->rx.reo_cmd_list, TAILQ_FOREACH_SAFE(reo_cmd, &soc->rx.reo_cmd_list,
reo_cmd_list_elem) { reo_cmd_list_elem, tmp_cmd) {
TAILQ_REMOVE(&soc->rx.reo_cmd_list, reo_cmd, TAILQ_REMOVE(&soc->rx.reo_cmd_list, reo_cmd,
reo_cmd_list_elem); reo_cmd_list_elem);
if (reo_cmd) { reo_cmd->handler(soc, reo_cmd->data,
reo_cmd->handler(soc, reo_cmd->data, &reo_status);
&reo_status); qdf_mem_free(reo_cmd);
qdf_mem_free(reo_cmd);
}
} }
qdf_spin_unlock_bh(&soc->rx.reo_cmd_lock); qdf_spin_unlock_bh(&soc->rx.reo_cmd_lock);
} }