From 8da282a66640da346422059fa43a36c427d1fab9 Mon Sep 17 00:00:00 2001
From: Jeff Johnson <quic_jjohnson@quicinc.com>
Date: Wed, 4 Jan 2023 12:59:32 -0800
Subject: [PATCH] qcacld-3.0: Fix UMAC Documentation

The kernel-doc script identified a multitude of documentation issues
in components/umac, so fix them.

Change-Id: If30358cb83e90348e410cfea163353f2dd26b3fa
CRs-Fixed: 3360814
---
 .../core/src/wlan_cm_roam_offload.c           |  19 +-
 .../core/src/wlan_cm_roam_offload.h           |   8 +-
 .../core/src/wlan_cm_vdev_api.h               |  14 +-
 .../dispatcher/inc/wlan_cm_roam_api.h         |  65 +++----
 .../inc/wlan_cm_roam_public_struct.h          | 178 ++++++++++++------
 .../dispatcher/inc/wlan_cm_roam_ucfg_api.h    |  10 +-
 .../dispatcher/inc/wlan_cm_tgt_if_tx_api.h    |   9 +-
 .../dispatcher/src/wlan_cm_roam_api.c         |   7 +-
 .../inc/wlan_wfa_config_public_struct.h       |   7 +-
 components/umac/twt/core/src/wlan_twt_cfg.h   |   4 +-
 components/umac/twt/core/src/wlan_twt_main.c  |   9 +-
 components/umac/twt/core/src/wlan_twt_main.h  |   4 +-
 12 files changed, 203 insertions(+), 131 deletions(-)

diff --git a/components/umac/mlme/connection_mgr/core/src/wlan_cm_roam_offload.c b/components/umac/mlme/connection_mgr/core/src/wlan_cm_roam_offload.c
index b1b3d00a16..f9b41bfe8f 100644
--- a/components/umac/mlme/connection_mgr/core/src/wlan_cm_roam_offload.c
+++ b/components/umac/mlme/connection_mgr/core/src/wlan_cm_roam_offload.c
@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -1083,7 +1083,7 @@ end:
  * cm_roam_init_req() - roam init request handling
  * @psoc: psoc pointer
  * @vdev_id: vdev id
- * @reason: reason for changing roam state for the requested vdev id
+ * @enable: should the offload be enabled
  *
  * Return: QDF_STATUS
  */
@@ -2863,8 +2863,7 @@ cm_roam_scan_btm_offload(struct wlan_objmgr_psoc *psoc,
  * cm_roam_mlo_config() - set roam mlo offload parameters
  * @psoc: psoc ctx
  * @vdev: vdev
- * @params:  roam mlo offload parameters
- * @rso_cfg: rso config
+ * @start_req: request to fill
  *
  * This function is used to set roam mlo offload related parameters
  *
@@ -3371,7 +3370,7 @@ free_mem:
 /**
  * cm_roam_fill_per_roam_request() - create PER roam offload config request
  * @psoc: psoc context
- * @vdev_id: vdev id
+ * @req: request to fill
  *
  * Return: QDF_STATUS
  */
@@ -3767,6 +3766,8 @@ QDF_STATUS cm_roam_send_rso_cmd(struct wlan_objmgr_psoc *psoc,
  * @pdev: pdev pointer
  * @vdev_id: vdev id
  * @reason: reason for changing roam state for the requested vdev id
+ * @send_resp:
+ * @start_timer:
  *
  * This function is used for WLAN_ROAM_RSO_STOPPED roam state handling
  *
@@ -4337,6 +4338,7 @@ cm_roam_switch_to_roam_sync(struct wlan_objmgr_pdev *pdev,
 #ifdef FEATURE_ROAM_DEBUG
 /**
  * union rso_rec_arg1 - argument 1 record rso state change
+ * @value: aggregate value of the structured param
  * @request_st: requested rso state
  * @cur_st: current rso state
  * @new_st: new rso state
@@ -4379,6 +4381,7 @@ static uint32_t get_rso_arg1(enum roam_offload_state request_st,
 
 /**
  * union rso_rec_arg2 - argument 2 record rso state change
+ * @value: aggregate value of the structured param
  * @is_up: vdev is up
  * @supp_dis_roam: supplicant disable roam
  * @roam_progress: roam in progress
@@ -4432,7 +4435,7 @@ static uint32_t get_rso_arg2(bool is_up,
  * @pdev: pdev object
  * @vdev_id: vdev id
  * @cur_st: current state
- * @request_state: requested state
+ * @requested_state: requested state
  * @reason: reason
  * @is_up: vdev is up
  * @status: request result code
@@ -4487,7 +4490,7 @@ cm_record_state_change(struct wlan_objmgr_pdev *pdev,
 #ifdef WLAN_FEATURE_11BE_MLO
 /**
  * cm_mlo_roam_switch_for_link() - roam state handling during mlo roam
-  for link/s.
+ *  for link/s.
  * @pdev: pdev pointer
  * @vdev_id: vdev id
  * @reason: reason for changing roam state for the requested vdev id
@@ -6773,6 +6776,7 @@ cm_roam_btm_resp_event(struct wmi_roam_trigger_info *trigger_info,
  * cm_roam_btm_candidate_event()  - Send BTM roam candidate logging event
  * @btm_data: BTM data
  * @vdev_id: Vdev id
+ * @idx: Candidate instance
  *
  * Return: QDF_STATUS
  */
@@ -7053,6 +7057,7 @@ cm_roam_btm_resp_event(struct wmi_roam_trigger_info *trigger_info,
  * cm_roam_btm_candidate_event()  - Send BTM roam candidate logging event
  * @btm_data: BTM data
  * @vdev_id: Vdev id
+ * @idx: Candidate instance
  *
  * Return: QDF_STATUS
  */
diff --git a/components/umac/mlme/connection_mgr/core/src/wlan_cm_roam_offload.h b/components/umac/mlme/connection_mgr/core/src/wlan_cm_roam_offload.h
index 335a293e15..b30472b2c2 100644
--- a/components/umac/mlme/connection_mgr/core/src/wlan_cm_roam_offload.h
+++ b/components/umac/mlme/connection_mgr/core/src/wlan_cm_roam_offload.h
@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -221,7 +221,7 @@ QDF_STATUS cm_roam_send_rso_cmd(struct wlan_objmgr_psoc *psoc,
  * cm_rso_set_roam_trigger() - Send roam trigger bitmap firmware
  * @pdev: Pointer to pdev
  * @vdev_id: vdev id
- * @triggers: Carries pointer of the object containing vdev id and
+ * @trigger: Carries pointer of the object containing vdev id and
  *  roam_trigger_bitmap.
  *
  * Return: QDF_STATUS
@@ -279,7 +279,7 @@ void cm_dump_freq_list(struct rso_chan_info *chan_info);
 
 /**
  * cm_start_roam_invoke() - Validate and send Roam invoke req to CM
- * @pdev: Pdev pointer
+ * @psoc: Psoc pointer
  * @vdev: vdev
  * @bssid: Target bssid
  * @chan_freq: channel frequency on which reassoc should be send
@@ -452,7 +452,7 @@ cm_exclude_rm_partial_scan_freq(struct wlan_objmgr_psoc *psoc,
 /**
  * cm_roam_full_scan_6ghz_on_disc() - Include the 6 GHz channels in roam full
  * scan only on prior discovery of any 6 GHz support in the environment
- * @pdev: Pointer to pdev
+ * @psoc: Pointer to psoc
  * @vdev_id: vdev id
  * @param_value: Include the 6 GHz channels in roam full scan:
  * 1 - Include only on prior discovery of any 6 GHz support in the environment
diff --git a/components/umac/mlme/connection_mgr/core/src/wlan_cm_vdev_api.h b/components/umac/mlme/connection_mgr/core/src/wlan_cm_vdev_api.h
index b09d8f4710..f140d2cf9d 100644
--- a/components/umac/mlme/connection_mgr/core/src/wlan_cm_vdev_api.h
+++ b/components/umac/mlme/connection_mgr/core/src/wlan_cm_vdev_api.h
@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2015, 2020-2021, The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -178,10 +178,9 @@ struct cm_ext_obj {
 #ifdef WLAN_FEATURE_FILS_SK
 /**
  * cm_update_hlp_info - API to save HLP IE
- * @psoc: Pointer to psoc
+ * @vdev: vdev ptr
  * @gen_ie: IE buffer to store
  * @len: length of the IE buffer @gen_ie
- * @vdev_id: vdev id
  * @flush: Flush the older saved HLP if any
  *
  * Return: None
@@ -220,6 +219,7 @@ void cm_diag_get_auth_enc_type_vdev_id(struct wlan_objmgr_psoc *psoc,
 #ifdef WLAN_UNIT_TEST
 /**
  * cm_get_sta_cxn_info - fill sta context info in buffer
+ * @vdev: Pointer to vdev
  * @buf: buffer to fill
  * @buf_sz: buf size
  *
@@ -424,7 +424,8 @@ cm_csr_connect_done_ind(struct wlan_objmgr_vdev *vdev,
 
 /**
  * cm_is_vdevid_connected() - check if vdev_id is in conneted state
- * @vdev: vdev pointer
+ * @pdev: pdev pointer
+ * @vdev_id: vdev ID
  *
  * Return: bool
  */
@@ -432,7 +433,8 @@ bool cm_is_vdevid_connected(struct wlan_objmgr_pdev *pdev, uint8_t vdev_id);
 
 /**
  * cm_is_vdevid_active() - check if vdev_id is in conneted/roaming state
- * @vdev: vdev pointer
+ * @pdev: pdev pointer
+ * @vdev_id: vdev ID
  *
  * Return: bool
  */
@@ -706,7 +708,7 @@ QDF_STATUS wlan_cm_send_connect_rsp(struct scheduler_msg *msg);
 void wlan_cm_free_connect_rsp(struct cm_vdev_join_rsp *rsp);
 
 /**
- * wlan_cm_handle_hw_mode_change_resp() Process hw_mode_change_resp
+ * wlan_cm_handle_hw_mode_change_resp() - Process hw_mode_change_resp
  * @pdev: pdev pointer
  * @vdev_id: vdev_id
  * @cm_id: connection manager id
diff --git a/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_roam_api.h b/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_roam_api.h
index e26486ee3a..6f5ec22384 100644
--- a/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_roam_api.h
+++ b/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_roam_api.h
@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -61,7 +61,7 @@ QDF_STATUS wlan_cm_roam_send_rso_cmd(struct wlan_objmgr_psoc *psoc,
 				     uint8_t vdev_id, uint8_t rso_command,
 				     uint8_t reason);
 
-/*
+/**
  * wlan_cm_handle_sta_sta_roaming_enablement() - Handle roaming in case
  * of STA + STA
  * @psoc: psoc common object
@@ -91,7 +91,7 @@ QDF_STATUS wlan_cm_roam_state_change(struct wlan_objmgr_pdev *pdev,
 				     uint8_t reason);
 
 /**
- * csr_roam_update_cfg() - Process RSO update cfg request
+ * wlan_roam_update_cfg() - Process RSO update cfg request
  * @psoc: psoc context
  * @vdev_id: vdev id
  * @reason: reason for requesting RSO update cfg
@@ -166,7 +166,7 @@ wlan_cm_enable_roaming_on_connected_sta(struct wlan_objmgr_pdev *pdev,
 #endif
 
 /**
- * wlan_cm_neighbor_roam_in_progress() -Check if STA is in the middle of
+ * wlan_cm_host_roam_in_progress() -Check if STA is in the middle of
  * roaming states
  * @psoc: psoc
  * @vdev_id: vdev id
@@ -205,7 +205,7 @@ char
  * wlan_cm_rso_set_roam_trigger() - Send roam trigger bitmap firmware
  * @pdev: Pointer to pdev
  * @vdev_id: vdev id
- * @triggers: Carries pointer of the object containing vdev id and
+ * @trigger_data: Carries pointer of the object containing vdev id and
  *  roam_trigger_bitmap.
  *
  * Return: QDF_STATUS
@@ -228,7 +228,7 @@ QDF_STATUS wlan_cm_disable_rso(struct wlan_objmgr_pdev *pdev, uint8_t vdev_id,
 			       uint8_t reason);
 
 /**
- * ucfg_cm_enable_rso() - Enable roam scan offload to firmware
+ * wlan_cm_enable_rso() - Enable roam scan offload to firmware
  * @pdev: Pointer to pdev
  * @vdev_id: vdev id
  * @requestor: RSO disable requestor
@@ -442,7 +442,7 @@ uint8_t *wlan_cm_get_rrm_cap_ie_data(void);
 
 /**
  * wlan_cm_append_assoc_ies() - Append specific IE to assoc IE's buffer
- * @req_buf: Pointer to Roam offload scan request
+ * @rso_mode_cfg: Pointer to Roam offload scan request
  * @ie_id: IE ID to be appended
  * @ie_len: IE length to be appended
  * @ie_data: IE data to be appended
@@ -458,7 +458,7 @@ void wlan_cm_append_assoc_ies(struct wlan_roam_scan_offload_params *rso_mode_cfg
  * @psoc: psoc ptr
  * @pdev: pdev
  * @chan_list: Pointer to channel list buffer to populate
- * @num_chan: Pointer to number of channels value to update
+ * @num_chnl: Pointer to number of channels value to update
  * @supp_chan_ie: Boolean to check if we need to populate as IE
  *
  * This function is called to update valid 5Ghz channels
@@ -478,7 +478,7 @@ void wlan_add_supported_5Ghz_channels(struct wlan_objmgr_psoc *psoc,
 /**
  * wlan_get_adaptive_11r_enabled() - Function to check if adaptive 11r
  * ini is enabled or disabled
- * @mac: pointer to mac context
+ * @lfr_cfg: LFR configuration
  *
  * Return: true if adaptive 11r is enabled
  */
@@ -500,7 +500,6 @@ wlan_get_adaptive_11r_enabled(struct wlan_mlme_lfr_cfg *lfr_cfg)
  * wlan_cm_get_fils_connection_info  - Copy fils connection information from
  * mlme vdev private object
  * @psoc: Pointer to psoc object
- * @dst_fils_info: Destination buffer to copy the fils info
  * @vdev_id: vdev id
  *
  * Return: QDF_STATUS
@@ -861,7 +860,7 @@ QDF_STATUS wlan_cm_set_roam_band_bitmask(struct wlan_objmgr_psoc *psoc,
 
 #ifdef FEATURE_RX_LINKSPEED_ROAM_TRIGGER
 /**
- * struct link_speed_cfg - link speed state config
+ * struct roam_link_speed_cfg - link speed state config
  * @psoc: pointer to psoc
  * @vdev_id: vdev id
  * @is_link_speed_good: true means link speed good, false means bad
@@ -893,7 +892,7 @@ void wlan_cm_roam_link_speed_update(struct wlan_objmgr_psoc *psoc,
 				    bool is_link_speed_good);
 
 /**
- * wlan_mlme_is_linkspeed_roam_trigger_supported() - Get roam linkspeed check
+ * wlan_cm_is_linkspeed_roam_trigger_supported() - Get roam linkspeed check
  * @psoc: pointer to psoc object
  *
  * Return: bool, true: Linkspeed check for low rssi roaming supported
@@ -1001,7 +1000,7 @@ cm_handle_scan_ch_list_data(struct cm_roam_scan_ch_resp *data);
  * wlan_cm_free_roam_synch_frame_ind() - Free the bcn_probe_rsp, reassoc_req,
  * reassoc_rsp received as part of the ROAM_SYNC_FRAME event
  *
- * @vdev - vdev obj mgr ptr
+ * @rso_cfg: RSO configuration to be freed
  *
  * This API is used to free the buffer allocated during the ROAM_SYNC_FRAME
  * event
@@ -1013,10 +1012,10 @@ QDF_STATUS wlan_cm_free_roam_synch_frame_ind(struct rso_config *rso_cfg);
 /**
  * cm_roam_sync_event_handler() - CM handler for roam sync event
  *
- * @psoc - psoc objmgr ptr
- * @event - event ptr
- * @len - event buff length
- * @vdev_id - vdev id
+ * @psoc: psoc objmgr ptr
+ * @event: event ptr
+ * @len: event buff length
+ * @sync_ind: sync indication data
  *
  * This API is used to handle the buffer allocated during the ROAM_SYNC_EVENT
  * event
@@ -1031,8 +1030,8 @@ QDF_STATUS cm_roam_sync_event_handler(struct wlan_objmgr_psoc *psoc,
 /**
  * cm_roam_sync_frame_event_handler() - CM handler for roam sync frame event
  *
- * @psoc - psoc objmgr ptr
- * @frame_ind - ptr to roam sync frame struct
+ * @psoc: psoc objmgr ptr
+ * @frame_ind: ptr to roam sync frame struct
  *
  * This API is used to handle the buffer allocated during the ROAM_SYNC_FRAME
  * event
@@ -1047,9 +1046,9 @@ cm_roam_sync_frame_event_handler(struct wlan_objmgr_psoc *psoc,
  * cm_roam_sync_event_handler_cb() - CM callback handler for roam
  * sync event
  *
- * @vdev - vdev objmgr ptr
- * @event - event ptr
- * @len - event data len
+ * @vdev: vdev objmgr ptr
+ * @event: event ptr
+ * @len: event data len
  *
  * This API is used to handle the buffer allocated during the ROAM_SYNC
  * event
@@ -1106,16 +1105,16 @@ void cm_report_roam_rt_stats(struct wlan_objmgr_psoc *psoc,
  * cm_roam_candidate_event_handler() - CM callback to save roam
  * candidate entry in scan db
  *
- * @psoc - psoc objmgr ptr
- * @frame - roam scan candidate info
+ * @psoc: psoc objmgr ptr
+ * @candidate: roam scan candidate info
  */
 QDF_STATUS
 cm_roam_candidate_event_handler(struct wlan_objmgr_psoc *psoc,
 				struct roam_scan_candidate_frame *candidate);
 
-/** wlan_cm_is_roam_sync_in_progress() - Check if the vdev is in roam sync
+/**
+ * wlan_cm_is_roam_sync_in_progress() - Check if the vdev is in roam sync
  * substate
- *
  * @psoc: psoc pointer
  * @vdev_id: vdev_id
  *
@@ -1724,14 +1723,14 @@ enum wlan_phymode
 wlan_cm_fw_to_host_phymode(WMI_HOST_WLAN_PHY_MODE phymode);
 
 /**
- * wlan_cm_sta_mlme_vdev_roam_notify() - STA mlme vdev roam nottify
+ * wlan_cm_sta_mlme_vdev_roam_notify() - STA mlme vdev roam notify
+ * @vdev_mlme: MLME-private vdev context
+ * @data_len: Length of @data
+ * @data: Roam data
  *
- * @sync_ind: Information needed for roam sync propagation
+ * This function will handle the roam notify event
  *
- * This function will invokes CM roam callback api to continue
- * the roam synch propagation.
- *
- * Return: None
+ * Return: QDF_STATUS
  */
 QDF_STATUS
 wlan_cm_sta_mlme_vdev_roam_notify(struct vdev_mlme_obj *vdev_mlme,
@@ -1789,6 +1788,7 @@ bool wlan_is_rso_enabled(struct wlan_objmgr_pdev *pdev, uint8_t vdev_id);
 
 /**
  * wlan_cm_set_sae_auth_ta() - Set SAE auth tx address
+ * @pdev: pdev object
  * @vdev_id : Vdev id
  * @sae_auth_ta: SAE auth tx address
  *
@@ -1801,6 +1801,7 @@ wlan_cm_set_sae_auth_ta(struct wlan_objmgr_pdev *pdev,
 
 /**
  * wlan_cm_get_sae_auth_ta() - Get SAE auth tx address
+ * @pdev: pdev object
  * @vdev_id: Vdev id
  * @sae_auth_ta: SAE auth tx address
  *
diff --git a/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_roam_public_struct.h b/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_roam_public_struct.h
index ff3e49b000..0fb74b4b86 100644
--- a/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_roam_public_struct.h
+++ b/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_roam_public_struct.h
@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -177,8 +177,8 @@
  * enum roam_trigger_sub_reason - Roam trigger sub reasons
  * @ROAM_TRIGGER_SUB_REASON_PERIODIC_TIMER: Roam scan triggered due to
  * periodic timer expiry
- * @ROAM_TRIGGER_SUB_REASON_INACTIVITY_TIMER: Roam scan triggered due to
- * inactivity detection and connected AP RSSI falls below a certain threshold
+ * @ROAM_TRIGGER_SUB_REASON_INACTIVITY_TIMER_LOW_RSSI: Roam scan triggered due
+ * to inactivity detection and connected AP RSSI falls below a certain threshold
  * @ROAM_TRIGGER_SUB_REASON_BTM_DI_TIMER: Roam scan triggered due to BTM
  * Disassoc Imminent timeout
  * @ROAM_TRIGGER_SUB_REASON_FULL_SCAN: Roam scan triggered due to partial scan
@@ -283,6 +283,35 @@ struct rso_chan_info {
 
 /**
  * struct rso_cfg_params - per vdev rso cfg
+ * @neighbor_scan_period:
+ * @neighbor_scan_min_period:
+ * @specific_chan_info:
+ * @neighbor_lookup_threshold:
+ * @rssi_thresh_offset_5g:
+ * @min_chan_scan_time:
+ * @max_chan_scan_time:
+ * @passive_max_chan_time:
+ * @neighbor_results_refresh_period:
+ * @empty_scan_refresh_period:
+ * @opportunistic_threshold_diff:
+ * @roam_rescan_rssi_diff:
+ * @roam_bmiss_first_bcn_cnt:
+ * @roam_bmiss_final_cnt:
+ * @hi_rssi_scan_max_count:
+ * @hi_rssi_scan_rssi_delta:
+ * @hi_rssi_scan_delay:
+ * @hi_rssi_scan_rssi_ub:
+ * @pref_chan_info:
+ * @full_roam_scan_period:
+ * @enable_scoring_for_roam:
+ * @roam_rssi_diff:
+ * @roam_rssi_diff_6ghz:
+ * @bg_rssi_threshold:
+ * @roam_scan_home_away_time:
+ * @roam_scan_n_probes:
+ * @roam_scan_inactivity_time:
+ * @roam_inactive_data_packet_count:
+ * @roam_scan_period_after_inactivity:
  */
 struct rso_cfg_params {
 	uint32_t neighbor_scan_period;
@@ -424,7 +453,7 @@ enum wlan_roam_failure_reason_code {
 
 #ifdef WLAN_FEATURE_HOST_ROAM
 /**
- * srtuct reassoc_timer_ctx - reassoc timer context
+ * struct reassoc_timer_ctx - reassoc timer context
  * @pdev: pdev object pointer
  * @vdev_id: vdev id
  * @cm_id: cm id to find cm_roam_req
@@ -492,6 +521,7 @@ struct owe_transition_mode_info {
  * @prev_ap_bcn_ie: last connected AP ie
  * @occupied_chan_lst: occupied channel list
  * @roam_candidate_count: candidate count
+ * @uapsd_mask: UAPSD mask
  * @is_ese_assoc: is ese assoc
  * @krk: krk data
  * @btk: btk data
@@ -590,7 +620,7 @@ struct rso_roam_policy_params {
 #define ENABLE_FT_OVER_DS      1   /* enable ft_over_ds */
 
 /**
- * struct rso_params - global RSO params
+ * struct rso_config_params - global RSO params
  * @num_ssid_allowed_list: The number of SSID profiles that are
  *                         in the Allowlist. When roaming, we
  *                         consider the BSSID's with this SSID
@@ -601,7 +631,7 @@ struct rso_roam_policy_params {
  * @bssid_favored_factor: RSSI to be added to this BSSID to prefer it
  * @good_rssi_roam: Lazy Roam
  * @alert_rssi_threshold: Alert RSSI
- * @rssi: rssi diff
+ * @rssi_diff: rssi diff
  * @raise_rssi_thresh_5g: The RSSI threshold below which the
  *                        raise_factor_5g (boost factor) should be applied.
  * @drop_rssi_thresh_5g: The RSSI threshold beyond which the
@@ -609,6 +639,7 @@ struct rso_roam_policy_params {
  * @raise_factor_5g: Boost factor
  * @drop_factor_5g: Penalty factor
  * @max_raise_rssi_5g: Maximum amount of Boost that can added
+ * @cat_rssi_offset:
  * @is_fils_roaming_supported: fils roaming supported
  * @policy_params: roam policy params
  * @neighbor_report_offload: neighbor report offload params
@@ -660,8 +691,10 @@ struct rso_config_params {
  * @ADAPTIVE_11R_CONNECTION: adaptive 11r
  * @HS_20_AP: Hotspot 2.0 AP
  * @MBO_OCE_ENABLED_AP: MBO/OCE enabled network
+ * @IS_SINGLE_PMK:
  * @LOST_LINK_RSSI: lost link RSSI
  * @ROAM_BAND: Allowed band for roaming in FW
+ * @HI_RSSI_SCAN_RSSI_DELTA:
  * @ROAM_RSSI_DIFF_6GHZ: roam rssi diff for 6 GHz AP
  */
 enum roam_cfg_param {
@@ -794,14 +827,14 @@ struct ap_profile {
  * @rssi_weightage: RSSI weightage out of total score in %
  * @ht_weightage: HT weightage out of total score in %.
  * @vht_weightage: VHT weightage out of total score in %.
- * @he_weightaget: 11ax weightage out of total score in %.
+ * @he_weightage: 11ax weightage out of total score in %.
  * @bw_weightage: Bandwidth weightage out of total score in %.
  * @band_weightage: Band(2G/5G) weightage out of total score in %.
  * @nss_weightage: NSS(1x1 / 2x2)weightage out of total score in %.
  * @esp_qbss_weightage: ESP/QBSS weightage out of total score in %.
  * @beamforming_weightage: Beamforming weightage out of total score in %.
  * @pcl_weightage: PCL weightage out of total score in %.
- * @oce_wan_weightage OCE WAN metrics weightage out of total score in %.
+ * @oce_wan_weightage: OCE WAN metrics weightage out of total score in %.
  * @oce_ap_tx_pwr_weightage: OCE AP TX power score in %
  * @oce_subnet_id_weightage: OCE subnet id score in %
  * @sae_pk_ap_weightage: SAE-PK AP score in %
@@ -880,36 +913,36 @@ struct scoring_param {
 
 /**
  * enum roam_trigger_reason - Reason for triggering roam
- * ROAM_TRIGGER_REASON_NONE: Roam trigger reason none
- * ROAM_TRIGGER_REASON_PER:  Roam triggered due to packet error
- * ROAM_TRIGGER_REASON_BMISS: Roam triggered due to beacon miss
- * ROAM_TRIGGER_REASON_LOW_RSSI: Roam triggered due to low RSSI of current
+ * @ROAM_TRIGGER_REASON_NONE: Roam trigger reason none
+ * @ROAM_TRIGGER_REASON_PER:  Roam triggered due to packet error
+ * @ROAM_TRIGGER_REASON_BMISS: Roam triggered due to beacon miss
+ * @ROAM_TRIGGER_REASON_LOW_RSSI: Roam triggered due to low RSSI of current
  * connected AP.
- * ROAM_TRIGGER_REASON_HIGH_RSSI: Roam triggered because sta is connected to
+ * @ROAM_TRIGGER_REASON_HIGH_RSSI: Roam triggered because sta is connected to
  * a AP in 2.4GHz band and a better 5GHz AP is available
- * ROAM_TRIGGER_REASON_PERIODIC: Roam triggered as better AP was found during
+ * @ROAM_TRIGGER_REASON_PERIODIC: Roam triggered as better AP was found during
  * periodic roam scan.
- * ROAM_TRIGGER_REASON_MAWC: Motion Aided WiFi Connectivity triggered roam.
- * ROAM_TRIGGER_REASON_DENSE: Roaming triggered due to dense environment
+ * @ROAM_TRIGGER_REASON_MAWC: Motion Aided WiFi Connectivity triggered roam.
+ * @ROAM_TRIGGER_REASON_DENSE: Roaming triggered due to dense environment
  * detected.
- * ROAM_TRIGGER_REASON_BACKGROUND: Roam triggered due to current AP having
+ * @ROAM_TRIGGER_REASON_BACKGROUND: Roam triggered due to current AP having
  * poor rssi and scan candidate found in scan results provided by other
  * scan clients.
- * ROAM_TRIGGER_REASON_FORCED: Forced roam trigger.
- * ROAM_TRIGGER_REASON_BTM: Roam triggered due to AP sent BTM query with
+ * @ROAM_TRIGGER_REASON_FORCED: Forced roam trigger.
+ * @ROAM_TRIGGER_REASON_BTM: Roam triggered due to AP sent BTM query with
  * Disassoc imminent bit set.
- * ROAM_TRIGGER_REASON_UNIT_TEST: Roam triggered due to unit test command.
- * ROAM_TRIGGER_REASON_BSS_LOAD: Roam triggered due to high channel utilization
+ * @ROAM_TRIGGER_REASON_UNIT_TEST: Roam triggered due to unit test command.
+ * @ROAM_TRIGGER_REASON_BSS_LOAD: Roam triggered due to high channel utilization
  * in the current connected channel
- * ROAM_TRIGGER_REASON_DEAUTH: Roam triggered due to deauth received from the
+ * @ROAM_TRIGGER_REASON_DEAUTH: Roam triggered due to deauth received from the
  * current connected AP.
- * ROAM_TRIGGER_REASON_IDLE: Roam triggered due to inactivity of the device.
- * ROAM_TRIGGER_REASON_STA_KICKOUT: Roam triggered due to sta kickout event.
- * ROAM_TRIGGER_REASON_ESS_RSSI: Roam triggered due to ess rssi
- * ROAM_TRIGGER_REASON_WTC_BTM: Roam triggered due to WTC BTM
- * ROAM_TRIGGER_REASON_PMK_TIMEOUT: Roam triggered due to PMK expiry
- * ROAM_TRIGGER_REASON_BTC: Roam triggered due to BT Coex
- * ROAM_TRIGGER_REASON_MAX: Maximum number of roam triggers
+ * @ROAM_TRIGGER_REASON_IDLE: Roam triggered due to inactivity of the device.
+ * @ROAM_TRIGGER_REASON_STA_KICKOUT: Roam triggered due to sta kickout event.
+ * @ROAM_TRIGGER_REASON_ESS_RSSI: Roam triggered due to ess rssi
+ * @ROAM_TRIGGER_REASON_WTC_BTM: Roam triggered due to WTC BTM
+ * @ROAM_TRIGGER_REASON_PMK_TIMEOUT: Roam triggered due to PMK expiry
+ * @ROAM_TRIGGER_REASON_BTC: Roam triggered due to BT Coex
+ * @ROAM_TRIGGER_REASON_MAX: Maximum number of roam triggers
  */
 enum roam_trigger_reason {
 	ROAM_TRIGGER_REASON_NONE = 0,
@@ -969,9 +1002,9 @@ struct roam_trigger_score_delta {
  * @roam_scan_scheme_bitmap: Bitmap of roam triggers as defined in
  * enum roam_trigger_reason, for which the roam scan scheme should
  * be partial scan
- * @control_param: roam trigger param
+ * @vendor_btm_param: roam trigger param
  * @min_rssi_params: Min RSSI values for different roam triggers
- * @score_delta_params: Roam score delta values for different triggers
+ * @score_delta_param: Roam score delta values for different triggers
  */
 struct wlan_roam_triggers {
 	uint32_t vdev_id;
@@ -989,7 +1022,7 @@ struct wlan_roam_triggers {
  * @profile: ap profile to match candidate
  * @param: scoring params to short candidate
  * @min_rssi_params: Min RSSI values for different roam triggers
- * @score_delta_params: Roam score delta values for different triggers
+ * @score_delta_param: Roam score delta values for different triggers
  * @owe_ap_profile: owe ap profile info
  */
 struct ap_profile_params {
@@ -1045,6 +1078,8 @@ struct wlan_roam_mawc_params {
  *                             AP's, in units of db
  * @num_disallowed_aps: How many APs the target should maintain in its LCA
  *                      list
+ * @num_rssi_rejection_ap: Number of entries in @rssi_rejection_ap
+ * @rssi_rejection_ap: APs rejected due to poor RSSI
  * @delta_rssi: (dB units) when AB in RSSI denylist improved by at least
  *              delta_rssi,it will be removed from denylist
  *
@@ -1387,7 +1422,7 @@ struct wlan_roam_scan_mode_params {
  * in the wmi_roam_offload_tlv_param TLV of WMI_ROAM_SCAN_MODE command.
  * @roam_rssi_cat_gap: RSSI category gap
  * @prefer_5ghz: Prefer 5G candidate AP
- * @select_5gz_margin: Prefer connecting to 5G AP even if its RSSI is lower by
+ * @select_5ghz_margin: Prefer connecting to 5G AP even if its RSSI is lower by
  * select_5g_margin dBm
  * @reassoc_failure_timeout: reassociation response failure timeout
  * @ho_delay_for_rx: Time in millisecs to delay hand-off by this duration to
@@ -1396,7 +1431,7 @@ struct wlan_roam_scan_mode_params {
  * reassoc req
  * @roam_preauth_no_ack_timeout: duration in millsecs to wait before another SW
  * retry made if no ack seen for previous frame
- * @diable_self_roam: Disable roaming to current connected BSS.
+ * @disable_self_roam: Disable roaming to current connected BSS.
  * @rct_validity_timer: duration value for which the entries in
  * roam candidate table(rct) are valid
  */
@@ -1414,7 +1449,7 @@ struct wlan_rso_lfr3_params {
 
 #define WLAN_ROAM_OFFLOAD_NUM_MCS_SET     (16)
 /**
- * struct wlan_lfr3_roam_offload_param  - LFR3 Roaming offload parameters
+ * struct wlan_rso_lfr3_caps  - LFR3 Roaming offload parameters
  * @capability: RSN capabilities
  * @ht_caps_info: HT capabilities information
  * @ampdu_param: AMPDU configs
@@ -1463,10 +1498,14 @@ struct wlan_rso_11i_params {
 /**
  * struct wlan_rso_11r_params  - LFR-3.0 parameters to fill
  * wmi_roam_11r_offload_tlv_param TLV related info in WMI_ROAM_SCAN_MODE command
+ * @is_11r_assoc:
+ * @is_adaptive_11r:
  * @enable_ft_im_roaming: Flag to enable/disable FT-IM roaming upon receiving
  * deauth
- * @rokh_id_length: r0kh id length
- * @rokh_id: r0kh id
+ * @psk_pmk: key material
+ * @pmk_len: length of key material
+ * @r0kh_id_length: r0kh id length
+ * @r0kh_id: r0kh id
  * @mdid: mobility domain info
  * @enable_ft_over_ds: Flag to enable/disable FT-over-DS
  */
@@ -1513,10 +1552,11 @@ struct wlan_rso_sae_offload_params {
 #define ROAM_SCAN_CHANNEL_SWITCH_TIME         (4)
 
 /**
- * struct roam_offload_scan_params - structure containing roaming offload scan
- * parameters to be filled over WMI_ROAM_SCAN_MODE command.
+ * struct wlan_roam_scan_offload_params - structure containing roaming offload
+ * scan parameters to be filled over WMI_ROAM_SCAN_MODE command.
  * @vdev_id: vdev id
  * @is_rso_stop: flag to tell whether roam req is valid or NULL
+ * @roaming_scan_policy:
  * @rso_mode_info: Roam scan mode related parameters
  * @rso_scan_params: Roam scan offload scan start params
  * @scan_params: Roaming scan related parameters
@@ -1568,6 +1608,7 @@ struct wlan_roam_scan_offload_params {
  * @hi_rssi_scan_rssi_delta: 5G scan rssi change threshold value
  * @hi_rssi_scan_rssi_ub: 5G scan upper bound
  * @raise_rssi_thresh_5g: flag to determine penalty and boost thresholds
+ * @drop_rssi_thresh_5g: flag to determine penalty and boost thresholds
  * @vdev_id: vdev id
  * @penalty_threshold_5g: RSSI threshold below which 5GHz RSSI is penalized
  * @boost_threshold_5g: RSSI threshold above which 5GHz RSSI is favored
@@ -1586,6 +1627,7 @@ struct wlan_roam_scan_offload_params {
  * @dense_min_aps_cnt: dense roam minimum APs
  * @initial_dense_status: dense status detected by host
  * @traffic_threshold: dense roam RSSI threshold
+ * @rssi_thresh_offset_5g:
  * @bg_scan_bad_rssi_thresh: Bad RSSI threshold to perform bg scan
  * @roam_bad_rssi_thresh_offset_2g: Offset from Bad RSSI threshold for 2G
  *                                  to 5G Roam
@@ -1689,7 +1731,7 @@ struct wlan_roam_scan_period_params {
 };
 
 /**
- * wlan_roam_scan_channel_list  - Roam Scan channel list related
+ * struct wlan_roam_scan_channel_list  - Roam Scan channel list related
  * parameters
  * @vdev_id: Vdev id
  * @chan_count: Channel count
@@ -1768,6 +1810,7 @@ struct wlan_roam_mlo_config {
  * @reason_vsie_enable: roam reason vsie enable parameters
  * @roam_triggers: roam triggers parameters
  * @scan_period_params: roam scan period parameters
+ * @rso_config: roam scan offload configuration
  * @rssi_change_params: Roam offload RSSI change parameters
  * @profile_params: ap profile parameters
  * @rso_chan_info: Roam scan channel list parameters
@@ -2097,30 +2140,30 @@ struct roam_invoke_req {
  * enum cm_roam_notif: roaming notification
  * @CM_ROAM_NOTIF_INVALID: invalid notification. Do not interpret notif field
  * @CM_ROAM_NOTIF_ROAM_START: indicate that roaming is started. sent only in
-			      non WOW state
+ *			      non WOW state
  * @CM_ROAM_NOTIF_ROAM_ABORT: indicate that roaming is aborted. sent only in
-			      non WOW state
+ *			      non WOW state
  * @CM_ROAM_NOTIF_ROAM_REASSOC: indicate that reassociation is done. sent only
-				in non WOW state
+ *				in non WOW state
  * @CM_ROAM_NOTIF_SCAN_MODE_SUCCESS: indicate that roaming scan mode is
-				     successful
+ *				     successful
  * @CM_ROAM_NOTIF_SCAN_MODE_FAIL: indicate that roaming scan mode is failed due
-				  to internal roaming state
+ *				  to internal roaming state
  * @CM_ROAM_NOTIF_DISCONNECT: indicate that roaming not allowed due BTM req
  * @CM_ROAM_NOTIF_SUBNET_CHANGED: indicate that subnet has changed
  * @CM_ROAM_NOTIF_SCAN_START: indicate roam scan start, notif_params to be sent
-			      as WMI_ROAM_TRIGGER_REASON_ID
+ *			      as WMI_ROAM_TRIGGER_REASON_ID
  * @CM_ROAM_NOTIF_DEAUTH_RECV: indicate deauth received, notif_params to be sent
-			       as reason code, notif_params1 to be sent as
-			       frame length
+ *			       as reason code, notif_params1 to be sent as
+ *			       frame length
  * @CM_ROAM_NOTIF_DISASSOC_RECV: indicate disassoc received, notif_params to be
-				 sent as reason code, notif_params1 to be sent
-				 as frame length
+ *				 sent as reason code, notif_params1 to be sent
+ *				 as frame length
  * @CM_ROAM_NOTIF_HO_FAIL: indicates that roaming scan mode is successful but
-			   caused disconnection and subsequent
-			   WMI_ROAM_REASON_HO_FAILED is event expected
+ *			   caused disconnection and subsequent
+ *			   WMI_ROAM_REASON_HO_FAILED is event expected
  * @CM_ROAM_NOTIF_SCAN_END: indicate roam scan end, notif_params to be sent
-			    as WMI_ROAM_TRIGGER_REASON_ID
+ *			    as WMI_ROAM_TRIGGER_REASON_ID
  */
 enum cm_roam_notif {
 	CM_ROAM_NOTIF_INVALID = 0,
@@ -2153,7 +2196,7 @@ enum cm_roam_notif {
  *  reason. Any roaming failure after reassociation will be indicated to host
  *  with WMI_ROAM_REASON_HO_FAILED no matter WMI_ROAM_INVOKE_CMDID is
  *  called or not.
- * @ROAM_REASON_RSO_STATUS
+ * @ROAM_REASON_RSO_STATUS:
  * @ROAM_REASON_BTM: Roaming because of BTM request received
  * @ROAM_REASON_DEAUTH: deauth/disassoc received
  */
@@ -2227,7 +2270,7 @@ struct vdev_disconnect_event_data {
 };
 
 /**
- * struct roam_scan_ch_resp - roam scan chan list response to userspace
+ * struct cm_roam_scan_ch_resp - roam scan chan list response to userspace
  * @vdev_id: vdev id
  * @num_channels: number of roam scan channels
  * @command_resp: command response or async event
@@ -2266,6 +2309,7 @@ enum roam_dispatcher_events {
  *		   reason is WMI_ROAM_REASON_DEAUTH.
  * @hw_mode_trans_ind: HW mode transition indication
  * @deauth_disassoc_frame: Deauth/disassoc frame received from AP
+ * @rso_timer_stopped: RSO timer stopped
  */
 struct roam_offload_roam_event {
 	uint8_t vdev_id;
@@ -2349,7 +2393,7 @@ struct roam_pmkid_req_event {
 };
 
 /**
- * wlan_cm_roam_tx_ops  - structure of tx function pointers for
+ * struct wlan_cm_roam_tx_ops  - structure of tx function pointers for
  * roaming related commands
  * @send_vdev_set_pcl_cmd: TX ops function pointer to send set vdev PCL
  * command
@@ -2357,16 +2401,24 @@ struct roam_pmkid_req_event {
  * module initialize request
  * @send_roam_start_req: TX ops function pointer to send roam start related
  * commands
+ * @send_roam_stop_offload:
+ * @send_roam_update_config:
  * @send_roam_abort: send roam abort
+ * @send_roam_per_config:
+ * @send_roam_triggers:
  * @send_roam_disable_config: send roam disable config
+ * @send_roam_invoke_cmd:
+ * @send_roam_sync_complete_cmd:
  * @send_roam_rt_stats_config: Send roam events vendor command param value to FW
  * @send_roam_ho_delay_config: Send roam Hand-off delay value to FW
  * @send_exclude_rm_partial_scan_freq: Include/exclude the channels in roam full
  * scan that are already scanned as part of partial scan.
  * @send_roam_full_scan_6ghz_on_disc: Include the 6 GHz channels in roam full
  * scan only on prior discovery of any 6 GHz support in the environment.
+ * @send_roam_mcc_disallow: Send MCC disallow to FW
  * @send_roam_linkspeed_state: Send roam link speed good/poor state to FW
  * @send_roam_vendor_handoff_config: send vendor handoff config command to FW
+ * @send_roam_mlo_config: send MLO config to FW
  */
 struct wlan_cm_roam_tx_ops {
 	QDF_STATUS (*send_vdev_set_pcl_cmd)(struct wlan_objmgr_vdev *vdev,
@@ -2426,12 +2478,12 @@ struct wlan_cm_roam_tx_ops {
 
 /**
  * enum roam_scan_freq_scheme - Scan mode for triggering roam
- * ROAM_SCAN_FREQ_SCHEME_NO_SCAN: Indicates the fw to not scan.
- * ROAM_SCAN_FREQ_SCHEME_PARTIAL_SCAN: Indicates the firmware to
+ * @ROAM_SCAN_FREQ_SCHEME_NO_SCAN: Indicates the fw to not scan.
+ * @ROAM_SCAN_FREQ_SCHEME_PARTIAL_SCAN: Indicates the firmware to
  * trigger partial frequency scans.
- * ROAM_SCAN_FREQ_SCHEME_FULL_SCAN: Indicates the firmware to
+ * @ROAM_SCAN_FREQ_SCHEME_FULL_SCAN: Indicates the firmware to
  * trigger full frequency scans.
- * ROAM_SCAN_FREQ_SCHEME_NONE: Invalid scan mode
+ * @ROAM_SCAN_FREQ_SCHEME_NONE: Invalid scan mode
  */
 enum roam_scan_freq_scheme {
 	ROAM_SCAN_FREQ_SCHEME_NO_SCAN = 0,
@@ -2444,7 +2496,7 @@ enum roam_scan_freq_scheme {
 /**
  * struct wlan_cm_vendor_handoff_param - vendor handoff configuration
  * structure
- * @vendor_handoff_context_cb: vendor handoff context
+ * @vendor_handoff_context: vendor handoff context
  * @req_in_progress: to check whether vendor handoff request in progress or not
  */
 struct wlan_cm_vendor_handoff_param {
@@ -2540,6 +2592,8 @@ struct policy_mgr_pdev_mac_freq_map {
  * @new_hw_mode_index: Index of new HW mode
  * @num_vdev_mac_entries: Number of vdev-mac id entries
  * @vdev_mac_map: vdev id-mac id map
+ * @num_freq_map: Number of frequency map entries
+ * @mac_freq_map: Frequency range map
  */
 struct cm_hw_mode_trans_ind {
 	uint32_t old_hw_mode_index;
@@ -2657,7 +2711,7 @@ struct roam_scan_candidate_frame {
 };
 
 /**
- * wlan_cm_roam_rx_ops  - structure of rx function pointers for
+ * struct wlan_cm_roam_rx_ops  - structure of rx function pointers for
  * roaming related commands
  * @roam_sync_event: RX ops function pointer for roam sync event
  * @roam_sync_frame_event: Rx ops function pointer for roam sync frame event
diff --git a/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_roam_ucfg_api.h b/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_roam_ucfg_api.h
index 04be405d6d..868a256847 100644
--- a/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_roam_ucfg_api.h
+++ b/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_roam_ucfg_api.h
@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -144,7 +144,7 @@ void ucfg_cm_roam_link_speed_update(struct wlan_objmgr_psoc *psoc,
 }
 
 /**
- * ucfg_mlme_is_linkspeed_roam_trigger_supported() - Get roam linkspeed check
+ * ucfg_cm_is_linkspeed_roam_trigger_supported() - Get roam linkspeed check
  * @psoc: pointer to psoc object
  *
  * Return: bool, true: Linkspeed check for low rssi roaming supported
@@ -433,10 +433,11 @@ ucfg_cm_roam_full_scan_6ghz_on_disc(struct wlan_objmgr_pdev *pdev,
 /**
  * ucfg_cm_roam_send_vendor_handoff_param_req() - send vendor handoff params
  * command request to FW
- * @pdev: Pointer to pdev
+ * @psoc: Pointer to psoc
  * @vdev_id: vdev id
  * @param_id: Vendor Control Param ID from
  * enum WMI_ROAM_GET_VENDOR_CONTROL_PARAM_ID
+ * @vendor_handoff_context:
  *
  * Return: QDF_STATUS
  */
@@ -464,6 +465,7 @@ ucfg_cm_roam_is_vendor_handoff_control_enable(struct wlan_objmgr_psoc *psoc)
 
 /**
  * ucfg_cm_get_sae_auth_ta() - Get SAE auth tx address
+ * @pdev: pointer to pdev object
  * @vdev_id: Vdev id
  * @sae_auth_ta: SAE auth tx address
  *
@@ -477,7 +479,7 @@ ucfg_cm_get_sae_auth_ta(struct wlan_objmgr_pdev *pdev,
 	return wlan_cm_get_sae_auth_ta(pdev, vdev_id, sae_auth_ta);
 }
 
-/*
+/**
  * ucfg_cm_get_roam_intra_band() - get Intra band roaming
  * @psoc: pointer to psoc object
  * @val:  Infra band value
diff --git a/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_tgt_if_tx_api.h b/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_tgt_if_tx_api.h
index 94963536d4..ff036fa791 100644
--- a/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_tgt_if_tx_api.h
+++ b/components/umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_tgt_if_tx_api.h
@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -104,7 +104,8 @@ wlan_cm_tgt_exclude_rm_partial_scan_freq(struct wlan_objmgr_psoc *psoc,
  * in roam full scan only on prior discovery of any 6 GHz support in the
  * environment.
  * @psoc: PSOC pointer
- * @roam_inc_6ghz_if_disc: Include the 6 GHz channels in roam full scan:
+ * @vdev_id: vdev ID
+ * @roam_full_scan_6ghz_on_disc: Include the 6 GHz channels in roam full scan:
  * 1 - Include only on prior discovery of any 6 GHz support in the environment
  * 0 - Include all the supported 6 GHz channels by default
  *
@@ -230,7 +231,7 @@ QDF_STATUS wlan_cm_tgt_send_roam_stop_req(struct wlan_objmgr_psoc *psoc,
 					 struct wlan_roam_stop_config *req);
 
 /**
- * wlan_cm_tgt_send_roam_start_req()  - Send roam update command to firmware
+ * wlan_cm_tgt_send_roam_update_req()  - Send roam update command to firmware
  * @psoc:    psoc pointer
  * @vdev_id: vdev id
  * @req: roam update config parameter
@@ -276,7 +277,7 @@ QDF_STATUS wlan_cm_tgt_send_roam_triggers(struct wlan_objmgr_psoc *psoc,
 					  struct wlan_roam_triggers *req);
 
 /**
- * wlan_cm_tgt_send_roam_triggers()  - Send roam trigger command to FW
+ * wlan_cm_tgt_send_roam_invoke_req()  - Send roam trigger command to FW
  * @psoc: psoc pointer
  * @roam_invoke_req: roam invoke parameter
  *
diff --git a/components/umac/mlme/connection_mgr/dispatcher/src/wlan_cm_roam_api.c b/components/umac/mlme/connection_mgr/dispatcher/src/wlan_cm_roam_api.c
index 4b160bd842..b1296203a6 100644
--- a/components/umac/mlme/connection_mgr/dispatcher/src/wlan_cm_roam_api.c
+++ b/components/umac/mlme/connection_mgr/dispatcher/src/wlan_cm_roam_api.c
@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -2792,6 +2792,7 @@ cm_roam_stats_get_trigger_detail_str(struct wmi_roam_trigger_info *ptr,
  * @data:  Pointer to the roam trigger data
  * @scan_data: Roam scan data pointer
  * @vdev_id: Vdev ID
+ * @is_full_scan: Was a full scan performed
  *
  * Prints the vdev, roam trigger reason, time of the day at which roaming
  * was triggered.
@@ -2828,8 +2829,10 @@ cm_roam_stats_print_trigger_info(struct wlan_objmgr_psoc *psoc,
 
 /**
  * cm_roam_stats_print_btm_rsp_info - BTM RSP related details
+ * @trigger_info:   Roam scan trigger reason
  * @data:    Pointer to the btm rsp data
  * @vdev_id: vdev id
+ * @is_wtc: is WTC?
  *
  * Prints the vdev, btm status, target_bssid and vsie reason
  *
@@ -3012,7 +3015,9 @@ cm_roam_stats_print_scan_info(struct wlan_objmgr_psoc *psoc,
 /**
  * cm_roam_stats_print_roam_result()  - Print roam result related info
  * @psoc: Pointer to psoc object
+ * @trigger: roam trigger information
  * @res:     Roam result structure pointer
+ * @scan_data: scan data
  * @vdev_id: Vdev id
  *
  * Print roam result and failure reason if roaming failed.
diff --git a/components/umac/mlme/wfa_config/dispatcher/inc/wlan_wfa_config_public_struct.h b/components/umac/mlme/wfa_config/dispatcher/inc/wlan_wfa_config_public_struct.h
index b5d30e291c..8614afe5d2 100644
--- a/components/umac/mlme/wfa_config/dispatcher/inc/wlan_wfa_config_public_struct.h
+++ b/components/umac/mlme/wfa_config/dispatcher/inc/wlan_wfa_config_public_struct.h
@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -30,7 +30,8 @@
 #include <qdf_types.h>
 
 /**
- * wlan_wfa_cmd_tx_ops - structure of tx function pointers for wfa test cmds
+ * struct wlan_wfa_cmd_tx_ops - structure of tx function pointers for wfa
+ *                              test cmds
  * @send_wfa_test_cmd: TX ops function pointer to send WFA test command
  */
 struct wlan_wfa_cmd_tx_ops {
@@ -39,7 +40,7 @@ struct wlan_wfa_cmd_tx_ops {
 };
 
 /**
- * wlan_wfa_test_feature_flags - WFA test feature flags
+ * enum wlan_wfa_test_feature_flags - WFA test feature flags
  * @WFA_TEST_IGNORE_RSNXE: Ignore the H2E RSNXE mismatch for 6g connection when
  *                         this flag is set
  */
diff --git a/components/umac/twt/core/src/wlan_twt_cfg.h b/components/umac/twt/core/src/wlan_twt_cfg.h
index f74d44e65a..7504d6b454 100644
--- a/components/umac/twt/core/src/wlan_twt_cfg.h
+++ b/components/umac/twt/core/src/wlan_twt_cfg.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -150,7 +150,7 @@ QDF_STATUS
 wlan_twt_cfg_set_responder_flag(struct wlan_objmgr_psoc *psoc, bool val);
 
 /**
- * wlan_twt_cfg_get_flex_twt_sched() - get flex scheduling
+ * wlan_twt_cfg_get_flex_sched() - get flex scheduling
  * @psoc: Pointer to global psoc
  * @val: pointer to output variable
  *
diff --git a/components/umac/twt/core/src/wlan_twt_main.c b/components/umac/twt/core/src/wlan_twt_main.c
index 9e0ca824b0..bef71e5253 100644
--- a/components/umac/twt/core/src/wlan_twt_main.c
+++ b/components/umac/twt/core/src/wlan_twt_main.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -996,6 +996,7 @@ bool wlan_twt_is_setup_in_progress(struct wlan_objmgr_psoc *psoc,
  * @psoc: Pointer to global psoc object
  * @peer_mac: Global peer mac address
  * @dialog_id: Dialog ID
+ * @context: TWT context
  *
  * Return: QDF_STATUS
  */
@@ -1052,6 +1053,7 @@ wlan_twt_set_ack_context(struct wlan_objmgr_psoc *psoc,
  * @psoc: Pointer to global psoc object
  * @peer_mac: Global peer mac address
  * @dialog_id: Dialog ID
+ * @context: TWT context
  *
  * Return: QDF_STATUS
  */
@@ -1428,7 +1430,6 @@ QDF_STATUS wlan_twt_ac_pdev_param_send(struct wlan_objmgr_psoc *psoc,
  * wlan_twt_sap_teardown_req() - sap TWT teardown request
  * @psoc: Pointer to psoc object
  * @req: TWT del dialog parameters
- * @context: TWT context
  *
  * Return: QDF Status
  */
@@ -1616,7 +1617,7 @@ wlan_twt_set_setup_done(struct wlan_objmgr_psoc *psoc,
 /**
  * wlan_twt_set_session_state() - Set the TWT session state for the given dialog
  * id in TWT context
- * @peer: Pointer to peer object
+ * @psoc: Pointer to psoc object
  * @peer_mac: Pointer to peer mac address
  * @dialog_id: Dialog id
  * @state: TWT session state
@@ -1729,7 +1730,7 @@ wlan_twt_process_renego_failure(struct wlan_objmgr_psoc *psoc,
  * wlan_twt_process_add_initial_nego() - Process initial TWT setup or
  * re-negotiation successful setup
  * @psoc: psoc
- * @add_dialog_event: pointer to event buf containing twt response parameters
+ * @event: pointer to event buf containing twt response parameters
  *
  * Return: None
  */
diff --git a/components/umac/twt/core/src/wlan_twt_main.h b/components/umac/twt/core/src/wlan_twt_main.h
index 3cee2f54e8..85babe7fa7 100644
--- a/components/umac/twt/core/src/wlan_twt_main.h
+++ b/components/umac/twt/core/src/wlan_twt_main.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -278,7 +278,7 @@ wlan_twt_get_session_state(struct wlan_objmgr_psoc *psoc,
  * @peer_mac: Pointer to peer mac address
  * @dialog_id: Dialog id
  * @cmd: TWT command
- * @active_cmd: Fill the active command in this output parameter
+ * @pactive_cmd: Fill the active command in this output parameter
  *
  * Return: True if given command is in progress.
  */