samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Validate the scan requester id before un-registering index

Browse Source 
In ucfg_scan_unregister_requester even if caller provide an invalid
requester id, the index is unregistered without checking if
requester id is valid.

Validate the scan requester id before un-registering the index.

Change-Id: I0e946b8c1bdb87b7929745bcd646076d2b664c38
CRs-Fixed: 2343177
This commit is contained in:
Abhishek Singh
2018-11-01 09:56:26 +05:30
committed by nshrivas
parent 1b28621e9d
commit 8d80aa857b
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
umac/scan/dispatcher/src/wlan_scan_ucfg_api.c
View File

@@ -1231,12 +1231,19 @@ void
ucfg_scan_unregister_requester(struct wlan_objmgr_psoc *psoc,
wlan_scan_requester requester)
{
int idx = requester & WLAN_SCAN_REQUESTER_ID_MASK;
int idx;
struct wlan_scan_obj *scan;
struct scan_requester_info *requesters;
idx = requester & WLAN_SCAN_REQUESTER_ID_PREFIX;
if (idx != WLAN_SCAN_REQUESTER_ID_PREFIX) {
scm_err("prefix didn't match for requester id %d", requester);
return;
}
idx = requester & WLAN_SCAN_REQUESTER_ID_MASK;
if (idx >= WLAN_MAX_REQUESTORS) {
scm_err("requester id invalid");
scm_err("requester id %d greater than max value", requester);
return;
}