qcacmn: hif: Replace explicit comparison to NULL

Per the Linux Kernel coding style, as enforced by the kernel
checkpatch script, pointers should not be explicitly compared to
NULL. Therefore within hif replace any such comparisons with logical
operations performed on the pointer itself.

Change-Id: I929cb64ee0523d11bc86d5145aade1ec5a713071
CRs-Fixed: 2418257

hif/src/ath_procfs.c

@@ -202,7 +202,7 @@ static const struct file_operations athdiag_fops = {
 int athdiag_procfs_init(void *scn)
 {
 	proc_dir = proc_mkdir(PROCFS_DIR, NULL);
-	if (proc_dir == NULL) {
+	if (!proc_dir) {
 		remove_proc_entry(PROCFS_DIR, NULL);
 		HIF_ERROR("%s: Error: Could not initialize /proc/%s",
 			__func__, PROCFS_DIR);
@@ -211,7 +211,7 @@ int athdiag_procfs_init(void *scn)
 
 	proc_file = proc_create_data(PROCFS_NAME, 0600, proc_dir,
 				     &athdiag_fops, (void *)scn);
-	if (proc_file == NULL) {
+	if (!proc_file) {
 		remove_proc_entry(PROCFS_NAME, proc_dir);
 		HIF_ERROR("%s: Could not initialize /proc/%s",
 			__func__, PROCFS_NAME);
@@ -228,7 +228,7 @@ int athdiag_procfs_init(void *scn)
  */
 void athdiag_procfs_remove(void)
 {
-	if (proc_dir != NULL) {
+	if (proc_dir) {
 		remove_proc_entry(PROCFS_NAME, proc_dir);
 		HIF_DBG("/proc/%s/%s removed", PROCFS_DIR, PROCFS_NAME);
 		remove_proc_entry(PROCFS_DIR, NULL);

hif/src/ce/ce_diag.c

@@ -162,7 +162,7 @@ QDF_STATUS hif_diag_read_mem(struct hif_opaque_softc *hif_ctx,
 	unsigned int boundary_addr = 0;
 
 	ce_diag = hif_state->ce_diag;
-	if (ce_diag == NULL) {
+	if (!ce_diag) {
 		HIF_ERROR("%s: DIAG CE not present", __func__);
 		return QDF_STATUS_E_INVAL;
 	}
@@ -367,7 +367,7 @@ QDF_STATUS hif_diag_write_mem(struct hif_opaque_softc *hif_ctx,
 	unsigned int target_type = 0;
 
 	ce_diag = hif_state->ce_diag;
-	if (ce_diag == NULL) {
+	if (!ce_diag) {
 		HIF_ERROR("%s: DIAG CE not present", __func__);
 		return QDF_STATUS_E_INVAL;
 	}

hif/src/ce/ce_main.c

@@ -818,7 +818,7 @@ static bool ce_mark_datapath(struct CE_state *ce_state)
 	int    i;
 	bool   rc = false;
 
-	if (ce_state != NULL) {
+	if (ce_state) {
 		hif_select_service_to_pipe_map(ce_state->scn, &svc_map,
 					       &map_sz);
 
@@ -1242,7 +1242,7 @@ QDF_STATUS alloc_mem_ce_debug_hist_data(struct hif_softc *scn, uint32_t ce_id)
 		event = &hist_ev[index];
 		event->data =
 			(uint8_t *)qdf_mem_malloc(CE_DEBUG_MAX_DATA_BUF_SIZE);
-		if (event->data == NULL)
+		if (!event->data)
 			return QDF_STATUS_E_NOMEM;
 	}
 	return QDF_STATUS_SUCCESS;
@@ -1270,7 +1270,7 @@ void free_mem_ce_debug_hist_data(struct hif_softc *scn, uint32_t ce_id)
 
 	for (index = 0; index < HIF_CE_HISTORY_MAX; index++) {
 		event = &hist_ev[index];
-		if (event->data != NULL)
+		if (event->data)
 			qdf_mem_free(event->data);
 		event->data = NULL;
 		event = NULL;
@@ -1322,7 +1322,7 @@ alloc_mem_ce_debug_history(struct hif_softc *scn, unsigned int CE_id)
 	scn->hif_ce_desc_hist.hist_ev[CE_id] = (struct hif_ce_desc_event *)
 	qdf_mem_malloc(HIF_CE_HISTORY_MAX * sizeof(struct hif_ce_desc_event));
 
-	if (scn->hif_ce_desc_hist.hist_ev[CE_id] == NULL) {
+	if (!scn->hif_ce_desc_hist.hist_ev[CE_id]) {
 		scn->hif_ce_desc_hist.enable[CE_id] = 0;
 		return QDF_STATUS_E_NOMEM;
 	} else {
@@ -1440,7 +1440,7 @@ struct CE_handle *ce_init(struct hif_softc *scn,
 	CE_state->service = ce_engine_service_reg;
 
 	qdf_atomic_init(&CE_state->rx_pending);
-	if (attr == NULL) {
+	if (!attr) {
 		/* Already initialized; caller wants the handle */
 		return (struct CE_handle *)CE_state;
 	}
@@ -1547,7 +1547,7 @@ struct CE_handle *ce_init(struct hif_softc *scn,
 					ce_alloc_ring_state(CE_state,
 							CE_RING_STATUS,
 							nentries);
-				if (CE_state->status_ring == NULL) {
+				if (!CE_state->status_ring) {
 					/*Allocation failed. Cleanup*/
 					qdf_mem_free(CE_state->dest_ring);
 					if (malloc_src_ring) {
@@ -1974,7 +1974,7 @@ hif_send_head(struct hif_opaque_softc *hif_ctx,
 	pipe_info->num_sends_allowed -= nfrags;
 	qdf_spin_unlock_bh(&pipe_info->completion_freeq_lock);
 
-	if (qdf_unlikely(ce_hdl == NULL)) {
+	if (qdf_unlikely(!ce_hdl)) {
 		HIF_ERROR("%s: error CE handle is null", __func__);
 		return A_ERROR;
 	}
@@ -2268,7 +2268,7 @@ void hif_dump_pipe_debug_count(struct hif_softc *scn)
 	struct HIF_CE_state *hif_state = HIF_GET_CE_STATE(scn);
 	int pipe_num;
 
-	if (hif_state == NULL) {
+	if (!hif_state) {
 		HIF_ERROR("%s hif_state is NULL", __func__);
 		return;
 	}
@@ -2495,7 +2495,7 @@ static void hif_recv_buffer_cleanup_on_pipe(struct HIF_CE_pipe_info *pipe_info)
 	scn = HIF_GET_SOFTC(hif_state);
 	ce_hdl = pipe_info->ce_hdl;
 
-	if (scn->qdf_dev == NULL)
+	if (!scn->qdf_dev)
 		return;
 	while (ce_revoke_recv_next
 		       (ce_hdl, &per_CE_context, (void **)&netbuf,
@@ -3250,7 +3250,7 @@ static void hif_post_static_buf_to_target(struct hif_softc *scn)
 
 	target_va = qdf_mem_alloc_consistent(scn->qdf_dev, scn->qdf_dev->dev,
 				FW_SHARED_MEM, &target_pa);
-	if (NULL == target_va) {
+	if (!target_va) {
 		HIF_TRACE("Memory allocation failed could not post target buf");
 		return;
 	}
@@ -3329,8 +3329,8 @@ int hif_config_ce(struct hif_softc *scn)
 			goto err;
 		}
 		qdf_spinlock_create(&pipe_info->recv_bufs_needed_lock);
-		QDF_ASSERT(pipe_info->ce_hdl != NULL);
-		if (pipe_info->ce_hdl == NULL) {
+		QDF_ASSERT(pipe_info->ce_hdl);
+		if (!pipe_info->ce_hdl) {
 			rv = QDF_STATUS_E_FAILURE;
 			A_TARGET_ACCESS_UNLIKELY(scn);
 			goto err;
@@ -3760,7 +3760,7 @@ int hif_dump_ce_registers(struct hif_softc *scn)
 	QDF_STATUS status;
 
 	for (i = 0; i < scn->ce_count; i++, ce_reg_address += CE_OFFSET) {
-		if (scn->ce_id_to_state[i] == NULL) {
+		if (!scn->ce_id_to_state[i]) {
 			HIF_DBG("CE%d not used.", i);
 			continue;
 		}

hif/src/ce/ce_service.c

@@ -188,7 +188,7 @@ void hif_record_ce_desc_event(struct hif_softc *scn, int ce_id,
 	event->type = type;
 	event->time = qdf_get_log_timestamp();
 
-	if (descriptor != NULL) {
+	if (descriptor) {
 		qdf_mem_copy(&event->descriptor, descriptor, sizeof(union ce_desc));
 	} else {
 		qdf_mem_zero(&event->descriptor, sizeof(union ce_desc));
@@ -487,7 +487,7 @@ qdf_nbuf_t ce_batch_send(struct CE_handle *ce_tx_hdl,  qdf_nbuf_t msdu,
 
 			deltacount = CE_RING_DELTA(nentries_mask, write_index,
 					sw_index-1);
-			if (freelist == NULL) {
+			if (!freelist) {
 				freelist = msdu;
 				hfreelist = msdu;
 			} else {
@@ -1299,13 +1299,13 @@ ce_send_cb_register(struct CE_handle *copyeng,
 	struct hif_softc *scn;
 	struct HIF_CE_state *hif_state;
 
-	if (CE_state == NULL) {
+	if (!CE_state) {
 		HIF_ERROR("%s: Error CE state = NULL", __func__);
 		return;
 	}
 	scn = CE_state->scn;
 	hif_state = HIF_GET_CE_STATE(scn);
-	if (hif_state == NULL) {
+	if (!hif_state) {
 		HIF_ERROR("%s: Error HIF state = NULL", __func__);
 		return;
 	}
@@ -1337,13 +1337,13 @@ ce_recv_cb_register(struct CE_handle *copyeng,
 	struct hif_softc *scn;
 	struct HIF_CE_state *hif_state;
 
-	if (CE_state == NULL) {
+	if (!CE_state) {
 		HIF_ERROR("%s: ERROR CE state = NULL", __func__);
 		return;
 	}
 	scn = CE_state->scn;
 	hif_state = HIF_GET_CE_STATE(scn);
-	if (hif_state == NULL) {
+	if (!hif_state) {
 		HIF_ERROR("%s: Error HIF state = NULL", __func__);
 		return;
 	}

hif/src/ce/ce_service_srng.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2016-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -273,7 +273,7 @@ ce_recv_buf_enqueue_srng(struct CE_handle *copyeng,
 				hal_srng_src_get_next(scn->hal_soc,
 							dest_ring->srng_ctx);
 
-		if (dest_desc == NULL) {
+		if (!dest_desc) {
 			status = QDF_STATUS_E_FAILURE;
 		} else {
 
@@ -364,7 +364,7 @@ ce_completed_recv_next_nolock_srng(struct CE_state *CE_state,
 	dest_status = hal_srng_dst_get_next(scn->hal_soc,
 						status_ring->srng_ctx);
 
-	if (dest_status == NULL) {
+	if (!dest_status) {
 		status = QDF_STATUS_E_FAILURE;
 		goto done;
 	}
@@ -440,7 +440,7 @@ ce_revoke_recv_next_srng(struct CE_handle *copyeng,
 		*per_transfer_contextp =
 			dest_ring->per_transfer_context[sw_index];
 
-	if (dest_ring->per_transfer_context[sw_index] == NULL)
+	if (!dest_ring->per_transfer_context[sw_index])
 		return QDF_STATUS_E_FAILURE;
 
 	/* provide end condition */
@@ -805,7 +805,7 @@ static void ce_prepare_shadow_register_v2_cfg_srng(struct hif_softc *scn,
 		struct pld_shadow_reg_v2_cfg **shadow_config,
 		int *num_shadow_registers_configured)
 {
-	if (scn->hal_soc == NULL) {
+	if (!scn->hal_soc) {
 		HIF_ERROR("%s: hal not initialized: not initializing shadow config",
 			  __func__);
 		return;

hif/src/ce/ce_tasklet.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2015-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2015-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -62,7 +62,7 @@ static void reschedule_ce_tasklet_work_handler(struct work_struct *work)
 	struct hif_softc *scn = ce_work->data;
 	struct HIF_CE_state *hif_ce_state;
 
-	if (NULL == scn) {
+	if (!scn) {
 		HIF_ERROR("%s: tasklet scn is null", __func__);
 		return;
 	}
@@ -482,7 +482,7 @@ QDF_STATUS ce_unregister_irq(struct HIF_CE_state *hif_ce_state, uint32_t mask)
 	int ret;
 	struct hif_softc *scn;
 
-	if (hif_ce_state == NULL) {
+	if (!hif_ce_state) {
 		HIF_WARN("%s: hif_ce_state = NULL", __func__);
 		return QDF_STATUS_SUCCESS;
 	}

hif/src/hif_exec.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2017-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -192,7 +192,7 @@ static struct hif_exec_context *hif_exec_napi_create(uint32_t scale)
 	struct hif_napi_exec_context *ctx;
 
 	ctx = qdf_mem_malloc(sizeof(struct hif_napi_exec_context));
-	if (ctx == NULL)
+	if (!ctx)
 		return NULL;
 
 	ctx->exec_ctx.sched_ops = &napi_sched_ops;
@@ -246,7 +246,7 @@ static struct hif_exec_context *hif_exec_tasklet_create(void)
 	struct hif_tasklet_exec_context *ctx;
 
 	ctx = qdf_mem_malloc(sizeof(struct hif_tasklet_exec_context));
-	if (ctx == NULL)
+	if (!ctx)
 		return NULL;
 
 	ctx->exec_ctx.sched_ops = &tasklet_sched_ops;
@@ -434,7 +434,7 @@ uint32_t hif_register_ext_group(struct hif_opaque_softc *hif_ctx,
 	}
 
 	hif_ext_group = hif_exec_create(type, scale);
-	if (hif_ext_group == NULL)
+	if (!hif_ext_group)
 		return QDF_STATUS_E_FAILURE;
 
 	hif_state->hif_ext_group[hif_state->hif_num_extgroup] =

hif/src/hif_irq_affinity.c

@@ -255,7 +255,7 @@ static int hncm_exec_migrate_to(struct qca_napi_data *napid, uint8_t ctx_id,
 	NAPI_DEBUG("-->%s(napi_cd=%d, didx=%d)", __func__, ctx_id, didx);
 
 	exec_ctx = hif_exec_get_ctx(&napid->hif_softc->osc, ctx_id);
-	if (exec_ctx == NULL)
+	if (!exec_ctx)
 		return -EINVAL;
 
 	exec_ctx->cpumask.bits[0] = (1 << didx);

hif/src/hif_main.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2015-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2015-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -463,7 +463,7 @@ void hif_close(struct hif_opaque_softc *hif_ctx)
 {
 	struct hif_softc *scn = HIF_GET_SOFTC(hif_ctx);
 
-	if (scn == NULL) {
+	if (!scn) {
 		HIF_ERROR("%s: hif_opaque_softc is NULL", __func__);
 		return;
 	}
@@ -492,7 +492,7 @@ static QDF_STATUS hif_hal_attach(struct hif_softc *scn)
 {
 	if (ce_srng_based(scn)) {
 		scn->hal_soc = hal_attach(scn, scn->qdf_dev);
-		if (scn->hal_soc == NULL)
+		if (!scn->hal_soc)
 			return QDF_STATUS_E_FAILURE;
 	}
 
@@ -540,7 +540,7 @@ QDF_STATUS hif_enable(struct hif_opaque_softc *hif_ctx, struct device *dev,
 	QDF_STATUS status;
 	struct hif_softc *scn = HIF_GET_SOFTC(hif_ctx);
 
-	if (scn == NULL) {
+	if (!scn) {
 		HIF_ERROR("%s: hif_ctx = NULL", __func__);
 		return QDF_STATUS_E_NULL_VALUE;
 	}

hif/src/hif_napi.c

@@ -901,7 +901,7 @@ int hif_napi_poll(struct hif_opaque_softc *hif_ctx,
 	struct qca_napi_info *napi_info;
 	struct CE_state *ce_state = NULL;
 
-	if (unlikely(NULL == hif)) {
+	if (unlikely(!hif)) {
 		HIF_ERROR("%s: hif context is NULL", __func__);
 		QDF_ASSERT(0);
 		goto out;
@@ -1037,20 +1037,20 @@ void hif_napi_update_yield_stats(struct CE_state *ce_state,
 	int ce_id = 0;
 	int cpu_id = 0;
 
-	if (unlikely(NULL == ce_state)) {
-		QDF_ASSERT(NULL != ce_state);
+	if (unlikely(!ce_state)) {
+		QDF_ASSERT(ce_state);
 		return;
 	}
 
 	hif = ce_state->scn;
 
-	if (unlikely(NULL == hif)) {
-		QDF_ASSERT(NULL != hif);
+	if (unlikely(!hif)) {
+		QDF_ASSERT(hif);
 		return;
 	}
 	napi_data = &(hif->napi_data);
-	if (unlikely(NULL == napi_data)) {
-		QDF_ASSERT(NULL != napi_data);
+	if (unlikely(!napi_data)) {
+		QDF_ASSERT(napi_data);
 		return;
 	}
 
@@ -1086,7 +1086,7 @@ void hif_napi_stats(struct qca_napi_data *napid)
 	int i;
 	struct qca_napi_cpu *cpu;
 
-	if (napid == NULL) {
+	if (!napid) {
 		qdf_debug("%s: napiid struct is null", __func__);
 		return;
 	}
@@ -1778,7 +1778,7 @@ int hif_napi_serialize(struct hif_opaque_softc *hif, int is_on)
 {
 	int rc = -EINVAL;
 
-	if (hif != NULL)
+	if (hif)
 		switch (is_on) {
 		case 0: { /* de-serialize */
 			rc = hif_napi_event(hif, NAPI_EVT_USR_NORMAL,

hif/src/pcie/if_pci.c

@@ -1280,7 +1280,7 @@ static void hif_disable_power_gating(struct hif_opaque_softc *hif_ctx)
 	struct hif_softc *scn = HIF_GET_SOFTC(hif_ctx);
 	struct hif_pci_softc *sc = HIF_GET_PCI_SOFTC(hif_ctx);
 
-	if (NULL == scn) {
+	if (!scn) {
 		HIF_ERROR("%s: Could not disable ASPM scn is null",
 		       __func__);
 		return;
@@ -1299,7 +1299,7 @@ static void hif_disable_power_gating(struct hif_opaque_softc *hif_ctx)
  */
 static void hif_enable_power_gating(struct hif_pci_softc *sc)
 {
-	if (NULL == sc) {
+	if (!sc) {
 		HIF_ERROR("%s: Could not disable ASPM scn is null",
 		       __func__);
 		return;
@@ -1324,7 +1324,7 @@ void hif_pci_enable_power_management(struct hif_softc *hif_sc,
 {
 	struct hif_pci_softc *pci_ctx = HIF_GET_PCI_SOFTC(hif_sc);
 
-	if (pci_ctx == NULL) {
+	if (!pci_ctx) {
 		HIF_ERROR("%s, hif_ctx null", __func__);
 		return;
 	}
@@ -1356,7 +1356,7 @@ void hif_pci_disable_power_management(struct hif_softc *hif_ctx)
 {
 	struct hif_pci_softc *pci_ctx = HIF_GET_PCI_SOFTC(hif_ctx);
 
-	if (pci_ctx == NULL) {
+	if (!pci_ctx) {
 		HIF_ERROR("%s, hif_ctx null", __func__);
 		return;
 	}
@@ -1368,7 +1368,7 @@ void hif_pci_display_stats(struct hif_softc *hif_ctx)
 {
 	struct hif_pci_softc *pci_ctx = HIF_GET_PCI_SOFTC(hif_ctx);
 
-	if (pci_ctx == NULL) {
+	if (!pci_ctx) {
 		HIF_ERROR("%s, hif_ctx null", __func__);
 		return;
 	}
@@ -1379,7 +1379,7 @@ void hif_pci_clear_stats(struct hif_softc *hif_ctx)
 {
 	struct hif_pci_softc *pci_ctx = HIF_GET_PCI_SOFTC(hif_ctx);
 
-	if (pci_ctx == NULL) {
+	if (!pci_ctx) {
 		HIF_ERROR("%s, hif_ctx null", __func__);
 		return;
 	}
@@ -2186,7 +2186,7 @@ static void hif_disable_pci(struct hif_pci_softc *sc)
 {
 	struct hif_softc *ol_sc = HIF_GET_SOFTC(sc);
 
-	if (ol_sc == NULL) {
+	if (!ol_sc) {
 		HIF_ERROR("%s: ol_sc = NULL", __func__);
 		return;
 	}
@@ -2652,7 +2652,7 @@ static void __hif_runtime_pm_set_state(struct hif_softc *scn,
 {
 	struct hif_pci_softc *sc = HIF_GET_PCI_SOFTC(scn);
 
-	if (NULL == sc) {
+	if (!sc) {
 		HIF_ERROR("%s: HIF_CTX not initialized",
 		       __func__);
 		return;
@@ -2698,7 +2698,7 @@ static void hif_log_runtime_suspend_success(struct hif_softc *hif_ctx)
 {
 	struct hif_pci_softc *sc = HIF_GET_PCI_SOFTC(hif_ctx);
 
-	if (sc == NULL)
+	if (!sc)
 		return;
 
 	sc->pm_stats.suspended++;
@@ -2715,7 +2715,7 @@ static void hif_log_runtime_suspend_failure(void *hif_ctx)
 {
 	struct hif_pci_softc *sc = HIF_GET_PCI_SOFTC(hif_ctx);
 
-	if (sc == NULL)
+	if (!sc)
 		return;
 
 	sc->pm_stats.suspend_err++;
@@ -2731,7 +2731,7 @@ static void hif_log_runtime_resume_success(void *hif_ctx)
 {
 	struct hif_pci_softc *sc = HIF_GET_PCI_SOFTC(hif_ctx);
 
-	if (sc == NULL)
+	if (!sc)
 		return;
 
 	sc->pm_stats.resumed++;
@@ -2750,7 +2750,7 @@ void hif_process_runtime_suspend_failure(struct hif_opaque_softc *hif_ctx)
 	struct hif_softc *scn = HIF_GET_SOFTC(hif_ctx);
 
 	hif_log_runtime_suspend_failure(hif_ctx);
-	if (hif_pci_sc != NULL)
+	if (hif_pci_sc)
 		hif_pm_runtime_mark_last_busy(hif_pci_sc->dev);
 	hif_runtime_pm_set_state_on(scn);
 }
@@ -2817,7 +2817,7 @@ void hif_process_runtime_resume_success(struct hif_opaque_softc *hif_ctx)
 	struct hif_softc *scn = HIF_GET_SOFTC(hif_ctx);
 
 	hif_log_runtime_resume_success(hif_ctx);
-	if (hif_pci_sc != NULL)
+	if (hif_pci_sc)
 		hif_pm_runtime_mark_last_busy(hif_pci_sc->dev);
 	hif_runtime_pm_set_state_on(scn);
 }
@@ -3849,7 +3849,7 @@ void hif_pm_runtime_get_noresume(struct hif_opaque_softc *hif_ctx)
 {
 	struct hif_pci_softc *sc = HIF_GET_PCI_SOFTC(hif_ctx);
 
-	if (NULL == sc)
+	if (!sc)
 		return;
 
 	sc->pm_stats.runtime_get++;
@@ -3876,7 +3876,7 @@ int hif_pm_runtime_get(struct hif_opaque_softc *hif_ctx)
 	int ret;
 	int pm_state;
 
-	if (NULL == scn) {
+	if (!scn) {
 		HIF_ERROR("%s: Could not do runtime get, scn is null",
 				__func__);
 		return -EFAULT;
@@ -3932,7 +3932,7 @@ int hif_pm_runtime_put(struct hif_opaque_softc *hif_ctx)
 	int pm_state, usage_count;
 	char *error = NULL;
 
-	if (NULL == scn) {
+	if (!scn) {
 		HIF_ERROR("%s: Could not do runtime put, scn is null",
 				__func__);
 		return -EFAULT;

hif/src/sdio/hif_bmi_reg_access.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2013-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -238,7 +238,7 @@ hif_bmi_buffer_receive(struct hif_sdio_dev *device,
 		timeout = BMI_COMMUNICATION_TIMEOUT;
 		while ((!want_timeout || timeout--) && !word_available) {
 
-			if (get_pending_events_func != NULL) {
+			if (get_pending_events_func) {
 				status = get_pending_events_func(device,
 							&hif_pending_events,
 							NULL);
@@ -404,7 +404,7 @@ QDF_STATUS hif_exchange_bmi_msg(struct hif_opaque_softc *hif_ctx,
 	struct hif_sdio_dev *device = scn->hif_handle;
 	QDF_STATUS status = QDF_STATUS_SUCCESS;
 
-	if (device == NULL) {
+	if (!device) {
 		AR_DEBUG_PRINTF(ATH_DEBUG_ERR,
 			("%s:Null device argument\n",
 			__func__));
@@ -419,7 +419,7 @@ QDF_STATUS hif_exchange_bmi_msg(struct hif_opaque_softc *hif_ctx,
 		return status;
 	}
 
-	if (response_message != NULL) {
+	if (response_message) {
 		status = hif_bmi_buffer_receive(device, response_message,
 						*response_length,
 						timeout_ms ? true : false);

hif/src/sdio/hif_sdio.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2013-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -87,7 +87,7 @@ void hif_sdio_stop(struct hif_softc *hif_ctx)
 	struct hif_sdio_device *htc_sdio_device = hif_dev_from_hif(hif_device);
 
 	HIF_ENTER();
-	if (htc_sdio_device != NULL) {
+	if (htc_sdio_device) {
 		hif_dev_disable_interrupts(htc_sdio_device);
 		hif_dev_destroy(htc_sdio_device);
 	}
@@ -174,7 +174,7 @@ void hif_post_init(struct hif_opaque_softc *hif_ctx, void *target,
 
 	HIF_ENTER();
 
-	if (htc_sdio_device == NULL)
+	if (!htc_sdio_device)
 		htc_sdio_device = hif_dev_create(hif_device, callbacks, target);
 
 	if (htc_sdio_device)

hif/src/sdio/hif_sdio_dev.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2013-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -56,7 +56,7 @@ HTC_PACKET *hif_dev_alloc_rx_buffer(struct hif_sdio_device *pdev)
 	bufsize = HIF_SDIO_RX_BUFFER_SIZE + HIF_SDIO_RX_DATA_OFFSET;
 	headsize = sizeof(HTC_PACKET);
 	netbuf = qdf_nbuf_alloc(NULL, bufsize + headsize, 0, 4, false);
-	if (netbuf == NULL) {
+	if (!netbuf) {
 		hif_err_rl("Allocate netbuf failed");
 		return NULL;
 	}

hif/src/sdio/native_sdio/src/hif.c

@@ -193,12 +193,12 @@ __hif_read_write(struct hif_sdio_dev *device,
 	uint8_t *tbuffer;
 	bool bounced = false;
 
-	if (device == NULL) {
+	if (!device) {
 		HIF_ERROR("%s: device null!", __func__);
 		return QDF_STATUS_E_INVAL;
 	}
 
-	if (device->func == NULL) {
+	if (!device->func) {
 		HIF_ERROR("%s: func null!", __func__);
 		return QDF_STATUS_E_INVAL;
 	}
@@ -261,7 +261,7 @@ __hif_read_write(struct hif_sdio_dev *device,
 		if (request & HIF_SDIO_WRITE) {
 #if HIF_USE_DMA_BOUNCE_BUFFER
 			if (BUFFER_NEEDS_BOUNCE(buffer)) {
-				AR_DEBUG_ASSERT(device->dma_buffer != NULL);
+				AR_DEBUG_ASSERT(device->dma_buffer);
 				tbuffer = device->dma_buffer;
 				/* copy the write data to the dma buffer */
 				AR_DEBUG_ASSERT(length <= HIF_DMA_BUFFER_SIZE);
@@ -279,7 +279,7 @@ __hif_read_write(struct hif_sdio_dev *device,
 #else
 			tbuffer = buffer;
 #endif
-			if (opcode == CMD53_FIXED_ADDRESS  && tbuffer != NULL) {
+			if (opcode == CMD53_FIXED_ADDRESS  && tbuffer) {
 				ret = sdio_writesb(device->func, address,
 						   tbuffer, length);
 				HIF_INFO_HI("%s:r=%d addr:0x%X, len:%d, 0x%X\n",
@@ -295,7 +295,7 @@ __hif_read_write(struct hif_sdio_dev *device,
 		} else if (request & HIF_SDIO_READ) {
 #if HIF_USE_DMA_BOUNCE_BUFFER
 			if (BUFFER_NEEDS_BOUNCE(buffer)) {
-				AR_DEBUG_ASSERT(device->dma_buffer != NULL);
+				AR_DEBUG_ASSERT(device->dma_buffer);
 				AR_DEBUG_ASSERT(length <= HIF_DMA_BUFFER_SIZE);
 				if (length > HIF_DMA_BUFFER_SIZE) {
 					AR_DEBUG_PRINTF(ATH_DEBUG_ERROR,
@@ -312,7 +312,7 @@ __hif_read_write(struct hif_sdio_dev *device,
 #else
 			tbuffer = buffer;
 #endif
-			if (opcode == CMD53_FIXED_ADDRESS && tbuffer != NULL) {
+			if (opcode == CMD53_FIXED_ADDRESS && tbuffer) {
 				ret = sdio_readsb(device->func, tbuffer,
 						  address, length);
 				HIF_INFO_HI("%s:r=%d addr:0x%X, len:%d, 0x%X\n",
@@ -366,12 +366,12 @@ void add_to_async_list(struct hif_sdio_dev *device,
 
 	qdf_spin_lock_irqsave(&device->asynclock);
 	active = device->asyncreq;
-	if (active == NULL) {
+	if (!active) {
 		device->asyncreq = busrequest;
 		device->asyncreq->inusenext = NULL;
 	} else {
 		for (async = device->asyncreq;
-		     async != NULL; async = async->inusenext) {
+		     async; async = async->inusenext) {
 			active = async;
 		}
 		active->inusenext = busrequest;
@@ -400,8 +400,8 @@ hif_read_write(struct hif_sdio_dev *device,
 	QDF_STATUS status = QDF_STATUS_SUCCESS;
 	struct bus_request *busrequest;
 
-	AR_DEBUG_ASSERT(device != NULL);
-	AR_DEBUG_ASSERT(device->func != NULL);
+	AR_DEBUG_ASSERT(device);
+	AR_DEBUG_ASSERT(device->func);
 	AR_DEBUG_PRINTF(ATH_DEBUG_TRACE,
 			("%s: device 0x%pK addr 0x%X buffer 0x%pK len %d req 0x%X context 0x%pK",
 			 __func__, device, address, buffer,
@@ -422,7 +422,7 @@ hif_read_write(struct hif_sdio_dev *device,
 					 (request & HIF_ASYNCHRONOUS) ? "Async"
 					 : "Synch"));
 			busrequest = hif_allocate_bus_request(device);
-			if (busrequest == NULL) {
+			if (!busrequest) {
 				AR_DEBUG_PRINTF(ATH_DEBUG_ERROR,
 					("no async bus requests available (%s, addr:0x%X, len:%d)\n",
 					 request & HIF_SDIO_READ ? "READ" :
@@ -524,9 +524,9 @@ static int async_task(void *param)
 		 */
 		qdf_spin_lock_irqsave(&device->asynclock);
 		/* pull the request to work on */
-		while (device->asyncreq != NULL) {
+		while (device->asyncreq) {
 			request = device->asyncreq;
-			if (request->inusenext != NULL)
+			if (request->inusenext)
 				device->asyncreq = request->inusenext;
 			else
 				device->asyncreq = NULL;
@@ -539,7 +539,7 @@ static int async_task(void *param)
 				sdio_claim_host(device->func);
 				claimed = true;
 			}
-			if (request->scatter_req != NULL) {
+			if (request->scatter_req) {
 				A_ASSERT(device->scatter_enabled);
 				/* pass the request to scatter routine which
 				 * executes it synchronously, note, no need
@@ -974,7 +974,7 @@ hif_configure_device(struct hif_softc *ol_sc, struct hif_sdio_dev *device,
 		device->htc_context = config;
 		break;
 	case HIF_DEVICE_GET_HTC_CONTEXT:
-		if (config == NULL) {
+		if (!config) {
 			HIF_ERROR("%s: htc context is NULL", __func__);
 			return QDF_STATUS_E_FAILURE;
 		}
@@ -1004,9 +1004,9 @@ void hif_sdio_shutdown(struct hif_softc *hif_ctx)
 
 	AR_DEBUG_PRINTF(ATH_DEBUG_TRACE,
 			("%s: Enter\n", __func__));
-	if (hif_device != NULL) {
+	if (hif_device) {
 		AR_DEBUG_ASSERT(hif_device->power_config == HIF_DEVICE_POWER_CUT
-				|| hif_device->func != NULL);
+				|| hif_device->func);
 	} else {
 		int i;
 		/* since we are unloading the driver anyways,
@@ -1017,7 +1017,7 @@ void hif_sdio_shutdown(struct hif_softc *hif_ctx)
 		 * a card that is already enumerated
 		 */
 		for (i = 0; i < MAX_HIF_DEVICES; ++i) {
-			if (hif_devices[i] && hif_devices[i]->func == NULL) {
+			if (hif_devices[i] && !hif_devices[i]->func) {
 				AR_DEBUG_PRINTF(ATH_DEBUG_TRACE,
 				("%s: Remove pending hif_device %pK\n",
 					 __func__, hif_devices[i]));
@@ -1071,13 +1071,13 @@ static int hif_device_inserted(struct hif_softc *ol_sc,
 	}
 
 	/* If device not found, then it is a new insertion, alloc and add it */
-	if (device == NULL) {
+	if (!device) {
 		if (add_hif_device(func) == NULL)
 			return QDF_STATUS_E_FAILURE;
 		device = get_hif_device(func);
 
 		for (i = 0; i < MAX_HIF_DEVICES; ++i) {
-			if (hif_devices[i] == NULL) {
+			if (!hif_devices[i]) {
 				hif_devices[i] = device;
 				break;
 			}
@@ -1164,7 +1164,7 @@ del_hif_dev:
  */
 void hif_ack_interrupt(struct hif_sdio_dev *device)
 {
-	AR_DEBUG_ASSERT(device != NULL);
+	AR_DEBUG_ASSERT(device);
 
 	/* Acknowledge our function IRQ */
 }
@@ -1195,7 +1195,7 @@ struct bus_request *hif_allocate_bus_request(struct hif_sdio_dev *device)
 	qdf_spin_lock_irqsave(&device->lock);
 	busrequest = device->bus_request_free_queue;
 	/* Remove first in list */
-	if (busrequest != NULL)
+	if (busrequest)
 		device->bus_request_free_queue = busrequest->next;
 
 	/* Release lock */
@@ -1217,7 +1217,7 @@ struct bus_request *hif_allocate_bus_request(struct hif_sdio_dev *device)
 void hif_free_bus_request(struct hif_sdio_dev *device,
 			  struct bus_request *busrequest)
 {
-	AR_DEBUG_ASSERT(busrequest != NULL);
+	AR_DEBUG_ASSERT(busrequest);
 	/* Acquire lock */
 	qdf_spin_lock_irqsave(&device->lock);
 
@@ -1373,7 +1373,7 @@ static void hif_device_removed(struct sdio_func *func)
 	struct hif_sdio_dev *device;
 	int i;
 
-	AR_DEBUG_ASSERT(func != NULL);
+	AR_DEBUG_ASSERT(func);
 	HIF_ENTER();
 	device = get_hif_device(func);
 
@@ -1412,17 +1412,17 @@ static struct hif_sdio_dev *add_hif_device(struct sdio_func *func)
 	int ret = 0;
 
 	HIF_ENTER();
-	AR_DEBUG_ASSERT(func != NULL);
+	AR_DEBUG_ASSERT(func);
 	hifdevice = (struct hif_sdio_dev *) qdf_mem_malloc(sizeof(
 							struct hif_sdio_dev));
-	AR_DEBUG_ASSERT(hifdevice != NULL);
+	AR_DEBUG_ASSERT(hifdevice);
 	if (!hifdevice)
 		return NULL;
 
 #if HIF_USE_DMA_BOUNCE_BUFFER
 	hifdevice->dma_buffer = qdf_mem_malloc(HIF_DMA_BUFFER_SIZE);
-	AR_DEBUG_ASSERT(hifdevice->dma_buffer != NULL);
-	if (hifdevice->dma_buffer == NULL) {
+	AR_DEBUG_ASSERT(hifdevice->dma_buffer);
+	if (!hifdevice->dma_buffer) {
 		qdf_mem_free(hifdevice);
 		return NULL;
 	}
@@ -1438,11 +1438,11 @@ static struct hif_sdio_dev *add_hif_device(struct sdio_func *func)
 
 static void del_hif_device(struct hif_sdio_dev *device)
 {
-	AR_DEBUG_ASSERT(device != NULL);
+	AR_DEBUG_ASSERT(device);
 	AR_DEBUG_PRINTF(ATH_DEBUG_TRACE,
 			("%s: deleting hif device 0x%pK\n",
 				__func__, device));
-	if (device->dma_buffer != NULL)
+	if (device->dma_buffer)
 		qdf_mem_free(device->dma_buffer);
 
 	qdf_mem_free(device);
@@ -1451,7 +1451,7 @@ static void del_hif_device(struct hif_sdio_dev *device)
 QDF_STATUS hif_attach_htc(struct hif_sdio_dev *device,
 				struct htc_callbacks *callbacks)
 {
-	if (device->htc_callbacks.context != NULL)
+	if (device->htc_callbacks.context)
 		/* already in use! */
 		return QDF_STATUS_E_FAILURE;
 	device->htc_callbacks = *callbacks;

hif/src/sdio/native_sdio/src/hif_scatter.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2013-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -79,7 +79,7 @@ static struct _HIF_SCATTER_REQ *alloc_scatter_req(struct hif_sdio_dev *device)
 
 	qdf_spin_unlock_irqrestore(&device->lock);
 
-	if (item != NULL)
+	if (item)
 		return A_CONTAINING_STRUCT(item,
 			struct _HIF_SCATTER_REQ, list_link);
 
@@ -113,7 +113,7 @@ QDF_STATUS do_hif_read_write_scatter(struct hif_sdio_dev *device,
 
 	req_priv = busrequest->scatter_req;
 
-	A_ASSERT(req_priv != NULL);
+	A_ASSERT(req_priv);
 	if (!req_priv) {
 		return QDF_STATUS_E_FAILURE;
 	}
@@ -220,7 +220,7 @@ QDF_STATUS do_hif_read_write_scatter(struct hif_sdio_dev *device,
 				("HIF-SCATTER: async_task completion routine req: 0x%lX (%d)\n",
 				 (unsigned long)busrequest, status));
 		/* complete the request */
-		A_ASSERT(req->completion_routine != NULL);
+		A_ASSERT(req->completion_routine);
 		if (req->completion_routine) {
 			req->completion_routine(req);
 		}
@@ -254,7 +254,7 @@ static QDF_STATUS hif_read_write_scatter(struct hif_sdio_dev *device,
 
 	do {
 
-		A_ASSERT(req_priv != NULL);
+		A_ASSERT(req_priv);
 		if (!req_priv) {
 			break;
 		}
@@ -376,7 +376,7 @@ QDF_STATUS setup_hif_scatter_support(struct hif_sdio_dev *device,
 			(struct HIF_SCATTER_REQ_PRIV *)
 			qdf_mem_malloc(sizeof(
 					struct HIF_SCATTER_REQ_PRIV));
-		if (NULL == req_priv)
+		if (!req_priv)
 			goto end;
 		/* save the device instance */
 		req_priv->device = device;
@@ -387,7 +387,7 @@ QDF_STATUS setup_hif_scatter_support(struct hif_sdio_dev *device,
 				       (MAX_SCATTER_ENTRIES_PER_REQ -
 			       1) * (sizeof(struct _HIF_SCATTER_ITEM)));
 
-		if (NULL == req_priv->hif_scatter_req) {
+		if (!req_priv->hif_scatter_req) {
 			qdf_mem_free(req_priv);
 			goto end;
 		}
@@ -395,7 +395,7 @@ QDF_STATUS setup_hif_scatter_support(struct hif_sdio_dev *device,
 		req_priv->hif_scatter_req->hif_private[0] = req_priv;
 		/* allocate a bus request for this scatter request */
 		busrequest = hif_allocate_bus_request(device);
-		if (NULL == busrequest) {
+		if (!busrequest) {
 			qdf_mem_free(req_priv->hif_scatter_req);
 			qdf_mem_free(req_priv);
 			goto end;
@@ -450,23 +450,23 @@ void cleanup_hif_scatter_resources(struct hif_sdio_dev *device)
 	while (true) {
 		req = alloc_scatter_req(device);
 
-		if (NULL == req)
+		if (!req)
 			break;
 
 		req_priv = (struct HIF_SCATTER_REQ_PRIV *)req->hif_private[0];
-		A_ASSERT(req_priv != NULL);
+		A_ASSERT(req_priv);
 		if (!req_priv) {
 			continue;
 		}
 
-		if (req_priv->busrequest != NULL) {
+		if (req_priv->busrequest) {
 			req_priv->busrequest->scatter_req = NULL;
 			/* free bus request */
 			hif_free_bus_request(device, req_priv->busrequest);
 			req_priv->busrequest = NULL;
 		}
 
-		if (req_priv->hif_scatter_req != NULL) {
+		if (req_priv->hif_scatter_req) {
 			qdf_mem_free(req_priv->hif_scatter_req);
 			req_priv->hif_scatter_req = NULL;
 		}

hif/src/sdio/regtable_sdio.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2013-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -47,7 +47,7 @@ void target_register_tbl_attach(struct hif_softc *scn, u32 target_type)
 
 void hif_register_tbl_attach(struct hif_softc *scn, u32 hif_type)
 {
-	if (NULL == scn) {
+	if (!scn) {
 		QDF_TRACE(QDF_MODULE_ID_HIF, QDF_TRACE_LEVEL_ERROR,
 			  "%s: sc is NULL", __func__);
 		return;

hif/src/sdio/transfer/mailbox.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2013-2019 The Linux Foundation. All rights reserved.
  *
  *
  * Permission to use, copy, modify, and/or distribute this software for
@@ -658,7 +658,7 @@ static QDF_STATUS hif_dev_issue_recv_packet_bundle
 	     !HTC_QUEUE_EMPTY(recv_pkt_queue) && i < HTC_MAX_MSG_PER_BUNDLE_RX;
 	     i++) {
 		packet = htc_packet_dequeue(recv_pkt_queue);
-		A_ASSERT(packet != NULL);
+		A_ASSERT(packet);
 		if (!packet)
 			break;
 		padded_length =
@@ -846,7 +846,7 @@ QDF_STATUS hif_dev_recv_message_pending_handler(struct hif_sdio_device *pdev,
 			if (pkts_fetched == 0) {
 				/* dequeue one packet */
 				pkt = htc_packet_dequeue(&recv_q);
-				A_ASSERT(pkt != NULL);
+				A_ASSERT(pkt);
 				if (!pkt)
 					break;
 
@@ -871,7 +871,7 @@ QDF_STATUS hif_dev_recv_message_pending_handler(struct hif_sdio_device *pdev,
 					qdf_nbuf_t nbuf;
 
 					pkt = htc_packet_dequeue(&recv_q);
-					if (pkt == NULL)
+					if (!pkt)
 						break;
 					nbuf = pkt->pNetBufContext;
 					if (nbuf)
@@ -906,7 +906,7 @@ QDF_STATUS hif_dev_recv_message_pending_handler(struct hif_sdio_device *pdev,
 			qdf_nbuf_t netbuf;
 
 			pkt = htc_packet_dequeue(&sync_comp_q);
-			A_ASSERT(pkt != NULL);
+			A_ASSERT(pkt);
 			if (!pkt)
 				break;
 
@@ -1346,7 +1346,7 @@ int hif_sdio_set_drvdata(struct sdio_func *func,
 
 struct hif_sdio_dev *get_hif_device(struct sdio_func *func)
 {
-	qdf_assert(func != NULL);
+	qdf_assert(func);
 
 	return (struct hif_sdio_dev *)sdio_get_drvdata(func);
 }

hif/src/sdio/transfer/transfer.c

@@ -347,7 +347,7 @@ QDF_STATUS hif_dev_alloc_and_prepare_rx_packets(struct hif_sdio_device *pdev,
 			qdf_nbuf_t netbuf;
 
 			packet = htc_packet_dequeue(queue);
-			if (packet == NULL)
+			if (!packet)
 				break;
 			netbuf = (qdf_nbuf_t)packet->pNetBufContext;
 			if (netbuf)
@@ -711,7 +711,7 @@ void hif_dev_free_recv_pkt_queue(HTC_PACKET_QUEUE *recv_pkt_queue)
 
 	while (!HTC_QUEUE_EMPTY(recv_pkt_queue)) {
 		packet = htc_packet_dequeue(recv_pkt_queue);
-		if (packet == NULL)
+		if (!packet)
 			break;
 		netbuf = (qdf_nbuf_t)packet->pNetBufContext;
 		if (netbuf)

hif/src/snoc/if_snoc.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2015-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2015-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -80,7 +80,7 @@ void hif_snoc_display_stats(struct hif_softc *hif_ctx)
 {
 	struct HIF_CE_state *hif_state = HIF_GET_CE_STATE(hif_ctx);
 
-	if (hif_state == NULL) {
+	if (!hif_state) {
 		HIF_ERROR("%s, hif_ctx null", __func__);
 		return;
 	}
@@ -91,7 +91,7 @@ void hif_snoc_clear_stats(struct hif_softc *hif_ctx)
 {
 	struct HIF_CE_state *hif_state = HIF_GET_CE_STATE(hif_ctx);
 
-	if (hif_state == NULL) {
+	if (!hif_state) {
 		HIF_ERROR("%s, hif_ctx null", __func__);
 		return;
 	}

hif/src/usb/hif_usb.c

@@ -206,7 +206,7 @@ static QDF_STATUS hif_send_internal(struct HIF_DEVICE_USB *hif_usb_device,
 				sizeof(struct hif_usb_send_context);
 
 	urb_context = usb_hif_alloc_urb_from_pipe(pipe);
-	if (NULL == urb_context) {
+	if (!urb_context) {
 		/* TODO : note, it is possible to run out of urbs if 2
 		 * endpoints map to the same pipe ID
 		 */
@@ -349,10 +349,10 @@ void hif_usb_device_deinit(struct hif_usb_softc *sc)
 
 	usb_set_intfdata(device->interface, NULL);
 
-	if (device->diag_cmd_buffer != NULL)
+	if (device->diag_cmd_buffer)
 		qdf_mem_free(device->diag_cmd_buffer);
 
-	if (device->diag_resp_buffer != NULL)
+	if (device->diag_resp_buffer)
 		qdf_mem_free(device->diag_resp_buffer);
 
 	HIF_TRACE("-%s", __func__);
@@ -399,13 +399,13 @@ QDF_STATUS hif_usb_device_init(struct hif_usb_softc *sc)
 
 		device->diag_cmd_buffer =
 			qdf_mem_malloc(USB_CTRL_MAX_DIAG_CMD_SIZE);
-		if (NULL == device->diag_cmd_buffer) {
+		if (!device->diag_cmd_buffer) {
 			status = QDF_STATUS_E_NOMEM;
 			break;
 		}
 		device->diag_resp_buffer =
 			qdf_mem_malloc(USB_CTRL_MAX_DIAG_RESP_SIZE);
-		if (NULL == device->diag_resp_buffer) {
+		if (!device->diag_resp_buffer) {
 			status = QDF_STATUS_E_NOMEM;
 			break;
 		}
@@ -645,7 +645,7 @@ static QDF_STATUS hif_ctrl_msg_exchange(struct HIF_DEVICE_USB *macp,
 		if (!QDF_IS_STATUS_SUCCESS(status))
 			break;
 
-		if (NULL == response_msg) {
+		if (!response_msg) {
 			/* no expected response */
 			break;
 		}

hif/src/usb/if_usb.c

@@ -436,7 +436,7 @@ void hif_usb_reg_tbl_attach(struct hif_softc *scn)
 	struct hif_target_info *tgt_info = &scn->target_info;
 	struct hif_opaque_softc *hif_hdl = GET_HIF_OPAQUE_HDL(scn);
 
-	if (scn->hostdef == NULL && scn->targetdef == NULL) {
+	if (!scn->hostdef && !scn->targetdef) {
 		switch (tgt_info->target_type) {
 		case TARGET_TYPE_AR6320:
 			switch (tgt_info->target_version) {

hif/src/usb/usbdrv.c

@@ -70,7 +70,7 @@ struct HIF_URB_CONTEXT *usb_hif_alloc_urb_from_pipe(struct HIF_USB_PIPE *pipe)
 
 	qdf_spin_lock_irqsave(&pipe->device->cs_lock);
 	item = dl_list_remove_item_from_head(&pipe->urb_list_head);
-	if (item != NULL) {
+	if (item) {
 		urb_context = A_CONTAINING_STRUCT(item, struct HIF_URB_CONTEXT,
 						  link);
 		pipe->urb_cnt--;
@@ -94,7 +94,7 @@ static struct HIF_URB_CONTEXT *usb_hif_dequeue_pending_transfer
 
 	qdf_spin_lock_irqsave(&pipe->device->cs_lock);
 	item = dl_list_remove_item_from_head(&pipe->urb_pending_list);
-	if (item != NULL)
+	if (item)
 		urb_context = A_CONTAINING_STRUCT(item, struct HIF_URB_CONTEXT,
 						  link);
 	qdf_spin_unlock_irqrestore(&pipe->device->cs_lock);
@@ -191,7 +191,7 @@ static void usb_hif_free_pipe_resources(struct HIF_USB_PIPE *pipe)
 {
 	struct HIF_URB_CONTEXT *urb_context;
 
-	if (NULL == pipe->device) {
+	if (!pipe->device) {
 		/* nothing allocated for this pipe */
 		HIF_ERROR("pipe->device is null");
 		return;
@@ -211,7 +211,7 @@ static void usb_hif_free_pipe_resources(struct HIF_USB_PIPE *pipe)
 
 	while (true) {
 		urb_context = usb_hif_alloc_urb_from_pipe(pipe);
-		if (NULL == urb_context)
+		if (!urb_context)
 			break;
 
 		if (urb_context->buf) {
@@ -376,7 +376,7 @@ QDF_STATUS usb_hif_setup_pipe_resources(struct HIF_DEVICE_USB *device)
 			continue;
 
 		pipe = &device->pipes[pipe_num];
-		if (pipe->device != NULL) {
+		if (pipe->device) {
 			/*pipe was already setup */
 			continue;
 		}
@@ -463,12 +463,12 @@ static void usb_hif_flush_pending_transfers(struct HIF_USB_PIPE *pipe)
 
 	while (1) {
 		urb_context = usb_hif_dequeue_pending_transfer(pipe);
-		if (NULL == urb_context) {
+		if (!urb_context) {
 			HIF_WARN("urb_context is NULL");
 			break;
 		}
 		HIF_TRACE("  pending urb ctxt: 0x%pK", urb_context);
-		if (urb_context->urb != NULL) {
+		if (urb_context->urb) {
 			HIF_TRACE("  killing urb: 0x%pK", urb_context->urb);
 			/* killing the URB will cause the completion routines to
 			 * run
@@ -493,7 +493,7 @@ void usb_hif_flush_all(struct HIF_DEVICE_USB *device)
 	HIF_TRACE("+%s", __func__);
 
 	for (i = 0; i < HIF_USB_PIPE_MAX; i++) {
-		if (device->pipes[i].device != NULL) {
+		if (device->pipes[i].device) {
 			usb_hif_flush_pending_transfers(&device->pipes[i]);
 			pipe = &device->pipes[i];
 
@@ -513,7 +513,7 @@ void usb_hif_flush_all(struct HIF_DEVICE_USB *device)
 static void usb_hif_cleanup_recv_urb(struct HIF_URB_CONTEXT *urb_context)
 {
 
-	if (urb_context->buf != NULL) {
+	if (urb_context->buf) {
 		qdf_nbuf_free(urb_context->buf);
 		urb_context->buf = NULL;
 	}
@@ -801,7 +801,7 @@ static void usb_hif_usb_recv_bundle_complete(struct urb *urb)
 			/* allocate a new skb and copy */
 			new_skb =
 				qdf_nbuf_alloc(NULL, frame_len, 0, 4, false);
-			if (new_skb == NULL) {
+			if (!new_skb) {
 				HIF_ERROR("athusb: allocate skb (len=%u) failed"
 						, frame_len);
 				break;
@@ -819,7 +819,7 @@ static void usb_hif_usb_recv_bundle_complete(struct urb *urb)
 		HIF_USB_SCHEDULE_WORK(pipe);
 	} while (false);
 
-	if (urb_context->buf == NULL)
+	if (!urb_context->buf)
 		HIF_ERROR("athusb: buffer in urb_context is NULL");
 
 	/* reset urb_context->buf ==> seems not necessary */
@@ -856,12 +856,12 @@ static void usb_hif_post_recv_prestart_transfers(struct HIF_USB_PIPE *recv_pipe,
 
 	for (i = 0; i < prestart_urb; i++) {
 		urb_context = usb_hif_alloc_urb_from_pipe(recv_pipe);
-		if (NULL == urb_context)
+		if (!urb_context)
 			break;
 
 		urb_context->buf =
 			qdf_nbuf_alloc(NULL, buffer_length, 0, 4, false);
-		if (NULL == urb_context->buf) {
+		if (!urb_context->buf) {
 			usb_hif_cleanup_recv_urb(urb_context);
 			break;
 		}
@@ -920,12 +920,12 @@ static void usb_hif_post_recv_transfers(struct HIF_USB_PIPE *recv_pipe,
 	while (1) {
 
 		urb_context = usb_hif_alloc_urb_from_pipe(recv_pipe);
-		if (NULL == urb_context)
+		if (!urb_context)
 			break;
 
 		urb_context->buf = qdf_nbuf_alloc(NULL, buffer_length, 0,
 						4, false);
-		if (NULL == urb_context->buf) {
+		if (!urb_context->buf) {
 			usb_hif_cleanup_recv_urb(urb_context);
 			break;
 		}
@@ -981,13 +981,13 @@ static void usb_hif_post_recv_bundle_transfers(struct HIF_USB_PIPE *recv_pipe,
 	while (1) {
 
 		urb_context = usb_hif_alloc_urb_from_pipe(recv_pipe);
-		if (NULL == urb_context)
+		if (!urb_context)
 			break;
 
-		if (NULL == urb_context->buf) {
+		if (!urb_context->buf) {
 			urb_context->buf =
 			qdf_nbuf_alloc(NULL, buffer_length, 0, 4, false);
-			if (NULL == urb_context->buf) {
+			if (!urb_context->buf) {
 				usb_hif_cleanup_recv_urb(urb_context);
 				break;
 			}
@@ -1125,7 +1125,7 @@ QDF_STATUS usb_hif_submit_ctrl_out(struct HIF_DEVICE_USB *device,
 
 		if (size > 0) {
 			buf = qdf_mem_malloc(size);
-			if (NULL == buf) {
+			if (!buf) {
 				ret = QDF_STATUS_E_NOMEM;
 				break;
 			}
@@ -1149,7 +1149,7 @@ QDF_STATUS usb_hif_submit_ctrl_out(struct HIF_DEVICE_USB *device,
 
 	} while (false);
 
-	if (buf != NULL)
+	if (buf)
 		qdf_mem_free(buf);
 
 	return ret;
@@ -1178,7 +1178,7 @@ QDF_STATUS usb_hif_submit_ctrl_in(struct HIF_DEVICE_USB *device,
 
 		if (size > 0) {
 			buf = qdf_mem_malloc(size);
-			if (NULL == buf) {
+			if (!buf) {
 				ret = QDF_STATUS_E_NOMEM;
 				break;
 			}
@@ -1204,7 +1204,7 @@ QDF_STATUS usb_hif_submit_ctrl_in(struct HIF_DEVICE_USB *device,
 
 	} while (false);
 
-	if (buf != NULL)
+	if (buf)
 		qdf_mem_free(buf);
 
 	return ret;