Browse Source

qcacld-3.0: Fix kernel module check patch warnings in PLD files

Fix kernel module check patch warnings in PLD files

Change-Id: Ic0473118a4799cc74eaa8684257013f8f38a746a
CRs-fixed: 2030824
Manikandan Mohan 8 years ago
parent
commit
8cf506171b

+ 1 - 1
core/pld/inc/pld_common.h

@@ -290,7 +290,7 @@ enum pld_recovery_reason {
  * @runtime_resume: optional operation, put the device into the fully
  *                  active state in response to a wakeup event generated by
  *                  hardware or at the request of software.
- * @suspend_noirq: optional operation, complete the actions started by suspend().
+ * @suspend_noirq: optional operation, complete the actions started by suspend()
  * @resume_noirq: optional operation, prepare for the execution of resume()
  */
 struct pld_driver_ops {

+ 1 - 0
core/pld/src/pld_pcie.c

@@ -521,6 +521,7 @@ void pld_pcie_unregister_driver(void)
 int pld_pcie_get_ce_id(int irq)
 {
 	int ce_id = irq - 100;
+
 	if (ce_id < CE_COUNT_MAX && ce_id >= 0)
 		return ce_id;
 

+ 0 - 11
core/pld/src/pld_pcie.h

@@ -41,7 +41,6 @@ static inline int pld_pcie_register_driver(void)
 
 static inline void pld_pcie_unregister_driver(void)
 {
-	return;
 }
 
 static inline int pld_pcie_get_ce_id(int irq)
@@ -80,7 +79,6 @@ static inline int pld_pcie_set_fw_log_mode(u8 fw_log_mode)
 }
 static inline void pld_pcie_intr_notify_q6(void)
 {
-	return;
 }
 #else
 static inline int pld_pcie_set_fw_log_mode(u8 fw_log_mode)
@@ -137,7 +135,6 @@ pld_pcie_get_fw_files_for_target(struct pld_fw_files *pfw_files,
 }
 static inline void pld_pcie_link_down(struct device *dev)
 {
-	return;
 }
 static inline int pld_pcie_shadow_control(bool enable)
 {
@@ -165,7 +162,6 @@ static inline int pld_pcie_wlan_get_dfs_nol(void *info, u16 info_len)
 static inline void pld_pcie_schedule_recovery_work(struct device *dev,
 					   enum pld_recovery_reason reason)
 {
-	return;
 }
 static inline void *pld_pcie_get_virt_ramdump_mem(unsigned long *size)
 {
@@ -173,20 +169,16 @@ static inline void *pld_pcie_get_virt_ramdump_mem(unsigned long *size)
 }
 static inline void pld_pcie_device_crashed(void)
 {
-	return;
 }
 static inline void pld_pcie_device_self_recovery(struct device *dev,
 					 enum pld_recovery_reason reason)
 {
-	return;
 }
 static inline void pld_pcie_request_pm_qos(u32 qos_val)
 {
-	return;
 }
 static inline void pld_pcie_remove_pm_qos(void)
 {
-	return;
 }
 static inline int pld_pcie_request_bus_bandwidth(int bandwidth)
 {
@@ -203,7 +195,6 @@ static inline int pld_pcie_get_soc_info(struct device *dev,
 }
 static inline void pld_pcie_set_driver_status(enum pld_driver_status status)
 {
-	return;
 }
 static inline int pld_pcie_auto_suspend(void)
 {
@@ -215,11 +206,9 @@ static inline int pld_pcie_auto_resume(void)
 }
 static inline void pld_pcie_lock_pm_sem(void)
 {
-	return;
 }
 static inline void pld_pcie_release_pm_sem(void)
 {
-	return;
 }
 static inline int pld_pcie_power_on(struct device *dev)
 {

+ 0 - 3
core/pld/src/pld_snoc.h

@@ -41,7 +41,6 @@ static inline int pld_snoc_register_driver(void)
 
 static inline void pld_snoc_unregister_driver(void)
 {
-	return;
 }
 static inline int pld_snoc_wlan_enable(struct pld_wlan_enable_cfg *config,
 		    enum pld_driver_mode mode, const char *host_version)
@@ -64,11 +63,9 @@ static inline int pld_snoc_ce_free_irq(unsigned int ce_id, void *ctx)
 }
 static inline void pld_snoc_enable_irq(unsigned int ce_id)
 {
-	return;
 }
 static inline void pld_snoc_disable_irq(unsigned int ce_id)
 {
-	return;
 }
 static inline int pld_snoc_get_soc_info(struct pld_soc_info *info)
 {

+ 2 - 2
core/pld/src/pld_usb.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2016-2017 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -198,8 +198,8 @@ int pld_usb_register_driver(void)
 void pld_usb_unregister_driver(void)
 {
 	struct pld_context *pld_context;
-	pld_context = pld_get_global_context();
 
+	pld_context = pld_get_global_context();
 	if (atomic_read(&pld_usb_reg_done) == false)
 		return;
 

+ 1 - 2
core/pld/src/pld_usb.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2016-2017 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -28,7 +28,6 @@ static inline int pld_usb_register_driver(void)
 
 static inline void pld_usb_unregister_driver(void)
 {
-	return;
 }
 
 static inline int pld_usb_get_ce_id(int irq)