Răsfoiți Sursa

qcacmn: Make dp_mlo_ctxt_{at,de}tach_wifi3() static

The following functions are currently public exported functions:
dp_mlo_ctxt_attach_wifi3()
dp_mlo_ctxt_detach_wifi3()

However these functions are only accessed from within the file where
they are defined, and they are only supposed to be called via the
cdp_mlo_ops, so make them static.

Change-Id: I8db6b7be9b91972c2183d2f699ed5fb64ec60713
CRs-Fixed: 3371955
Jeff Johnson 2 ani în urmă
părinte
comite
87286d59a8
2 a modificat fișierele cu 10 adăugiri și 17 ștergeri
  1. 1 5
      dp/inc/cdp_txrx_mlo.h
  2. 9 12
      dp/wifi3.0/be/mlo/dp_mlo.c

+ 1 - 5
dp/inc/cdp_txrx_mlo.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -19,10 +19,6 @@
 
 struct cdp_mlo_ctxt;
 
-struct
-cdp_mlo_ctxt *dp_mlo_ctxt_attach_wifi3(struct cdp_ctrl_mlo_mgr *ctrl_ctxt);
-void dp_mlo_ctxt_detach_wifi3(struct cdp_mlo_ctxt *ml_ctxt);
-
 static inline
 struct cdp_mlo_ctxt *cdp_mlo_ctxt_attach(ol_txrx_soc_handle soc,
 					 struct cdp_ctrl_mlo_mgr *ctrl_ctxt)

+ 9 - 12
dp/wifi3.0/be/mlo/dp_mlo.c

@@ -24,12 +24,14 @@
 #include <dp_internal.h>
 #include <wlan_cfg.h>
 #include <wlan_mlo_mgr_cmn.h>
-/*
- * dp_mlo_ctxt_attach_wifi3 () – Attach DP MLO context
+
+/**
+ * dp_mlo_ctxt_attach_wifi3() - Attach DP MLO context
+ * @ctrl_ctxt: CDP control context
  *
  * Return: DP MLO context handle on success, NULL on failure
  */
-struct cdp_mlo_ctxt *
+static struct cdp_mlo_ctxt *
 dp_mlo_ctxt_attach_wifi3(struct cdp_ctrl_mlo_mgr *ctrl_ctxt)
 {
 	struct dp_mlo_ctxt *mlo_ctxt =
@@ -60,16 +62,13 @@ dp_mlo_ctxt_attach_wifi3(struct cdp_ctrl_mlo_mgr *ctrl_ctxt)
 	return dp_mlo_ctx_to_cdp(mlo_ctxt);
 }
 
-qdf_export_symbol(dp_mlo_ctxt_attach_wifi3);
-
-/*
- * dp_mlo_ctxt_detach_wifi3 () – Detach DP MLO context
- *
- * @ml_ctxt: pointer to DP MLO context
+/**
+ * dp_mlo_ctxt_detach_wifi3() - Detach DP MLO context
+ * @cdp_ml_ctxt: pointer to CDP DP MLO context
  *
  * Return: void
  */
-void dp_mlo_ctxt_detach_wifi3(struct cdp_mlo_ctxt *cdp_ml_ctxt)
+static void dp_mlo_ctxt_detach_wifi3(struct cdp_mlo_ctxt *cdp_ml_ctxt)
 {
 	struct dp_mlo_ctxt *mlo_ctxt = cdp_mlo_ctx_to_dp(cdp_ml_ctxt);
 
@@ -81,8 +80,6 @@ void dp_mlo_ctxt_detach_wifi3(struct cdp_mlo_ctxt *cdp_ml_ctxt)
 	qdf_mem_free(mlo_ctxt);
 }
 
-qdf_export_symbol(dp_mlo_ctxt_detach_wifi3);
-
 /*
  * dp_mlo_set_soc_by_chip_id() – Add DP soc to ML context soc list
  *