From 83953b769c7524557dbc08f1590633568a2c896a Mon Sep 17 00:00:00 2001 From: Rajeev Kumar Date: Mon, 26 Feb 2018 16:14:09 -0800 Subject: [PATCH] qcacmn: Change return type of fw down callback from void to bool Change the signature of QDF FW down callback API to return bool instead of void. Return type true indicates fw is down and return type false indicates fw is not down. Change-Id: I2be6f14e5fbdb7b24ccd604244e1314a8f127291 CRs-Fixed: 2196217 --- qdf/inc/qdf_util.h | 10 ++++++++-- qdf/src/qdf_util.c | 6 +++--- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/qdf/inc/qdf_util.h b/qdf/inc/qdf_util.h index be0f470ef4..c0e87ed761 100644 --- a/qdf/inc/qdf_util.h +++ b/qdf/inc/qdf_util.h @@ -42,7 +42,12 @@ #endif typedef __qdf_wait_queue_head_t qdf_wait_queue_head_t; -typedef void (*qdf_fw_down_callback)(void); +/** + * qdf_is_fw_down_callback - callback to query if fw is down + * + * Return: true if fw is down and false if fw is not down + */ +typedef bool (*qdf_is_fw_down_callback)(void); /** * qdf_unlikely - Compiler-dependent macro denoting code likely to execute @@ -673,8 +678,9 @@ void qdf_get_random_bytes(void *buf, int nbytes) /** * qdf_register_fw_down_callback() - API to register fw down callback + * @is_fw_down: callback to query if fw is down or not * * Return: none */ -void qdf_register_fw_down_callback(qdf_fw_down_callback *fw_down_callback); +void qdf_register_fw_down_callback(qdf_is_fw_down_callback *is_fw_down); #endif /*_QDF_UTIL_H*/ diff --git a/qdf/src/qdf_util.c b/qdf/src/qdf_util.c index fa557b1f8a..89c823821b 100644 --- a/qdf/src/qdf_util.c +++ b/qdf/src/qdf_util.c @@ -19,10 +19,10 @@ #include "qdf_module.h" #include "qdf_util.h" -static qdf_fw_down_callback *is_fw_down_cb; +static qdf_is_fw_down_callback *is_fw_down_cb; -void qdf_register_fw_down_callback(qdf_fw_down_callback *fw_down_callback) +void qdf_register_fw_down_callback(qdf_is_fw_down_callback *is_fw_down) { - is_fw_down_cb = fw_down_callback; + is_fw_down_cb = is_fw_down; } qdf_export_symbol(qdf_register_fw_down_callback);