samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

disp: msm: dsi: add check before buffer copy

Browse Source 
This change adds a check for the length of the buffer
before copying it to avoid a buffer overflow.

Change-Id: I146895660be4060d9896706636257a57c6aef94f
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
This commit is contained in:
Satya Rama Aditya Pinapala
2019-07-19 16:07:23 -07:00
committed by Gerrit - the friendly Code Review server
parent a6bfb7fc1e
commit 804f6e0de2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
msm/dsi/dsi_ctrl.c
View File

@@ -116,7 +116,7 @@ static ssize_t debugfs_state_info_read(struct file *file,
dsi_ctrl->clk_freq.pix_clk_rate, dsi_ctrl->clk_freq.pix_clk_rate,
dsi_ctrl->clk_freq.esc_clk_rate); dsi_ctrl->clk_freq.esc_clk_rate);
/* TODO: make sure that this does not exceed 4K */ len = min_t(size_t, len, SZ_4K);
if (copy_to_user(buff, buf, len)) { if (copy_to_user(buff, buf, len)) {
kfree(buf); kfree(buf);
return -EFAULT; return -EFAULT;
@@ -172,7 +172,7 @@ static ssize_t debugfs_reg_dump_read(struct file *file,
} }
/* TODO: make sure that this does not exceed 4K */ len = min_t(size_t, len, SZ_4K);
if (copy_to_user(buff, buf, len)) { if (copy_to_user(buff, buf, len)) {
kfree(buf); kfree(buf);
return -EFAULT; return -EFAULT;