Browse Source

qcacmn: Do not return error if ol_ctx is NULL

For chips that do not use BMI, the epping enable process
will break if the epping_enable() flow is returned when
ol_ctx is NULL. This should not happen because ol_ctx
is only used when BMI is enabled. Whenever ol_ctx is referred
to, it will be checked for NULL before use, so we should
not return error here.

Change-Id: Ia873536a294b79f774193493646519163baf28c4
CRs-Fixed: 2901231
Guisen Yang 4 years ago
parent
commit
7f654edca5
1 changed files with 1 additions and 6 deletions
  1. 1 6
      utils/epping/src/epping_main.c

+ 1 - 6
utils/epping/src/epping_main.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2014-2019 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2014-2019,2021 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -274,11 +274,6 @@ int epping_enable(struct device *parent_dev, bool rtnl_held)
 	tgt_info = hif_get_target_info_handle(scn);
 
 	ol_ctx = cds_get_context(QDF_MODULE_ID_BMI);
-	if (!ol_ctx) {
-		QDF_TRACE(QDF_MODULE_ID_QDF, QDF_TRACE_LEVEL_FATAL,
-			  "%s: ol_ctx is NULL", __func__);
-		return A_ERROR;
-	}
 
 	if (epping_bmi_download_fw(ol_ctx) != QDF_STATUS_SUCCESS)
 		return A_ERROR;