Prechádzať zdrojové kódy

qcacld-3.0: Add mac_handle null pointer checks

Current code does not have null pointer checks
in functions: hdd_cm_update_rssi_snr_by_bssid,
and hdd_send_mlo_ps_to_fw.
Fix this by adding null pointer checks.

Change-Id: Iee17b8371bebbb158ba188c22a0d04cabdf12f0c
CRs-Fixed: 3562611
Mohammed Ahmed 1 rok pred
rodič
commit
7ee13f112f

+ 7 - 1
core/hdd/src/wlan_hdd_cm_connect.c

@@ -201,9 +201,15 @@ void hdd_cm_update_rssi_snr_by_bssid(struct wlan_hdd_link_info *link_info)
 	struct hdd_adapter *adapter = link_info->adapter;
 	mac_handle_t mac_handle;
 
+	if (!adapter) {
+		hdd_err_rl("null hdd_adapter pointer");
+		return;
+	}
+
 	mac_handle = hdd_adapter_get_mac_handle(adapter);
+
 	if (!mac_handle) {
-		hdd_err("mac_handle is NULL");
+		hdd_err_rl("null mac_handle pointer");
 		return;
 	}
 

+ 26 - 2
core/hdd/src/wlan_hdd_power.c

@@ -628,7 +628,19 @@ out:
 static void hdd_send_mlo_ps_to_fw(struct hdd_adapter *adapter)
 {
 	struct wlan_hdd_link_info *link_info;
-	mac_handle_t mac_handle = hdd_adapter_get_mac_handle(adapter);
+	mac_handle_t mac_handle;
+
+	if (!adapter) {
+		hdd_err_rl("null hdd_adapter pointer");
+		return;
+	}
+
+	mac_handle = hdd_adapter_get_mac_handle(adapter);
+
+	if (!mac_handle) {
+		hdd_err_rl("null mac_handle pointer");
+		return;
+	}
 
 	hdd_adapter_for_each_active_link_info(adapter, link_info)
 		sme_ps_update(mac_handle, link_info->vdev_id);
@@ -639,7 +651,19 @@ static void hdd_send_mlo_ps_to_fw(struct hdd_adapter *adapter)
 	int i;
 	struct hdd_adapter *link_adapter;
 	struct hdd_mlo_adapter_info *mlo_adapter_info;
-	mac_handle_t mac_handle = hdd_adapter_get_mac_handle(adapter);
+	mac_handle_t mac_handle;
+
+	if (!adapter) {
+		hdd_err_rl("null hdd_adapter pointer");
+		return;
+	}
+
+	mac_handle = hdd_adapter_get_mac_handle(adapter);
+
+	if (!mac_handle) {
+		hdd_err_rl("null mac_handle pointer");
+		return;
+	}
 
 	mlo_adapter_info = &adapter->mlo_adapter_info;
 	for (i = 0; i < WLAN_MAX_MLD; i++) {