Browse Source

qcacmn: Fix uninitialized variable in target_if_process_sfft_report_gen3

Uninitialized detector ID is passed to the get_spectral_mode API. Fix it.

CRs-Fixed: 3033507
Change-Id: Ifa621791c19adef2de41cb53ef8581aabff7725f
Shiva Krishna Pittala 3 years ago
parent
commit
7c49199b38
1 changed files with 8 additions and 7 deletions
  1. 8 7
      target_if/spectral/target_if_spectral_phyerr.c

+ 8 - 7
target_if/spectral/target_if_spectral_phyerr.c

@@ -3072,13 +3072,6 @@ target_if_process_sfft_report_gen3(
 		return QDF_STATUS_E_NULL_VALUE;
 	}
 
-	spectral_mode = target_if_get_spectral_mode(p_sfft->fft_detector_id,
-						    &spectral->rparams);
-	if (spectral_mode >= SPECTRAL_SCAN_MODE_MAX) {
-		spectral_err_rl("No valid Spectral mode for detector id %u",
-				p_sfft->fft_detector_id);
-		return QDF_STATUS_E_FAILURE;
-	}
 	/*
 	 * For easy comparision between MDK team and OS team, the MDK script
 	 * variable names have been used
@@ -3129,6 +3122,14 @@ target_if_process_sfft_report_gen3(
 		return QDF_STATUS_E_FAILURE;
 	}
 
+	spectral_mode = target_if_get_spectral_mode(p_sfft->fft_detector_id,
+						    &spectral->rparams);
+	if (spectral_mode >= SPECTRAL_SCAN_MODE_MAX) {
+		spectral_err_rl("No valid Spectral mode for detector id %u",
+				p_sfft->fft_detector_id);
+		return QDF_STATUS_E_FAILURE;
+	}
+
 	/* Populate the Search FFT Info */
 	p_sfft->timestamp = p_fft_report->fft_timestamp;
 	p_sfft->last_raw_timestamp = spectral->timestamp_war.