qcacmn: Fix OSIF Documentation

The kernel-doc script identified some documentation issues in the
os_if folder, so fix most of them. However do not modify the file
qca_vendor.h since most of the issues there are present upstream, and
the downstream file should match the upstream file.

Change-Id: I71948fb497c1ea2d1dd46308277d99beefde18b8
CRs-Fixed: 3390428

os_if/linux/cp_stats/inc/wlan_cfg80211_ic_cp_stats.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -66,7 +67,7 @@ int wlan_cfg80211_get_pdev_cp_stats(struct wlan_objmgr_pdev *pdev_obj,
 
 #ifdef WLAN_ATF_ENABLE
 /**
- * wlan_cfg80211_get_peer_atf_cp_stats() - API to get ATF peer stats object
+ * wlan_cfg80211_get_atf_peer_cp_stats() - API to get ATF peer stats object
  * @peer_obj: peer object as input
  * @atf_cp_stats: atf peer cp stats object to populate
  *
@@ -77,7 +78,7 @@ wlan_cfg80211_get_atf_peer_cp_stats(struct wlan_objmgr_peer *peer_obj,
 				    struct atf_peer_cp_stats *atf_cp_stats);
 
 /**
- * wlan_cfg80211_get_peer_atf_cp_stats_from_mac() - API to get ATF peer
+ * wlan_cfg80211_get_atf_peer_cp_stats_from_mac() - API to get ATF peer
  * stats object from peer mac address
  * @vdev_obj: vdev object as input
  * @mac: peer mac address as input

os_if/linux/crypto/inc/wlan_cfg80211_crypto.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2019-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -61,7 +61,7 @@ void wlan_cfg80211_translate_key(struct wlan_objmgr_vdev *vdev,
  * @key_index: Index to be set as the default
  * @key_type: denotes if the key is pairwise or group key
  * @mac_addr: BSSID for which the key is to be set
- * @key_params: Params received from the kernel
+ * @params: Key params received from the kernel
  *
  * Return: Zero for success and negative for failure.
  */

os_if/linux/crypto/inc/wlan_nl_to_crypto_params.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -37,7 +38,7 @@ osif_nl_to_crypto_auth_type(enum nl80211_auth_type auth_type);
 
 /**
  * osif_nl_to_crypto_akm_type() - populate akm type for crypto
- * @akm_type: NL akm_type
+ * @key_mgmt: NL akm_type
  *
  * set the crypto akm type for corresponding akm type received
  * from NL

os_if/linux/crypto/src/wlan_nl_to_crypto_params.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2019-2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -39,7 +39,7 @@
 #include "wlan_crypto_global_def.h"
 
 /**
- * struct osif_akm_crypto_mapping - mapping akm type received from
+ * struct osif_akm_type_crypto_mapping - mapping akm type received from
  *                                 NL to internal crypto type
  * @akm_suite: NL akm type
  * @akm_type_crypto: akm crypto type
@@ -66,7 +66,7 @@ struct osif_cipher_crypto_mapping {
 	u32 cipher_len;
 };
 
-/**
+/*
  * mapping table for auth type received from NL and crypto auth type
  */
 static const wlan_crypto_auth_mode

os_if/linux/gpio/inc/wlan_cfg80211_gpio.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -36,6 +37,7 @@ extern const struct nla_policy
 
 /**
  * wlan_cfg80211_start_gpio_config() - set GPIO config
+ * @wiphy: target wiphy
  * @psoc: pointer to psoc common object
  * @data: Pointer to the data to be passed via vendor interface
  * @data_len: Length of the data to be passed

os_if/linux/mlme/inc/osif_cm_util.h

@@ -334,18 +334,18 @@ typedef QDF_STATUS
 #endif
 
 /**
- * osif_cm_ops: connection manager legacy callbacks
- * @osif_cm_connect_comp_cb: callback for connect complete to legacy
+ * struct osif_cm_ops - connection manager legacy callbacks
+ * @connect_complete_cb: callback for connect complete to legacy
  * modules
- * @osif_cm_disconnect_comp_cb: callback for disconnect complete to
+ * @disconnect_complete_cb: callback for disconnect complete to
  * legacy modules
- * @osif_cm_netif_queue_ctrl_cb: callback to legacy module to take
+ * @netif_queue_control_cb: callback to legacy module to take
  * actions on netif queue
- * @os_if_cm_napi_serialize_ctrl_cb: callback to legacy module to take
+ * @napi_serialize_control_cb: callback to legacy module to take
  * actions on napi serialization
  * @save_gtk_cb : callback to legacy module to save gtk
  * @send_vdev_keys_cb: callback to send vdev keys
- * @osif_cm_get_scan_ie_params_cb: callback to get scan ie params
+ * @get_scan_ie_params_cb: callback to get scan ie params
  * @set_hlp_data_cb: callback to legacy module to save hlp data
  * @ft_preauth_complete_cb: callback to legacy module to send fast
  * transition event

os_if/linux/mlme/inc/wlan_cfg80211_vdev_mlme.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -30,7 +31,7 @@
 #include "include/wlan_vdev_mlme.h"
 
 /**
- * wlan_cfg80211_vdev_mlme_get_param_ssid() – cfg80211 MLME API to
+ * wlan_cfg80211_vdev_mlme_get_param_ssid() - cfg80211 MLME API to
  * get ssid
  * @vdev: pointer to vdev object
  * @ssid: pointer to store the ssid
@@ -44,7 +45,7 @@ wlan_cfg80211_vdev_mlme_get_param_ssid(struct wlan_objmgr_vdev *vdev,
 				       uint8_t *ssid_len);
 
 /**
- * wlan_cfg80211_vdev_mlme_get_trans_bssid() – cfg80211 MLME API to
+ * wlan_cfg80211_vdev_mlme_get_trans_bssid() - cfg80211 MLME API to
  * get trans bssid
  * @vdev: pointer to vdev object
  * @addr: pointer to store the addr of the transmission bssid
@@ -56,7 +57,7 @@ wlan_cfg80211_vdev_mlme_get_trans_bssid(struct wlan_objmgr_vdev *vdev,
 					uint8_t *addr);
 
 /**
- * wlan_cfg80211_vdev_mlme_set_param() – cfg80211 MLME API to fill common
+ * wlan_cfg80211_vdev_mlme_set_param() - cfg80211 MLME API to fill common
  * parameters of vdev_mlme object
  * @vdev: pointer to vdev object
  * @param_id: param id for which the value should be set
@@ -70,7 +71,7 @@ wlan_cfg80211_vdev_mlme_set_param(struct wlan_objmgr_vdev *vdev,
 				  struct wlan_vdev_mgr_cfg mlme_cfg);
 
 /**
- * wlan_cfg80211_vdev_mlme_get_param() – cfg80211 MLME API to get common
+ * wlan_cfg80211_vdev_mlme_get_param() - cfg80211 MLME API to get common
  * parameters of vdev_mlme object
  * @vdev: pointer to vdev object
  * @param_id: param id for which the value should be set

os_if/linux/mlme/src/osif_cm_connect_rsp.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2015, 2020-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -141,7 +141,7 @@ osif_get_connect_status_code(struct wlan_cm_connect_resp *rsp)
 
 /**
  * osif_convert_timeout_reason() - Convert to kernel specific enum
- * @timeout_reason: reason for connect timeout
+ * @reason: reason for connect timeout
  *
  * This function is used to convert host timeout
  * reason enum to kernel specific enum.
@@ -199,7 +199,8 @@ osif_connect_timeout(struct net_device *dev, const u8 *bssid,
  * __osif_connect_bss() - API to send connection status to supplicant
  * @dev: network device
  * @bss: bss info
- * @connect_rsp: Connection manager connect response
+ * @rsp: Connection manager connect response
+ * @status: 802.11 status code
  *
  * Context: Any context.
  * Return: void
@@ -266,7 +267,7 @@ static void __osif_connect_bss(struct net_device *dev,
  * osif_connect_bss() - API to send connection status to supplicant
  * @dev: network device
  * @bss: bss info
- * @connect_rsp: Connection manager connect response
+ * @rsp: Connection manager connect response
  *
  * The API is a wrapper to send connection status to supplicant
  *
@@ -314,7 +315,7 @@ static void osif_connect_bss(struct net_device *dev, struct cfg80211_bss *bss,
 #if defined(CFG80211_FILS_SK_OFFLOAD_SUPPORT)
 /**
  * osif_populate_fils_params() - Populate FILS keys to connect response
- * @conn_rsp_params: connect response to supplicant
+ * @rsp_params: connect response to supplicant
  * @connect_ies: Connect response IEs
  *
  * Context: Any context.
@@ -349,7 +350,7 @@ osif_populate_fils_params(struct cfg80211_connect_resp_params *rsp_params,
 #if defined(WLAN_FEATURE_FILS_SK)
 /**
  * osif_populate_fils_params() - Populate FILS keys to connect response
- * @conn_rsp_params: connect response to supplicant
+ * @rsp_params: connect response to supplicant
  * @connect_ies: Connect response IEs
  *
  * Context: Any context.
@@ -802,7 +803,7 @@ osif_connect_done(struct net_device *dev, struct cfg80211_bss *bss,
  * supplicant.
  * @dev: network device
  * @bss: bss info
- * @connect_rsp: Connection manager connect response
+ * @rsp: Connection manager connect response
  * @vdev: pointer to vdev
  *
  * The API is a wrapper to send connection status to supplicant

os_if/linux/mlme/src/osif_cm_roam_rsp.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2015,2020-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -52,17 +52,6 @@ static inline void osif_update_fils_hlp_data(struct net_device *dev,
 }
 #endif
 
-/**
- * osif_roamed_ind() - send roamed indication to cfg80211
- * @dev: network device
- * @bss: cfg80211 roamed bss pointer
- * @req_ie: IEs used in reassociation request
- * @req_ie_len: Length of the @req_ie
- * @resp_ie: IEs received in successful reassociation response
- * @resp_ie_len: Length of @resp_ie
- *
- * Return: none
- */
 #if defined CFG80211_ROAMED_API_UNIFIED || \
 	(LINUX_VERSION_CODE >= KERNEL_VERSION(4, 12, 0))
 #ifdef CFG80211_SINGLE_NETDEV_MULTI_LINK_SUPPORT
@@ -196,6 +185,19 @@ static void osif_fill_mlo_roam_params(struct wlan_objmgr_vdev *vdev,
 				      struct cfg80211_roam_info *info)
 {}
 #endif
+/**
+ * osif_roamed_ind() - send roamed indication to cfg80211
+ * @dev: network device
+ * @vdev: vdev object
+ * @rsp: CM connect response
+ * @bss: cfg80211 roamed bss pointer
+ * @req_ie: IEs used in reassociation request
+ * @req_ie_len: Length of the @req_ie
+ * @resp_ie: IEs received in successful reassociation response
+ * @resp_ie_len: Length of @resp_ie
+ *
+ * Return: none
+ */
 static void osif_roamed_ind(struct net_device *dev,
 			    struct wlan_objmgr_vdev *vdev,
 			    struct wlan_cm_connect_resp *rsp,
@@ -232,7 +234,7 @@ static inline void osif_roamed_ind(struct net_device *dev,
 #ifdef WLAN_FEATURE_ROAM_OFFLOAD
 #ifdef WLAN_FEATURE_FILS_SK
 /**
- * wlan_hdd_add_fils_params_roam_auth_event() - Adds FILS params in roam auth
+ * osif_add_fils_params_roam_auth_event() - Adds FILS params in roam auth
  * @skb: SK buffer
  * @roam_info: Roam info
  *
@@ -334,6 +336,7 @@ static uint8_t *osif_get_bss_mac_addr(struct wlan_objmgr_vdev *vdev)
  * links event response to kernel
  * @skb : sk buffer pointer
  * @vdev: vdev pointer
+ * @osif_priv: osif vdev private data
  * @rsp: Connection manager response
  *
  * This is called when wlan driver needs to send the mlo links roaming
@@ -443,6 +446,10 @@ osif_send_roam_auth_mlo_links_event(struct sk_buff *skb,
  * @vdev: vdev pointer
  * @osif_priv: OS private structure of vdev
  * @rsp: Connection manager response
+ * @req_ie: request IE
+ * @req_ie_len: request IE length
+ * @resp_ie: response IE
+ * @resp_ie_len: response IE length
  *
  * This is called when wlan driver needs to send the roaming and
  * authorization information after roaming.

os_if/linux/mlme/src/osif_cm_rsp.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2015,2020-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -47,7 +47,7 @@ QDF_STATUS osif_disconnect_handler(struct wlan_objmgr_vdev *vdev,
  * osif_cm_get_assoc_req_ie_data() - Get the assoc req IE offset and length
  * if valid assoc req is present
  * @assoc_req: assoc req info
- * @ie_data_len: IE date length to be calculated
+ * @ie_data_len: IE data length to be calculated
  * @ie_data_ptr: IE data pointer to be calculated
  *
  * Return: void
@@ -59,8 +59,8 @@ void osif_cm_get_assoc_req_ie_data(struct element_info *assoc_req,
 /**
  * osif_cm_get_assoc_rsp_ie_data() - Get the assoc resp IE offset and length
  * if valid assoc req is present
- * @assoc_req: assoc req info
- * @ie_data_len: IE date length to be calculated
+ * @assoc_rsp: assoc response info
+ * @ie_data_len: IE data length to be calculated
  * @ie_data_ptr: IE data pointer to be calculated
  *
  * Return: void
@@ -99,7 +99,7 @@ void osif_indicate_reassoc_results(struct wlan_objmgr_vdev *vdev,
 				   struct wlan_cm_connect_resp *rsp);
 
 /**
- * @osif_pmksa_candidate_notify_cb: Roam pmksa candidate notify callback
+ * osif_pmksa_candidate_notify() - Roam pmksa candidate notify callback
  * @vdev: vdev pointer
  * @bssid: bssid
  * @index: index
@@ -161,7 +161,7 @@ osif_cm_indicate_disconnect(struct wlan_objmgr_vdev *vdev,
 /**
  * osif_get_partner_info_from_mlie() - API to get partner information
  * from basic variant mlo ie
- * @rsp: Connection manager connect response for the candidate
+ * @connect_rsp: Connection manager connect response for the candidate
  * @partner_info: mlo partner info pointer
  *
  * The API is is used get partner information from basic variant ml ie.
@@ -172,11 +172,12 @@ osif_cm_indicate_disconnect(struct wlan_objmgr_vdev *vdev,
 QDF_STATUS
 osif_get_partner_info_from_mlie(struct wlan_cm_connect_resp *connect_rsp,
 				struct mlo_partner_info *partner_info);
+
 /**
  * osif_get_link_id_from_assoc_ml_ie() - API to get link id from assoc rsp
  * ml ie.
  * @rsp_link_info: pointer to mlo link info
- * @partner_info: mlo partner info pointer
+ * @assoc_partner_info: mlo partner info pointer
  * @link_id: Link id information
  *
  * The API is used to get link id from assoc response basic variant mlo ie

os_if/linux/mlme/src/osif_cm_util.c

@@ -216,8 +216,8 @@ osif_cm_failed_candidate_cb(struct wlan_objmgr_vdev *vdev,
  * osif_cm_update_id_and_src_cb() - Callback to update id and
  * source of the connect/disconnect request
  * @vdev: vdev pointer
- * @Source: Source of the connect req
- * @id: Connect/disconnect id
+ * @source: Source of the connect req
+ * @cm_id: Connect/disconnect id
  *
  * Context: Any context. Takes and releases cmd id spinlock
  * Return: QDF_STATUS
@@ -244,7 +244,7 @@ osif_cm_update_id_and_src_cb(struct wlan_objmgr_vdev *vdev,
 /**
  * osif_cm_disconnect_complete_cb() - Disconnect done callback
  * @vdev: vdev pointer
- * @disconnect_rsp: Disconnect response
+ * @rsp: Disconnect response
  *
  * Context: Any context
  * Return: QDF_STATUS
@@ -309,7 +309,7 @@ osif_cm_roam_sync_cb(struct wlan_objmgr_vdev *vdev)
 }
 
 /**
- * @osif_pmksa_candidate_notify_cb: Roam pmksa candidate notify callback
+ * osif_pmksa_candidate_notify_cb() - Roam pmksa candidate notify callback
  * @vdev: vdev pointer
  * @bssid: bssid
  * @index: index
@@ -328,6 +328,9 @@ osif_pmksa_candidate_notify_cb(struct wlan_objmgr_vdev *vdev,
 /**
  * osif_cm_send_keys_cb() - Send keys callback
  * @vdev: vdev pointer
+ * @key_index: key index
+ * @pairwise: true if pairwise
+ * @cipher_type: cipher type
  *
  * This callback indicates os_if that
  * so that os_if can stop all the activity on this connection
@@ -406,7 +409,6 @@ osif_cm_roam_abort_cb(struct wlan_objmgr_vdev *vdev)
 /**
  * osif_cm_roam_cmpl_cb() - Roam sync complete callback
  * @vdev: vdev pointer
- * @rsp: connect rsp
  *
  * This callback indicates os_if that roam sync is complete
  * so that os_if can stop all the activity on this connection

os_if/linux/scan/inc/wlan_cfg80211_scan.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2017-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -65,8 +65,7 @@ extern const struct nla_policy cfg80211_scan_policy[
 #define SCAN_WAKE_LOCK_SCAN_DURATION (5 * 1000) /* in msec */
 
 /**
- * typedef struct qcom_ie_age - age ie
- *
+ * typedef qcom_ie_age - age ie
  * @element_id: Element id
  * @len: Length
  * @oui_1: OUI 1
@@ -93,11 +92,11 @@ typedef struct {
 
 /**
  * struct osif_scan_pdev - OS scan private structure
- * scan_req_q: Scan request queue
- * scan_req_q_lock: Protect scan request queue
- * req_id: Scan request Id
- * runtime_pm_lock: Runtime suspend lock
- * scan_wake_lock: Scan wake lock
+ * @scan_req_q: Scan request queue
+ * @scan_req_q_lock: Protect scan request queue
+ * @req_id: Scan request Id
+ * @runtime_pm_lock: Runtime suspend lock
+ * @scan_wake_lock: Scan wake lock
  */
 struct osif_scan_pdev{
 	qdf_list_t scan_req_q;
@@ -279,7 +278,7 @@ int wlan_cfg80211_scan(struct wlan_objmgr_vdev *vdev,
 /**
  * wlan_cfg80211_inform_bss_frame_data() - API to inform beacon to cfg80211
  * @wiphy: wiphy
- * @bss_data: bss data
+ * @bss: bss data
  *
  * API to inform beacon to cfg80211
  *
@@ -293,7 +292,6 @@ wlan_cfg80211_inform_bss_frame_data(struct wiphy *wiphy,
  * wlan_cfg80211_inform_bss_frame() - API to inform beacon to cfg80211
  * @pdev: Pointer to pdev
  * @scan_params: scan entry
- * @request: Pointer to scan request
  *
  * API to inform beacon to cfg80211
  *
@@ -401,7 +399,7 @@ void wlan_cfg80211_cleanup_scan_queue(struct wlan_objmgr_pdev *pdev,
 				      struct net_device *dev);
 
 /**
- * wlan_hdd_cfg80211_add_connected_pno_support() - Set connected PNO support
+ * wlan_scan_cfg80211_add_connected_pno_support() - Set connected PNO support
  * @wiphy: Pointer to wireless phy
  *
  * This function is used to set connected PNO support to kernel
@@ -423,9 +421,9 @@ void wlan_scan_cfg80211_add_connected_pno_support(struct wiphy *wiphy)
 		defined(CFG80211_MULTI_SCAN_PLAN_BACKPORT)) && \
 		defined(FEATURE_WLAN_SCAN_PNO)
 /**
- * hdd_config_sched_scan_plans_to_wiphy() - configure sched scan plans to wiphy
+ * wlan_config_sched_scan_plans_to_wiphy() - configure sched scan plans to wiphy
  * @wiphy: pointer to wiphy
- * @config: pointer to config
+ * @psoc: pointer to psoc object
  *
  * Return: None
  */

os_if/linux/scan/src/wlan_cfg80211_scan.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2017-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -166,6 +166,7 @@ static void wlan_scan_rand_attrs(struct wlan_objmgr_vdev *vdev,
 /**
  * wlan_config_sched_scan_plan() - configures the sched scan plans
  *   from the framework.
+ * @psoc: psoc object
  * @pno_req: pointer to PNO scan request
  * @request: pointer to scan request from framework
  *
@@ -756,11 +757,12 @@ wlan_schedule_scan_start_request(struct wlan_objmgr_pdev *pdev,
 
 /**
  * wlan_scan_request_dequeue() - dequeue scan request
- * @nl_ctx: Global HDD context
+ * @pdev: pdev object
  * @scan_id: scan id
  * @req: scan request
- * @dev: net device
  * @source : returns source of the scan request
+ * @dev: returns source net device
+ * @scan_start_timestamp: returns scan start timestamp
  *
  * Return: QDF_STATUS
  */
@@ -875,7 +877,7 @@ void wlan_cfg80211_scan_done(struct net_device *netdev,
  * @netdev: Net device
  * @req : Scan request
  * @aborted : true scan aborted false scan success
- * @osif_priv - OS private structure
+ * @osif_priv: OS private structure
  *
  * This function notifies scan done to cfg80211
  *
@@ -1377,7 +1379,8 @@ void wlan_cfg80211_cleanup_scan_queue(struct wlan_objmgr_pdev *pdev,
 /**
  * wlan_cfg80211_update_scan_policy_type_flags() - Set scan flags according to
  * scan request
- * @scan_req: Pointer to csr scan req
+ * @req: scan request to populate
+ * @scan_req: Pointer to scan request params
  *
  * Return: None
  */
@@ -2007,8 +2010,8 @@ static inline void wlan_add_age_ie(uint8_t *mgmt_frame,
 	defined(CFG80211_INFORM_BSS_FRAME_DATA)
 /**
  * wlan_fill_per_chain_rssi() - fill per chain RSSI in inform bss
- * @data: bss data
- * @per_chain_snr: per chain RSSI
+ * @data: destination bss data
+ * @bss: source bss data containing per chain RSSI
  *
  * Return: void
  */

os_if/linux/spectral/inc/wlan_cfg80211_spectral.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2017, 2019-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -71,8 +72,7 @@ wlan_spectral_get_phy_ch_width(uint8_t nl_chwidth);
 /**
  * wlan_cfg80211_register_spectral_cmd_handler() - Registration api for spectral
  * @pdev:    Pointer to pdev
- * @idx:     Index in function table
- * @handler: Pointer to handler
+ * @handlers: Pointer to handlers
  *
  * Return: 0 on success, negative value on failure
  */

os_if/linux/spectral/src/os_if_spectral_netlink.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2011, 2017-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  *
  * Permission to use, copy, modify, and/or distribute this software for
@@ -35,7 +36,7 @@
 
 /**
  * os_if_spectral_remove_nbuf_debug_entry() - Remove nbuf from nbuf debug table
- * @nbuf - nbuf to remove from the nbuf debug table
+ * @nbuf: nbuf to remove from the nbuf debug table
  *
  * Remove nbuf from the nbuf debug hash table and decrement the nbuf count
  *

os_if/linux/twt/inc/osif_twt_req.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -17,7 +17,7 @@
  */
 
 /**
- * DOC : osif_twt_req.h
+ * DOC: osif_twt_req.h
  *
  */
 

os_if/linux/twt/inc/osif_twt_rsp.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -17,7 +17,7 @@
  */
 
 /**
- * DOC : osif_twt_rsp.h
+ * DOC: osif_twt_rsp.h
  *
  */
 

os_if/linux/twt/inc/osif_twt_util.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -17,7 +17,7 @@
  */
 
 /**
- * DOC : osif_twt_util.h
+ * DOC: osif_twt_util.h
  *
  */
 
@@ -27,7 +27,8 @@
 #if defined(WLAN_SUPPORT_TWT) && defined(WLAN_TWT_CONV_SUPPORTED)
 /**
  * struct twt_en_dis_priv - twt enable/disable private context
- * @vdev_id: vdev id
+ * @pdev_id: pdev id
+ * @status: TWT status
  */
 struct twt_en_dis_priv {
 	uint32_t pdev_id;

os_if/linux/wifi_pos/inc/os_if_wifi_pos.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2017, 2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -127,6 +127,7 @@ static inline int os_if_wifi_pos_populate_caps(struct wlan_objmgr_psoc *psoc,
  * @CLD80211_VENDOR_SUB_CMD_OEM_DATA: oem data req/rsp
  * @CLD80211_VENDOR_SUB_CMD_OEM_ERROR: oem error rsp
  * @CLD80211_VENDOR_SUB_CMD_PEER_STATUS_IND: peer status indication
+ * @CLD80211_VENDOR_SUB_CMD__AFTER_LAST: internal marker
  * @CLD80211_VENDOR_SUB_CMD_MAX: Max cld80211 vendor sub cmds
  */
 enum cld80211_vendor_sub_cmds {
@@ -160,6 +161,7 @@ enum cld80211_vendor_sub_cmds {
  * @CLD80211_SUB_ATTR_CAPS_CURRENT_DWELL_TIME_MAX: Current dwell time max
  * @CLD80211_SUB_ATTR_CAPS_SUPPORTED_BANDS: Supported bands
  * @CLD80211_SUB_ATTR_CAPS_USER_DEFINED_CAPS: User defined capabilities
+ * @CLD80211_SUB_ATTR_CAPS_AFTER_LAST: internal marker
  * @CLD80211_SUB_ATTR_CAPS_MAX: Max number for CAP sub attribute
  *
  */
@@ -190,7 +192,7 @@ enum cld80211_sub_attr_cap_rsp {
  * @CLD80211_SUB_ATTR_CH_RESP_INVALID: Invalid channel resp
  * @CLD80211_SUB_ATTR_CH_MORE_DATA: More date sub attr for frag response
  * @CLD80211_SUB_ATTR_CHANNEL_NUM_CHAN: Number of channels in response
- * @CLD80211_SUB_ATTR_CHANNEL_LIST: Channel list nesting
+ * @CLD80211_SUB_ATTR_CH_LIST: Channel list nesting
  * @CLD80211_SUB_ATTR_CH_CHAN_ID: Channel number
  * @CLD80211_SUB_ATTR_CH_MHZ: Channel frequency
  * @CLD80211_SUB_ATTR_CH_BAND_CF_1: Center frequency 1
@@ -198,7 +200,8 @@ enum cld80211_sub_attr_cap_rsp {
  * @CLD80211_SUB_ATTR_CH_INFO: channel info
  * @CLD80211_SUB_ATTR_CH_REG_INFO_1: regulatory info field 1
  * @CLD80211_SUB_ATTR_CH_REG_INFO_2: regulatory info field 2
- * @CLD80211_SUB_ATTR_CAPS_MAX: Max number for CHAN Info sub attribute
+ * @CLD80211_SUB_ATTR_CH_AFTER_LAST: internal marker
+ * @CLD80211_SUB_ATTR_CH_MAX: Max number for CHAN Info sub attribute
  *
  */
 enum cld80211_sub_attr_channel_rsp {
@@ -227,6 +230,7 @@ enum cld80211_sub_attr_channel_rsp {
  * @CLD80211_SUB_ATTR_MSG_OEM_DATA_INVALID: Invalid OEM data request
  * @CLD80211_SUB_ATTR_MSG_OEM_DATA_FW: Data to Firmware
  * @CLD80211_SUB_ATTR_MSG_OEM_DATA_DRIVER: Data to driver
+ * @CLD80211_SUB_ATTR_MSG_OEM_DATA_REQ_AFTER_LAST: internal marker
  * @CLD80211_SUB_ATTR_MSG_OEM_DATA_REQ_MAX: Max number for OEM data req sub
  * attribute
  *
@@ -250,6 +254,7 @@ enum cld80211_sub_attr_oem_data_req {
  * @CLD80211_SUB_ATTR_OEM_DATA_INVALID: Invalid oem data resp
  * @CLD80211_SUB_ATTR_OEM_MORE_DATA: more date sub attribute
  * @CLD80211_SUB_ATTR_BINARY_DATA: Binary data sub attribute
+ * @CLD80211_SUB_ATTR_OEM_DATA_RESP_AFTER_LAST: internal marker
  * @CLD80211_SUB_ATTR_OEM_DATA_RESP_MAX: Max number for OEM data resp
  * sub attribute
  *
@@ -277,6 +282,8 @@ enum cld80211_sub_attr_oem_data_resp {
  * @CLD80211_SUB_ATTR_PEER_CAPABILITY: peer capabilities
  * @CLD80211_SUB_ATTR_PEER_RESERVED: reserved bytes
  * @CLD80211_SUB_ATTR_PEER_CHAN_INFO: peer channel info
+ * @CLD80211_SUB_ATTR_PEER_AFTER_LAST: internal marker
+ * @CLD80211_SUB_ATTR_PEER_MAX: Max number for peer sub attribute
  *
  */
 enum cld80211_sub_attr_peer_info {

os_if/linux/wifi_pos/src/os_if_wifi_pos.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -573,6 +573,11 @@ static void os_if_send_nl_resp(uint32_t pid, uint8_t *buf,
 
 /**
  * os_if_wifi_pos_send_rsp() - send oem registration response
+ * @psoc: soc object
+ * @pid: registering process ID
+ * @cmd: OEM command
+ * @buf_len: length of the OEM message in @buf
+ * @buf: OEM message
  *
  * This function sends oem message to registered application process
  *
@@ -884,14 +889,17 @@ static int wifi_pos_parse_req(struct sk_buff *skb, struct wifi_pos_req_msg *req,
 }
 #endif
 
+#ifdef CNSS_GENL
 /**
  * __os_if_wifi_pos_callback() - callback registered with NL service socket to
  * process wifi pos request
- * @skb: request message sk_buff
+ * @data: request message buffer
+ * @data_len: length of @data
+ * @ctx: context registered with the dispatcher (unused)
+ * @pid: caller process ID
  *
  * Return: status of operation
  */
-#ifdef CNSS_GENL
 static void __os_if_wifi_pos_callback(const void *data, int data_len,
 				      void *ctx, int pid)
 {
@@ -936,6 +944,13 @@ static void os_if_wifi_pos_callback(const void *data, int data_len,
 	qdf_op_unprotect(op_sync);
 }
 #else
+/**
+ * __os_if_wifi_pos_callback() - callback registered with NL service socket to
+ * process wifi pos request
+ * @skb: request message sk_buff
+ *
+ * Return: status of operation
+ */
 static int __os_if_wifi_pos_callback(struct sk_buff *skb)
 {
 	uint8_t err;

os_if/linux/wlan_cfg80211.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2016-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -104,6 +104,11 @@
  * @QCA_NL80211_VENDOR_SUBCMD_TDLS_STATE_CHANGE_INDEX: Ext tdls state change
  * @QCA_NL80211_VENDOR_SUBCMD_DO_ACS_INDEX: ACS command
  * @QCA_NL80211_VENDOR_SUBCMD_KEY_MGMT_ROAM_AUTH_INDEX: Pass Roam and Auth info
+ * @QCA_NL80211_VENDOR_SUBCMD_DFS_OFFLOAD_CAC_STARTED_INDEX:
+ * @QCA_NL80211_VENDOR_SUBCMD_DFS_OFFLOAD_CAC_FINISHED_INDEX:
+ * @QCA_NL80211_VENDOR_SUBCMD_DFS_OFFLOAD_CAC_ABORTED_INDEX:
+ * @QCA_NL80211_VENDOR_SUBCMD_DFS_OFFLOAD_CAC_NOP_FINISHED_INDEX:
+ * @QCA_NL80211_VENDOR_SUBCMD_DFS_OFFLOAD_RADAR_DETECTED_INDEX:
  * @QCA_NL80211_VENDOR_SUBCMD_EXTSCAN_HOTLIST_AP_LOST_INDEX: hotlist ap lost
  * @QCA_NL80211_VENDOR_SUBCMD_EXTSCAN_PNO_NETWORK_FOUND_INDEX:
  *	pno network found index
@@ -117,7 +122,10 @@
  *	hotlist ssid found index
  * @QCA_NL80211_VENDOR_SUBCMD_EXTSCAN_HOTLIST_SSID_LOST_INDEX:
  *	hotlist ssid lost index
- * @QCA_NL80211_VENDOR_SUBCMD_DCC_STATS_EVENT_INDEX
+ * @QCA_NL80211_VENDOR_SUBCMD_GET_WIFI_CONFIGURATION_INDEX:
+ * @QCA_NL80211_VENDOR_SUBCMD_MONITOR_RSSI_INDEX:
+ * @QCA_NL80211_VENDOR_SUBCMD_WIFI_LOGGER_MEMORY_DUMP_INDEX:
+ * @QCA_NL80211_VENDOR_SUBCMD_DCC_STATS_EVENT_INDEX:
  *	dcc stats event index
  * @QCA_NL80211_VENDOR_SUBCMD_SCAN_INDEX: vendor scan index
  * @QCA_NL80211_VENDOR_SUBCMD_SCAN_DONE_INDEX:
@@ -127,17 +135,26 @@
  * @QCA_NL80211_VENDOR_SUBCMD_INTEROP_ISSUES_AP_INDEX:
  *	update aps info which has interop issues events index
  * @QCA_NL80211_VENDOR_SUBCMD_TSF_INDEX: TSF response events index
+ * @QCA_NL80211_VENDOR_SUBCMD_NDP_INDEX:
  * @QCA_NL80211_VENDOR_SUBCMD_P2P_LO_EVENT_INDEX:
  *      P2P listen offload index
  * @QCA_NL80211_VENDOR_SUBCMD_SAP_CONDITIONAL_CHAN_SWITCH_INDEX: SAP
  *      conditional channel switch index
+ * @QCA_NL80211_VENDOR_SUBCMD_UPDATE_EXTERNAL_ACS_CONFIG:
+ * @QCA_NL80211_VENDOR_SUBCMD_PWR_SAVE_FAIL_DETECTED_INDEX:
  * @QCA_NL80211_VENDOR_SUBCMD_NUD_STATS_GET_INDEX: NUD DEBUG Stats index
  * @QCA_NL80211_VENDOR_SUBCMD_HANG_REASON_INDEX: hang event reason index
  * @QCA_NL80211_VENDOR_SUBCMD_WLAN_MAC_INFO_INDEX: MAC mode info index
  * @QCA_NL80211_VENDOR_SUBCMD_NAN_EXT_INDEX: NAN Extended index
+ * @QCA_NL80211_VENDOR_SUBCMD_THROUGHPUT_CHANGE_EVENT_INDEX:
+ * @QCA_NL80211_VENDOR_SUBCMD_LINK_PROPERTIES_INDEX:
+ * @QCA_NL80211_VENDOR_SUBCMD_PEER_STATS_CACHE_FLUSH_INDEX:
  * @QCA_NL80211_VENDOR_SUBCMD_BEACON_REPORTING_INDEX: Beacon reporting index
+ * @QCA_NL80211_VENDOR_SUBCMD_ROAM_INDEX:
+ * @QCA_NL80211_VENDOR_SUBCMD_OEM_DATA_INDEX:
  * @QCA_NL80211_VENDOR_SUBCMD_REQUEST_SAR_LIMITS_INDEX: Request SAR limit index
  * @QCA_NL80211_VENDOR_SUBCMD_UPDATE_STA_INFO_INDEX: Update STA info index
+ * @QCA_NL80211_VENDOR_SUBCMD_MEDIUM_ASSESS_INDEX:
  * @QCA_NL80211_VENDOR_SUBCMD_UPDATE_SSID_INDEX: Update SSID index
  * @QCA_NL80211_VENDOR_SUBCMD_WIFI_FW_STATS_INDEX: Wifi FW stats index
  * @QCA_NL80211_VENDOR_SUBCMD_MBSSID_TX_VDEV_STATUS_INDEX:
@@ -145,12 +162,18 @@
  * @QCA_NL80211_VENDOR_SUBCMD_THERMAL_INDEX: Report thermal event index
  * @QCA_NL80211_VENDOR_SUBCMD_CONFIG_TWT_INDEX: TWT config index
  * @QCA_NL80211_VENDOR_SUBCMD_PEER_CFR_CAPTURE_CFG_INDEX: CFR data event index
+ * @QCA_NL80211_VENDOR_SUBCMD_DIAG_EVENT_INDEX:
+ * @QCA_NL80211_VENDOR_SUBCMD_ROAM_EVENTS_INDEX:
+ * @QCA_NL80211_VENDOR_SUBCMD_MCC_QUOTA_INDEX:
+ * @QCA_NL80211_VENDOR_SUBCMD_PEER_FLUSH_PENDING_INDEX:
  * @QCA_NL80211_VENDOR_SUBCMD_DRIVER_READY_INDEX: Driver Ready after SSR index
+ * @QCA_NL80211_VENDOR_SUBCMD_PASN_AUTH_STATUS_INDEX: PASN auth status index
  * @QCA_NL80211_VENDOR_SUBCMD_SCS_RULE_CONFIG_INDEX: SCS rule config index
  * @QCA_NL80211_VENDOR_SUBCMD_SR_INDEX: SR Event index
  * @QCA_NL80211_VENDOR_SUBCMD_MLO_PEER_PRIM_NETDEV_EVENT_INDEX: primary netdev
  *     event index
  * @QCA_NL80211_VENDOR_SUBCMD_AFC_EVENT_INDEX: AFC Event index
+ * @QCA_NL80211_VENDOR_SUBCMD_DOZED_AP_INDEX: Dozed AP event index
  */
 
 enum qca_nl80211_vendor_subcmds_index {

os_if/linux/wlan_osif_priv.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2016-2017,2020-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -32,7 +32,7 @@ struct osif_tdls_vdev;
  * struct pdev_osif_priv - OS private structure
  * @wiphy:            wiphy handle
  * @legacy_osif_priv: legacy osif private handle
- * @scan_priv:        Scan related data used by cfg80211 scan
+ * @osif_scan:        Scan related data used by cfg80211 scan
  * @nif:              pdev net device
  * @osif_check_netdev_state: check driver internal netdev state
  */

os_if/linux/wlan_osif_request_manager.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2017-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -71,7 +72,8 @@
 struct osif_request;
 
 /**
- * typedef osif_request_dealloc - Private data deallocation function
+ * typedef osif_request_dealloc() - Private data deallocation function
+ * @priv: pointer to request private date
  */
 typedef void (*osif_request_dealloc)(void *priv);