qcacmn: Resolve duplicate hif_get_target_type definition

Duplicate deffinitions of hif_get_target_type prevented compilation
of snoc and pci functionality at the same time.

Change-Id: I44cdca79c6f296c4294a54a4e1bfb459a519f46b
CRs-Fixed: 986480

hif/src/hif_main.h

@@ -168,9 +168,6 @@ void athdiag_procfs_remove(void);
 qdf_size_t init_buffer_count(qdf_size_t maxSize);
 
 irqreturn_t hif_fw_interrupt_handler(int irq, void *arg);
-int hif_get_target_type(struct hif_softc *ol_sc, struct device *dev,
-	void *bdev, const hif_bus_id *bid, uint32_t *hif_type,
-	uint32_t *target_type);
 int hif_get_device_type(uint32_t device_id,
 			uint32_t revision_id,
 			uint32_t *hif_type, uint32_t *target_type);

hif/src/pcie/if_pci.c

@@ -3270,33 +3270,6 @@ err_enable_pci:
 	return ret;
 }
 
-/**
- * hif_get_target_type(): Get the target type
- *
- * This function is used to query the target type.
- *
- * @ol_sc: hif_softc struct pointer
- * @dev: device pointer
- * @bdev: bus dev pointer
- * @bid: bus id pointer
- * @hif_type: HIF type such as HIF_TYPE_QCA6180
- * @target_type: target type such as TARGET_TYPE_QCA6180
- *
- * Return: 0 for success
- */
-int hif_get_target_type(struct hif_softc *ol_sc, struct device *dev,
-	void *bdev, const hif_bus_id *bid, uint32_t *hif_type,
-	uint32_t *target_type)
-{
-	uint16_t revision_id;
-	struct pci_dev *pdev = bdev;
-	const struct pci_device_id *id = (const struct pci_device_id *)bid;
-
-	pci_read_config_word(pdev, 0x08, &revision_id);
-	return hif_get_device_type(id->device, revision_id,
-			hif_type, target_type);
-}
-
 /**
  * hif_pci_irq_enable() - ce_irq_enable
  * @scn: hif_softc

hif/src/snoc/if_snoc.c

@@ -178,7 +178,7 @@ int hif_snoc_bus_configure(struct hif_softc *scn)
 }
 
 /**
- * hif_get_target_type(): Get the target type
+ * hif_snoc_get_target_type(): Get the target type
  *
  * This function is used to query the target type.
  *
@@ -191,9 +191,9 @@ int hif_snoc_bus_configure(struct hif_softc *scn)
  *
  * Return: 0 for success
  */
-int hif_get_target_type(struct hif_softc *ol_sc, struct device *dev,
-	void *bdev, const hif_bus_id *bid, uint32_t *hif_type,
-	uint32_t *target_type)
+static inline int hif_snoc_get_target_type(struct hif_softc *ol_sc,
+	struct device *dev, void *bdev, const hif_bus_id *bid,
+	uint32_t *hif_type, uint32_t *target_type)
 {
 	/* TODO: need to use CNSS's HW version. Hard code for now */
 #ifdef QCA_WIFI_3_0_ADRASTEA
@@ -235,7 +235,7 @@ QDF_STATUS hif_snoc_enable_bus(struct hif_softc *ol_sc,
 		return QDF_STATUS_E_NOMEM;
 	}
 
-	ret = hif_get_target_type(ol_sc, dev, bdev, bid,
+	ret = hif_snoc_get_target_type(ol_sc, dev, bdev, bid,
 			&hif_type, &target_type);
 	if (ret < 0) {
 		HIF_ERROR("%s: invalid device id/revision_id", __func__);