samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Panic on uninitialized lock destroy

Browse Source 
Currently, if an uninitialized QDF mutex or spinlock is destroyed, the
issue is logged in dmesg. This has allowed multiple uninitialized
spinlock issues to merge into mainline and remain unnoticed for several
weeks. Instead, if an uninitialized lock is detected during destroy,
panic.

Change-Id: I929cfa3f295cb1e76634653bbd4aec3a6f1268b7
CRs-Fixed: 2347717
This commit is contained in:
Dustin Brown
2018-11-08 12:35:38 -08:00
committed by nshrivas
parent 095729006f
commit 75e3c8cc7e
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
qdf/linux/src/qdf_lock.c
View File

@@ -855,10 +855,8 @@ void qdf_lock_stats_cookie_destroy(struct lock_stats *stats)
{ {
struct qdf_lock_cookie *cookie = stats->cookie; struct qdf_lock_cookie *cookie = stats->cookie;
if (cookie == NULL) { if (!cookie) {
QDF_TRACE(QDF_MODULE_ID_QDF, QDF_TRACE_LEVEL_ERROR, QDF_DEBUG_PANIC("Lock destroyed twice or never created");
"%s: Double cookie destroy", __func__);
QDF_ASSERT(0);
return; return;
} }