Parcourir la source

qcacld-3.0: Assign op mode after null vdev check

To avoid assignment before null check for vdev.
First check null vdev and then assign operational
mode value.

Change-Id: Ifbff1f79f04d51dddf6a6c1aec27793389516045
CRs-Fixed: 3340858
Amruta Kulkarni il y a 2 ans
Parent
commit
7566d61fff

+ 2 - 1
components/umac/mlme/connection_mgr/core/src/wlan_cm_vdev_connect.c

@@ -1514,7 +1514,7 @@ cm_install_link_vdev_keys(struct wlan_objmgr_vdev *vdev)
 {
 	struct wlan_objmgr_peer *peer;
 	struct wlan_crypto_key *crypto_key;
-	enum QDF_OPMODE op_mode = wlan_vdev_mlme_get_opmode(vdev);
+	enum QDF_OPMODE op_mode;
 	uint16_t i;
 	bool pairwise;
 	uint8_t vdev_id;
@@ -1526,6 +1526,7 @@ cm_install_link_vdev_keys(struct wlan_objmgr_vdev *vdev)
 		return;
 
 	vdev_id = wlan_vdev_get_id(vdev);
+	op_mode = wlan_vdev_mlme_get_opmode(vdev);
 	if (op_mode != QDF_STA_MODE ||
 	    !wlan_vdev_mlme_is_mlo_link_vdev(vdev))
 		return;