Эх сурвалжийг харах

qcacmn: Fix flaw in cdp_update_mlo_ptnr_list() parameter

In mlo_ap_vdev_attach() we call cdp_update_mlo_ptnr_list(), and logic
exists which was supposed to test the return value for success.
However due to a misplaced parenthesis, the test for success is actually
applied to the last parameter, and that test result is sent as a
true/false value to cdp_update_mlo_ptnr_list().

To fix this issue relocate the parenthesis so that the last parameter
is correctly passed and the test for success is applied to the
return value.

Change-Id: I055150dae726a69f0e70f02f7fbe26550f48e558
CRs-Fixed: 3181220
Ruben Columbus 3 жил өмнө
parent
commit
751084e7f8

+ 3 - 3
umac/mlo_mgr/src/wlan_mlo_mgr_ap.c

@@ -50,7 +50,7 @@ bool mlo_ap_vdev_attach(struct wlan_objmgr_vdev *vdev,
 	wlan_vdev_set_link_id(vdev, link_id);
 	wlan_vdev_mlme_set_mlo_vdev(vdev);
 
-	/**
+	/*
 	 * every link will trigger mlo_ap_vdev_attach,
 	 * and they should provide the same vdev_count.
 	 */
@@ -65,7 +65,7 @@ bool mlo_ap_vdev_attach(struct wlan_objmgr_vdev *vdev,
 
 	if (cdp_update_mlo_ptnr_list(wlan_psoc_get_dp_handle(psoc),
 				pr_vdev_ids, WLAN_UMAC_MLO_MAX_VDEVS,
-				wlan_vdev_get_id(vdev) != QDF_STATUS_SUCCESS)) {
+				wlan_vdev_get_id(vdev)) != QDF_STATUS_SUCCESS) {
 		mlo_debug("Failed to add vdev to partner vdev list, vdev id:%d",
 			 wlan_vdev_get_id(vdev));
 	}
@@ -88,7 +88,7 @@ bool mlo_ap_vdev_attach(struct wlan_objmgr_vdev *vdev,
 	wlan_vdev_set_link_id(vdev, link_id);
 	wlan_vdev_mlme_set_mlo_vdev(vdev);
 
-	/**
+	/*
 	 * every link will trigger mlo_ap_vdev_attach,
 	 * and they should provide the same vdev_count.
 	 */