Ver código fonte

qcacld-3.0: Initialize variable before using it

In hdd_wmm_classify_pkt_cb, local variable user_pri and is_critical
should be initialized in hdd_wmm_classify_pkt_cb. we can't expect
hdd_wmm_classify_critical_pkt to do it.

Invalid user_pri is set to skb->priority because user_pri and
is_critical is not initialized.

Change-Id: I6d57251bcb8c7bc3d0f031f2d9b127e3e16d1b47
CRs-Fixed: 3408478
Bing Sun 2 anos atrás
pai
commit
74bdded6d9
1 arquivos alterados com 2 adições e 2 exclusões
  1. 2 2
      core/hdd/src/wlan_hdd_wmm.c

+ 2 - 2
core/hdd/src/wlan_hdd_wmm.c

@@ -2056,8 +2056,8 @@ void hdd_wmm_classify_pkt(struct hdd_adapter *adapter,
 void hdd_wmm_classify_pkt_cb(void *adapter,
 			     struct sk_buff *skb)
 {
-	enum sme_qos_wmmuptype user_pri;
-	bool is_critical;
+	enum sme_qos_wmmuptype user_pri = SME_QOS_WMM_UP_BE;
+	bool is_critical = false;
 
 	hdd_wmm_classify_critical_pkt(skb, &user_pri, &is_critical);