From 72eeed89e5fde9f910aee2d5e566fc7a32ff64a0 Mon Sep 17 00:00:00 2001 From: Jiachao Wu Date: Tue, 17 Jul 2018 16:36:33 +0800 Subject: [PATCH] qcacmn: Add NULL check for 'pl_dev' Currently 'pl_dev' is dereferenced without check for NULL in get_pktlog_handle function in pktlog_internal.c. To address this issue add NULL check before dereferencing. Change-Id: I7017560d5eb36df3ca0a547cf62451f339f5940b CRs-Fixed: 2280047 --- utils/pktlog/pktlog_internal.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/utils/pktlog/pktlog_internal.c b/utils/pktlog/pktlog_internal.c index 917d908cac..d5d0d11136 100644 --- a/utils/pktlog/pktlog_internal.c +++ b/utils/pktlog/pktlog_internal.c @@ -473,7 +473,12 @@ A_STATUS process_tx_info(struct cdp_pdev *txrx_pdev, void *data) return A_ERROR; } - qdf_assert(pl_dev); + if (!pl_dev) { + pr_err("Invalid pktlog handle in %s\n", __func__); + qdf_assert(pl_dev); + return A_ERROR; + } + qdf_assert(data); fw_data = (struct ol_fw_data *)data;