samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Fix null ptr dereference in hdd_set_power_save_offload_config

Browse Source 
Currently, hdd_set_power_save_offload_config does not do null validation
for power usage before string comparison which can lead to null pointer
derefrence.

Add null pointer check for power usage in
hdd_set_power_save_offload_config.

Change-Id: I91eba2f5eb27aebf7451be58a6744634aaebd184
CRs-Fixed: 2423777
This commit is contained in:
sheenam monga
2019-04-05 18:17:27 +05:30
committed by nshrivas
parent 3b59080d82
commit 70a83dacbf
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
core/hdd/src/wlan_hdd_cfg.c
View File

@@ -561,11 +561,18 @@ static QDF_STATUS hdd_apply_cfg_ini(struct hdd_context *hdd_ctx,
static void hdd_set_power_save_offload_config(struct hdd_context *hdd_ctx) static void hdd_set_power_save_offload_config(struct hdd_context *hdd_ctx)
{ {
uint32_t listen_interval = 0; uint32_t listen_interval = 0;
char *power_usage = NULL;
if (strcmp(ucfg_mlme_get_power_usage(hdd_ctx->psoc), "Min") == 0) power_usage = ucfg_mlme_get_power_usage(hdd_ctx->psoc);
if (!power_usage) {
hdd_err("invalid power usage");
return;
}
if (strcmp(power_usage, "Min") == 0)
ucfg_mlme_get_bmps_min_listen_interval(hdd_ctx->psoc, ucfg_mlme_get_bmps_min_listen_interval(hdd_ctx->psoc,
&listen_interval); &listen_interval);
else if (strcmp(ucfg_mlme_get_power_usage(hdd_ctx->psoc), "Max") == 0) else if (strcmp(power_usage, "Max") == 0)
ucfg_mlme_get_bmps_max_listen_interval(hdd_ctx->psoc, ucfg_mlme_get_bmps_max_listen_interval(hdd_ctx->psoc,
&listen_interval); &listen_interval);
/* /*