From 708e7f57c5cfb7c75ea6b4dde02f8ec0074ef853 Mon Sep 17 00:00:00 2001 From: Rajeev Kumar Date: Tue, 3 Apr 2018 13:47:31 -0700 Subject: [PATCH] qcacmn: Remove multicast logging check from wlan_log_to_user API Multicast logging is MCL specific feature which controls sending of host and fw netlink DIAG events to user space. This feature should not control console logging from wlan_log_to_user because it can lead to all debug logs getting logged on console until CFG INI for multicast logging is parsed during initialization and this can lead to watchdog bark beacuse of excessive logging during WiFi driver initialization. Hence remove multicast logging check from wlan_log_to_user API to avoid logging all debug logs on console during WiFi driver initialization sequence. Change-Id: I2a29928757f683a72345436a57de1ee8d02f53b3 CRs-Fixed: 2217749 --- utils/logging/src/wlan_logging_sock_svc.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/utils/logging/src/wlan_logging_sock_svc.c b/utils/logging/src/wlan_logging_sock_svc.c index c759bee9b8..2fe2b56b2f 100644 --- a/utils/logging/src/wlan_logging_sock_svc.c +++ b/utils/logging/src/wlan_logging_sock_svc.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2014-2017 The Linux Foundation. All rights reserved. + * Copyright (c) 2014-2018 The Linux Foundation. All rights reserved. * * Previously licensed under the ISC license by Qualcomm Atheros, Inc. * @@ -332,20 +332,7 @@ int wlan_log_to_user(QDF_TRACE_LEVEL log_level, char *to_be_sent, int length) radio = cds_get_radio_index(); #endif - if ( -#ifdef CONFIG_MCL - !cds_is_multicast_logging() || -#endif - (radio == -EINVAL) || - (!gwlan_logging.is_active)) { - /* - * This is to make sure that we print the logs to kmsg console - * when no logger app is running. This is also needed to - * log the initial messages during loading of driver where even - * if app is running it will not be able to - * register with driver immediately and start logging all the - * messages. - */ + if ((radio == -EINVAL) || (!gwlan_logging.is_active)) { /* * R%d: if the radio index is invalid, just post the message * to console.