samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Replace typedef tSirSmeHTProfile

Browse Source 
The Linux Coding Style enumerates a few special cases where typedefs
are useful, but stresses "NEVER EVER use a typedef unless you can
clearly match one of those rules." The tSirSmeHTProfile typedef does
not meet any of those criteria, so replace it with a reference to the
underlying struct.

Further note the Linux Coding Style frowns upon mixed-case names and
so-called Hungarian notation, so in conjunction rename the underlying
struct to be in compliance.

Change-Id: I3686dbfadfc144d06267e6162c5642aa61a894fd
CRs-Fixed: 2393734
This commit is contained in:
Jeff Johnson
2019-02-02 16:11:55 -08:00
committed by nshrivas
parent 704b891933
commit 704af11d34
4 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/mac/inc/sir_api.h
View File

@@ -691,7 +691,7 @@ struct bss_description {
typedef struct bss_description tSirBssDescription, *tpSirBssDescription;
#ifdef FEATURE_WLAN_MCC_TO_SCC_SWITCH
typedef struct sSirSmeHTProfile {
struct ht_profile {
uint8_t dot11mode;
uint8_t htCapability;
uint8_t htSupportedChannelWidthSet;
@@ -700,7 +700,7 @@ typedef struct sSirSmeHTProfile {
uint8_t vhtCapability;
uint8_t apCenterChan;
uint8_t apChanWidth;
} tSirSmeHTProfile;
};
#endif
/* / Definition for response message to previously */
/* / issued start BSS request */
@@ -715,7 +715,7 @@ typedef struct sSirSmeStartBssRsp {
uint16_t beaconInterval; /* Beacon Interval for both type */
uint32_t staId; /* Station ID for Self */
#ifdef FEATURE_WLAN_MCC_TO_SCC_SWITCH
tSirSmeHTProfile HTProfile;
struct ht_profile HTProfile;
#endif
tSirBssDescription bssDescription; /* Peer BSS description */
} tSirSmeStartBssRsp, *tpSirSmeStartBssRsp;
@@ -1034,7 +1034,7 @@ typedef struct sSirSmeJoinRsp {
uint32_t max_rate_flags;
#ifdef FEATURE_WLAN_MCC_TO_SCC_SWITCH
tSirSmeHTProfile HTProfile;
struct ht_profile HTProfile;
#endif
bool supported_nss_1x1;
tDot11fIEHTCaps ht_caps;

5
core/mac/src/pe/lim/lim_api.c
View File

@@ -1885,9 +1885,10 @@ void lim_ps_offload_handle_missed_beacon_ind(struct mac_context *mac,
*
* Return: None
*/
void lim_fill_join_rsp_ht_caps(struct pe_session *session, tpSirSmeJoinRsp join_rsp)
void lim_fill_join_rsp_ht_caps(struct pe_session *session,
tpSirSmeJoinRsp join_rsp)
{
tSirSmeHTProfile *ht_profile;
struct ht_profile *ht_profile;
if (session == NULL) {
pe_err("Invalid Session");

2
core/mac/src/pe/lim/lim_send_sme_rsp_messages.c
View File

@@ -211,7 +211,7 @@ static void lim_handle_join_rsp_status(struct mac_context *mac_ctx,
tpSirSmeJoinReq join_reassoc_req = NULL;
#ifdef FEATURE_WLAN_MCC_TO_SCC_SWITCH
tSirSmeHTProfile *ht_profile;
struct ht_profile *ht_profile;
#endif
if (result_code == eSIR_SME_SUCCESS) {
if (session_entry->beacon != NULL) {

8
core/sme/src/csr/csr_api_roam.c
View File

@@ -6093,7 +6093,7 @@ static void csr_roam_synch_clean_up(struct mac_context *mac, uint8_t session_id)
* Return: None
*/
static void csr_roam_copy_ht_profile(tCsrRoamHTProfile *dst_profile,
tSirSmeHTProfile *src_profile)
struct ht_profile *src_profile)
{
dst_profile->phymode =
csr_roamdot11mode_to_phymode(src_profile->dot11mode);
@@ -6363,7 +6363,7 @@ static void csr_roam_process_start_bss_success(struct mac_context *mac_ctx,
QDF_STATUS status;
host_log_ibss_pkt_type *ibss_log;
#ifdef FEATURE_WLAN_MCC_TO_SCC_SWITCH
tSirSmeHTProfile *src_profile = NULL;
struct ht_profile *src_profile = NULL;
tCsrRoamHTProfile *dst_profile = NULL;
#endif
@@ -6725,7 +6725,7 @@ static void csr_roam_process_join_res(struct mac_context *mac_ctx,
struct tag_csrscan_result *scan_res = NULL;
sme_qos_csr_event_indType ind_qos;
#ifdef FEATURE_WLAN_MCC_TO_SCC_SWITCH
tSirSmeHTProfile *src_profile = NULL;
struct ht_profile *src_profile = NULL;
tCsrRoamHTProfile *dst_profile = NULL;
#endif
tCsrRoamConnectedProfile *conn_profile = NULL;
@@ -20613,7 +20613,7 @@ static QDF_STATUS csr_process_roam_sync_callback(struct mac_context *mac_ctx,
uint32_t pmkid_index;
uint16_t len;
#ifdef FEATURE_WLAN_MCC_TO_SCC_SWITCH
tSirSmeHTProfile *src_profile = NULL;
struct ht_profile *src_profile = NULL;
tCsrRoamHTProfile *dst_profile = NULL;
#endif