From 6feba28f2a0152f7f323094f444d0789e0227af0 Mon Sep 17 00:00:00 2001 From: Srikanth Marepalli Date: Wed, 12 Apr 2023 12:23:48 +0530 Subject: [PATCH] qcacld-3.0: Delete TDLS peers before sending TDLS disable to FW As part of commit(Id680d0f6193740b24e78115ac7dc7be26e28acff) during roam driver notify the TDLS STA about disconnection. During this driver sends the TDLS disable command to Firmware without deleting the TDLS peers. As a result of this in FW the TDLS delete instance is called and TDLS handle is marked as NULL. And later in driver the TDLS peers are getting deleted and now the teardown update command is sent to Firmware. But in FW as the TDLS handle is already NULL, it has asserted and crashed. Fix is to delete the TDLS peers in driver and update the teardown to Firmware and then send the TDLS disable command to Firmware. Change-Id: Ic425cc065a29bbc444531f523eaccb14014ae47a CRs-Fixed: 3455117 --- .../umac/mlme/connection_mgr/core/src/wlan_cm_roam_fw_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/umac/mlme/connection_mgr/core/src/wlan_cm_roam_fw_sync.c b/components/umac/mlme/connection_mgr/core/src/wlan_cm_roam_fw_sync.c index 58da1bac1b..53a8a5210c 100644 --- a/components/umac/mlme/connection_mgr/core/src/wlan_cm_roam_fw_sync.c +++ b/components/umac/mlme/connection_mgr/core/src/wlan_cm_roam_fw_sync.c @@ -167,7 +167,7 @@ cm_fw_roam_sync_start_ind(struct wlan_objmgr_vdev *vdev, DLM_AP_DISCONNECTED); /* Notify TDLS STA about disconnection due to roaming */ - wlan_tdls_notify_sta_disconnect(vdev_id, true, false, vdev); + wlan_tdls_notify_sta_disconnect(vdev_id, true, true, vdev); if (IS_ROAM_REASON_STA_KICKOUT(sync_ind->roam_reason)) { struct reject_ap_info ap_info;