diff --git a/components/mlme/dispatcher/inc/wlan_mlme_public_struct.h b/components/mlme/dispatcher/inc/wlan_mlme_public_struct.h index 0f3f929b7c..fae9d6cdaa 100644 --- a/components/mlme/dispatcher/inc/wlan_mlme_public_struct.h +++ b/components/mlme/dispatcher/inc/wlan_mlme_public_struct.h @@ -41,6 +41,16 @@ #define CFG_VHT_TX_MCS_MAP_STAMAX 0xFFFF #define CFG_VHT_TX_MCS_MAP_STADEF 0xFFFE +/* + * MLME_CFG_VHT_CSN_BEAMFORMEE_ANT_SUPPORTED_FW_DEF + 1 is + * assumed to be the default fw supported BF antennas, if fw + * says it supports 8 antennas in rx ready event and if + * gTxBFCsnValue INI value is configured above 3, set + * the same to MLME_CFG_VHT_CSN_BEAMFORMEE_ANT_SUPPORTED. + * Otherwise, fall back and set fw default value[3]. + */ +#define MLME_VHT_CSN_BEAMFORMEE_ANT_SUPPORTED_FW_DEF 3 + #define CFG_STR_DATA_LEN 17 #define CFG_EDCA_DATA_LEN 17 #define CFG_MAX_TX_POWER_2_4_LEN 128 diff --git a/core/hdd/src/wlan_hdd_main.c b/core/hdd/src/wlan_hdd_main.c index a295be7be7..88cf27bae2 100644 --- a/core/hdd/src/wlan_hdd_main.c +++ b/core/hdd/src/wlan_hdd_main.c @@ -1994,12 +1994,10 @@ int hdd_update_tgt_cfg(hdd_handle_t hdd_handle, struct wma_tgt_cfg *cfg) hdd_err("set tx_bfee_ant_supp failed"); } - if ((value > - WNI_CFG_VHT_CSN_BEAMFORMEE_ANT_SUPPORTED_FW_DEF) && + if ((value > MLME_VHT_CSN_BEAMFORMEE_ANT_SUPPORTED_FW_DEF) && !cfg->tx_bfee_8ss_enabled) { - status = - ucfg_mlme_cfg_set_vht_tx_bfee_ant_supp(hdd_ctx->psoc, - WNI_CFG_VHT_CSN_BEAMFORMEE_ANT_SUPPORTED_FW_DEF); + status = ucfg_mlme_cfg_set_vht_tx_bfee_ant_supp(hdd_ctx->psoc, + MLME_VHT_CSN_BEAMFORMEE_ANT_SUPPORTED_FW_DEF); if (QDF_IS_STATUS_ERROR(status)) { status = false; hdd_err("set tx_bfee_ant_supp failed"); diff --git a/core/mac/inc/wni_cfg.h b/core/mac/inc/wni_cfg.h index 4b29df7f99..1ec42dc951 100644 --- a/core/mac/inc/wni_cfg.h +++ b/core/mac/inc/wni_cfg.h @@ -73,7 +73,6 @@ * the same to WNI_CFG_VHT_CSN_BEAMFORMEE_ANT_SUPPORTED. * Otherwise, fall back and set fw default value[3]. */ -#define WNI_CFG_VHT_CSN_BEAMFORMEE_ANT_SUPPORTED_FW_DEF 3 #define WNI_CFG_WPS_ENABLE_AP 1 diff --git a/core/sme/src/csr/csr_api_roam.c b/core/sme/src/csr/csr_api_roam.c index 6763f53675..d19f6f883b 100644 --- a/core/sme/src/csr/csr_api_roam.c +++ b/core/sme/src/csr/csr_api_roam.c @@ -16663,7 +16663,7 @@ QDF_STATUS csr_send_mb_start_bss_req_msg(struct mac_context *mac, uint32_t pMsg->vht_config.su_beam_formee = (uint8_t)value && (uint8_t)mac->mlme_cfg->vht_caps.vht_cap_info.tx_bfee_sap; - value = mac->mlme_cfg->vht_caps.vht_cap_info.tx_bfee_ant_supp; + value = MLME_VHT_CSN_BEAMFORMEE_ANT_SUPPORTED_FW_DEF; pMsg->vht_config.csnof_beamformer_antSup = (uint8_t)value; pMsg->vht_config.mu_beam_formee = 0;