samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

disp: msm: sde: fix null access for wb modes

Browse Source 
Writeback modes are passed from DRM driver client and it may provide
invalid configuration. Add null checks for sde_wb_config provided by
client to avoid null access in subsequent calls.

Change-Id: I0924f8907d98e2ecb891cfc0c09191823d9033e8
Signed-off-by: Lakshmi Narayana Kalavala <lkalaval@codeaurora.org>
This commit is contained in:
Lakshmi Narayana Kalavala
2019-06-13 11:41:01 -07:00
parent 9d87e36a77
commit 6da86ccee2
1 changed files with 48 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
msm/sde/sde_wb.c
View File

@@ -170,7 +170,12 @@ int sde_wb_connector_set_modes(struct sde_wb_device *wb_dev,
if (connected) {
SDE_DEBUG("connect\n");
if (count_modes && modes) {
if (!count_modes || !modes) {
SDE_ERROR("invalid count_modes :%u and modes :%d\n",
count_modes, !modes);
return -EINVAL;
}
modeinfo = kcalloc(count_modes,
sizeof(struct drm_mode_modeinfo),
GFP_KERNEL);
@@ -218,7 +223,6 @@ int sde_wb_connector_set_modes(struct sde_wb_device *wb_dev,
goto error;
}
}
}
if (wb_dev->modes) {
wb_dev->count_modes = 0;