samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Replace hdd_context_t in wlan_hdd_driver_ops.[ch]

Browse Source 
The Linux Coding Style enumerates a few special cases where typedefs
are useful, but stresses "NEVER EVER use a typedef unless you can
clearly match one of those rules." The hdd_context_t typedef does not
meet any of those criteria, so replace references to it with a
reference to the underlying struct.

Change-Id: I1eceef88a686678814b4463ad924f9dfb1a06b29
CRs-Fixed: 2100201
This commit is contained in:
Jeff Johnson
2017-08-28 12:02:36 -07:00
committed by snandini
parent 878d4af633
commit 6bc79d8865
2 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/hdd/inc/wlan_hdd_driver_ops.h
View File

@@ -30,6 +30,8 @@
#include "hif.h" #include "hif.h"
struct hdd_context;
/** /**
* DOC: wlan_hdd_driver_ops.h * DOC: wlan_hdd_driver_ops.h
* *
@@ -108,7 +110,7 @@ int wlan_hdd_bus_resume_noirq(void);
* *
* Helper function to close HIF * Helper function to close HIF
*/ */
void hdd_hif_close(hdd_context_t *hdd_ctx, void *hif_ctx); void hdd_hif_close(struct hdd_context *hdd_ctx, void *hif_ctx);
/** /**
* hdd_hif_open() - HIF open helper * hdd_hif_open() - HIF open helper

16
core/hdd/src/wlan_hdd_driver_ops.c
View File

@@ -209,7 +209,7 @@ int hdd_hif_open(struct device *dev, void *bdev, const struct hif_bus_id *bid,
qdf_device_t qdf_ctx = cds_get_context(QDF_MODULE_ID_QDF_DEVICE); qdf_device_t qdf_ctx = cds_get_context(QDF_MODULE_ID_QDF_DEVICE);
struct hif_driver_state_callbacks cbk; struct hif_driver_state_callbacks cbk;
uint32_t mode = cds_get_conparam(); uint32_t mode = cds_get_conparam();
hdd_context_t *hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD); struct hdd_context *hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD);
if (!hdd_ctx) { if (!hdd_ctx) {
hdd_err("hdd_ctx error"); hdd_err("hdd_ctx error");
@@ -268,7 +268,7 @@ err_hif_close:
return ret; return ret;
} }
void hdd_hif_close(hdd_context_t *hdd_ctx, void *hif_ctx) void hdd_hif_close(struct hdd_context *hdd_ctx, void *hif_ctx)
{ {
if (!hdd_ctx) { if (!hdd_ctx) {
hdd_err("hdd_ctx error"); hdd_err("hdd_ctx error");
@@ -630,7 +630,7 @@ static int __wlan_hdd_bus_suspend(struct wow_enable_params wow_params)
{ {
int err; int err;
QDF_STATUS status; QDF_STATUS status;
hdd_context_t *hdd_ctx; struct hdd_context *hdd_ctx;
void *hif_ctx; void *hif_ctx;
void *dp_soc; void *dp_soc;
void *dp_pdev; void *dp_pdev;
@@ -738,7 +738,7 @@ int wlan_hdd_unit_test_bus_suspend(struct wow_enable_params wow_params)
*/ */
static int __wlan_hdd_bus_suspend_noirq(void) static int __wlan_hdd_bus_suspend_noirq(void)
{ {
hdd_context_t *hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD); struct hdd_context *hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD);
void *hif_ctx; void *hif_ctx;
int err; int err;
int status; int status;
@@ -815,7 +815,7 @@ int wlan_hdd_bus_suspend_noirq(void)
*/ */
static int __wlan_hdd_bus_resume(void) static int __wlan_hdd_bus_resume(void)
{ {
hdd_context_t *hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD); struct hdd_context *hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD);
void *hif_ctx; void *hif_ctx;
int status; int status;
QDF_STATUS qdf_status; QDF_STATUS qdf_status;
@@ -901,7 +901,7 @@ int wlan_hdd_bus_resume(void)
*/ */
static int __wlan_hdd_bus_resume_noirq(void) static int __wlan_hdd_bus_resume_noirq(void)
{ {
hdd_context_t *hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD); struct hdd_context *hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD);
void *hif_ctx; void *hif_ctx;
int status; int status;
QDF_STATUS qdf_status; QDF_STATUS qdf_status;
@@ -1002,7 +1002,7 @@ static int __wlan_hdd_runtime_suspend(struct device *dev)
{ {
int err; int err;
QDF_STATUS status; QDF_STATUS status;
hdd_context_t *hdd_ctx; struct hdd_context *hdd_ctx;
hdd_debug("Starting runtime suspend"); hdd_debug("Starting runtime suspend");
@@ -1077,7 +1077,7 @@ static int hdd_pld_runtime_resume_cb(void)
*/ */
static int __wlan_hdd_runtime_resume(struct device *dev) static int __wlan_hdd_runtime_resume(struct device *dev)
{ {
hdd_context_t *hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD); struct hdd_context *hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD);
QDF_STATUS status; QDF_STATUS status;
hdd_debug("Starting runtime resume"); hdd_debug("Starting runtime resume");