samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Don't destroy uncreated completion_freeq_lock

Browse Source 
Sometimes, BMI download FW fail, cause destroy this uncreated spinlock.

Because fw download fail, hif_start() not called, so 
&pipe_info->completion_freeq_lock not be created.But hif_ce_stop() call
qdf_spinlock_destroy(&pipe_info->completion_freeq_lock);Cause WLAN Panic 
@ qdf_lock_stats_cookie_destroy:824: Lock destroyed twice or never created

hif_state->started be set to true in hif_start( )This fixes use 
hif_state->started to judge hif_start() be called or not.If false, 
hif_start() not be called, so needn’t destroy  uncreated 
completion_freeq_lock

Change-Id: Id6aae8024fe9df2ac6cf7976047ebd7a850438e4
This commit is contained in:
Baowei Liu
2020-03-25 15:16:06 +08:00
committed by nshrivas
parent 7d8cf5af55
commit 68487f9c5c
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
hif/src/ce/ce_main.c
View File

@@ -2799,7 +2799,8 @@ void hif_ce_stop(struct hif_softc *scn)
pipe_info = &hif_state->pipe_info[pipe_num];
if (pipe_info->ce_hdl) {
if (pipe_info->ce_hdl != ce_diag) {
if (pipe_info->ce_hdl != ce_diag &&
hif_state->started) {
attr = hif_state->host_ce_config[pipe_num];
if (attr.src_nentries)
qdf_spinlock_destroy(&pipe_info->