disp: msm: sde: add support for 3d_mux DSC topology

This change adds support for dsc using the 3d mux hw block.
The 3d_mux hw block merges the input from layer mixer before passing to
dsc block for compression.

Change-Id: I21544c33fff2c1e604c0ae712a036a127d25afcf
Signed-off-by: Abhijit Kulkarni <[email protected]>

msm/sde/sde_encoder_dce.c

@@ -172,8 +172,10 @@ static bool _dce_dsc_ich_reset_override_needed(bool pu_en,
 
 static void _dce_dsc_pipe_cfg(struct sde_hw_dsc *hw_dsc,
 		struct sde_hw_pingpong *hw_pp, struct msm_display_dsc_info *dsc,
-		u32 common_mode, bool ich_reset, bool enable,
-		struct sde_hw_pingpong *hw_dsc_pp)
+		u32 common_mode, bool ich_reset,
+		struct sde_hw_pingpong *hw_dsc_pp,
+		enum sde_3d_blend_mode mode_3d,
+		bool disable_merge_3d, bool enable)
 {
 	if (!enable) {
 		if (hw_dsc_pp && hw_dsc_pp->ops.disable_dsc)
@@ -185,6 +187,9 @@ static void _dce_dsc_pipe_cfg(struct sde_hw_dsc *hw_dsc,
 		if (hw_dsc && hw_dsc->ops.bind_pingpong_blk)
 			hw_dsc->ops.bind_pingpong_blk(hw_dsc, false,
 					PINGPONG_MAX);
+
+		if (mode_3d && hw_pp && hw_pp->ops.reset_3d_mode)
+			hw_pp->ops.reset_3d_mode(hw_pp);
 		return;
 	}
 
@@ -203,13 +208,39 @@ static void _dce_dsc_pipe_cfg(struct sde_hw_dsc *hw_dsc,
 	if (hw_dsc_pp && hw_dsc_pp->ops.setup_dsc)
 		hw_dsc_pp->ops.setup_dsc(hw_dsc_pp);
 
-	if (hw_dsc->ops.bind_pingpong_blk)
+	if (mode_3d && disable_merge_3d && hw_pp->ops.reset_3d_mode) {
+		SDE_DEBUG("disabling 3d mux \n");
+		hw_pp->ops.reset_3d_mode(hw_pp);
+	} else if (mode_3d && disable_merge_3d && hw_pp->ops.setup_3d_mode) {
+		SDE_DEBUG("enabling 3d mux \n");
+		hw_pp->ops.setup_3d_mode(hw_pp, mode_3d);
+	}
+
+	if (hw_dsc && hw_dsc->ops.bind_pingpong_blk)
 		hw_dsc->ops.bind_pingpong_blk(hw_dsc, true, hw_pp->idx);
 
 	if (hw_dsc_pp && hw_dsc_pp->ops.enable_dsc)
 		hw_dsc_pp->ops.enable_dsc(hw_dsc_pp);
 }
 
+static inline bool _dce_check_half_panel_update(int num_dsc,
+		bool merge_3d,
+		unsigned long affected_displays)
+{
+	/**
+	 * partial update logic is currently supported only upto dual
+	 * pipe configurations.
+	 */
+
+	if (merge_3d) {
+		int num_mixers = 2;
+
+		return (hweight_long(affected_displays) != num_mixers);
+	} else if (num_dsc > 1) {
+		return (hweight_long(affected_displays) != num_dsc);
+	}
+	return false;
+}
 static int _dce_dsc_setup(struct sde_encoder_virt *sde_enc,
 		struct sde_encoder_kickoff_params *params)
 {
@@ -226,8 +257,10 @@ static int _dce_dsc_setup(struct sde_encoder_virt *sde_enc,
 	const struct sde_rm_topology_def *def;
 	const struct sde_rect *roi;
 	struct sde_hw_ctl *hw_ctl;
-	struct sde_ctl_dsc_cfg cfg;
-	bool half_panel_partial_update, dsc_merge;
+	struct sde_hw_intf_cfg_v1 cfg;
+	enum sde_3d_blend_mode mode_3d;
+	bool half_panel_partial_update, dsc_merge, merge_3d;
+	bool disable_merge_3d = false;
 	int this_frame_slices;
 	int intf_ip_w, enc_ip_w;
 	int num_intf, num_dsc;
@@ -268,7 +301,6 @@ static int _dce_dsc_setup(struct sde_encoder_virt *sde_enc,
 			sde_enc->cur_master->cached_mode.hdisplay,
 			sde_enc->cur_master->cached_mode.vdisplay);
 
-	memset(&cfg, 0, sizeof(cfg));
 	enc_master = sde_enc->cur_master;
 	roi = &sde_enc->cur_conn_roi;
 	hw_ctl = enc_master->hw_ctl;
@@ -280,6 +312,8 @@ static int _dce_dsc_setup(struct sde_encoder_virt *sde_enc,
 
 	num_dsc = def->num_comp_enc;
 	num_intf = def->num_intf;
+	mode_3d = (topology == SDE_RM_TOPOLOGY_DUALPIPE_3DMERGE_DSC) ?
+		BLEND_3D_H_ROW_INT : BLEND_3D_NONE;
 
 	/*
 	 * If this encoder is driving more than one DSC encoder, they
@@ -287,13 +321,16 @@ static int _dce_dsc_setup(struct sde_encoder_virt *sde_enc,
 	 * each of them.(pp-split is assumed to be not supported)
 	 */
 	_dce_dsc_update_pic_dim(dsc, roi->w, roi->h);
-
-	half_panel_partial_update = (num_dsc > 1) ?
-			(hweight_long(params->affected_displays) != num_dsc) :
-			false;
+	merge_3d = (mode_3d != BLEND_3D_NONE) ? true: false;
 	dsc_merge = (num_dsc > num_intf) ? true : false;
 
-	if (!half_panel_partial_update)
+	half_panel_partial_update = _dce_check_half_panel_update(
+			num_dsc, merge_3d, params->affected_displays);
+
+	if (half_panel_partial_update && merge_3d)
+		disable_merge_3d = true;
+
+	if (!half_panel_partial_update && !merge_3d)
 		dsc_common_mode |= DSC_MODE_SPLIT_PANEL;
 	if (dsc_merge)
 		dsc_common_mode |= DSC_MODE_MULTIPLEX;
@@ -323,7 +360,7 @@ static int _dce_dsc_setup(struct sde_encoder_virt *sde_enc,
 	 * updating pic dimension, mdss_panel_dsc_update_pic_dim.
 	 */
 	ich_res = _dce_dsc_ich_reset_override_needed(
-			half_panel_partial_update, dsc);
+			(half_panel_partial_update && !merge_3d), dsc);
 
 	SDE_DEBUG_DCE(sde_enc, "pic_w: %d pic_h: %d mode:%d\n",
 				roi->w, roi->h, dsc_common_mode);
@@ -331,44 +368,80 @@ static int _dce_dsc_setup(struct sde_encoder_virt *sde_enc,
 	for (i = 0; i < num_dsc; i++) {
 		bool active = !!((1 << i) & params->affected_displays);
 
-		hw_pp[i] = sde_enc->hw_pp[i];
+		/*
+		 * in 3d_merge and half_panel partial update dsc should be
+		 * bound to the pp which is driving the update, else in
+		 * 3d_merge dsc should be bound to left side of the pipe
+		 */
+		if (merge_3d && half_panel_partial_update)
+			hw_pp[i] = (active) ? sde_enc->hw_pp[0]:
+				sde_enc->hw_pp[1];
+		else
+			hw_pp[i] = sde_enc->hw_pp[i];
+
 		hw_dsc[i] = sde_enc->hw_dsc[i];
 		hw_dsc_pp[i] = sde_enc->hw_dsc_pp[i];
 
 		if (!hw_pp[i] || !hw_dsc[i]) {
 			SDE_ERROR_DCE(sde_enc, "invalid params for DSC\n");
-			SDE_EVT32(DRMID(&sde_enc->base), roi->w, roi->h,
-				dsc_common_mode, i, active);
+			SDE_EVT32(DRMID(&sde_enc->base), !hw_pp[i], !hw_dsc[i],
+					SDE_EVTLOG_ERROR);
 			return -EINVAL;
 		}
 
+		SDE_EVT32(DRMID(&sde_enc->base), roi->w, roi->h,
+				dsc_common_mode, i, active, merge_3d,
+				disable_merge_3d);
+
 		_dce_dsc_pipe_cfg(hw_dsc[i], hw_pp[i], dsc,
-				dsc_common_mode, ich_res, active, hw_dsc_pp[i]);
-
-		if (active) {
-			if (cfg.dsc_count >= MAX_DSC_PER_CTL_V1) {
-				pr_err("Invalid dsc count:%d\n",
-						cfg.dsc_count);
-				return -EINVAL;
-			}
-			cfg.dsc[cfg.dsc_count++] = hw_dsc[i]->idx;
-
-			if (hw_ctl->ops.update_bitmask_dsc)
-				hw_ctl->ops.update_bitmask_dsc(hw_ctl,
-						hw_dsc[i]->idx, 1);
-		}
-	}
+				dsc_common_mode, ich_res, hw_dsc_pp[i],
+				mode_3d, disable_merge_3d, active);
+
+		memset(&cfg, 0, sizeof(cfg));
+		cfg.dsc[cfg.dsc_count++] = hw_dsc[i]->idx;
+
+		if (hw_ctl->ops.update_intf_cfg)
+			hw_ctl->ops.update_intf_cfg(hw_ctl,
+					&cfg,
+					active);
+
+		if (hw_ctl->ops.update_bitmask_dsc)
+			hw_ctl->ops.update_bitmask_dsc(hw_ctl,
+					hw_dsc[i]->idx, active);
 
-	/* setup dsc active configuration in the control path */
-	if (hw_ctl->ops.setup_dsc_cfg) {
-		hw_ctl->ops.setup_dsc_cfg(hw_ctl, &cfg);
 		SDE_DEBUG_DCE(sde_enc,
-				"setup dsc_cfg hw_ctl[%d], count:%d,dsc[0]:%d, dsc[1]:%d\n",
+				"update_intf_cfg hw_ctl[%d], dsc:%d, %s",
 				hw_ctl->idx,
-				cfg.dsc_count,
 				cfg.dsc[0],
-				cfg.dsc[1]);
+				active ? "enabled" : "disabled");
+
+		if (mode_3d) {
+			memset(&cfg, 0, sizeof(cfg));
+
+			cfg.merge_3d[cfg.merge_3d_count++] =
+				hw_pp[i]->merge_3d->idx;
+
+			if (hw_ctl->ops.update_intf_cfg)
+				hw_ctl->ops.update_intf_cfg(hw_ctl,
+						&cfg,
+						!disable_merge_3d);
+
+			if (hw_ctl->ops.update_bitmask_merge3d)
+				hw_ctl->ops.update_bitmask_merge3d(
+						hw_ctl,
+						hw_pp[i]->merge_3d->idx, true);
+
+			SDE_DEBUG("mode_3d %s, on CTL_%d PP-%d merge3d:%d\n",
+					!disable_merge_3d ?
+					"enabled" : "disabled",
+					hw_ctl->idx - CTL_0,
+					hw_pp[i]->idx - PINGPONG_0,
+					hw_pp[i]->merge_3d ?
+					hw_pp[i]->merge_3d->idx - MERGE_3D_0 :
+					-1);
+		}
 	}
+
 	return 0;
 }
 
@@ -379,7 +452,7 @@ static void _dce_dsc_disable(struct sde_encoder_virt *sde_enc)
 	struct sde_hw_pingpong *hw_dsc_pp = NULL;
 	struct sde_hw_dsc *hw_dsc = NULL;
 	struct sde_hw_ctl *hw_ctl = NULL;
-	struct sde_ctl_dsc_cfg cfg;
+	struct sde_hw_intf_cfg_v1 cfg;
 
 	if (!sde_enc || !sde_enc->phys_encs[0] ||
 			!sde_enc->phys_encs[0]->connector) {
@@ -391,6 +464,8 @@ static void _dce_dsc_disable(struct sde_encoder_virt *sde_enc)
 	if (sde_enc->cur_master)
 		hw_ctl = sde_enc->cur_master->hw_ctl;
 
+	memset(&cfg, 0, sizeof(cfg));
+
 	/* Disable DSC for all the pp's present in this topology */
 	for (i = 0; i < MAX_CHANNELS_PER_ENC; i++) {
 		hw_pp = sde_enc->hw_pp[i];
@@ -398,17 +473,18 @@ static void _dce_dsc_disable(struct sde_encoder_virt *sde_enc)
 		hw_dsc_pp = sde_enc->hw_dsc_pp[i];
 
 		_dce_dsc_pipe_cfg(hw_dsc, hw_pp, NULL,
-						0, 0, 0, hw_dsc_pp);
+					0, 0, hw_dsc_pp,
+					BLEND_3D_NONE, false, false);
 
-		if (hw_dsc)
+		if (hw_dsc) {
 			sde_enc->dirty_dsc_ids[i] = hw_dsc->idx;
+			cfg.dsc[cfg.dsc_count++] = hw_dsc->idx;
+		}
 	}
 
 	/* Clear the DSC ACTIVE config for this CTL */
-	if (hw_ctl && hw_ctl->ops.setup_dsc_cfg) {
-		memset(&cfg, 0, sizeof(cfg));
-		hw_ctl->ops.setup_dsc_cfg(hw_ctl, &cfg);
-	}
+	if (hw_ctl && hw_ctl->ops.update_intf_cfg)
+		hw_ctl->ops.update_intf_cfg(hw_ctl, &cfg, false);
 
 	/**
 	 * Since pending flushes from previous commit get cleared

msm/sde/sde_encoder_phys_wb.c

@@ -487,7 +487,7 @@ static void _sde_encoder_phys_wb_setup_cwb(struct sde_encoder_phys *phys_enc,
 			intf_cfg.cwb[intf_cfg.cwb_count++] =
 				(enum sde_cwb)(hw_pp->idx + i);
 
-		if (enable && hw_pp->merge_3d && (intf_cfg.merge_3d_count <
+		if (hw_pp->merge_3d && (intf_cfg.merge_3d_count <
 				MAX_MERGE_3D_PER_CTL_V1) && need_merge)
 			intf_cfg.merge_3d[intf_cfg.merge_3d_count++] =
 				hw_pp->merge_3d->idx;

msm/sde/sde_hw_ctl.c

@@ -1087,6 +1087,7 @@ static int sde_hw_ctl_update_intf_cfg(struct sde_hw_ctl *ctx,
 	u32 cwb_active = 0;
 	u32 merge_3d_active = 0;
 	u32 wb_active = 0;
+	u32 dsc_active = 0;
 	struct sde_hw_blk_reg_map *c;
 
 	if (!ctx)
@@ -1095,7 +1096,6 @@ static int sde_hw_ctl_update_intf_cfg(struct sde_hw_ctl *ctx,
 	c = &ctx->hw;
 
 	if (cfg->cwb_count) {
-		wb_active = 0;
 		cwb_active = SDE_REG_READ(c, CTL_CWB_ACTIVE);
 		for (i = 0; i < cfg->cwb_count; i++) {
 			if (cfg->cwb[i])
@@ -1117,28 +1117,21 @@ static int sde_hw_ctl_update_intf_cfg(struct sde_hw_ctl *ctx,
 					(cfg->merge_3d[i] - MERGE_3D_0),
 					enable);
 		}
+
 		SDE_REG_WRITE(c, CTL_MERGE_3D_ACTIVE, merge_3d_active);
 	}
 
-	return 0;
-}
-
-static int sde_hw_ctl_dsc_cfg(struct sde_hw_ctl *ctx,
-		struct sde_ctl_dsc_cfg *cfg)
-{
-	struct sde_hw_blk_reg_map *c;
-	u32 dsc_active = 0;
-	int i;
-
-	if (!ctx)
-		return -EINVAL;
+	if (cfg->dsc_count) {
+		dsc_active = SDE_REG_READ(c, CTL_DSC_ACTIVE);
+		for (i = 0; i < cfg->dsc_count; i++) {
+			if (cfg->dsc[i])
+				UPDATE_ACTIVE(dsc_active,
+					(cfg->dsc[i] - DSC_0), enable);
+		}
 
-	c = &ctx->hw;
-	for (i = 0; i < cfg->dsc_count; i++)
-		if (cfg->dsc[i])
-			dsc_active |= BIT(cfg->dsc[i] - DSC_0);
+		SDE_REG_WRITE(c, CTL_DSC_ACTIVE, dsc_active);
+	}
 
-	SDE_REG_WRITE(c, CTL_DSC_ACTIVE, dsc_active);
 	return 0;
 }
 
@@ -1288,7 +1281,6 @@ static void _setup_ctl_ops(struct sde_hw_ctl_ops *ops,
 
 		ops->setup_intf_cfg_v1 = sde_hw_ctl_intf_cfg_v1;
 		ops->update_intf_cfg = sde_hw_ctl_update_intf_cfg;
-		ops->setup_dsc_cfg = sde_hw_ctl_dsc_cfg;
 
 		ops->update_bitmask_cdm = sde_hw_ctl_update_bitmask_cdm_v1;
 		ops->update_bitmask_wb = sde_hw_ctl_update_bitmask_wb_v1;

msm/sde/sde_hw_ctl.h

@@ -82,6 +82,8 @@ struct sde_hw_intf_cfg {
  * @cwb:                      Id of active cwb blocks
  * @cdm_count:                No. of active chroma down module
  * @cdm:                      Id of active cdm blocks
+ * @dsc_count:                No. of active dsc blocks
+ * @dsc:                      Id of active dsc blocks
  */
 struct sde_hw_intf_cfg_v1 {
 	uint32_t intf_count;
@@ -100,16 +102,7 @@ struct sde_hw_intf_cfg_v1 {
 
 	uint32_t cdm_count;
 	enum sde_cdm cdm[MAX_CDM_PER_CTL_V1];
-};
 
-/**
- * struct sde_hw_ctl_dsc_cfg :Describes the DSC blocks being used for this
- *                            display on a platoform which supports ctl path
- *                            version 1.
- * @dsc_count:                No. of active dsc blocks
- * @dsc:                      Id of active dsc blocks
- */
-struct sde_ctl_dsc_cfg {
 	uint32_t dsc_count;
 	enum sde_dsc dsc[MAX_DSC_PER_CTL_V1];
 };
@@ -264,15 +257,6 @@ struct sde_hw_ctl_ops {
 	int (*setup_intf_cfg_v1)(struct sde_hw_ctl *ctx,
 		struct sde_hw_intf_cfg_v1 *cfg);
 
-	/**
-	 * Setup ctl_path dsc config for SDE_CTL_ACTIVE_CFG
-	 * @ctx   : ctl path ctx pointer
-	 * @cfg    : dsc config structure pointer
-	 * @Return: error code
-	 */
-	int (*setup_dsc_cfg)(struct sde_hw_ctl *ctx,
-		struct sde_ctl_dsc_cfg *cfg);
-
 	/** Update the interface selection with input WB config
 	 * @ctx       : ctl path ctx pointer
 	 * @cfg       : pointer to input wb config