samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

disp: msm: dp: configure aux switch only on state change

Browse Source 
The driver currently does not cache the current status of the aux switch
and calls the switch configure on any hpd event. So when there are
back to back disconnect notifications, it ends up calling switch
disconnect multiple times. But this is disrupting other operations
since the switch driver restores default settings on any call to
update settings.

This change caches the switch state and reconfigures it only on a
configuration change.

Change-Id: Ieeeaf5ac3bf8a7771b3118735422365cf2ee1f7b
Signed-off-by: Rajkumar Subbiah <quic_rsubbia@quicinc.com>
This commit is contained in:
Rajkumar Subbiah
2023-04-18 19:42:21 -04:00
parent 8ef80f7cf4
commit 5fb27733a7
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
msm/dp/dp_aux.c
View File

@@ -90,6 +90,9 @@ struct dp_aux_private {
u32 aux_error_num;
u32 retry_cnt;
bool switch_enable;
int switch_orientation;
atomic_t aborted;
};
@@ -844,6 +847,9 @@ static int dp_aux_configure_wcd_switch(struct dp_aux *dp_aux,
goto end;
}
if ((aux->switch_enable == enable) && (aux->switch_orientation == orientation))
goto end;
if (enable) {
status = WCD_USBSS_CABLE_CONNECT;
@@ -865,9 +871,12 @@ static int dp_aux_configure_wcd_switch(struct dp_aux *dp_aux,
enable, orientation, event);
rc = wcd_usbss_switch_update(event, status);
if (rc)
if (rc) {
DP_AUX_ERR(dp_aux, "failed to configure wcd939x i2c device (%d)\n", rc);
} else {
aux->switch_enable = enable;
aux->switch_orientation = orientation;
}
end:
return rc;
}
@@ -904,6 +913,7 @@ struct dp_aux *dp_aux_get(struct device *dev, struct dp_catalog_aux *catalog,
aux->aux_bridge = aux_bridge;
dp_aux = &aux->dp_aux;
aux->retry_cnt = 0;
aux->switch_orientation = -1;
dp_aux->isr = dp_aux_isr;
dp_aux->init = dp_aux_init;