msm: camera: isp: fix potential out of bounds
This change fix multiple prevent issues. fix over bound array access, add NULL checks, fix format specifier and fix typecasting. CRs-Fixed: 3643117 Change-Id: I16b4405c52ae9a6c53f6ff954dc32735719a99ad Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
This commit is contained in:
@@ -226,7 +226,7 @@ static int cam_isp_dev_component_bind(struct device *dev,
|
||||
g_isp_dev.isp_device_type);
|
||||
if (rc != 0) {
|
||||
CAM_ERR(CAM_ISP, "Can not initialized ISP HW manager!");
|
||||
goto kfree;
|
||||
goto free_mem;
|
||||
}
|
||||
|
||||
for (i = 0; i < g_isp_dev.max_context; i++) {
|
||||
@@ -238,7 +238,7 @@ static int cam_isp_dev_component_bind(struct device *dev,
|
||||
g_isp_dev.isp_device_type, iommu_hdl);
|
||||
if (rc) {
|
||||
CAM_ERR(CAM_ISP, "ISP context init failed!");
|
||||
goto kfree;
|
||||
goto free_mem;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -250,7 +250,7 @@ static int cam_isp_dev_component_bind(struct device *dev,
|
||||
|
||||
if (rc) {
|
||||
CAM_ERR(CAM_ISP, "ISP node init failed!");
|
||||
goto kfree;
|
||||
goto free_mem;
|
||||
}
|
||||
|
||||
node->sd_handler = cam_isp_subdev_close_internal;
|
||||
@@ -263,7 +263,7 @@ static int cam_isp_dev_component_bind(struct device *dev,
|
||||
|
||||
return 0;
|
||||
|
||||
kfree:
|
||||
free_mem:
|
||||
kfree(g_isp_dev.ctx);
|
||||
g_isp_dev.ctx = NULL;
|
||||
kfree(g_isp_dev.ctx_isp);
|
||||
|
Reference in New Issue
Block a user