From 5c6ac7b88701cc76009018d224990534693925e8 Mon Sep 17 00:00:00 2001
From: David Oladunjoye <quic_doladunj@quicinc.com>
Date: Thu, 9 Jun 2022 08:55:48 -0700
Subject: [PATCH] qcacmn: dp: Replace fallthrough comment with attribute

-Wimplicit-fallthrough is being enabled by default. Some compilers
such as clang require the attribute instead of just a fallthrough comment.

Change-Id: I443da8d7f5e1771dceb3386c4458b0da6a5e9476
CRs-Fixed: 3218236
---
 dp/wifi3.0/be/dp_be.h           | 2 +-
 dp/wifi3.0/dp_rx_defrag.c       | 2 +-
 dp/wifi3.0/dp_rx_err.c          | 1 -
 dp/wifi3.0/dp_tx_desc.h         | 6 +++---
 dp/wifi3.0/dp_tx_flow_control.c | 8 ++++----
 5 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/dp/wifi3.0/be/dp_be.h b/dp/wifi3.0/be/dp_be.h
index 050d2dd3ff..55243c6931 100644
--- a/dp/wifi3.0/be/dp_be.h
+++ b/dp/wifi3.0/be/dp_be.h
@@ -719,7 +719,7 @@ _dp_srng_test_and_update_nf_params(struct dp_soc *soc,
 		switch (near_full_level) {
 		case DP_SRNG_THRESH_CRITICAL:
 			/* Currently not doing anything special here */
-			/* fall through */
+			fallthrough;
 		case DP_SRNG_THRESH_NEAR_FULL:
 			ring_near_full = 1;
 			*max_reap_limit *= DP_SRNG_PER_LOOP_NF_REAP_MULTIPLIER;
diff --git a/dp/wifi3.0/dp_rx_defrag.c b/dp/wifi3.0/dp_rx_defrag.c
index d69913be53..72225c3253 100644
--- a/dp/wifi3.0/dp_rx_defrag.c
+++ b/dp/wifi3.0/dp_rx_defrag.c
@@ -1496,7 +1496,7 @@ static QDF_STATUS dp_rx_defrag(struct dp_txrx_peer *txrx_peer, unsigned int tid,
 	switch (txrx_peer->security[index].sec_type) {
 	case cdp_sec_type_tkip:
 		tkip_demic = 1;
-
+		fallthrough;
 	case cdp_sec_type_tkip_nomic:
 		while (cur) {
 			tmp_next = qdf_nbuf_next(cur);
diff --git a/dp/wifi3.0/dp_rx_err.c b/dp/wifi3.0/dp_rx_err.c
index ba297823c7..174e42dd56 100644
--- a/dp/wifi3.0/dp_rx_err.c
+++ b/dp/wifi3.0/dp_rx_err.c
@@ -712,7 +712,6 @@ _dp_rx_bar_frame_handle(struct dp_soc *soc, qdf_nbuf_t nbuf,
 	if (err_status == HAL_REO_ERROR_DETECTED) {
 		switch (error_code) {
 		case HAL_REO_ERR_BAR_FRAME_2K_JUMP:
-			/* fallthrough */
 		case HAL_REO_ERR_BAR_FRAME_OOR:
 			dp_rx_err_handle_bar(soc, peer, nbuf);
 			DP_STATS_INC(soc, rx.err.reo_error[error_code], 1);
diff --git a/dp/wifi3.0/dp_tx_desc.h b/dp/wifi3.0/dp_tx_desc.h
index 91403c1db7..5c4c12c837 100644
--- a/dp/wifi3.0/dp_tx_desc.h
+++ b/dp/wifi3.0/dp_tx_desc.h
@@ -264,19 +264,19 @@ dp_tx_adjust_flow_pool_state(struct dp_soc *soc,
 		soc->pause_cb(pool->flow_pool_id,
 			      WLAN_NETIF_PRIORITY_QUEUE_OFF,
 			      WLAN_DATA_FLOW_CTRL_PRI);
-		/* fallthrough */
+		fallthrough;
 
 	case FLOW_POOL_VO_PAUSED:
 		soc->pause_cb(pool->flow_pool_id,
 			      WLAN_NETIF_VO_QUEUE_OFF,
 			      WLAN_DATA_FLOW_CTRL_VO);
-		/* fallthrough */
+		fallthrough;
 
 	case FLOW_POOL_VI_PAUSED:
 		soc->pause_cb(pool->flow_pool_id,
 			      WLAN_NETIF_VI_QUEUE_OFF,
 			      WLAN_DATA_FLOW_CTRL_VI);
-		/* fallthrough */
+		fallthrough;
 
 	case FLOW_POOL_BE_BK_PAUSED:
 		soc->pause_cb(pool->flow_pool_id,
diff --git a/dp/wifi3.0/dp_tx_flow_control.c b/dp/wifi3.0/dp_tx_flow_control.c
index 020dbf4c81..ff877c131e 100644
--- a/dp/wifi3.0/dp_tx_flow_control.c
+++ b/dp/wifi3.0/dp_tx_flow_control.c
@@ -136,25 +136,25 @@ dp_tx_flow_ctrl_reset_subqueues(struct dp_soc *soc,
 		soc->pause_cb(pool->flow_pool_id,
 			      WLAN_NETIF_PRIORITY_QUEUE_ON,
 			      WLAN_DATA_FLOW_CTRL_PRI);
-		/* fallthrough */
+		fallthrough;
 
 	case FLOW_POOL_VO_PAUSED:
 		soc->pause_cb(pool->flow_pool_id,
 			      WLAN_NETIF_VO_QUEUE_ON,
 			      WLAN_DATA_FLOW_CTRL_VO);
-		/* fallthrough */
+		fallthrough;
 
 	case FLOW_POOL_VI_PAUSED:
 		soc->pause_cb(pool->flow_pool_id,
 			      WLAN_NETIF_VI_QUEUE_ON,
 			      WLAN_DATA_FLOW_CTRL_VI);
-		/* fallthrough */
+		fallthrough;
 
 	case FLOW_POOL_BE_BK_PAUSED:
 		soc->pause_cb(pool->flow_pool_id,
 			      WLAN_NETIF_BE_BK_QUEUE_ON,
 			      WLAN_DATA_FLOW_CTRL_BE_BK);
-		/* fallthrough */
+		fallthrough;
 	default:
 		break;
 	}