samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Check if tlv reo_dest_indication is valid

Browse Source 
Currently if hash-based routing fails, packets will be sent
with default routing which will result in packet being queued
to REO2SW1 with tlv reo_dest_indication = 1. Host will create fisa
flow with napi = 0 for REO2SW1.

When next packet received with correct tlv reo_dest_indication value
on different REO with flow_index_invalid = 1 and if tuple matches
with earlier created flow, it can result in REO mismatch issue.

To fix the issue if rx_hash is enabled add check for
tlv reo_dest_indication value.

Change-Id: Ib0895ce666cc788a6df8ae3483e0777e84937ef8
CRs-Fixed: 3500655
This commit is contained in:
Amit Mehta
2023-05-18 21:44:48 -07:00
committed by Rahul Choudhary
parent f04c083253
commit 5bc13c99ec
2 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
components/dp/core/src/wlan_dp_fisa_rx.c
View File

@@ -1125,17 +1125,23 @@ dp_fisa_rx_get_sw_ft_entry(struct dp_rx_fst *fisa_hdl, qdf_nbuf_t nbuf,
#ifdef DP_OFFLOAD_FRAME_WITH_SW_EXCEPTION
/*
* dp_rx_reo_dest_honor_check() - check if packet reo destination is changed
by FW offload
by FW offload and is valid
* @fisa_hdl: handle to FISA context
*@nbuf: RX packet nbuf
*@tlv_reo_dest_ind: reo_dest_ind fetched from rx_packet_tlv
*
* Return: QDF_STATUS_SUCCESS - reo destination not change, others - yes.
* Return: QDF_STATUS_SUCCESS - reo dest not change/ not valid, others - yes.
*/
static inline QDF_STATUS
dp_rx_reo_dest_honor_check(qdf_nbuf_t nbuf, uint32_t tlv_reo_dest_ind)
dp_rx_reo_dest_honor_check(struct dp_rx_fst *fisa_hdl, qdf_nbuf_t nbuf,
uint32_t tlv_reo_dest_ind)
{
uint8_t sw_exception =
qdf_nbuf_get_rx_reo_dest_ind_or_sw_excpt(nbuf);
if (fisa_hdl->rx_hash_enabled &&
(tlv_reo_dest_ind < HAL_REO_DEST_IND_START_OFFSET))
return QDF_STATUS_E_FAILURE;
/*
* If sw_exception bit is marked, then this data packet is
* re-injected by FW offload, reo destination will not honor
@@ -1145,7 +1151,8 @@ dp_rx_reo_dest_honor_check(qdf_nbuf_t nbuf, uint32_t tlv_reo_dest_ind)
}
#else
static inline QDF_STATUS
dp_rx_reo_dest_honor_check(qdf_nbuf_t nbuf, uint32_t tlv_reo_dest_ind)
dp_rx_reo_dest_honor_check(struct dp_rx_fst *fisa_hdl, qdf_nbuf_t nbuf,
uint32_t tlv_reo_dest_ind)
{
uint8_t ring_reo_dest_ind =
qdf_nbuf_get_rx_reo_dest_ind_or_sw_excpt(nbuf);
@@ -1156,7 +1163,9 @@ dp_rx_reo_dest_honor_check(qdf_nbuf_t nbuf, uint32_t tlv_reo_dest_ind)
* skip FISA to avoid REO2SW ring mismatch issue for same flow.
*/
if (tlv_reo_dest_ind != ring_reo_dest_ind ||
REO_DEST_IND_IPA_REROUTE == ring_reo_dest_ind)
REO_DEST_IND_IPA_REROUTE == ring_reo_dest_ind ||
(fisa_hdl->rx_hash_enabled &&
(tlv_reo_dest_ind < HAL_REO_DEST_IND_START_OFFSET)))
return QDF_STATUS_E_FAILURE;
return QDF_STATUS_SUCCESS;
@@ -1189,7 +1198,7 @@ dp_rx_get_fisa_flow(struct dp_rx_fst *fisa_hdl, struct dp_vdev *vdev,
rx_tlv_hdr = qdf_nbuf_data(nbuf);
hal_rx_msdu_get_reo_destination_indication(hal_soc_hdl, rx_tlv_hdr,
&tlv_reo_dest_ind);
status = dp_rx_reo_dest_honor_check(nbuf, tlv_reo_dest_ind);
status = dp_rx_reo_dest_honor_check(fisa_hdl, nbuf, tlv_reo_dest_ind);
if (QDF_IS_STATUS_ERROR(status))
return sw_ft_entry;

1
components/dp/core/src/wlan_dp_rx_fst.c
View File

@@ -370,6 +370,7 @@ QDF_STATUS dp_rx_fst_attach(struct dp_soc *soc, struct dp_pdev *pdev)
qdf_atomic_init(&fst->fse_cache_flush_posted);
fst->fse_cache_flush_allow = true;
fst->rx_hash_enabled = wlan_cfg_is_rx_hash_enabled(soc->wlan_cfg_ctx);
fst->soc_hdl = soc;
soc->rx_fst = fst;
soc->fisa_enable = true;