Bladeren bron

qcacld-3.0: Fix suspicious dereference of pointer

qcacld-2.0 to qcacld-3.0 propagation

Dereference of 'roamSession' pointer before NULL check in
sme_is_sta_smps_allowed().

Fix to move dereference statements after NULL check.

Change-Id: I04d72a4b8fbc4ba68850ae665e2248a386fa4c10
CRs-Fixed: 992082
Sreelakshmi Konamki 9 jaren geleden
bovenliggende
commit
58697e1331
1 gewijzigde bestanden met toevoegingen van 5 en 7 verwijderingen
  1. 5 7
      core/sme/src/common/sme_api.c

+ 5 - 7
core/sme/src/common/sme_api.c

@@ -15590,18 +15590,16 @@ bool sme_is_sta_smps_allowed(tHalHandle hal, uint8_t session_id)
 	tpAniSirGlobal mac_ctx = PMAC_STRUCT(hal);
 	tCsrRoamSession *csr_session;
 
-	if (!CSR_IS_SESSION_VALID(mac_ctx, session_id)) {
+	csr_session = CSR_GET_SESSION(mac_ctx, session_id);
+	if (NULL == csr_session) {
 		sms_log(mac_ctx, LOGE,
-			"CSR session not valid: %d",
-			session_id);
+			FL("SME session not valid: %d"), session_id);
 		return false;
 	}
 
-	csr_session = CSR_GET_SESSION(mac_ctx, session_id);
-	if (NULL == csr_session) {
+	if (!CSR_IS_SESSION_VALID(mac_ctx, session_id)) {
 		sms_log(mac_ctx, LOGE,
-			"SME session not valid: %d",
-			session_id);
+			FL("CSR session not valid: %d"), session_id);
 		return false;
 	}