samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

video: driver: update proper state in vb2_buffer_done

Browse Source 
V4l2 clears buffer state related flags. So for driver errors
send state as error to avoid skipping V4L2_BUF_FLAG_ERROR
flag at v4l2 side.

Change-Id: Ifcb96d390746a71e8dbcf261f718439ef9ecfc91
Signed-off-by: Govindaraj Rajagopal <grajagop@codeaurora.org>
This commit is contained in:
Govindaraj Rajagopal
2021-05-07 21:34:42 +05:30
parent 2e2fbdb7e5
commit 57180ce6f2
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
driver/vidc/src/msm_vidc_driver.c
View File

@@ -3058,7 +3058,7 @@ int msm_vidc_release_internal_buffers(struct msm_vidc_inst *inst,
int msm_vidc_vb2_buffer_done(struct msm_vidc_inst *inst,
struct msm_vidc_buffer *buf)
{
int type, port;
int type, port, state;
struct vb2_queue *q;
struct vb2_buffer *vb2;
struct vb2_v4l2_buffer *vbuf;
@@ -3095,11 +3095,21 @@ int msm_vidc_vb2_buffer_done(struct msm_vidc_inst *inst,
print_vidc_buffer(VIDC_ERR, "err ", "vb2 not found for", inst, buf);
return -EINVAL;
}
/**
* v4l2 clears buffer state related flags. For driver errors
* send state as error to avoid skipping V4L2_BUF_FLAG_ERROR
* flag at v4l2 side.
*/
if (buf->flags & MSM_VIDC_BUF_FLAG_ERROR)
state = VB2_BUF_STATE_ERROR;
else
state = VB2_BUF_STATE_DONE;
vbuf = to_vb2_v4l2_buffer(vb2);
vbuf->flags = buf->flags;
vb2->timestamp = buf->timestamp;
vb2->planes[0].bytesused = buf->data_size + vb2->planes[0].data_offset;
vb2_buffer_done(vb2, VB2_BUF_STATE_DONE);
vb2_buffer_done(vb2, state);
return 0;
}