samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Use qdf_dbg instead of qdf_print for non-error logs

Browse Source 
Stats printing with excessive loops should not go to the console.
Avoids watch-dog bites.

Change-Id: I7b0f9d73139dff97c16f492cbd1cb2d255255b3e
CRs-Fixed: 2091039
This commit is contained in:
Houston Hoffman
2017-08-10 15:19:13 -07:00
committed by snandini
parent 8f6788d071
commit 5645dd2803
5 changed files with 35 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
hif/src/ce/ce_tasklet.c
View File

@@ -346,7 +346,7 @@ void hif_display_ce_stats(struct HIF_CE_state *hif_ce_state)
char str_buffer[STR_SIZE];
int size, ret;
qdf_print("CE interrupt statistics:");
qdf_debug("CE interrupt statistics:");
for (i = 0; i < CE_COUNT_MAX; i++) {
size = STR_SIZE;
pos = 0;
@@ -358,7 +358,7 @@ void hif_display_ce_stats(struct HIF_CE_state *hif_ce_state)
size -= ret;
pos += ret;
}
qdf_print("CE id[%2d] - %s", i, str_buffer);
qdf_debug("CE id[%2d] - %s", i, str_buffer);
}
#undef STR_SIZE
}

8
hif/src/hif_napi.c
View File

@@ -916,16 +916,16 @@ void hif_napi_stats(struct qca_napi_data *napid)
struct qca_napi_cpu *cpu;
if (napid == NULL) {
qdf_print("%s: napiid struct is null", __func__);
qdf_debug("%s: napiid struct is null", __func__);
return;
}
cpu = napid->napi_cpu;
qdf_print("NAPI CPU TABLE");
qdf_print("lilclhead=%d, bigclhead=%d",
qdf_debug("NAPI CPU TABLE");
qdf_debug("lilclhead=%d, bigclhead=%d",
napid->lilcl_head, napid->bigcl_head);
for (i = 0; i < NR_CPUS; i++) {
qdf_print("CPU[%02d]: state:%d crid=%02d clid=%02d crmk:0x%0lx thmk:0x%0lx frq:%d napi = 0x%08x lnk:%d",
qdf_debug("CPU[%02d]: state:%d crid=%02d clid=%02d crmk:0x%0lx thmk:0x%0lx frq:%d napi = 0x%08x lnk:%d",
i,
cpu[i].state, cpu[i].core_id, cpu[i].cluster_id,
cpu[i].core_mask.bits[0],

2
hif/src/hif_napi.h
View File

@@ -143,7 +143,7 @@ int hif_napi_poll(struct hif_opaque_softc *hif_ctx,
#ifdef FEATURE_NAPI_DEBUG
#define NAPI_DEBUG(fmt, ...) \
qdf_print("wlan: NAPI: %s:%d "fmt, __func__, __LINE__, ##__VA_ARGS__)
qdf_debug("wlan: NAPI: %s:%d "fmt, __func__, __LINE__, ##__VA_ARGS__)
#else
#define NAPI_DEBUG(fmt, ...) /* NO-OP */
#endif /* FEATURE NAPI_DEBUG */

48
hif/src/mp_dev.c
View File

@@ -180,9 +180,9 @@ void priv_dump_chaninfo(struct hif_softc *scn)
hif_read32_mb(scn->mem +
BB_chn_tables_intf_data) &
0x0000ffff;
qdf_print("0x%x\t", val);
qdf_debug("0x%x\t", val);
if (i % 4 == 0)
qdf_print("\n");
qdf_debug("\n");
}
} else {
len = (bw == 2) ? 59 : 60;
@@ -190,10 +190,10 @@ void priv_dump_chaninfo(struct hif_softc *scn)
tmp =
hif_read32_mb(scn->mem +
BB_chn_tables_intf_data);
qdf_print("0x%x\t", ((tmp >> 16) & 0x0000ffff));
qdf_print("0x%x\t", (tmp & 0x0000ffff));
qdf_debug("0x%x\t", ((tmp >> 16) & 0x0000ffff));
qdf_debug("0x%x\t", (tmp & 0x0000ffff));
if (i % 2 == 0)
qdf_print("\n");
qdf_debug("\n");
}
if (bw > 2) {
/* bw == 3 for vht80 */
@@ -205,11 +205,11 @@ void priv_dump_chaninfo(struct hif_softc *scn)
tmp =
hif_read32_mb(scn->mem +
BB_chn_tables_intf_data);
qdf_print("0x%x\t",
qdf_debug("0x%x\t",
((tmp >> 16) & 0x0000ffff));
qdf_print("0x%x\t", (tmp & 0x0000ffff));
qdf_debug("0x%x\t", (tmp & 0x0000ffff));
if (i % 2 == 0)
qdf_print("\n");
qdf_debug("\n");
}
}
}
@@ -222,9 +222,9 @@ void priv_dump_chaninfo(struct hif_softc *scn)
hif_read32_mb(scn->mem +
BB_chn1_tables_intf_data) &
0x0000ffff;
qdf_print("0x%x\t", val);
qdf_debug("0x%x\t", val);
if (i % 4 == 0)
qdf_print("\n");
qdf_debug("\n");
}
} else {
len = (bw == 2) ? 59 : 60;
@@ -232,10 +232,10 @@ void priv_dump_chaninfo(struct hif_softc *scn)
tmp =
hif_read32_mb(scn->mem +
BB_chn1_tables_intf_data);
qdf_print("0x%x\n", (tmp >> 16) & 0x0000ffff);
qdf_print("0x%x\n", tmp & 0x0000ffff);
qdf_debug("0x%x\n", (tmp >> 16) & 0x0000ffff);
qdf_debug("0x%x\n", tmp & 0x0000ffff);
if (i % 2 == 0)
qdf_print("\n");
qdf_debug("\n");
}
if (bw > 2) {
/* bw == 3 for vht80 */
@@ -247,11 +247,11 @@ void priv_dump_chaninfo(struct hif_softc *scn)
tmp =
hif_read32_mb(scn->mem +
BB_chn1_tables_intf_data);
qdf_print("0x%x\t",
qdf_debug("0x%x\t",
((tmp >> 16) & 0x0000ffff));
qdf_print("0x%x\t", (tmp & 0x0000ffff));
qdf_debug("0x%x\t", (tmp & 0x0000ffff));
if (i % 2 == 0)
qdf_print("\n");
qdf_debug("\n");
}
}
}
@@ -287,9 +287,9 @@ void priv_dump_agc(struct hif_softc *scn)
BB_chaninfo_tab_b0 + i * 4);
val = hif_read32_mb(scn->mem +
PHY_BB_CHN_TABLES_INTF_DATA);
qdf_print("0x%x\t", val);
qdf_debug("0x%x\t", val);
if (i % 4 == 0)
qdf_print("\n");
qdf_debug("\n");
}
}
if (chain1) {
@@ -299,9 +299,9 @@ void priv_dump_agc(struct hif_softc *scn)
BB_chaninfo_tab_b0 + i * 4);
val = hif_read32_mb(scn->mem +
PHY_BB_CHN1_TABLES_INTF_DATA);
qdf_print("0x%x\t", val);
qdf_debug("0x%x\t", val);
if (i % 4 == 0)
qdf_print("\n");
qdf_debug("\n");
}
}
HIF_TRACE("%s: AGC history buffer dump X", __func__);
@@ -319,12 +319,12 @@ void priv_dump_bbwatchdog(struct hif_softc *scn)
HIF_TRACE("%s: BB watchdog dump E", __func__);
val = hif_read32_mb(scn->mem + BB_watchdog_status);
qdf_print("0x%x\t", val);
qdf_debug("0x%x\t", val);
val = hif_read32_mb(scn->mem + BB_watchdog_ctrl_1);
qdf_print("0x%x\t", val);
qdf_debug("0x%x\t", val);
val = hif_read32_mb(scn->mem + BB_watchdog_ctrl_2);
qdf_print("0x%x\t", val);
qdf_debug("0x%x\t", val);
val = hif_read32_mb(scn->mem + BB_watchdog_status_B);
qdf_print("0x%x", val);
qdf_debug("0x%x", val);
HIF_TRACE("%s: BB watchdog dump X", __func__);
}

4
qdf/inc/qdf_types.h
View File

@@ -540,7 +540,11 @@ void __printf(3, 4) qdf_trace_msg(QDF_MODULE_ID module, QDF_TRACE_LEVEL level,
#define qdf_print(args...) \
QDF_TRACE(QDF_MODULE_ID_QDF, QDF_TRACE_LEVEL_ERROR, ## args)
#define qdf_debug(args...) \
QDF_TRACE(QDF_MODULE_ID_QDF, QDF_TRACE_LEVEL_DEBUG, ## args)
#else
#define qdf_debug printk
#define qdf_print printk
#endif /* CONFIG_MCL */