qcacld-3.0: skip sending DHCP indication message if host suspended

Scenario:
(1) Host entered into system suspend.
(2) FW received DHCP Req and trigger WOW wake up.
(3) Host send WMI_WOW_HOSTWAKEUP_FROM_SLEEP_CMDID to FW.
(4) FW reinject RX DHCP Req to REO, send WMI_WOW_WAKEUP_HOST_EVENTID
    to host.
(5) Since DP RX thread has been disabled, host DP receives DHCP Req
    and do DHCP inspection directly, send DHCP indication message
    to FW, but wmi_handle->is_target_suspended is true,
    trigger crash.
(6) Host set wmi_handle->is_target_suspended to false only after receiving
    WMI_WOW_WAKEUP_HOST_EVENTID.

Solution:
skip sending DHCP indication message if host suspended and DP RX
thread is not enabled, do not update sta_info->dhcp_nego_status,
then TX DHCP ACK won't do dp_post_dhcp_ind() in this case as well.

Change-Id: Ie4c414357ed7547ee9b882f3ec659bfe91b6b20d
CRs-Fixed: 3585743

components/dp/core/src/wlan_dp_softap_txrx.c

@@ -229,6 +229,19 @@ int dp_post_dhcp_ind(struct wlan_dp_link *dp_link, uint8_t *mac_addr,
 	}
 
 	dp_intf = dp_link->dp_intf;
+	/*
+	 * If DP RX thread is enabled, RX DHCP packets are enqueue into
+	 * DP RX thread queue, defer DHCP inspection until host has
+	 * resumed entirely, no issue to send DHCP indication MSG.
+	 * If DP RX thread is disabled, DHCP inspection happens earlier,
+	 * skip sending DHCP indication MSG if host has not resumed.
+	 */
+	if (qdf_unlikely(!dp_intf->dp_ctx->enable_dp_rx_threads &&
+			 dp_intf->dp_ctx->is_suspend)) {
+		dp_err_rl("Device is system suspended, skip DHCP Ind");
+		return QDF_STATUS_E_INVAL;
+	}
+
 	sb_ops = &dp_intf->dp_ctx->sb_ops;
 	msg.dhcp_start = dhcp_start;
 	msg.device_mode = dp_intf->device_mode;
@@ -322,7 +335,9 @@ int dp_softap_inspect_dhcp_packet(struct wlan_dp_link *dp_link,
 						sta_info->sta_mac.bytes,
 						true);
 			sta_info->dhcp_phase = DHCP_PHASE_DISCOVER;
-			sta_info->dhcp_nego_status = DHCP_NEGO_IN_PROGRESS;
+			if (QDF_IS_STATUS_SUCCESS(errno))
+				sta_info->dhcp_nego_status =
+						DHCP_NEGO_IN_PROGRESS;
 			break;
 		case QDF_PROTO_DHCP_OFFER:
 			sta_info->dhcp_phase = DHCP_PHASE_OFFER;
@@ -335,7 +350,9 @@ int dp_softap_inspect_dhcp_packet(struct wlan_dp_link *dp_link,
 						dp_link,
 						sta_info->sta_mac.bytes,
 						true);
-			sta_info->dhcp_nego_status = DHCP_NEGO_IN_PROGRESS;
+			if (QDF_IS_STATUS_SUCCESS(errno))
+				sta_info->dhcp_nego_status =
+						DHCP_NEGO_IN_PROGRESS;
 			fallthrough;
 		case QDF_PROTO_DHCP_DECLINE:
 			if (dir == QDF_RX)