Преглед изворни кода

qcacmn: Assert only when unmapped is true in rx_desc

The existing assertions for unmapped variable in
rx descriptor results in an undesired bug_on since
the unmapped value is 0 for active descriptors.

The fix is to modify this assertion so that bug_on will
be triggered only if the unmapped value is 1 in rx
desc.

Change-Id: I03b27e0e42ce3c42b9fa148da9258063b0209b08
CRs-Fixed: 2985248
Yeshwanth Sriram Guntuka пре 4 година
родитељ
комит
5246cc0bf2
3 измењених фајлова са 3 додато и 3 уклоњено
  1. 1 1
      dp/wifi3.0/be/dp_be_rx.c
  2. 1 1
      dp/wifi3.0/dp_rx_err.c
  3. 1 1
      dp/wifi3.0/li/dp_li_rx.c

+ 1 - 1
dp/wifi3.0/be/dp_be_rx.c

@@ -183,7 +183,7 @@ more_data:
 					   ring_desc, rx_desc);
 		if (QDF_IS_STATUS_ERROR(status)) {
 			if (qdf_unlikely(rx_desc && rx_desc->nbuf)) {
-				qdf_assert_always(rx_desc->unmapped);
+				qdf_assert_always(!rx_desc->unmapped);
 				dp_ipa_reo_ctx_buf_mapping_lock(
 							soc,
 							reo_ring_num);

+ 1 - 1
dp/wifi3.0/dp_rx_err.c

@@ -1938,7 +1938,7 @@ static int dp_rx_err_handle_msdu_buf(struct dp_soc *soc,
 
 	/* After this point the rx_desc and nbuf are valid */
 	dp_ipa_rx_buf_smmu_mapping_lock(soc);
-	qdf_assert_always(rx_desc->unmapped);
+	qdf_assert_always(!rx_desc->unmapped);
 	dp_ipa_handle_rx_buf_smmu_mapping(soc,
 					  rx_desc->nbuf,
 					  RX_DATA_BUFFER_SIZE,

+ 1 - 1
dp/wifi3.0/li/dp_li_rx.c

@@ -188,7 +188,7 @@ more_data:
 					   ring_desc, rx_desc);
 		if (QDF_IS_STATUS_ERROR(status)) {
 			if (qdf_unlikely(rx_desc && rx_desc->nbuf)) {
-				qdf_assert_always(rx_desc->unmapped);
+				qdf_assert_always(!rx_desc->unmapped);
 				dp_ipa_reo_ctx_buf_mapping_lock(soc,
 								reo_ring_num);
 				dp_ipa_handle_rx_buf_smmu_mapping(