samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Cleanup HDD suspend/resume logging messages

Browse Source 
Some HDD suspend/resume logging messages are vague or include redundant
status codes. Update these messages to reflect what actually happened and
remove redundant status codes.

Change-Id: Ic3613ab37a4c118447ce14087c8e0b0b65a108d9
CRs-Fixed: 1062544
This commit is contained in:
Dustin Brown
2016-09-01 15:58:23 -07:00
committed by Gerrit - the friendly Code Review server
parent 186f3a1d94
commit 5237aeac13
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
core/hdd/src/wlan_hdd_driver_ops.c
View File

@@ -554,7 +554,7 @@ static int __wlan_hdd_bus_suspend(pm_message_t state)
if (err) if (err)
goto resume_wma; goto resume_wma;
hdd_err("suspend done, status = %d", err); hdd_err("suspend done");
return err; return err;
resume_wma: resume_wma:
@@ -564,7 +564,7 @@ resume_oltxrx:
status = ol_txrx_bus_resume(); status = ol_txrx_bus_resume();
QDF_BUG(!status); QDF_BUG(!status);
done: done:
hdd_err("suspend done, status = %d", err); hdd_err("suspend failed, status = %d", err);
return err; return err;
} }
@@ -603,9 +603,10 @@ int __wlan_hdd_bus_suspend_noirq(void)
{ {
hdd_context_t *hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD); hdd_context_t *hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD);
void *hif_ctx; void *hif_ctx;
int err = wlan_hdd_validate_context(hdd_ctx); int err;
int status; int status;
err = wlan_hdd_validate_context(hdd_ctx);
if (err) if (err)
goto done; goto done;
@@ -628,14 +629,17 @@ int __wlan_hdd_bus_suspend_noirq(void)
if (err) if (err)
goto resume_hif_noirq; goto resume_hif_noirq;
hdd_err("suspend_noirq done, status = %d", err); hdd_err("suspend_noirq done");
return err; return err;
resume_hif_noirq: resume_hif_noirq:
status = hif_bus_resume_noirq(hif_ctx); status = hif_bus_resume_noirq(hif_ctx);
QDF_BUG(!status); QDF_BUG(!status);
done: done:
hdd_err("suspend_noirq done, status = %d", err); if (err == -EAGAIN)
hdd_err("firmware not ready for suspend, try again");
else
hdd_err("suspend_noirq failed, status = %d", err);
return err; return err;
} }