diff --git a/dp/wifi3.0/be/dp_be.c b/dp/wifi3.0/be/dp_be.c index 5dd1bf78cc..7b7a87c653 100644 --- a/dp/wifi3.0/be/dp_be.c +++ b/dp/wifi3.0/be/dp_be.c @@ -672,7 +672,7 @@ QDF_STATUS dp_peer_setup_ppeds_be(struct dp_soc *soc, mld_soc = mld_peer->vdev->pdev->soc; cdp_soc = &mld_soc->cdp_soc; if (!cdp_soc->ol_ops->get_ppeds_profile_info_for_vap) { - dp_err("%pK: Register PPEDS profile info API before use\n", cdp_soc); + dp_err("%pK: Register PPEDS profile info API before use", cdp_soc); return QDF_STATUS_E_NULL_VALUE; } @@ -680,7 +680,7 @@ QDF_STATUS dp_peer_setup_ppeds_be(struct dp_soc *soc, mld_peer->vdev->vdev_id, &vp_params); if (qdf_status == QDF_STATUS_E_NULL_VALUE) { - dp_err("%pK: Failed to get ppeds profile for mld soc\n", mld_soc); + dp_err("%pK: Failed to get ppeds profile for mld soc", mld_soc); return qdf_status; } @@ -1219,7 +1219,7 @@ static void dp_soc_txrx_peer_setup_be(struct dp_soc *soc, uint8_t vdev_id, * Extract the VP profile from the VAP */ if (!cdp_soc->ol_ops->get_ppeds_profile_info_for_vap) { - dp_err("%pK: Register get ppeds profile info first\n", cdp_soc); + dp_err("%pK: Register get ppeds profile info first", cdp_soc); qdf_status = QDF_STATUS_E_NULL_VALUE; goto fail; } @@ -1232,7 +1232,7 @@ static void dp_soc_txrx_peer_setup_be(struct dp_soc *soc, uint8_t vdev_id, tgt_peer->vdev->vdev_id, &vp_params); if (qdf_status == QDF_STATUS_E_NULL_VALUE) { - dp_err("%pK: Could not find ppeds profile info vdev\n", be_vdev); + dp_err("%pK: Could not find ppeds profile info vdev", be_vdev); qdf_status = QDF_STATUS_E_NULL_VALUE; goto fail; } @@ -2164,7 +2164,7 @@ dp_mlo_peer_find_hash_find_be(struct dp_soc *soc, if (vdev_id != DP_VDEV_ALL) { vdev = dp_vdev_get_ref_by_id(soc, vdev_id, mod_id); if (!vdev) { - dp_err("vdev is null\n"); + dp_err("vdev is null"); return NULL; } } else { diff --git a/dp/wifi3.0/dp_htt.c b/dp/wifi3.0/dp_htt.c index d70a2c9bee..b648686f9e 100644 --- a/dp/wifi3.0/dp_htt.c +++ b/dp/wifi3.0/dp_htt.c @@ -3457,7 +3457,7 @@ dp_rx_mlo_timestamp_ind_handler(struct dp_soc *soc, HTT_T2H_MLO_TIMESTAMP_OFFSET_MLO_TIMESTAMP_COMP_PERIOD_US_GET( *(msg_word + 7)); - dp_htt_debug("tsf_lo=%d tsf_hi=%d, mlo_ofst_lo=%d, mlo_ofst_hi=%d\n", + dp_htt_debug("tsf_lo=%d tsf_hi=%d, mlo_ofst_lo=%d, mlo_ofst_hi=%d", pdev->timestamp.sync_tstmp_lo_us, pdev->timestamp.sync_tstmp_hi_us, pdev->timestamp.mlo_offset_lo_us, diff --git a/dp/wifi3.0/dp_main.c b/dp/wifi3.0/dp_main.c index 86d01c2dcc..8e9a79906f 100644 --- a/dp/wifi3.0/dp_main.c +++ b/dp/wifi3.0/dp_main.c @@ -5115,13 +5115,13 @@ static int dp_get_sec_type(struct cdp_soc_t *soc, uint8_t vdev_id, DP_MOD_ID_CDP); if (!peer) { - dp_cdp_err("%pK: Peer is NULL!\n", (struct dp_soc *)soc); + dp_cdp_err("%pK: Peer is NULL!", (struct dp_soc *)soc); return sec_type; } if (!peer->txrx_peer) { dp_peer_unref_delete(peer, DP_MOD_ID_CDP); - dp_peer_debug("%pK: txrx peer is NULL!\n", soc); + dp_peer_debug("%pK: txrx peer is NULL!", soc); return sec_type; } sec_type = peer->txrx_peer->security[sec_idx].sec_type; @@ -5151,7 +5151,7 @@ dp_peer_authorize(struct cdp_soc_t *soc_hdl, uint8_t vdev_id, DP_MOD_ID_CDP); if (!peer) { - dp_cdp_debug("%pK: Peer is NULL!\n", soc); + dp_cdp_debug("%pK: Peer is NULL!", soc); status = QDF_STATUS_E_FAILURE; } else { peer->authorize = authorize ? 1 : 0; @@ -5187,7 +5187,7 @@ dp_peer_get_authorize(struct cdp_soc_t *soc_hdl, uint8_t vdev_id, DP_MOD_ID_CDP); if (!peer) { - dp_cdp_debug("%pK: Peer is NULL!\n", soc); + dp_cdp_debug("%pK: Peer is NULL!", soc); return authorize; } @@ -7356,17 +7356,17 @@ dp_set_vdev_param(struct cdp_soc_t *cdp_soc, uint8_t vdev_id, switch (param) { case CDP_ENABLE_WDS: - dp_cdp_err("%pK: wds_enable %d for vdev(%pK) id(%d)\n", + dp_cdp_err("%pK: wds_enable %d for vdev(%pK) id(%d)", dsoc, val.cdp_vdev_param_wds, vdev, vdev->vdev_id); vdev->wds_enabled = val.cdp_vdev_param_wds; break; case CDP_ENABLE_MEC: - dp_cdp_err("%pK: mec_enable %d for vdev(%pK) id(%d)\n", + dp_cdp_err("%pK: mec_enable %d for vdev(%pK) id(%d)", dsoc, val.cdp_vdev_param_mec, vdev, vdev->vdev_id); vdev->mec_enabled = val.cdp_vdev_param_mec; break; case CDP_ENABLE_DA_WAR: - dp_cdp_err("%pK: da_war_enable %d for vdev(%pK) id(%d)\n", + dp_cdp_err("%pK: da_war_enable %d for vdev(%pK) id(%d)", dsoc, val.cdp_vdev_param_da_war, vdev, vdev->vdev_id); vdev->pdev->soc->da_war_enabled = val.cdp_vdev_param_da_war; dp_wds_flush_ast_table_wifi3(((struct cdp_soc_t *) @@ -9403,7 +9403,7 @@ dp_soc_handle_pdev_mode_change pdev->lmac_id = lmac_id; pdev->target_pdev_id = dp_calculate_target_pdev_id_from_host_pdev_id(soc, pdev_id); - dp_info(" mode change %d %d\n", pdev->pdev_id, pdev->lmac_id); + dp_info("mode change %d %d", pdev->pdev_id, pdev->lmac_id); /*Set host PDEV ID for lmac_id*/ wlan_cfg_set_pdev_idx(soc->wlan_cfg_ctx, @@ -9597,7 +9597,7 @@ static QDF_STATUS dp_peer_map_attach_wifi3(struct cdp_soc_t *soc_hdl, return QDF_STATUS_E_FAILURE; } - dp_info("max_peers %u, calculated max_peers %u max_ast_index: %u\n", + dp_info("max_peers %u, calculated max_peers %u max_ast_index: %u", max_peers, soc->max_peer_id, max_ast_index); status = dp_peer_find_attach(soc); @@ -9751,7 +9751,7 @@ dp_get_peer_extd_rate_link_stats(struct cdp_soc_t *soc_hdl, uint8_t *mac_addr) struct cdp_peer_info peer_info = { 0 }; if (!mac_addr) { - dp_err("NULL peer mac addr\n"); + dp_err("NULL peer mac addr"); return QDF_STATUS_E_FAILURE; } @@ -9760,7 +9760,7 @@ dp_get_peer_extd_rate_link_stats(struct cdp_soc_t *soc_hdl, uint8_t *mac_addr) peer = dp_peer_hash_find_wrapper(soc, &peer_info, DP_MOD_ID_CDP); if (!peer) { - dp_err("Invalid peer\n"); + dp_err("Invalid peer"); return QDF_STATUS_E_FAILURE; } @@ -9799,14 +9799,14 @@ dp_get_peer_extd_rate_link_stats(struct cdp_soc_t *soc_hdl, uint8_t *mac_addr) struct dp_soc *soc = (struct dp_soc *)soc_hdl; if (!mac_addr) { - dp_err("NULL peer mac addr\n"); + dp_err("NULL peer mac addr"); return QDF_STATUS_E_FAILURE; } peer = dp_peer_find_hash_find(soc, mac_addr, 0, DP_VDEV_ALL, DP_MOD_ID_CDP); if (!peer) { - dp_err("Invalid peer\n"); + dp_err("Invalid peer"); return QDF_STATUS_E_FAILURE; } @@ -12016,7 +12016,7 @@ dp_soc_attach(struct cdp_ctrl_objmgr_psoc *ctrl_psoc, wlan_set_srng_cfg(&soc->wlan_srng_cfg); soc->wlan_cfg_ctx = wlan_cfg_soc_attach(soc->ctrl_psoc); if (!soc->wlan_cfg_ctx) { - dp_err("wlan_cfg_ctx failed\n"); + dp_err("wlan_cfg_ctx failed"); goto fail2; } @@ -12449,7 +12449,7 @@ uint16_t dp_get_peer_id(ol_txrx_soc_handle soc, uint8_t vdev_id, uint8_t *mac) uint16_t peer_id = HTT_INVALID_PEER; if (!peer) { - dp_cdp_debug("%pK: Peer is NULL!\n", (struct dp_soc *)soc); + dp_cdp_debug("%pK: Peer is NULL!", (struct dp_soc *)soc); return peer_id; } @@ -12472,7 +12472,7 @@ QDF_STATUS dp_wds_ext_set_peer_rx(ol_txrx_soc_handle soc, QDF_STATUS status = QDF_STATUS_E_INVAL; if (!peer) { - dp_cdp_debug("%pK: Peer is NULL!\n", (struct dp_soc *)soc); + dp_cdp_debug("%pK: Peer is NULL!", (struct dp_soc *)soc); return status; } @@ -12517,13 +12517,13 @@ QDF_STATUS dp_wds_ext_get_peer_osif_handle( DP_MOD_ID_CDP); if (!peer) { - dp_cdp_debug("%pK: Peer is NULL!\n", dp_soc); + dp_cdp_debug("%pK: Peer is NULL!", dp_soc); return QDF_STATUS_E_INVAL; } txrx_peer = dp_get_txrx_peer(peer); if (!txrx_peer) { - dp_cdp_debug("%pK: TXRX Peer is NULL!\n", dp_soc); + dp_cdp_debug("%pK: TXRX Peer is NULL!", dp_soc); dp_peer_unref_delete(peer, DP_MOD_ID_CDP); return QDF_STATUS_E_INVAL; } @@ -12852,7 +12852,7 @@ static QDF_STATUS dp_pdev_init(struct cdp_soc_t *txrx_soc, } if (dp_monitor_pdev_init(pdev)) { - dp_init_err("%pK: dp_monitor_pdev_init failed\n", soc); + dp_init_err("%pK: dp_monitor_pdev_init failed", soc); goto fail6; } diff --git a/dp/wifi3.0/dp_rings_main.c b/dp/wifi3.0/dp_rings_main.c index 39bdb3c4fd..e0223ef504 100644 --- a/dp/wifi3.0/dp_rings_main.c +++ b/dp/wifi3.0/dp_rings_main.c @@ -1296,7 +1296,7 @@ uint32_t dp_service_srngs(void *dp_ctx, uint32_t dp_budget, int cpu) rx_wbm_rel_mask = int_ctx->rx_wbm_rel_ring_mask; reo_status_mask = int_ctx->reo_status_ring_mask; - dp_verbose_debug("tx %x rx %x rx_err %x rx_wbm_rel %x reo_status %x rx_mon_ring %x host2rxdma %x rxdma2host %x\n", + dp_verbose_debug("tx %x rx %x rx_err %x rx_wbm_rel %x reo_status %x rx_mon_ring %x host2rxdma %x rxdma2host %x", tx_mask, rx_mask, rx_err_mask, rx_wbm_rel_mask, reo_status_mask, int_ctx->rx_mon_ring_mask, @@ -4005,7 +4005,7 @@ void dp_drain_txrx(struct cdp_soc_t *soc_handle) * pendings writes(HP/TP) are flushed before read returns. */ val = HAL_REG_READ((struct hal_soc *)soc->hal_soc, 0); - dp_debug("Register value at offset 0: %u\n", val); + dp_debug("Register value at offset 0: %u", val); } #endif diff --git a/dp/wifi3.0/dp_rx.c b/dp/wifi3.0/dp_rx.c index c25714845f..a8eeb68c58 100644 --- a/dp/wifi3.0/dp_rx.c +++ b/dp/wifi3.0/dp_rx.c @@ -1910,7 +1910,7 @@ qdf_nbuf_t dp_rx_sg_create(struct dp_soc *soc, qdf_nbuf_t nbuf) nbuf->next = NULL; break; } else if (qdf_nbuf_is_rx_chfrag_end(nbuf)) { - dp_err("Invalid packet length\n"); + dp_err("Invalid packet length"); qdf_assert_always(0); } nbuf = nbuf->next; @@ -2885,7 +2885,7 @@ QDF_STATUS dp_rx_vdev_detach(struct dp_vdev *vdev) if (vdev->osif_rx_flush) { ret = vdev->osif_rx_flush(vdev->osif_vdev, vdev->vdev_id); if (!QDF_IS_STATUS_SUCCESS(ret)) { - dp_err("Failed to flush rx pkts for vdev %d\n", + dp_err("Failed to flush rx pkts for vdev %d", vdev->vdev_id); return ret; } diff --git a/dp/wifi3.0/dp_rx_defrag.c b/dp/wifi3.0/dp_rx_defrag.c index b30fff8238..dc9818e99d 100644 --- a/dp/wifi3.0/dp_rx_defrag.c +++ b/dp/wifi3.0/dp_rx_defrag.c @@ -317,7 +317,7 @@ dp_rx_defrag_fraglist_insert(struct dp_txrx_peer *txrx_peer, unsigned int tid, rx_desc_info = qdf_nbuf_data(frag); cur_fragno = dp_rx_frag_get_mpdu_frag_number(soc, rx_desc_info); - dp_debug("cur_fragno %d\n", cur_fragno); + dp_debug("cur_fragno %d", cur_fragno); /* If this is the first fragment */ if (!(*head_addr)) { *head_addr = *tail_addr = frag; @@ -1968,10 +1968,10 @@ dp_rx_defrag_store_fragment(struct dp_soc *soc, /* Check if the fragment is for the same sequence or a different one */ dp_debug("rx_tid %d", tid); if (rx_reorder_array_elem->head) { - dp_debug("rxseq %d\n", rxseq); + dp_debug("rxseq %d", rxseq); if (rxseq != rx_tid->curr_seq_num) { - dp_debug("mismatch cur_seq %d rxseq %d\n", + dp_debug("mismatch cur_seq %d rxseq %d", rx_tid->curr_seq_num, rxseq); /* Drop stored fragments if out of sequence * fragment is received @@ -1980,7 +1980,7 @@ dp_rx_defrag_store_fragment(struct dp_soc *soc, DP_STATS_INC(soc, rx.rx_frag_oor, 1); - dp_debug("cur rxseq %d\n", rxseq); + dp_debug("cur rxseq %d", rxseq); /* * The sequence number for this fragment becomes the * new sequence number to be processed @@ -1995,7 +1995,7 @@ dp_rx_defrag_store_fragment(struct dp_soc *soc, qdf_spin_unlock_bh(&rx_tid->defrag_tid_lock); goto discard_frag; } - dp_debug("cur rxseq %d\n", rxseq); + dp_debug("cur rxseq %d", rxseq); /* Start of a new sequence */ dp_rx_defrag_cleanup(txrx_peer, tid); rx_tid->curr_seq_num = rxseq; diff --git a/dp/wifi3.0/dp_rx_tid.c b/dp/wifi3.0/dp_rx_tid.c index d607ec14e1..b8d6b5e6e0 100644 --- a/dp/wifi3.0/dp_rx_tid.c +++ b/dp/wifi3.0/dp_rx_tid.c @@ -139,7 +139,7 @@ void dp_peer_update_tid_stats_from_reo(struct dp_soc *soc, void *cb_ctxt, uint16_t peer_id; if (queue_status->header.status != HAL_REO_CMD_SUCCESS) { - dp_err("REO stats failure %d\n", + dp_err("REO stats failure %d", queue_status->header.status); return; } @@ -174,7 +174,7 @@ void dp_rx_tid_stats_cb(struct dp_soc *soc, void *cb_ctxt, return; if (queue_status->header.status != HAL_REO_CMD_SUCCESS) { - DP_PRINT_STATS("REO stats failure %d for TID %d\n", + DP_PRINT_STATS("REO stats failure %d for TID %d", queue_status->header.status, rx_tid->tid); return; } @@ -1246,7 +1246,7 @@ int dp_addba_resp_tx_completion_wifi3(struct cdp_soc_t *cdp_soc, struct dp_rx_tid *rx_tid = NULL; if (!peer) { - dp_peer_debug("%pK: Peer is NULL!\n", cdp_soc); + dp_peer_debug("%pK: Peer is NULL!", cdp_soc); goto fail; } rx_tid = &peer->rx_tid[tid]; @@ -1339,7 +1339,7 @@ dp_addba_responsesetup_wifi3(struct cdp_soc_t *cdp_soc, uint8_t *peer_mac, DP_MOD_ID_CDP); if (!peer) { - dp_peer_debug("%pK: Peer is NULL!\n", cdp_soc); + dp_peer_debug("%pK: Peer is NULL!", cdp_soc); return QDF_STATUS_E_FAILURE; } rx_tid = &peer->rx_tid[tid]; @@ -1439,7 +1439,7 @@ QDF_STATUS dp_rx_tid_update_ba_win_size(struct cdp_soc_t *cdp_soc, peer_mac, 0, vdev_id, DP_MOD_ID_CDP); if (!peer) { - dp_peer_debug("%pK: Peer is NULL!\n", cdp_soc); + dp_peer_debug("%pK: Peer is NULL!", cdp_soc); return QDF_STATUS_E_FAILURE; } @@ -1477,7 +1477,7 @@ int dp_addba_requestprocess_wifi3(struct cdp_soc_t *cdp_soc, DP_MOD_ID_CDP); if (!peer) { - dp_peer_debug("%pK: Peer is NULL!\n", cdp_soc); + dp_peer_debug("%pK: Peer is NULL!", cdp_soc); return QDF_STATUS_E_FAILURE; } rx_tid = &peer->rx_tid[tid]; @@ -1554,7 +1554,7 @@ dp_set_addba_response(struct cdp_soc_t *cdp_soc, uint8_t *peer_mac, struct dp_rx_tid *rx_tid; if (!peer) { - dp_peer_debug("%pK: Peer is NULL!\n", cdp_soc); + dp_peer_debug("%pK: Peer is NULL!", cdp_soc); return QDF_STATUS_E_FAILURE; } @@ -1578,7 +1578,7 @@ int dp_delba_process_wifi3(struct cdp_soc_t *cdp_soc, uint8_t *peer_mac, DP_MOD_ID_CDP); if (!peer) { - dp_peer_debug("%pK: Peer is NULL!\n", cdp_soc); + dp_peer_debug("%pK: Peer is NULL!", cdp_soc); return QDF_STATUS_E_FAILURE; } rx_tid = &peer->rx_tid[tid]; @@ -1682,14 +1682,14 @@ dp_set_pn_check_wifi3(struct cdp_soc_t *soc_t, uint8_t vdev_id, DP_MOD_ID_CDP); if (!peer) { - dp_peer_debug("%pK: Peer is NULL!\n", soc); + dp_peer_debug("%pK: Peer is NULL!", soc); return QDF_STATUS_E_FAILURE; } vdev = peer->vdev; if (!vdev) { - dp_peer_debug("%pK: VDEV is NULL!\n", soc); + dp_peer_debug("%pK: VDEV is NULL!", soc); dp_peer_unref_delete(peer, DP_MOD_ID_CDP); return QDF_STATUS_E_FAILURE; } diff --git a/dp/wifi3.0/li/dp_li_rx.c b/dp/wifi3.0/li/dp_li_rx.c index 9685059d55..f3199ca403 100644 --- a/dp/wifi3.0/li/dp_li_rx.c +++ b/dp/wifi3.0/li/dp_li_rx.c @@ -543,7 +543,7 @@ done: &head[mac_id], &tail[mac_id]); } - dp_verbose_debug("replenished %u\n", rx_bufs_reaped[0]); + dp_verbose_debug("replenished %u", rx_bufs_reaped[0]); /* Peer can be NULL is case of LFR */ if (qdf_likely(txrx_peer)) vdev = NULL; diff --git a/dp/wifi3.0/monitor/1.0/dp_mon_1.0.c b/dp/wifi3.0/monitor/1.0/dp_mon_1.0.c index e0a4f5459a..6eea4f2dfd 100644 --- a/dp/wifi3.0/monitor/1.0/dp_mon_1.0.c +++ b/dp/wifi3.0/monitor/1.0/dp_mon_1.0.c @@ -388,7 +388,7 @@ QDF_STATUS dp_vdev_set_monitor_mode_rings(struct dp_pdev *pdev, /* Allocate sw rx descriptor pool for mon RxDMA buffer ring */ status = dp_rx_pdev_mon_buf_desc_pool_alloc(pdev, mac_for_pdev); if (!QDF_IS_STATUS_SUCCESS(status)) { - dp_err("%s: dp_rx_pdev_mon_buf_desc_pool_alloc() failed\n", + dp_err("%s: dp_rx_pdev_mon_buf_desc_pool_alloc() failed", __func__); goto fail0; } diff --git a/dp/wifi3.0/monitor/1.0/dp_rx_mon_1.0.h b/dp/wifi3.0/monitor/1.0/dp_rx_mon_1.0.h index 5b6be5bc6d..f6665fa98c 100644 --- a/dp/wifi3.0/monitor/1.0/dp_rx_mon_1.0.h +++ b/dp/wifi3.0/monitor/1.0/dp_rx_mon_1.0.h @@ -285,7 +285,7 @@ dp_rx_mon_add_msdu_to_list_failure_handler(void *rx_tlv_hdr, qdf_frag_free(rx_tlv_hdr); if (head_msdu) qdf_nbuf_list_free(*head_msdu); - dp_err("[%s] failed to allocate subsequent parent buffer to hold all frag\n", + dp_err("[%s] failed to allocate subsequent parent buffer to hold all frag", func_name); if (head_msdu) *head_msdu = NULL; @@ -555,7 +555,7 @@ QDF_STATUS dp_rx_mon_add_msdu_to_list(struct dp_soc *soc, qdf_nbuf_t *head_msdu, /* Here head_msdu and *head_msdu must not be NULL */ /* Dont add frag to skb if frag length is zero. Drop frame */ if (qdf_unlikely(!frag_len || !head_msdu || !(*head_msdu))) { - dp_err("[%s] frag_len[%d] || head_msdu[%pK] || *head_msdu is Null while adding frag to skb\n", + dp_err("[%s] frag_len[%d] || head_msdu[%pK] || *head_msdu is Null while adding frag to skb", __func__, frag_len, head_msdu); return QDF_STATUS_E_FAILURE; } @@ -568,7 +568,7 @@ QDF_STATUS dp_rx_mon_add_msdu_to_list(struct dp_soc *soc, qdf_nbuf_t *head_msdu, /* Current msdu must not be NULL */ if (qdf_unlikely(!msdu_curr)) { - dp_err("[%s] Current msdu can't be Null while adding frag to skb\n", + dp_err("[%s] Current msdu can't be Null while adding frag to skb", __func__); return QDF_STATUS_E_FAILURE; } diff --git a/dp/wifi3.0/monitor/1.0/dp_rx_mon_dest_1.0.c b/dp/wifi3.0/monitor/1.0/dp_rx_mon_dest_1.0.c index 8a591e2d80..6b13fe760d 100644 --- a/dp/wifi3.0/monitor/1.0/dp_rx_mon_dest_1.0.c +++ b/dp/wifi3.0/monitor/1.0/dp_rx_mon_dest_1.0.c @@ -1347,7 +1347,7 @@ dp_rx_pdev_mon_desc_pool_alloc(struct dp_pdev *pdev) for (mac_id = 0; mac_id < NUM_RXDMA_RINGS_PER_PDEV; mac_id++) { status = dp_rx_pdev_mon_cmn_desc_pool_alloc(pdev, mac_id); if (!QDF_IS_STATUS_SUCCESS(status)) { - dp_rx_mon_dest_err("%pK: %d failed\n", + dp_rx_mon_dest_err("%pK: %d failed", pdev->soc, mac_id); for (count = 0; count < mac_id; count++) @@ -2218,7 +2218,7 @@ void dp_rx_mon_update_pf_tag_to_buf_headroom(struct dp_soc *soc, qdf_nbuf_t ext_list; if (qdf_unlikely(!soc)) { - dp_err("Soc[%pK] Null. Can't update pftag to nbuf headroom\n", + dp_err("Soc[%pK] Null. Can't update pftag to nbuf headroom", soc); qdf_assert_always(0); } diff --git a/dp/wifi3.0/monitor/dp_rx_mon.c b/dp/wifi3.0/monitor/dp_rx_mon.c index 1af24c2db7..1ea2d43067 100644 --- a/dp/wifi3.0/monitor/dp_rx_mon.c +++ b/dp/wifi3.0/monitor/dp_rx_mon.c @@ -530,8 +530,7 @@ dp_rx_populate_cdp_indication_ppdu_user(struct dp_pdev *pdev, * HTT_UL_OFDMA_V0_RU_SIZE_RU_996x2 */ if (qdf_unlikely(ru_size >= OFDMA_NUM_RU_SIZE)) { - dp_err("invalid ru_size %d\n", - ru_size); + dp_err("invalid ru_size %d", ru_size); return; } is_data = dp_rx_inc_rusize_cnt(pdev, diff --git a/dp/wifi3.0/rh/dp_rh_htt.c b/dp/wifi3.0/rh/dp_rh_htt.c index d942d265ed..9507d703b8 100644 --- a/dp/wifi3.0/rh/dp_rh_htt.c +++ b/dp/wifi3.0/rh/dp_rh_htt.c @@ -76,7 +76,7 @@ dp_htt_flow_pool_map_handler_rh(struct dp_soc *soc, uint8_t flow_id, status = dp_tx_flow_pool_map_handler(pdev, flow_id, flow_type, flow_pool_id, flow_pool_size); if (QDF_IS_STATUS_ERROR(status)) { - dp_err("failed to create tx flow pool %d\n", flow_pool_id); + dp_err("failed to create tx flow pool %d", flow_pool_id); goto err_out; } diff --git a/dp/wifi3.0/rh/dp_rh_rx.c b/dp/wifi3.0/rh/dp_rh_rx.c index 5fc243dff9..698a73d590 100644 --- a/dp/wifi3.0/rh/dp_rh_rx.c +++ b/dp/wifi3.0/rh/dp_rh_rx.c @@ -960,7 +960,7 @@ dp_rx_data_indication_handler(struct dp_soc *soc, qdf_nbuf_t data_ind, &head[mac_id], &tail[mac_id]); } - dp_verbose_debug("replenished %u\n", rx_bufs_reaped[0]); + dp_verbose_debug("replenished %u", rx_bufs_reaped[0]); /* Peer can be NULL is case of LFR */ if (qdf_likely(txrx_peer)) vdev = NULL; diff --git a/dp/wifi3.0/rh/dp_rh_tx.c b/dp/wifi3.0/rh/dp_rh_tx.c index 4e36700a8c..41205418fe 100644 --- a/dp/wifi3.0/rh/dp_rh_tx.c +++ b/dp/wifi3.0/rh/dp_rh_tx.c @@ -610,25 +610,25 @@ QDF_STATUS dp_tx_desc_pool_alloc_rh(struct dp_soc *soc, uint32_t num_elem, status = dp_tx_tcl_desc_pool_alloc_rh(soc, num_elem, pool_id); if (QDF_IS_STATUS_ERROR(status)) { - dp_err("failed to allocate tcl desc pool %d\n", pool_id); + dp_err("failed to allocate tcl desc pool %d", pool_id); goto err_tcl_desc_pool; } status = dp_tx_ext_desc_pool_alloc_by_id(soc, num_elem, pool_id); if (QDF_IS_STATUS_ERROR(status)) { - dp_err("failed to allocate tx ext desc pool %d\n", pool_id); + dp_err("failed to allocate tx ext desc pool %d", pool_id); goto err_free_tcl_pool; } status = dp_tx_tso_desc_pool_alloc_by_id(soc, num_elem, pool_id); if (QDF_IS_STATUS_ERROR(status)) { - dp_err("failed to allocate tso desc pool %d\n", pool_id); + dp_err("failed to allocate tso desc pool %d", pool_id); goto err_free_tx_ext_pool; } status = dp_tx_tso_num_seg_pool_alloc_by_id(soc, num_elem, pool_id); if (QDF_IS_STATUS_ERROR(status)) { - dp_err("failed to allocate tso num seg pool %d\n", pool_id); + dp_err("failed to allocate tso num seg pool %d", pool_id); goto err_free_tso_pool; } diff --git a/hal/wifi3.0/be/hal_be_rx_tlv.h b/hal/wifi3.0/be/hal_be_rx_tlv.h index 1ab2c8ee69..ab664cfd9c 100644 --- a/hal/wifi3.0/be/hal_be_rx_tlv.h +++ b/hal/wifi3.0/be/hal_be_rx_tlv.h @@ -932,7 +932,7 @@ static inline void hal_rx_print_pn_be(uint8_t *buf) uint32_t pn_95_64 = HAL_RX_TLV_MPDU_PN_95_64_GET(rx_pkt_tlvs); uint32_t pn_127_96 = HAL_RX_TLV_MPDU_PN_127_96_GET(rx_pkt_tlvs); - hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x ", + hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x", pn_127_96, pn_95_64, pn_63_32, pn_31_0); } @@ -1201,7 +1201,7 @@ static inline void hal_rx_print_pn_be(uint8_t *buf) uint32_t pn_63_32 = HAL_RX_TLV_MPDU_PN_63_32_GET(rx_pkt_tlvs); uint32_t pn_95_64 = HAL_RX_TLV_MPDU_PN_95_64_GET(rx_pkt_tlvs); - hal_debug("PN number pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x ", + hal_debug("PN number pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x", pn_95_64, pn_63_32, pn_31_0); } diff --git a/hal/wifi3.0/hal_api.h b/hal/wifi3.0/hal_api.h index 79c24b3dae..d412ee2e1a 100644 --- a/hal/wifi3.0/hal_api.h +++ b/hal/wifi3.0/hal_api.h @@ -109,7 +109,7 @@ static inline int hal_history_get_next_index(qdf_atomic_t *table_index, } #else #define HAL_REG_WRITE_FAIL_HIST_ADD(hal_soc, offset, wr_val, rd_val) \ - hal_err("write failed at reg offset 0x%x, write 0x%x read 0x%x\n", \ + hal_err("write failed at reg offset 0x%x, write 0x%x read 0x%x", \ offset, \ wr_val, \ rd_val) diff --git a/hal/wifi3.0/hal_srng.c b/hal/wifi3.0/hal_srng.c index a4b6d14b56..3dc0e08c0c 100644 --- a/hal/wifi3.0/hal_srng.c +++ b/hal/wifi3.0/hal_srng.c @@ -1785,7 +1785,7 @@ void *hal_srng_setup_idx(void *hal_soc, int ring_type, int ring_num, int mac_id, if (idx) { hal->ops->hal_tx_ring_halt_set(hal_hdl); do { - hal_info("Waiting for ring reset\n"); + hal_info("Waiting for ring reset"); } while (!(hal->ops->hal_tx_ring_halt_poll(hal_hdl))); } hal_srng_hw_init(hal, srng, idle_check, idx); diff --git a/hal/wifi3.0/qca5018/hal_5018.c b/hal/wifi3.0/qca5018/hal_5018.c index bbe5bbb29c..e3e32db18e 100644 --- a/hal/wifi3.0/qca5018/hal_5018.c +++ b/hal/wifi3.0/qca5018/hal_5018.c @@ -772,7 +772,7 @@ static void hal_rx_print_pn_5018(uint8_t *buf) uint32_t pn_95_64 = HAL_RX_MPDU_PN_95_64_GET(mpdu_info); uint32_t pn_127_96 = HAL_RX_MPDU_PN_127_96_GET(mpdu_info); - hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x ", + hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x", pn_127_96, pn_95_64, pn_63_32, pn_31_0); } diff --git a/hal/wifi3.0/qca6290/hal_6290.c b/hal/wifi3.0/qca6290/hal_6290.c index 2da7bdc850..66e73edef4 100644 --- a/hal/wifi3.0/qca6290/hal_6290.c +++ b/hal/wifi3.0/qca6290/hal_6290.c @@ -251,7 +251,7 @@ static void hal_rx_print_pn_6290(uint8_t *buf) uint32_t pn_95_64 = HAL_RX_MPDU_PN_95_64_GET(mpdu_info); uint32_t pn_127_96 = HAL_RX_MPDU_PN_127_96_GET(mpdu_info); - hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x ", + hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x", pn_127_96, pn_95_64, pn_63_32, pn_31_0); } diff --git a/hal/wifi3.0/qca6390/hal_6390.c b/hal/wifi3.0/qca6390/hal_6390.c index 29f99f81fc..85da3ed229 100644 --- a/hal/wifi3.0/qca6390/hal_6390.c +++ b/hal/wifi3.0/qca6390/hal_6390.c @@ -251,7 +251,7 @@ static void hal_rx_print_pn_6390(uint8_t *buf) uint32_t pn_95_64 = HAL_RX_MPDU_PN_95_64_GET(mpdu_info); uint32_t pn_127_96 = HAL_RX_MPDU_PN_127_96_GET(mpdu_info); - hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x ", + hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x", pn_127_96, pn_95_64, pn_63_32, pn_31_0); } diff --git a/hal/wifi3.0/qca6490/hal_6490.c b/hal/wifi3.0/qca6490/hal_6490.c index ead5139c59..57ac6d406c 100644 --- a/hal/wifi3.0/qca6490/hal_6490.c +++ b/hal/wifi3.0/qca6490/hal_6490.c @@ -657,7 +657,7 @@ static void hal_rx_print_pn_6490(uint8_t *buf) uint32_t pn_95_64 = HAL_RX_MPDU_PN_95_64_GET(mpdu_info); uint32_t pn_127_96 = HAL_RX_MPDU_PN_127_96_GET(mpdu_info); - hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x ", + hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x", pn_127_96, pn_95_64, pn_63_32, pn_31_0); } diff --git a/hal/wifi3.0/qca6750/hal_6750.c b/hal/wifi3.0/qca6750/hal_6750.c index 8441dfd184..e4d668de81 100644 --- a/hal/wifi3.0/qca6750/hal_6750.c +++ b/hal/wifi3.0/qca6750/hal_6750.c @@ -652,7 +652,7 @@ static void hal_rx_print_pn_6750(uint8_t *buf) uint32_t pn_95_64 = HAL_RX_MPDU_PN_95_64_GET(mpdu_info); uint32_t pn_127_96 = HAL_RX_MPDU_PN_127_96_GET(mpdu_info); - hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x ", + hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x", pn_127_96, pn_95_64, pn_63_32, pn_31_0); } diff --git a/hal/wifi3.0/qca8074v1/hal_8074v1.c b/hal/wifi3.0/qca8074v1/hal_8074v1.c index bc19fb5b07..4f0ad64584 100644 --- a/hal/wifi3.0/qca8074v1/hal_8074v1.c +++ b/hal/wifi3.0/qca8074v1/hal_8074v1.c @@ -270,7 +270,7 @@ static void hal_rx_print_pn_8074v1(uint8_t *buf) uint32_t pn_95_64 = HAL_RX_MPDU_PN_95_64_GET(mpdu_info); uint32_t pn_127_96 = HAL_RX_MPDU_PN_127_96_GET(mpdu_info); - hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x ", + hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x", pn_127_96, pn_95_64, pn_63_32, pn_31_0); } diff --git a/hal/wifi3.0/qca8074v2/hal_8074v2.c b/hal/wifi3.0/qca8074v2/hal_8074v2.c index d8719adda3..1540d1173b 100644 --- a/hal/wifi3.0/qca8074v2/hal_8074v2.c +++ b/hal/wifi3.0/qca8074v2/hal_8074v2.c @@ -257,7 +257,7 @@ static void hal_rx_print_pn_8074v2(uint8_t *buf) uint32_t pn_95_64 = HAL_RX_MPDU_PN_95_64_GET(mpdu_info); uint32_t pn_127_96 = HAL_RX_MPDU_PN_127_96_GET(mpdu_info); - hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x ", + hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x", pn_127_96, pn_95_64, pn_63_32, pn_31_0); } diff --git a/hal/wifi3.0/qcn6122/hal_qcn6122.c b/hal/wifi3.0/qcn6122/hal_qcn6122.c index 4d922e6d8d..8166f28436 100644 --- a/hal/wifi3.0/qcn6122/hal_qcn6122.c +++ b/hal/wifi3.0/qcn6122/hal_qcn6122.c @@ -776,7 +776,7 @@ static void hal_rx_print_pn_6122(uint8_t *buf) uint32_t pn_95_64 = HAL_RX_MPDU_PN_95_64_GET(mpdu_info); uint32_t pn_127_96 = HAL_RX_MPDU_PN_127_96_GET(mpdu_info); - hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x ", + hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x", pn_127_96, pn_95_64, pn_63_32, pn_31_0); } diff --git a/hal/wifi3.0/qcn9000/hal_9000.c b/hal/wifi3.0/qcn9000/hal_9000.c index b0047537c5..fc97a2b6e8 100644 --- a/hal/wifi3.0/qcn9000/hal_9000.c +++ b/hal/wifi3.0/qcn9000/hal_9000.c @@ -774,7 +774,7 @@ static void hal_rx_print_pn_9000(uint8_t *buf) uint32_t pn_95_64 = HAL_RX_MPDU_PN_95_64_GET(mpdu_info); uint32_t pn_127_96 = HAL_RX_MPDU_PN_127_96_GET(mpdu_info); - hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x ", + hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x", pn_127_96, pn_95_64, pn_63_32, pn_31_0); } diff --git a/hal/wifi3.0/wcn6450/hal_wcn6450.c b/hal/wifi3.0/wcn6450/hal_wcn6450.c index 394bebfb78..b3293034f5 100644 --- a/hal/wifi3.0/wcn6450/hal_wcn6450.c +++ b/hal/wifi3.0/wcn6450/hal_wcn6450.c @@ -911,7 +911,7 @@ static void hal_rx_print_pn_6450(uint8_t *buf) uint32_t pn_95_64 = HAL_RX_MPDU_PN_95_64_GET(mpdu_info); uint32_t pn_127_96 = HAL_RX_MPDU_PN_127_96_GET(mpdu_info); - hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x ", + hal_debug("PN number pn_127_96 0x%x pn_95_64 0x%x pn_63_32 0x%x pn_31_0 0x%x", pn_127_96, pn_95_64, pn_63_32, pn_31_0); } diff --git a/hif/src/hif_exec.c b/hif/src/hif_exec.c index 45afa5a10b..37419e45b2 100644 --- a/hif/src/hif_exec.c +++ b/hif/src/hif_exec.c @@ -1101,7 +1101,7 @@ qdf_export_symbol(hif_register_ext_group); struct hif_exec_context *hif_exec_create(enum hif_exec_type type, uint32_t scale) { - hif_debug("%s: create exec_type %d budget %d\n", + hif_debug("%s: create exec_type %d budget %d", __func__, type, QCA_NAPI_BUDGET * scale); switch (type) { @@ -1154,7 +1154,7 @@ void hif_deregister_exec_group(struct hif_opaque_softc *hif_ctx, if (!hif_ext_group) continue; - hif_debug("%s: Deregistering grp id %d name %s\n", + hif_debug("%s: Deregistering grp id %d name %s", __func__, hif_ext_group->grp_id, hif_ext_group->context_name); @@ -1216,7 +1216,7 @@ QDF_STATUS hif_get_umac_reset_irq(struct hif_opaque_softc *hif_scn, "umac_reset", 0, umac_reset_irq); if (ret) { - hif_err("umac reset get irq failed ret %d\n", ret); + hif_err("umac reset get irq failed ret %d", ret); return QDF_STATUS_E_FAILURE; } return QDF_STATUS_SUCCESS; diff --git a/hif/src/pcie/if_pci.c b/hif/src/pcie/if_pci.c index e46598b7c1..d97390e541 100644 --- a/hif/src/pcie/if_pci.c +++ b/hif/src/pcie/if_pci.c @@ -3703,7 +3703,7 @@ static void hif_pci_get_soc_info_pld(struct hif_pci_softc *sc, sc->device_version.major_version = info.device_version.major_version; sc->device_version.minor_version = info.device_version.minor_version; - hif_info("%s: fam num %u dev ver %u maj ver %u min ver %u\n", __func__, + hif_info("%s: fam num %u dev ver %u maj ver %u min ver %u", __func__, sc->device_version.family_number, sc->device_version.device_number, sc->device_version.major_version, diff --git a/hif/src/sdio/transfer/mailbox.c b/hif/src/sdio/transfer/mailbox.c index 3788ba6143..351d7403c6 100644 --- a/hif/src/sdio/transfer/mailbox.c +++ b/hif/src/sdio/transfer/mailbox.c @@ -477,14 +477,14 @@ void hif_dev_dump_registers(struct hif_sdio_device *pdev, } if (irq_en) { - hif_debug("IntStatusEnable: 0x%x\n", + hif_debug("IntStatusEnable: 0x%x", irq_en->int_status_enable); - hif_debug("CounterIntStatus: 0x%x\n", + hif_debug("CounterIntStatus: 0x%x", irq_en->counter_int_status_enable); } for (i = 0; mbox_regs && i < 4; i++) - hif_debug("Counter[%d]: 0x%x\n", i, mbox_regs->counter[i]); + hif_debug("Counter[%d]: 0x%x", i, mbox_regs->counter[i]); } /* under HL SDIO, with Interface Memory support, we have @@ -603,7 +603,7 @@ void hif_fixup_write_param(struct hif_sdio_dev *pdev, uint32_t req, } else if (taddr == mboxinfo.mbox_prop[1].extended_address) { mboxlen = mboxinfo.mbox_prop[1].extended_size; } else { - hif_err("%s: Invalid write addr: 0x%08x\n", __func__, taddr); + hif_err("%s: Invalid write addr: 0x%08x", __func__, taddr); return; } @@ -672,7 +672,7 @@ static QDF_STATUS hif_dev_recv_packet(struct hif_sdio_device *pdev, if (status == QDF_STATUS_SUCCESS) { HTC_FRAME_HDR *hdr = (HTC_FRAME_HDR *) packet->pBuffer; - hif_debug("%s:EP:%d,Len:%d,Flg:%d,CB:0x%02X,0x%02X\n", + hif_debug("%s:EP:%d,Len:%d,Flg:%d,CB:0x%02X,0x%02X", __func__, hdr->EndpointID, hdr->PayloadLen, hdr->Flags, hdr->ControlBytes0, @@ -706,7 +706,7 @@ static QDF_STATUS hif_dev_issue_recv_packet_bundle if ((HTC_PACKET_QUEUE_DEPTH(recv_pkt_queue) - HTC_MAX_MSG_PER_BUNDLE_RX) > 0) { partial_bundle = true; - hif_warn("%s, partial bundle detected num: %d, %d\n", + hif_warn("%s, partial bundle detected num: %d, %d", __func__, HTC_PACKET_QUEUE_DEPTH(recv_pkt_queue), HTC_MAX_MSG_PER_BUNDLE_RX); @@ -716,7 +716,7 @@ static QDF_STATUS hif_dev_issue_recv_packet_bundle HTC_MAX_MSG_PER_BUNDLE_RX * target->TargetCreditSize; packet_rx_bundle = allocate_htc_bundle_packet(target); if (!packet_rx_bundle) { - hif_err("%s: packet_rx_bundle is NULL\n", __func__); + hif_err("%s: packet_rx_bundle is NULL", __func__); qdf_sleep(NBUF_ALLOC_FAIL_WAIT_TIME); /* 100 msec sleep */ return QDF_STATUS_E_NOMEM; } @@ -767,7 +767,7 @@ static QDF_STATUS hif_dev_issue_recv_packet_bundle HIF_RD_SYNC_BLOCK_FIX, NULL); if (status != QDF_STATUS_SUCCESS) { - hif_err("%s, hif_send Failed status:%d\n", + hif_err("%s, hif_send Failed status:%d", __func__, status); } else { unsigned char *buffer = bundle_buffer; @@ -813,7 +813,7 @@ QDF_STATUS hif_dev_recv_message_pending_handler(struct hif_sdio_device *pdev, HTC_PACKET_QUEUE recv_q, sync_comp_q; QDF_STATUS (*rxCompletion)(void *, qdf_nbuf_t, uint8_t); - hif_debug("%s: NumLookAheads: %d\n", __func__, num_look_aheads); + hif_debug("%s: NumLookAheads: %d", __func__, num_look_aheads); if (num_pkts_fetched) *num_pkts_fetched = 0; @@ -855,7 +855,7 @@ QDF_STATUS hif_dev_recv_message_pending_handler(struct hif_sdio_device *pdev, id = ((HTC_FRAME_HDR *)&look_aheads[0])->EndpointID; if (id >= ENDPOINT_MAX) { - hif_err("%s: Invalid Endpoint in lookahead: %d\n", + hif_err("%s: Invalid Endpoint in lookahead: %d", __func__, id); status = QDF_STATUS_E_PROTO; break; @@ -1606,7 +1606,7 @@ static QDF_STATUS hif_sdio_func_enable(struct hif_softc *ol_sc, ret = sdio_set_block_size(func, HIF_BLOCK_SIZE); if (ret) { - hif_err("%s: Unable to set block size 0x%X : %d\n", + hif_err("%s: Unable to set block size 0x%X : %d", __func__, HIF_BLOCK_SIZE, ret); sdio_release_host(func); return QDF_STATUS_E_FAILURE; @@ -1614,7 +1614,7 @@ static QDF_STATUS hif_sdio_func_enable(struct hif_softc *ol_sc, ret = hif_sdio_quirk_mod_strength(ol_sc, func); if (ret) { - hif_err("%s: Error setting mod strength : %d\n", + hif_err("%s: Error setting mod strength : %d", __func__, ret); sdio_release_host(func); return QDF_STATUS_E_FAILURE; @@ -1678,13 +1678,13 @@ __hif_read_write(struct hif_sdio_dev *device, length = (length / HIF_BLOCK_SIZE) * HIF_BLOCK_SIZE; - hif_debug("%s: Block mode (BlockLen: %d)\n", + hif_debug("%s: Block mode (BlockLen: %d)", __func__, length); } else if (request & HIF_BYTE_BASIS) { - hif_debug("%s: Byte mode (BlockLen: %d)\n", + hif_debug("%s: Byte mode (BlockLen: %d)", __func__, length); } else { - hif_err("%s: Invalid data mode: 0x%08x\n", + hif_err("%s: Invalid data mode: 0x%08x", __func__, request); status = QDF_STATUS_E_INVAL; break; @@ -1693,21 +1693,21 @@ __hif_read_write(struct hif_sdio_dev *device, hif_fixup_write_param(device, request, &length, &address); - hif_debug("addr:%08X, len:0x%08X, dummy:0x%04X\n", + hif_debug("addr:%08X, len:0x%08X, dummy:0x%04X", address, length, (request & HIF_DUMMY_SPACE_MASK) >> 16); } if (request & HIF_FIXED_ADDRESS) { opcode = CMD53_FIXED_ADDRESS; - hif_debug("%s: Addr mode: fixed 0x%X\n", + hif_debug("%s: Addr mode: fixed 0x%X", __func__, address); } else if (request & HIF_INCREMENTAL_ADDRESS) { opcode = CMD53_INCR_ADDRESS; - hif_debug("%s: Address mode: Incremental 0x%X\n", + hif_debug("%s: Address mode: Incremental 0x%X", __func__, address); } else { - hif_err("%s: Invalid address mode: 0x%08x\n", + hif_err("%s: Invalid address mode: 0x%08x", __func__, request); status = QDF_STATUS_E_INVAL; break; @@ -1721,7 +1721,7 @@ __hif_read_write(struct hif_sdio_dev *device, /* copy the write data to the dma buffer */ AR_DEBUG_ASSERT(length <= HIF_DMA_BUFFER_SIZE); if (length > HIF_DMA_BUFFER_SIZE) { - hif_err("%s: Invalid write len: %d\n", + hif_err("%s: Invalid write len: %d", __func__, length); status = QDF_STATUS_E_INVAL; break; @@ -1737,13 +1737,13 @@ __hif_read_write(struct hif_sdio_dev *device, if (opcode == CMD53_FIXED_ADDRESS && tbuffer) { ret = sdio_writesb(device->func, address, tbuffer, length); - hif_debug("%s:r=%d addr:0x%X, len:%d, 0x%X\n", + hif_debug("%s:r=%d addr:0x%X, len:%d, 0x%X", __func__, ret, address, length, *(int *)tbuffer); } else if (tbuffer) { ret = sdio_memcpy_toio(device->func, address, tbuffer, length); - hif_debug("%s:r=%d addr:0x%X, len:%d, 0x%X\n", + hif_debug("%s:r=%d addr:0x%X, len:%d, 0x%X", __func__, ret, address, length, *(int *)tbuffer); } @@ -1753,7 +1753,7 @@ __hif_read_write(struct hif_sdio_dev *device, AR_DEBUG_ASSERT(device->dma_buffer); AR_DEBUG_ASSERT(length <= HIF_DMA_BUFFER_SIZE); if (length > HIF_DMA_BUFFER_SIZE) { - hif_err("%s: Invalid read len: %d\n", + hif_err("%s: Invalid read len: %d", __func__, length); status = QDF_STATUS_E_INVAL; break; @@ -1769,14 +1769,14 @@ __hif_read_write(struct hif_sdio_dev *device, if (opcode == CMD53_FIXED_ADDRESS && tbuffer) { ret = sdio_readsb(device->func, tbuffer, address, length); - hif_debug("%s:r=%d addr:0x%X, len:%d, 0x%X\n", + hif_debug("%s:r=%d addr:0x%X, len:%d, 0x%X", __func__, ret, address, length, *(int *)tbuffer); } else if (tbuffer) { ret = sdio_memcpy_fromio(device->func, tbuffer, address, length); - hif_debug("%s:r=%d addr:0x%X, len:%d, 0x%X\n", + hif_debug("%s:r=%d addr:0x%X, len:%d, 0x%X", __func__, ret, address, length, *(int *)tbuffer); } diff --git a/hif/src/sdio/transfer/transfer.c b/hif/src/sdio/transfer/transfer.c index fac5fec2d5..594915f803 100644 --- a/hif/src/sdio/transfer/transfer.c +++ b/hif/src/sdio/transfer/transfer.c @@ -216,7 +216,7 @@ QDF_STATUS hif_dev_alloc_and_prepare_rx_packets(struct hif_sdio_device *pdev, for (i = 0; i < messages; i++) { hdr = (HTC_FRAME_HDR *)&look_aheads[i]; if (hdr->EndpointID >= ENDPOINT_MAX) { - hif_err("%s: Invalid Endpoint:%d\n", + hif_err("%s: Invalid Endpoint:%d", __func__, hdr->EndpointID); status = QDF_STATUS_E_INVAL; break; @@ -303,7 +303,7 @@ QDF_STATUS hif_dev_alloc_and_prepare_rx_packets(struct hif_sdio_device *pdev, hif_err("%s: header reports payload: %u(%u)", __func__, hdr->PayloadLen, full_length); - hif_err("%s: endpoint buffer size: %d\n", + hif_err("%s: endpoint buffer size: %d", __func__, packet->BufferLength); status = QDF_STATUS_E_INVAL; break;