qcacld-3.0: Replace typedef tSirSmeReadyReq
The Linux Coding Style enumerates a few special cases where typedefs are useful, but stresses "NEVER EVER use a typedef unless you can clearly match one of those rules." The tSirSmeReadyReq typedef does not meet any of those criteria, so replace it (and the "tp" variant) with a reference to the underlying struct. Further note the Linux Coding Style frowns upon mixed-case names and so-called Hungarian notation, so in conjunction rename the underlying struct to be in compliance. Change-Id: Ibf51b14ced59634a77ca8add5b7ac9f6d07215de CRs-Fixed: 2392402
This commit is contained in:
@@ -366,7 +366,7 @@ typedef struct sSirSmeRsp {
|
||||
} tSirSmeRsp, *tpSirSmeRsp;
|
||||
|
||||
/* / Definition for indicating all modules ready on STA */
|
||||
typedef struct sSirSmeReadyReq {
|
||||
struct sme_ready_req {
|
||||
uint16_t messageType; /* eWNI_SME_SYS_READY_IND */
|
||||
uint16_t length;
|
||||
uint16_t transactionId;
|
||||
@@ -375,7 +375,7 @@ typedef struct sSirSmeReadyReq {
|
||||
void *stop_roaming_cb;
|
||||
QDF_STATUS (*sme_msg_cb)(struct mac_context *mac,
|
||||
struct scheduler_msg *msg);
|
||||
} tSirSmeReadyReq, *tpSirSmeReadyReq;
|
||||
};
|
||||
|
||||
/**
|
||||
* struct s_sir_set_hw_mode - Set HW mode request
|
||||
|
@@ -148,7 +148,7 @@ void pe_deregister_mgmt_rx_frm_callback(struct mac_context *mac_ctx);
|
||||
* Return: None
|
||||
*/
|
||||
void pe_register_callbacks_with_wma(struct mac_context *mac,
|
||||
tSirSmeReadyReq *ready_req);
|
||||
struct sme_ready_req *ready_req);
|
||||
|
||||
/**
|
||||
* Function to cleanup LIM state.
|
||||
|
@@ -1310,7 +1310,7 @@ void pe_deregister_mgmt_rx_frm_callback(struct mac_context *mac_ctx)
|
||||
* (function documentation in lim_api.h)
|
||||
*/
|
||||
void pe_register_callbacks_with_wma(struct mac_context *mac,
|
||||
tSirSmeReadyReq *ready_req)
|
||||
struct sme_ready_req *ready_req)
|
||||
{
|
||||
QDF_STATUS status;
|
||||
|
||||
|
@@ -449,10 +449,11 @@ __lim_is_defered_msg_for_radar(struct mac_context *mac_ctx,
|
||||
* false-Posting to HAL successful, so HAL will consume the buffer.
|
||||
*/
|
||||
|
||||
static bool __lim_process_sme_sys_ready_ind(struct mac_context *mac, uint32_t *pMsgBuf)
|
||||
static bool __lim_process_sme_sys_ready_ind(struct mac_context *mac,
|
||||
uint32_t *pMsgBuf)
|
||||
{
|
||||
struct scheduler_msg msg = {0};
|
||||
tSirSmeReadyReq *ready_req = (tSirSmeReadyReq *) pMsgBuf;
|
||||
struct sme_ready_req *ready_req = (struct sme_ready_req *) pMsgBuf;
|
||||
|
||||
msg.type = WMA_SYS_READY_IND;
|
||||
msg.reserved = 0;
|
||||
|
@@ -1104,7 +1104,7 @@ static void sme_process_ready_to_ext_wow(struct mac_context *mac,
|
||||
*/
|
||||
QDF_STATUS sme_hdd_ready_ind(mac_handle_t mac_handle)
|
||||
{
|
||||
tSirSmeReadyReq *msg;
|
||||
struct sme_ready_req *msg;
|
||||
QDF_STATUS status = QDF_STATUS_E_FAILURE;
|
||||
struct mac_context *mac = MAC_CONTEXT(mac_handle);
|
||||
|
||||
|
Reference in New Issue
Block a user