Jelajahi Sumber

qcacmn: Fix -Wmissing-prototypes in QDF

We want to enable the compiler's -Wmissing-prototypes switch, but
there is existing code that is generating warnings. Fix all warnings
in qdf.

Change-Id: Ib499e7d0a5bfb6d2e5a7eaa7fbe769bb2b49772a
CRs-Fixed: 1076314
Jeff Johnson 8 tahun lalu
induk
melakukan
4729b6f857
3 mengubah file dengan 37 tambahan dan 48 penghapusan
  1. 18 0
      qdf/inc/qdf_mc_timer.h
  2. 5 26
      qdf/linux/src/qdf_nbuf.c
  3. 14 22
      qdf/linux/src/qdf_trace.c

+ 18 - 0
qdf/inc/qdf_mc_timer.h

@@ -249,4 +249,22 @@ unsigned long qdf_mc_timer_get_system_ticks(void);
  */
 unsigned long qdf_mc_timer_get_system_time(void);
 
+/**
+ * qdf_timer_module_init() - initializes a QDF timer module.
+ *
+ * This API initializes the QDF timer module. This needs to be called
+ * exactly once prior to using any QDF timers.
+ *
+ * Return: none
+ */
+void qdf_timer_module_init(void);
+
+/**
+ * qdf_timer_module_deinit() - Deinitializes a QDF timer module.
+ *
+ * This API deinitializes the QDF timer module.
+ * Return: none
+ */
+void qdf_timer_module_deinit(void);
+
 #endif /* __QDF_MC_TIMER_H */

+ 5 - 26
qdf/linux/src/qdf_nbuf.c

@@ -1386,7 +1386,7 @@ EXPORT_SYMBOL(qdf_net_buf_debug_exit);
  *
  * Return: hash value
  */
-uint32_t qdf_net_buf_debug_hash(qdf_nbuf_t net_buf)
+static uint32_t qdf_net_buf_debug_hash(qdf_nbuf_t net_buf)
 {
 	uint32_t i;
 
@@ -1396,7 +1396,6 @@ uint32_t qdf_net_buf_debug_hash(qdf_nbuf_t net_buf)
 
 	return i;
 }
-EXPORT_SYMBOL(qdf_net_buf_debug_hash);
 
 /**
  * qdf_net_buf_debug_look_up() - look up network buffer in debug hash table
@@ -1404,7 +1403,7 @@ EXPORT_SYMBOL(qdf_net_buf_debug_hash);
  * Return: If skb is found in hash table then return pointer to network buffer
  *	else return %NULL
  */
-QDF_NBUF_TRACK *qdf_net_buf_debug_look_up(qdf_nbuf_t net_buf)
+static QDF_NBUF_TRACK *qdf_net_buf_debug_look_up(qdf_nbuf_t net_buf)
 {
 	uint32_t i;
 	QDF_NBUF_TRACK *p_node;
@@ -1420,7 +1419,6 @@ QDF_NBUF_TRACK *qdf_net_buf_debug_look_up(qdf_nbuf_t net_buf)
 
 	return NULL;
 }
-EXPORT_SYMBOL(qdf_net_buf_debug_look_up);
 
 /**
  * qdf_net_buf_debug_add_node() - store skb in debug hash table
@@ -1585,7 +1583,7 @@ struct qdf_tso_cmn_seg_info_t {
  *
  * Return: 0 - success 1 - failure
  */
-uint8_t __qdf_nbuf_get_tso_cmn_seg_info(struct sk_buff *skb,
+static uint8_t __qdf_nbuf_get_tso_cmn_seg_info(struct sk_buff *skb,
 	struct qdf_tso_cmn_seg_info_t *tso_info)
 {
 	/* Get ethernet type and ethernet header length */
@@ -1627,7 +1625,6 @@ uint8_t __qdf_nbuf_get_tso_cmn_seg_info(struct sk_buff *skb,
 		skb->len);
 	return 0;
 }
-EXPORT_SYMBOL(__qdf_nbuf_get_tso_cmn_seg_info);
 
 
 /**
@@ -2268,22 +2265,6 @@ __qdf_nbuf_dmamap_set_cb(__qdf_dma_map_t dmap, void *cb, void *arg)
 EXPORT_SYMBOL(__qdf_nbuf_dmamap_set_cb);
 
 
-/**
- * __qdf_nbuf_get_vlan_info() - get vlan info
- * @hdl: net handle
- * @skb: sk buff
- * @vlan: vlan header
- *
- * Return: QDF status
- */
-QDF_STATUS
-__qdf_nbuf_get_vlan_info(qdf_net_handle_t hdl, struct sk_buff *skb,
-			qdf_net_vlanhdr_t *vlan)
-{
-	return QDF_STATUS_SUCCESS;
-}
-EXPORT_SYMBOL(__qdf_nbuf_get_vlan_info);
-
 #ifndef REMOVE_INIT_DEBUG_CODE
 /**
  * __qdf_nbuf_sync_single_for_cpu() - nbuf sync
@@ -2294,14 +2275,13 @@ EXPORT_SYMBOL(__qdf_nbuf_get_vlan_info);
  * Return: none
  */
 #if defined(A_SIMOS_DEVHOST)
-void __qdf_nbuf_sync_single_for_cpu(
+static void __qdf_nbuf_sync_single_for_cpu(
 	qdf_device_t osdev, qdf_nbuf_t buf, qdf_dma_dir_t dir)
 {
 	return;
 }
-EXPORT_SYMBOL(__qdf_nbuf_sync_single_for_cpu);
 #else
-void __qdf_nbuf_sync_single_for_cpu(
+static void __qdf_nbuf_sync_single_for_cpu(
 	qdf_device_t osdev, qdf_nbuf_t buf, qdf_dma_dir_t dir)
 {
 	if (0 ==  QDF_NBUF_CB_PADDR(buf)) {
@@ -2311,7 +2291,6 @@ void __qdf_nbuf_sync_single_for_cpu(
 	dma_sync_single_for_cpu(osdev->dev, QDF_NBUF_CB_PADDR(buf),
 		skb_end_offset(buf) - skb_headroom(buf), dir);
 }
-EXPORT_SYMBOL(__qdf_nbuf_sync_single_for_cpu);
 #endif
 /**
  * __qdf_nbuf_sync_for_cpu() - nbuf sync

+ 14 - 22
qdf/linux/src/qdf_trace.c

@@ -953,6 +953,7 @@ EXPORT_SYMBOL(dump_hex_trace);
  *
  * Return: string version of code
  */
+static
 const char *qdf_dp_code_to_string(enum QDF_DP_TRACE_ID code)
 {
 	switch (code) {
@@ -1004,7 +1005,6 @@ const char *qdf_dp_code_to_string(enum QDF_DP_TRACE_ID code)
 		return "Invalid";
 	}
 }
-EXPORT_SYMBOL(qdf_dp_code_to_string);
 
 /**
  * qdf_dp_dir_to_str() - convert direction to string
@@ -1012,7 +1012,7 @@ EXPORT_SYMBOL(qdf_dp_code_to_string);
  *
  * Return: string version of direction
  */
-const char *qdf_dp_dir_to_str(enum qdf_proto_dir dir)
+static const char *qdf_dp_dir_to_str(enum qdf_proto_dir dir)
 {
 	switch (dir) {
 	case QDF_TX:
@@ -1023,7 +1023,6 @@ const char *qdf_dp_dir_to_str(enum qdf_proto_dir dir)
 		return "invalid";
 	}
 }
-EXPORT_SYMBOL(qdf_dp_dir_to_str);
 
 /**
  * qdf_dp_type_to_str() - convert packet type to string
@@ -1031,7 +1030,7 @@ EXPORT_SYMBOL(qdf_dp_dir_to_str);
  *
  * Return: string version of packet type
  */
-const char *qdf_dp_type_to_str(enum qdf_proto_type type)
+static const char *qdf_dp_type_to_str(enum qdf_proto_type type)
 {
 	switch (type) {
 	case QDF_PROTO_TYPE_DHCP:
@@ -1046,7 +1045,6 @@ const char *qdf_dp_type_to_str(enum qdf_proto_type type)
 		return "invalid";
 	}
 }
-EXPORT_SYMBOL(qdf_dp_type_to_str);
 
 /**
  * qdf_dp_subtype_to_str() - convert packet subtype to string
@@ -1054,7 +1052,7 @@ EXPORT_SYMBOL(qdf_dp_type_to_str);
  *
  * Return: string version of packet subtype
  */
-const char *qdf_dp_subtype_to_str(enum qdf_proto_subtype subtype)
+static const char *qdf_dp_subtype_to_str(enum qdf_proto_subtype subtype)
 {
 	switch (subtype) {
 	case QDF_PROTO_EAPOL_M1:
@@ -1097,7 +1095,6 @@ const char *qdf_dp_subtype_to_str(enum qdf_proto_subtype subtype)
 		return "invalid";
 	}
 }
-EXPORT_SYMBOL(qdf_dp_subtype_to_str);
 
 /**
  * qdf_dp_enable_check() - check if dptrace is enable or not
@@ -1106,8 +1103,8 @@ EXPORT_SYMBOL(qdf_dp_subtype_to_str);
  *
  * Return: true/false
  */
-bool qdf_dp_enable_check(qdf_nbuf_t nbuf, enum QDF_DP_TRACE_ID code,
-		enum qdf_proto_dir dir)
+static bool qdf_dp_enable_check(qdf_nbuf_t nbuf, enum QDF_DP_TRACE_ID code,
+				enum qdf_proto_dir dir)
 {
 	/* Return when Dp trace is not enabled */
 	if (!g_qdf_dp_trace_data.enable)
@@ -1124,7 +1121,6 @@ bool qdf_dp_enable_check(qdf_nbuf_t nbuf, enum QDF_DP_TRACE_ID code,
 
 	return true;
 }
-EXPORT_SYMBOL(qdf_dp_enable_check);
 
 /**
  * qdf_dp_add_record() - add dp trace record
@@ -1135,8 +1131,8 @@ EXPORT_SYMBOL(qdf_dp_enable_check);
  *
  * Return: none
  */
-void qdf_dp_add_record(enum QDF_DP_TRACE_ID code,
-		       uint8_t *data, uint8_t size, bool print)
+static void qdf_dp_add_record(enum QDF_DP_TRACE_ID code,
+			      uint8_t *data, uint8_t size, bool print)
 {
 	struct qdf_dp_trace_record_s *rec = NULL;
 	int index;
@@ -1184,7 +1180,6 @@ void qdf_dp_add_record(enum QDF_DP_TRACE_ID code,
 	if (g_qdf_dp_trace_data.live_mode || (print == true))
 		qdf_dp_trace_cb_table[rec->code] (rec, index);
 }
-EXPORT_SYMBOL(qdf_dp_add_record);
 
 
 /**
@@ -1195,8 +1190,8 @@ EXPORT_SYMBOL(qdf_dp_add_record);
  *
  * Return: true/false
  */
-bool qdf_log_eapol_pkt(uint8_t session_id, struct sk_buff *skb,
-		       enum qdf_proto_dir dir)
+static bool qdf_log_eapol_pkt(uint8_t session_id, struct sk_buff *skb,
+			      enum qdf_proto_dir dir)
 {
 	enum qdf_proto_subtype subtype;
 
@@ -1218,7 +1213,6 @@ bool qdf_log_eapol_pkt(uint8_t session_id, struct sk_buff *skb,
 	}
 	return false;
 }
-EXPORT_SYMBOL(qdf_log_eapol_pkt);
 
 /**
  * qdf_log_dhcp_pkt() - log DHCP packet
@@ -1228,8 +1222,8 @@ EXPORT_SYMBOL(qdf_log_eapol_pkt);
  *
  * Return: true/false
  */
-bool qdf_log_dhcp_pkt(uint8_t session_id, struct sk_buff *skb,
-		      enum qdf_proto_dir dir)
+static bool qdf_log_dhcp_pkt(uint8_t session_id, struct sk_buff *skb,
+			     enum qdf_proto_dir dir)
 {
 	enum qdf_proto_subtype subtype = QDF_PROTO_INVALID;
 
@@ -1251,7 +1245,6 @@ bool qdf_log_dhcp_pkt(uint8_t session_id, struct sk_buff *skb,
 	}
 	return false;
 }
-EXPORT_SYMBOL(qdf_log_dhcp_pkt);
 
 /**
  * qdf_log_arp_pkt() - log ARP packet
@@ -1261,8 +1254,8 @@ EXPORT_SYMBOL(qdf_log_dhcp_pkt);
  *
  * Return: true/false
  */
-bool qdf_log_arp_pkt(uint8_t session_id, struct sk_buff *skb,
-		     enum qdf_proto_dir dir)
+static bool qdf_log_arp_pkt(uint8_t session_id, struct sk_buff *skb,
+			    enum qdf_proto_dir dir)
 {
 	enum qdf_proto_subtype proto_subtype;
 
@@ -1284,7 +1277,6 @@ bool qdf_log_arp_pkt(uint8_t session_id, struct sk_buff *skb,
 	}
 	return false;
 }
-EXPORT_SYMBOL(qdf_log_arp_pkt);
 
 /**
  * qdf_dp_trace_log_pkt() - log packet type enabled through iwpriv