qcacld-3.0: Rename pMsgBuf identifier

The Linux Coding Style doesn't allow mixed-case names and
so-called Hungarian notation, so rename the pMsgBuf to be
compliant.

Change-Id: Ia28e9e8ce69c7fbb6853278ccdb12e722ec24e06
CRs-Fixed: 2463442

core/mac/src/pe/include/lim_ft.h

@@ -132,9 +132,9 @@ static inline void lim_ft_prepare_add_bss_req(struct mac_context *mac,
 {}
 #endif
 
-bool lim_process_ft_update_key(struct mac_context *mac, uint32_t *pMsgBuf);
+bool lim_process_ft_update_key(struct mac_context *mac, uint32_t *msg_buf);
 QDF_STATUS lim_process_ft_aggr_qos_req(struct mac_context *mac,
-		uint32_t *pMsgBuf);
+		uint32_t *msg_buf);
 void lim_process_ft_aggr_qos_rsp(struct mac_context *mac,
 				 struct scheduler_msg *limMsg);
 void lim_ft_cleanup_all_ft_sessions(struct mac_context *mac);

core/mac/src/pe/lim/lim_ft.c

@@ -740,7 +740,7 @@ void lim_fill_ft_session(struct mac_context *mac,
  * This function is called to process the update key request from SME
  *
  *------------------------------------------------------------------*/
-bool lim_process_ft_update_key(struct mac_context *mac, uint32_t *pMsgBuf)
+bool lim_process_ft_update_key(struct mac_context *mac, uint32_t *msg_buf)
 {
 	tAddBssParams *pAddBssParams;
 	tSirFTUpdateKeyInfo *pKeyInfo;
@@ -748,14 +748,13 @@ bool lim_process_ft_update_key(struct mac_context *mac, uint32_t *pMsgBuf)
 	uint8_t sessionId;
 
 	/* Sanity Check */
-	if (!mac || !pMsgBuf) {
+	if (!mac || !msg_buf)
 		return false;
-	}
 
-	pKeyInfo = (tSirFTUpdateKeyInfo *) pMsgBuf;
+	pKeyInfo = (tSirFTUpdateKeyInfo *)msg_buf;
 
 	pe_session = pe_find_session_by_bssid(mac, pKeyInfo->bssid.bytes,
-						 &sessionId);
+					      &sessionId);
 	if (!pe_session) {
 		pe_err("%s: Unable to find session for the following bssid",
 			       __func__);
@@ -927,10 +926,10 @@ void lim_process_ft_aggr_qos_rsp(struct mac_context *mac,
 }
 
 QDF_STATUS lim_process_ft_aggr_qos_req(struct mac_context *mac,
-				       uint32_t *pMsgBuf)
+				       uint32_t *msg_buf)
 {
 	struct scheduler_msg msg = {0};
-	tSirAggrQosReq *aggrQosReq = (tSirAggrQosReq *) pMsgBuf;
+	tSirAggrQosReq *aggrQosReq = (tSirAggrQosReq *) msg_buf;
 	struct aggr_add_ts_param *pAggrAddTsParam;
 	struct pe_session *pe_session = NULL;
 	tpLimTspecInfo tspecInfo;

core/mac/src/pe/lim/lim_process_mlm_rsp_messages.c

@@ -70,56 +70,56 @@ void lim_process_mlm_purge_sta_ind(struct mac_context *, uint32_t *);
  *
  * @param mac       Pointer to Global MAC structure
  * @param  msgType   Indicates the MLM message type
- * @param  *pMsgBuf  A pointer to the MLM message buffer
+ * @param  *msg_buf  A pointer to the MLM message buffer
  *
  * @return None
  */
 void
 lim_process_mlm_rsp_messages(struct mac_context *mac, uint32_t msgType,
-			     uint32_t *pMsgBuf)
+			     uint32_t *msg_buf)
 {
 
-	if (!pMsgBuf) {
+	if (!msg_buf) {
 		pe_err("Buffer is Pointing to NULL");
 		return;
 	}
 	MTRACE(mac_trace(mac, TRACE_CODE_TX_LIM_MSG, 0, msgType));
 	switch (msgType) {
 	case LIM_MLM_AUTH_CNF:
-		lim_process_mlm_auth_cnf(mac, pMsgBuf);
+		lim_process_mlm_auth_cnf(mac, msg_buf);
 		break;
 	case LIM_MLM_ASSOC_CNF:
-		lim_process_mlm_assoc_cnf(mac, pMsgBuf);
+		lim_process_mlm_assoc_cnf(mac, msg_buf);
 		break;
 	case LIM_MLM_START_CNF:
-		lim_process_mlm_start_cnf(mac, pMsgBuf);
+		lim_process_mlm_start_cnf(mac, msg_buf);
 		break;
 	case LIM_MLM_JOIN_CNF:
-		lim_process_mlm_join_cnf(mac, pMsgBuf);
+		lim_process_mlm_join_cnf(mac, msg_buf);
 		break;
 	case LIM_MLM_ASSOC_IND:
-		lim_process_mlm_assoc_ind(mac, pMsgBuf);
+		lim_process_mlm_assoc_ind(mac, msg_buf);
 		break;
 	case LIM_MLM_REASSOC_CNF:
-		lim_process_mlm_reassoc_cnf(mac, pMsgBuf);
+		lim_process_mlm_reassoc_cnf(mac, msg_buf);
 		break;
 	case LIM_MLM_DISASSOC_CNF:
-		lim_process_mlm_disassoc_cnf(mac, pMsgBuf);
+		lim_process_mlm_disassoc_cnf(mac, msg_buf);
 		break;
 	case LIM_MLM_DISASSOC_IND:
-		lim_process_mlm_disassoc_ind(mac, pMsgBuf);
+		lim_process_mlm_disassoc_ind(mac, msg_buf);
 		break;
 	case LIM_MLM_PURGE_STA_IND:
-		lim_process_mlm_purge_sta_ind(mac, pMsgBuf);
+		lim_process_mlm_purge_sta_ind(mac, msg_buf);
 		break;
 	case LIM_MLM_DEAUTH_CNF:
-		lim_process_mlm_deauth_cnf(mac, pMsgBuf);
+		lim_process_mlm_deauth_cnf(mac, msg_buf);
 		break;
 	case LIM_MLM_DEAUTH_IND:
-		lim_process_mlm_deauth_ind(mac, (tLimMlmDeauthInd *)pMsgBuf);
+		lim_process_mlm_deauth_ind(mac, (tLimMlmDeauthInd *)msg_buf);
 		break;
 	case LIM_MLM_SETKEYS_CNF:
-		lim_process_mlm_set_keys_cnf(mac, pMsgBuf);
+		lim_process_mlm_set_keys_cnf(mac, msg_buf);
 		break;
 	case LIM_MLM_TSPEC_CNF:
 		break;
@@ -143,11 +143,11 @@ lim_process_mlm_rsp_messages(struct mac_context *mac, uint32_t msgType,
  ***NOTE:
  *
  * @param mac       Pointer to Global MAC structure
- * @param pMsgBuf    A pointer to the MLM message buffer
+ * @param msg_buf    A pointer to the MLM message buffer
  *
  * @return None
  */
-void lim_process_mlm_start_cnf(struct mac_context *mac, uint32_t *pMsgBuf)
+void lim_process_mlm_start_cnf(struct mac_context *mac, uint32_t *msg_buf)
 {
 	struct pe_session *pe_session = NULL;
 	tLimMlmStartCnf *pLimMlmStartCnf;
@@ -155,11 +155,11 @@ void lim_process_mlm_start_cnf(struct mac_context *mac, uint32_t *pMsgBuf)
 	uint8_t channelId;
 	uint8_t send_bcon_ind = false;
 
-	if (!pMsgBuf) {
+	if (!msg_buf) {
 		pe_err("Buffer is Pointing to NULL");
 		return;
 	}
-	pLimMlmStartCnf = (tLimMlmStartCnf *) pMsgBuf;
+	pLimMlmStartCnf = (tLimMlmStartCnf *)msg_buf;
 	pe_session = pe_find_session_by_session_id(mac,
 				pLimMlmStartCnf->sessionId);
 	if (!pe_session) {
@@ -177,7 +177,7 @@ void lim_process_mlm_start_cnf(struct mac_context *mac, uint32_t *pMsgBuf)
 				pe_session->limSmeState);
 		return;
 	}
-	if (((tLimMlmStartCnf *) pMsgBuf)->resultCode == eSIR_SME_SUCCESS) {
+	if (((tLimMlmStartCnf *)msg_buf)->resultCode == eSIR_SME_SUCCESS) {
 
 		/*
 		 * Update global SME state so that Beacon Generation
@@ -202,11 +202,10 @@ void lim_process_mlm_start_cnf(struct mac_context *mac, uint32_t *pMsgBuf)
 	}
 	/* Send response to Host */
 	lim_send_sme_start_bss_rsp(mac, eWNI_SME_START_BSS_RSP,
-				((tLimMlmStartCnf *)pMsgBuf)->resultCode,
+				((tLimMlmStartCnf *)msg_buf)->resultCode,
 				pe_session, smesessionId);
-	if ((pe_session) &&
-		(((tLimMlmStartCnf *) pMsgBuf)->resultCode ==
-						eSIR_SME_SUCCESS)) {
+	if (pe_session &&
+	    (((tLimMlmStartCnf *)msg_buf)->resultCode == eSIR_SME_SUCCESS)) {
 		channelId = pe_session->pLimStartBssReq->channelId;
 		lim_ndi_mlme_vdev_up_transition(pe_session);
 
@@ -737,24 +736,14 @@ lim_fill_assoc_ind_params(struct mac_context *mac_ctx,
 }
 
 /**
- * lim_process_mlm_assoc_ind()
- *
- ***FUNCTION:
- * This function is called to processes MLM_ASSOC_IND
+ * lim_process_mlm_assoc_ind() - This function is called to processes MLM_ASSOC_IND
  * message from MLM State machine.
+ * @mac       Pointer to Global MAC structure
+ * @msg_buf   A pointer to the MLM message buffer
  *
- ***LOGIC:
- *
- ***ASSUMPTIONS:
- *
- ***NOTE:
- *
- * @param mac       Pointer to Global MAC structure
- * @param pMsgBuf    A pointer to the MLM message buffer
- *
- * @return None
+ * Return: None
  */
-void lim_process_mlm_assoc_ind(struct mac_context *mac, uint32_t *pMsgBuf)
+void lim_process_mlm_assoc_ind(struct mac_context *mac, uint32_t *msg_buf)
 {
 	uint32_t len;
 	struct scheduler_msg msg = {0};
@@ -762,13 +751,12 @@ void lim_process_mlm_assoc_ind(struct mac_context *mac, uint32_t *pMsgBuf)
 	tpDphHashNode sta = 0;
 	struct pe_session *pe_session;
 
-	if (!pMsgBuf) {
+	if (!msg_buf) {
 		pe_err("Buffer is Pointing to NULL");
 		return;
 	}
 	pe_session = pe_find_session_by_session_id(mac,
-				((tpLimMlmAssocInd) pMsgBuf)->
-				sessionId);
+				((tpLimMlmAssocInd) msg_buf)->sessionId);
 	if (!pe_session) {
 		pe_err("Session Does not exist for given sessionId");
 		return;
@@ -782,18 +770,18 @@ void lim_process_mlm_assoc_ind(struct mac_context *mac, uint32_t *pMsgBuf)
 	}
 
 	pSirSmeAssocInd->messageType = eWNI_SME_ASSOC_IND;
-	lim_fill_assoc_ind_params(mac, (tpLimMlmAssocInd) pMsgBuf,
+	lim_fill_assoc_ind_params(mac, (tpLimMlmAssocInd) msg_buf,
 				  pSirSmeAssocInd,
 				  pe_session);
 	msg.type = eWNI_SME_ASSOC_IND;
 	msg.bodyptr = pSirSmeAssocInd;
 	msg.bodyval = 0;
 	sta = dph_get_hash_entry(mac,
-				    ((tpLimMlmAssocInd) pMsgBuf)->aid,
+				    ((tpLimMlmAssocInd) msg_buf)->aid,
 				    &pe_session->dph.dphHashTable);
 	if (!sta) {
 		pe_err("MLM AssocInd: Station context no longer valid (aid %d)",
-			((tpLimMlmAssocInd) pMsgBuf)->aid);
+			((tpLimMlmAssocInd) msg_buf)->aid);
 		qdf_mem_free(pSirSmeAssocInd);
 
 		return;
@@ -812,36 +800,26 @@ void lim_process_mlm_assoc_ind(struct mac_context *mac, uint32_t *pMsgBuf)
 	** turn on a timer to detect the loss of ASSOC CNF
 	**/
 	lim_activate_cnf_timer(mac,
-			       (uint16_t) ((tpLimMlmAssocInd) pMsgBuf)->aid,
+			       (uint16_t) ((tpLimMlmAssocInd)msg_buf)->aid,
 			       pe_session);
 
 	mac->lim.sme_msg_callback(mac, &msg);
 } /*** end lim_process_mlm_assoc_ind() ***/
 
 /**
- * lim_process_mlm_disassoc_ind()
+ * lim_process_mlm_disassoc_ind() - This function is called to processes
+ * MLM_DISASSOC_IND message from MLM State machine.
+ * @mac:       Pointer to Global MAC structure
+ * @msg_buf:    A pointer to the MLM message buffer
  *
- ***FUNCTION:
- * This function is called to processes MLM_DISASSOC_IND
- * message from MLM State machine.
- *
- ***LOGIC:
- *
- ***ASSUMPTIONS:
- *
- ***NOTE:
- *
- * @param mac       Pointer to Global MAC structure
- * @param pMsgBuf    A pointer to the MLM message buffer
- *
- * @return None
+ * Return None
  */
-void lim_process_mlm_disassoc_ind(struct mac_context *mac, uint32_t *pMsgBuf)
+void lim_process_mlm_disassoc_ind(struct mac_context *mac, uint32_t *msg_buf)
 {
 	tLimMlmDisassocInd *pMlmDisassocInd;
 	struct pe_session *pe_session;
 
-	pMlmDisassocInd = (tLimMlmDisassocInd *) pMsgBuf;
+	pMlmDisassocInd = (tLimMlmDisassocInd *)msg_buf;
 	pe_session = pe_find_session_by_session_id(mac,
 				pMlmDisassocInd->sessionId);
 	if (!pe_session) {
@@ -1000,22 +978,22 @@ static void lim_process_mlm_deauth_ind(struct mac_context *mac_ctx,
  ***NOTE:
  *
  * @param mac       Pointer to Global MAC structure
- * @param pMsgBuf    A pointer to the MLM message buffer
+ * @param msg_buf    A pointer to the MLM message buffer
  *
  * @return None
  */
-void lim_process_mlm_deauth_cnf(struct mac_context *mac, uint32_t *pMsgBuf)
+void lim_process_mlm_deauth_cnf(struct mac_context *mac, uint32_t *msg_buf)
 {
 	uint16_t aid;
 	tSirResultCodes resultCode;
 	tLimMlmDeauthCnf *pMlmDeauthCnf;
 	struct pe_session *pe_session;
 
-	if (!pMsgBuf) {
+	if (!msg_buf) {
 		pe_err("Buffer is Pointing to NULL");
 		return;
 	}
-	pMlmDeauthCnf = (tLimMlmDeauthCnf *) pMsgBuf;
+	pMlmDeauthCnf = (tLimMlmDeauthCnf *)msg_buf;
 	pe_session = pe_find_session_by_session_id(mac,
 				pMlmDeauthCnf->sessionId);
 	if (!pe_session) {
@@ -1077,21 +1055,21 @@ void lim_process_mlm_deauth_cnf(struct mac_context *mac, uint32_t *pMsgBuf)
  ***NOTE:
  *
  * @param mac       Pointer to Global MAC structure
- * @param pMsgBuf    A pointer to the MLM message buffer
+ * @param msg_buf    A pointer to the MLM message buffer
  *
  * @return None
  */
-void lim_process_mlm_purge_sta_ind(struct mac_context *mac, uint32_t *pMsgBuf)
+void lim_process_mlm_purge_sta_ind(struct mac_context *mac, uint32_t *msg_buf)
 {
 	tSirResultCodes resultCode;
 	tpLimMlmPurgeStaInd pMlmPurgeStaInd;
 	struct pe_session *pe_session;
 
-	if (!pMsgBuf) {
+	if (!msg_buf) {
 		pe_err("Buffer is Pointing to NULL");
 		return;
 	}
-	pMlmPurgeStaInd = (tpLimMlmPurgeStaInd) pMsgBuf;
+	pMlmPurgeStaInd = (tpLimMlmPurgeStaInd)msg_buf;
 	pe_session = pe_find_session_by_session_id(mac,
 				pMlmPurgeStaInd->sessionId);
 	if (!pe_session) {
@@ -1161,11 +1139,11 @@ void lim_process_mlm_purge_sta_ind(struct mac_context *mac, uint32_t *pMsgBuf)
  ***NOTE:
  *
  * @param mac       Pointer to Global MAC structure
- * @param pMsgBuf    A pointer to the MLM message buffer
+ * @param msg_buf    A pointer to the MLM message buffer
  *
  * @return None
  */
-void lim_process_mlm_set_keys_cnf(struct mac_context *mac, uint32_t *pMsgBuf)
+void lim_process_mlm_set_keys_cnf(struct mac_context *mac, uint32_t *msg_buf)
 {
 	/* Prepare and send SME_SETCONTEXT_RSP message */
 	tLimMlmSetKeysCnf *pMlmSetKeysCnf;
@@ -1173,11 +1151,11 @@ void lim_process_mlm_set_keys_cnf(struct mac_context *mac, uint32_t *pMsgBuf)
 	uint16_t aid;
 	tpDphHashNode sta_ds;
 
-	if (!pMsgBuf) {
+	if (!msg_buf) {
 		pe_err("Buffer is Pointing to NULL");
 		return;
 	}
-	pMlmSetKeysCnf = (tLimMlmSetKeysCnf *) pMsgBuf;
+	pMlmSetKeysCnf = (tLimMlmSetKeysCnf *)msg_buf;
 	pe_session = pe_find_session_by_session_id(mac,
 					   pMlmSetKeysCnf->sessionId);
 	if (!pe_session) {

core/mac/src/pe/lim/lim_process_sme_req_messages.c

@@ -352,7 +352,7 @@ __lim_is_defered_msg_for_radar(struct mac_context *mac_ctx,
 /**
  * __lim_process_sme_sys_ready_ind () - Process ready indication from WMA
  * @mac: Global MAC context
- * @pMsgBuf: Message from WMA
+ * @msg_buf: Message from WMA
  *
  * handles the notification from HDD. PE just forwards this message to HAL.
  *
@@ -361,14 +361,14 @@ __lim_is_defered_msg_for_radar(struct mac_context *mac_ctx,
  */
 
 static bool __lim_process_sme_sys_ready_ind(struct mac_context *mac,
-					    uint32_t *pMsgBuf)
+					    uint32_t *msg_buf)
 {
 	struct scheduler_msg msg = {0};
-	struct sme_ready_req *ready_req = (struct sme_ready_req *) pMsgBuf;
+	struct sme_ready_req *ready_req = (struct sme_ready_req *)msg_buf;
 
 	msg.type = WMA_SYS_READY_IND;
 	msg.reserved = 0;
-	msg.bodyptr = pMsgBuf;
+	msg.bodyptr = msg_buf;
 	msg.bodyval = 0;
 
 	if (ANI_DRIVER_TYPE(mac) != QDF_DRIVER_TYPE_MFG) {
@@ -2028,12 +2028,12 @@ bool send_disassoc_frame = 1;
  ***NOTE:
  *
  * @param  mac      Pointer to Global MAC structure
- * @param  *pMsgBuf  A pointer to the SME message buffer
+ * @param  *msg_buf  A pointer to the SME message buffer
  * @return None
  */
 
 static void __lim_process_sme_disassoc_req(struct mac_context *mac,
-					   uint32_t *pMsgBuf)
+					   uint32_t *msg_buf)
 {
 	uint16_t disassocTrigger, reasonCode;
 	tLimMlmDisassocReq *pMlmDisassocReq;
@@ -2043,12 +2043,12 @@ static void __lim_process_sme_disassoc_req(struct mac_context *mac,
 	uint8_t sessionId;
 	uint8_t smesessionId;
 
-	if (!pMsgBuf) {
+	if (!msg_buf) {
 		pe_err("Buffer is Pointing to NULL");
 		return;
 	}
 
-	qdf_mem_copy(&smeDisassocReq, pMsgBuf, sizeof(struct disassoc_req));
+	qdf_mem_copy(&smeDisassocReq, msg_buf, sizeof(struct disassoc_req));
 	smesessionId = smeDisassocReq.sessionId;
 	if (!lim_is_sme_disassoc_req_valid(mac,
 					   &smeDisassocReq,
@@ -2241,7 +2241,7 @@ sendDisassoc:
    \return none
    \sa
    ----------------------------------------------------------------- */
-void __lim_process_sme_disassoc_cnf(struct mac_context *mac, uint32_t *pMsgBuf)
+void __lim_process_sme_disassoc_cnf(struct mac_context *mac, uint32_t *msg_buf)
 {
 	struct disassoc_cnf smeDisassocCnf;
 	uint16_t aid;
@@ -2251,7 +2251,7 @@ void __lim_process_sme_disassoc_cnf(struct mac_context *mac, uint32_t *pMsgBuf)
 	uint32_t *msg = NULL;
 	QDF_STATUS status;
 
-	qdf_mem_copy(&smeDisassocCnf, pMsgBuf, sizeof(smeDisassocCnf));
+	qdf_mem_copy(&smeDisassocCnf, msg_buf, sizeof(smeDisassocCnf));
 
 	pe_session = pe_find_session_by_bssid(mac,
 				smeDisassocCnf.bssid.bytes,
@@ -2862,7 +2862,7 @@ static void lim_delete_peers_and_send_vdev_stop(struct pe_session *session)
 }
 
 static void
-__lim_handle_sme_stop_bss_request(struct mac_context *mac, uint32_t *pMsgBuf)
+__lim_handle_sme_stop_bss_request(struct mac_context *mac, uint32_t *msg_buf)
 {
 	struct stop_bss_req stop_bss_req;
 	tLimSmeStates prevState;
@@ -2870,10 +2870,10 @@ __lim_handle_sme_stop_bss_request(struct mac_context *mac, uint32_t *pMsgBuf)
 	uint8_t smesessionId;
 	uint8_t sessionId;
 
-	qdf_mem_copy(&stop_bss_req, pMsgBuf, sizeof(stop_bss_req));
+	qdf_mem_copy(&stop_bss_req, msg_buf, sizeof(stop_bss_req));
 	smesessionId = stop_bss_req.sessionId;
 
-	if (!lim_is_sme_stop_bss_req_valid(pMsgBuf)) {
+	if (!lim_is_sme_stop_bss_req_valid(msg_buf)) {
 		pe_warn("received invalid SME_STOP_BSS_REQ message");
 		/* Send Stop BSS response to host */
 		lim_send_sme_rsp(mac, eWNI_SME_STOP_BSS_RSP,
@@ -3148,7 +3148,8 @@ end:
 	qdf_mem_free(assoc_cnf.owe_ie);
 }
 
-static void __lim_process_sme_addts_req(struct mac_context *mac, uint32_t *pMsgBuf)
+static void
+__lim_process_sme_addts_req(struct mac_context *mac, uint32_t *msg_buf)
 {
 	tpDphHashNode sta;
 	tSirMacAddr peerMac;
@@ -3158,12 +3159,12 @@ static void __lim_process_sme_addts_req(struct mac_context *mac, uint32_t *pMsgB
 	uint8_t sessionId;      /* PE sessionId */
 	uint8_t smesessionId;
 
-	if (!pMsgBuf) {
+	if (!msg_buf) {
 		pe_err("Buffer is Pointing to NULL");
 		return;
 	}
 
-	pSirAddts = (tpSirAddtsReq) pMsgBuf;
+	pSirAddts = (tpSirAddtsReq) msg_buf;
 	smesessionId = pSirAddts->sessionId;
 	pe_session = pe_find_session_by_bssid(mac, pSirAddts->bssid.bytes,
 						 &sessionId);
@@ -3292,12 +3293,13 @@ send_failure_addts_rsp:
 			       smesessionId);
 }
 
-static void __lim_process_sme_delts_req(struct mac_context *mac, uint32_t *pMsgBuf)
+static void
+__lim_process_sme_delts_req(struct mac_context *mac, uint32_t *msg_buf)
 {
 	tSirMacAddr peerMacAddr;
 	uint8_t ac;
 	struct mac_ts_info *pTsinfo;
-	tpSirDeltsReq pDeltsReq = (tpSirDeltsReq) pMsgBuf;
+	tpSirDeltsReq pDeltsReq = (tpSirDeltsReq) msg_buf;
 	tpDphHashNode sta = NULL;
 	struct pe_session *pe_session;
 	uint8_t sessionId;
@@ -3436,35 +3438,31 @@ void lim_process_sme_addts_rsp_timeout(struct mac_context *mac, uint32_t param)
 
 #ifndef QCA_SUPPORT_CP_STATS
 /**
- * __lim_process_sme_get_statistics_request()
+ * __lim_process_sme_get_statistics_request() - Post WMA_GET_STATISTICS_REQ to
+ * wma
+ * @mac      Pointer to Global MAC structure
+ * @msg_buf  A pointer to the SME message buffer
  *
- ***FUNCTION:
- *
- *
- ***NOTE:
- *
- * @param  mac      Pointer to Global MAC structure
- * @param  *pMsgBuf  A pointer to the SME message buffer
- * @return None
+ * @Return None
  */
-static void
-__lim_process_sme_get_statistics_request(struct mac_context *mac, uint32_t *pMsgBuf)
+static void __lim_process_sme_get_statistics_request(struct mac_context *mac,
+						     uint32_t *msg_buf)
 {
 	tpAniGetPEStatsReq pPEStatsReq;
 	struct scheduler_msg msgQ = {0};
 
-	pPEStatsReq = (tpAniGetPEStatsReq) pMsgBuf;
+	pPEStatsReq = (tpAniGetPEStatsReq)msg_buf;
 
 	msgQ.type = WMA_GET_STATISTICS_REQ;
 
 	msgQ.reserved = 0;
-	msgQ.bodyptr = pMsgBuf;
+	msgQ.bodyptr = msg_buf;
 	msgQ.bodyval = 0;
 	MTRACE(mac_trace_msg_tx(mac, NO_SESSION, msgQ.type));
 
 	if (QDF_STATUS_SUCCESS != (wma_post_ctrl_msg(mac, &msgQ))) {
-		qdf_mem_free(pMsgBuf);
-		pMsgBuf = NULL;
+		qdf_mem_free(msg_buf);
+		msg_buf = NULL;
 		pe_err("Unable to forward request");
 		return;
 	}
@@ -3473,7 +3471,7 @@ __lim_process_sme_get_statistics_request(struct mac_context *mac, uint32_t *pMsg
 }
 #else
 static void __lim_process_sme_get_statistics_request(
-			struct mac_context *mac_ctx, uint32_t *pMsgBuf) {}
+			struct mac_context *mac_ctx, uint32_t *msg_buf) {}
 #endif
 
 #ifdef FEATURE_WLAN_ESE
@@ -3481,24 +3479,24 @@ static void __lim_process_sme_get_statistics_request(
  * __lim_process_sme_get_tsm_stats_request() - get tsm stats request
  *
  * @mac: Pointer to Global MAC structure
- * @pMsgBuf: A pointer to the SME message buffer
+ * @msg_buf: A pointer to the SME message buffer
  *
  * Return: None
  */
-static void
-__lim_process_sme_get_tsm_stats_request(struct mac_context *mac, uint32_t *pMsgBuf)
+static void __lim_process_sme_get_tsm_stats_request(struct mac_context *mac,
+						    uint32_t *msg_buf)
 {
 	struct scheduler_msg msgQ = {0};
 
 	msgQ.type = WMA_TSM_STATS_REQ;
 	msgQ.reserved = 0;
-	msgQ.bodyptr = pMsgBuf;
+	msgQ.bodyptr = msg_buf;
 	msgQ.bodyval = 0;
 	MTRACE(mac_trace_msg_tx(mac, NO_SESSION, msgQ.type));
 
 	if (QDF_STATUS_SUCCESS != (wma_post_ctrl_msg(mac, &msgQ))) {
-		qdf_mem_free(pMsgBuf);
-		pMsgBuf = NULL;
+		qdf_mem_free(msg_buf);
+		msg_buf = NULL;
 		pe_err("Unable to forward request");
 		return;
 	}
@@ -3810,7 +3808,7 @@ static void __lim_process_sme_session_update(struct mac_context *mac_ctx,
    Update the beacon Interval dynamically if beaconInterval is different in MCC
  */
 static void __lim_process_sme_change_bi(struct mac_context *mac,
-					uint32_t *pMsgBuf)
+					uint32_t *msg_buf)
 {
 	struct change_bi_params *pChangeBIParams;
 	struct pe_session *pe_session;
@@ -3819,13 +3817,13 @@ static void __lim_process_sme_change_bi(struct mac_context *mac,
 
 	pe_debug("received Update Beacon Interval message");
 
-	if (!pMsgBuf) {
+	if (!msg_buf) {
 		pe_err("Buffer is Pointing to NULL");
 		return;
 	}
 
 	qdf_mem_zero(&beaconParams, sizeof(tUpdateBeaconParams));
-	pChangeBIParams = (struct change_bi_params *)pMsgBuf;
+	pChangeBIParams = (struct change_bi_params *)msg_buf;
 
 	pe_session = pe_find_session_by_bssid(mac,
 				pChangeBIParams->bssid.bytes,
@@ -3870,7 +3868,7 @@ static void __lim_process_sme_change_bi(struct mac_context *mac,
 
 #ifdef QCA_HT_2040_COEX
 static void __lim_process_sme_set_ht2040_mode(struct mac_context *mac,
-					      uint32_t *pMsgBuf)
+					      uint32_t *msg_buf)
 {
 	struct set_ht2040_mode *pSetHT2040Mode;
 	struct pe_session *pe_session;
@@ -3881,12 +3879,12 @@ static void __lim_process_sme_set_ht2040_mode(struct mac_context *mac,
 	tpDphHashNode sta = NULL;
 
 	pe_debug("received Set HT 20/40 mode message");
-	if (!pMsgBuf) {
+	if (!msg_buf) {
 		pe_err("Buffer is Pointing to NULL");
 		return;
 	}
 
-	pSetHT2040Mode = (struct set_ht2040_mode *) pMsgBuf;
+	pSetHT2040Mode = (struct set_ht2040_mode *)msg_buf;
 
 	pe_session = pe_find_session_by_bssid(mac,
 				pSetHT2040Mode->bssid.bytes,
@@ -4149,19 +4147,19 @@ skip_match:
 	return;
 }
 
-static void
-__lim_process_sme_reset_ap_caps_change(struct mac_context *mac, uint32_t *pMsgBuf)
+static void __lim_process_sme_reset_ap_caps_change(struct mac_context *mac,
+						   uint32_t *msg_buf)
 {
 	tpSirResetAPCapsChange pResetCapsChange;
 	struct pe_session *pe_session;
 	uint8_t sessionId = 0;
 
-	if (!pMsgBuf) {
+	if (!msg_buf) {
 		pe_err("Buffer is Pointing to NULL");
 		return;
 	}
 
-	pResetCapsChange = (tpSirResetAPCapsChange) pMsgBuf;
+	pResetCapsChange = (tpSirResetAPCapsChange)msg_buf;
 	pe_session =
 		pe_find_session_by_bssid(mac, pResetCapsChange->bssId.bytes,
 					 &sessionId);
@@ -4660,16 +4658,20 @@ static void lim_process_sme_deauth_req(struct mac_context *mac_ctx,
  *
  * @param  mac      Pointer to Global MAC structure
  * @param  msgType   Indicates the SME message type
- * @param  *pMsgBuf  A pointer to the SME message buffer
- * @return Boolean - true - if pMsgBuf is consumed and can be freed.
- *                   false - if pMsgBuf is not to be freed.
+ * @param  *msg_buf  A pointer to the SME message buffer
+ * @return Boolean - true - if msg_buf is consumed and can be freed.
+ *                   false - if msg_buf is not to be freed.
  */
 
 bool lim_process_sme_req_messages(struct mac_context *mac,
 				  struct scheduler_msg *pMsg)
 {
-	bool bufConsumed = true;        /* Set this flag to false within case block of any following message, that doesn't want pMsgBuf to be freed. */
-	uint32_t *pMsgBuf = pMsg->bodyptr;
+	/*
+	 * Set this flag to false within case block of any following message,
+	 * that doesn't want msg_buf to be freed.
+	 */
+	bool bufConsumed = true;
+	uint32_t *msg_buf = pMsg->bodyptr;
 
 	pe_debug("LIM Received SME Message %s(%d) Global LimSmeState:%s(%d) Global LimMlmState: %s(%d)",
 		       lim_msg_str(pMsg->type), pMsg->type,
@@ -4680,7 +4682,7 @@ bool lim_process_sme_req_messages(struct mac_context *mac,
 
 	switch (pMsg->type) {
 	case eWNI_SME_SYS_READY_IND:
-		bufConsumed = __lim_process_sme_sys_ready_ind(mac, pMsgBuf);
+		bufConsumed = __lim_process_sme_sys_ready_ind(mac, msg_buf);
 		break;
 
 	case eWNI_SME_START_BSS_REQ:
@@ -4688,11 +4690,11 @@ bool lim_process_sme_req_messages(struct mac_context *mac,
 		break;
 
 	case eWNI_SME_JOIN_REQ:
-		__lim_process_sme_join_req(mac, pMsgBuf);
+		__lim_process_sme_join_req(mac, msg_buf);
 		break;
 
 	case eWNI_SME_REASSOC_REQ:
-		__lim_process_sme_reassoc_req(mac, pMsgBuf);
+		__lim_process_sme_reassoc_req(mac, msg_buf);
 		break;
 
 	case eWNI_SME_DISASSOC_REQ:
@@ -4709,11 +4711,11 @@ bool lim_process_sme_req_messages(struct mac_context *mac,
 		break;
 
 	case eWNI_SME_SEND_DISASSOC_FRAME:
-		__lim_process_send_disassoc_frame(mac, pMsgBuf);
+		__lim_process_send_disassoc_frame(mac, msg_buf);
 		break;
 
 	case eWNI_SME_SETCONTEXT_REQ:
-		__lim_process_sme_set_context_req(mac, pMsgBuf);
+		__lim_process_sme_set_context_req(mac, msg_buf);
 		break;
 
 	case eWNI_SME_STOP_BSS_REQ:
@@ -4724,17 +4726,17 @@ bool lim_process_sme_req_messages(struct mac_context *mac,
 		if (pMsg->type == eWNI_SME_ASSOC_CNF)
 			pe_debug("Received ASSOC_CNF message");
 			__lim_process_sme_assoc_cnf_new(mac, pMsg->type,
-							pMsgBuf);
+							msg_buf);
 		break;
 
 	case eWNI_SME_ADDTS_REQ:
 		pe_debug("Received ADDTS_REQ message");
-		__lim_process_sme_addts_req(mac, pMsgBuf);
+		__lim_process_sme_addts_req(mac, msg_buf);
 		break;
 
 	case eWNI_SME_DELTS_REQ:
 		pe_debug("Received DELTS_REQ message");
-		__lim_process_sme_delts_req(mac, pMsgBuf);
+		__lim_process_sme_delts_req(mac, msg_buf);
 		break;
 
 	case SIR_LIM_ADDTS_RSP_TIMEOUT:
@@ -4743,35 +4745,38 @@ bool lim_process_sme_req_messages(struct mac_context *mac,
 		break;
 
 	case eWNI_SME_GET_STATISTICS_REQ:
-		__lim_process_sme_get_statistics_request(mac, pMsgBuf);
-		/* HAL consumes pMsgBuf. It will be freed there. Set bufConsumed to false. */
+		__lim_process_sme_get_statistics_request(mac, msg_buf);
+		/*
+		 * HAL consumes msg_buf. It will be freed there.
+		 * Set bufConsumed to false.
+		 */
 		bufConsumed = false;
 		break;
 #ifdef FEATURE_WLAN_ESE
 	case eWNI_SME_GET_TSM_STATS_REQ:
-		__lim_process_sme_get_tsm_stats_request(mac, pMsgBuf);
+		__lim_process_sme_get_tsm_stats_request(mac, msg_buf);
 		bufConsumed = false;
 		break;
 #endif /* FEATURE_WLAN_ESE */
 	case eWNI_SME_SESSION_UPDATE_PARAM:
-		__lim_process_sme_session_update(mac, pMsgBuf);
+		__lim_process_sme_session_update(mac, msg_buf);
 		break;
 	case eWNI_SME_ROAM_SCAN_OFFLOAD_REQ:
-		__lim_process_roam_scan_offload_req(mac, pMsgBuf);
+		__lim_process_roam_scan_offload_req(mac, msg_buf);
 		bufConsumed = false;
 		break;
 	case eWNI_SME_ROAM_INVOKE:
-		lim_process_roam_invoke(mac, pMsgBuf);
+		lim_process_roam_invoke(mac, msg_buf);
 		bufConsumed = false;
 		break;
 	case eWNI_SME_CHNG_MCC_BEACON_INTERVAL:
 		/* Update the beaconInterval */
-		__lim_process_sme_change_bi(mac, pMsgBuf);
+		__lim_process_sme_change_bi(mac, msg_buf);
 		break;
 
 #ifdef QCA_HT_2040_COEX
 	case eWNI_SME_SET_HT_2040_MODE:
-		__lim_process_sme_set_ht2040_mode(mac, pMsgBuf);
+		__lim_process_sme_set_ht2040_mode(mac, msg_buf);
 		break;
 #endif
 
@@ -4784,87 +4789,87 @@ bool lim_process_sme_req_messages(struct mac_context *mac,
 		bufConsumed = (bool) lim_process_ft_pre_auth_req(mac, pMsg);
 		break;
 	case eWNI_SME_FT_UPDATE_KEY:
-		lim_process_ft_update_key(mac, pMsgBuf);
+		lim_process_ft_update_key(mac, msg_buf);
 		break;
 
 	case eWNI_SME_FT_AGGR_QOS_REQ:
-		lim_process_ft_aggr_qos_req(mac, pMsgBuf);
+		lim_process_ft_aggr_qos_req(mac, msg_buf);
 		break;
 
 	case eWNI_SME_REGISTER_MGMT_FRAME_REQ:
-		__lim_process_sme_register_mgmt_frame_req(mac, pMsgBuf);
+		__lim_process_sme_register_mgmt_frame_req(mac, msg_buf);
 		break;
 #ifdef FEATURE_WLAN_TDLS
 	case eWNI_SME_TDLS_SEND_MGMT_REQ:
-		lim_process_sme_tdls_mgmt_send_req(mac, pMsgBuf);
+		lim_process_sme_tdls_mgmt_send_req(mac, msg_buf);
 		break;
 	case eWNI_SME_TDLS_ADD_STA_REQ:
-		lim_process_sme_tdls_add_sta_req(mac, pMsgBuf);
+		lim_process_sme_tdls_add_sta_req(mac, msg_buf);
 		break;
 	case eWNI_SME_TDLS_DEL_STA_REQ:
-		lim_process_sme_tdls_del_sta_req(mac, pMsgBuf);
+		lim_process_sme_tdls_del_sta_req(mac, msg_buf);
 		break;
 #endif
 	case eWNI_SME_RESET_AP_CAPS_CHANGED:
-		__lim_process_sme_reset_ap_caps_change(mac, pMsgBuf);
+		__lim_process_sme_reset_ap_caps_change(mac, msg_buf);
 		break;
 
 	case eWNI_SME_CHANNEL_CHANGE_REQ:
-		lim_process_sme_channel_change_request(mac, pMsgBuf);
+		lim_process_sme_channel_change_request(mac, msg_buf);
 		break;
 
 	case eWNI_SME_START_BEACON_REQ:
-		lim_process_sme_start_beacon_req(mac, pMsgBuf);
+		lim_process_sme_start_beacon_req(mac, msg_buf);
 		break;
 
 	case eWNI_SME_DFS_BEACON_CHAN_SW_IE_REQ:
-		lim_process_sme_dfs_csa_ie_request(mac, pMsgBuf);
+		lim_process_sme_dfs_csa_ie_request(mac, msg_buf);
 		break;
 
 	case eWNI_SME_UPDATE_ADDITIONAL_IES:
-		lim_process_update_add_ies(mac, pMsgBuf);
+		lim_process_update_add_ies(mac, msg_buf);
 		break;
 
 	case eWNI_SME_MODIFY_ADDITIONAL_IES:
-		lim_process_modify_add_ies(mac, pMsgBuf);
+		lim_process_modify_add_ies(mac, msg_buf);
 		break;
 	case eWNI_SME_SET_HW_MODE_REQ:
-		lim_process_set_hw_mode(mac, pMsgBuf);
+		lim_process_set_hw_mode(mac, msg_buf);
 		break;
 	case eWNI_SME_NSS_UPDATE_REQ:
-		lim_process_nss_update_request(mac, pMsgBuf);
+		lim_process_nss_update_request(mac, msg_buf);
 		break;
 	case eWNI_SME_SET_DUAL_MAC_CFG_REQ:
-		lim_process_set_dual_mac_cfg_req(mac, pMsgBuf);
+		lim_process_set_dual_mac_cfg_req(mac, msg_buf);
 		break;
 	case eWNI_SME_SET_IE_REQ:
-		lim_process_set_ie_req(mac, pMsgBuf);
+		lim_process_set_ie_req(mac, msg_buf);
 		break;
 	case eWNI_SME_REGISTER_MGMT_FRAME_CB:
-		lim_register_mgmt_frame_ind_cb(mac, pMsgBuf);
+		lim_register_mgmt_frame_ind_cb(mac, msg_buf);
 		break;
 	case eWNI_SME_EXT_CHANGE_CHANNEL:
-		lim_process_ext_change_channel(mac, pMsgBuf);
+		lim_process_ext_change_channel(mac, msg_buf);
 		break;
 	case eWNI_SME_SET_ANTENNA_MODE_REQ:
-		lim_process_set_antenna_mode_req(mac, pMsgBuf);
+		lim_process_set_antenna_mode_req(mac, msg_buf);
 		break;
 	case eWNI_SME_PDEV_SET_HT_VHT_IE:
-		lim_process_set_pdev_IEs(mac, pMsgBuf);
+		lim_process_set_pdev_IEs(mac, msg_buf);
 		break;
 	case eWNI_SME_SET_VDEV_IES_PER_BAND:
-		lim_process_set_vdev_ies_per_band(mac, pMsgBuf);
+		lim_process_set_vdev_ies_per_band(mac, msg_buf);
 		break;
 	case eWNI_SME_UPDATE_ACCESS_POLICY_VENDOR_IE:
-		lim_process_sme_update_access_policy_vendor_ie(mac, pMsgBuf);
+		lim_process_sme_update_access_policy_vendor_ie(mac, msg_buf);
 		break;
 	case eWNI_SME_UPDATE_CONFIG:
 		lim_process_sme_update_config(mac,
-					(struct update_config *)pMsgBuf);
+					(struct update_config *)msg_buf);
 		break;
 	case eWNI_SME_SET_ADDBA_ACCEPT:
 		lim_process_sme_set_addba_accept(mac,
-					(struct sme_addba_accept *)pMsgBuf);
+					(struct sme_addba_accept *)msg_buf);
 		break;
 	case eWNI_SME_UPDATE_EDCA_PROFILE:
 		lim_process_sme_update_edca_params(mac, pMsg->bodyval);
@@ -4874,7 +4879,7 @@ bool lim_process_sme_req_messages(struct mac_context *mac,
 		break;
 	case WNI_SME_CFG_ACTION_FRM_HE_TB_PPDU:
 		lim_process_sme_cfg_action_frm_in_tb_ppdu(mac,
-				(struct  sir_cfg_action_frm_tb_ppdu *)pMsgBuf);
+				(struct  sir_cfg_action_frm_tb_ppdu *)msg_buf);
 		break;
 	case WNI_SME_REGISTER_BCN_REPORT_SEND_CB:
 		lim_register_bcn_report_send_cb(mac, pMsg);
@@ -4904,9 +4909,9 @@ bool lim_process_sme_req_messages(struct mac_context *mac,
  *
  * @param  mac      Pointer to Global MAC structure
  * @param  msgType   Indicates the SME message type
- * @param  *pMsgBuf  A pointer to the SME message buffer
- * @return Boolean - true - if pMsgBuf is consumed and can be freed.
- *                   false - if pMsgBuf is not to be freed.
+ * @param  *msg_buf  A pointer to the SME message buffer
+ * @return Boolean - true - if msg_buf is consumed and can be freed.
+ *                   false - if msg_buf is not to be freed.
  */
 static void lim_process_sme_start_beacon_req(struct mac_context *mac, uint32_t *pMsg)
 {

core/mac/src/pe/lim/lim_types.h

@@ -766,29 +766,30 @@ QDF_STATUS lim_send_sa_query_response_frame(struct mac_context *mac,
  *
  * @param mac      Pointer to Global MAC structure
  * @param msgType   Indicates the MLM primitive message type
- * @param *pMsgBuf  A pointer to the MLM message buffer
+ * @param *msg_buf  A pointer to the MLM message buffer
  *
  * @return None
  */
 static inline void
-lim_post_sme_message(struct mac_context *mac, uint32_t msgType, uint32_t *pMsgBuf)
+lim_post_sme_message(struct mac_context *mac, uint32_t msgType,
+		     uint32_t *msg_buf)
 {
 	struct scheduler_msg msg = {0};
 
-	if (!pMsgBuf) {
+	if (!msg_buf) {
 		pe_err("Buffer is Pointing to NULL");
 		return;
 	}
 
 	msg.type = (uint16_t) msgType;
-	msg.bodyptr = pMsgBuf;
+	msg.bodyptr = msg_buf;
 	msg.bodyval = 0;
 	if (msgType > eWNI_SME_MSG_TYPES_BEGIN) {
 		MTRACE(mac_trace(mac, TRACE_CODE_TX_SME_MSG, NO_SESSION,
 				 msg.type));
 		lim_process_sme_req_messages(mac, &msg);
 	} else {
-		lim_process_mlm_rsp_messages(mac, msgType, pMsgBuf);
+		lim_process_mlm_rsp_messages(mac, msgType, msg_buf);
 	}
 } /*** end lim_post_sme_message() ***/
 
@@ -813,21 +814,22 @@ lim_post_sme_message(struct mac_context *mac, uint32_t msgType, uint32_t *pMsgBu
  *
  * @param mac      Pointer to Global MAC structure
  * @param msgType   Indicates the MLM primitive message type
- * @param *pMsgBuf  A pointer to the MLM message buffer
+ * @param *msg_buf  A pointer to the MLM message buffer
  *
  * @return None
  */
 static inline void
-lim_post_mlm_message(struct mac_context *mac, uint32_t msgType, uint32_t *pMsgBuf)
+lim_post_mlm_message(struct mac_context *mac, uint32_t msgType,
+		     uint32_t *msg_buf)
 {
 	struct scheduler_msg msg = {0};
 
-	if (!pMsgBuf) {
+	if (!msg_buf) {
 		pe_err("Buffer is Pointing to NULL");
 		return;
 	}
 	msg.type = (uint16_t) msgType;
-	msg.bodyptr = pMsgBuf;
+	msg.bodyptr = msg_buf;
 	msg.bodyval = 0;
 	MTRACE(mac_trace_msg_rx(mac, NO_SESSION, msg.type));
 	lim_process_mlm_req_messages(mac, &msg);

core/sme/inc/csr_internal.h

@@ -954,7 +954,7 @@ QDF_STATUS csr_get_config_param(struct mac_context *mac,
 					  struct csr_config_params *pParam);
 QDF_STATUS csr_change_default_config_param(struct mac_context *mac,
 		struct csr_config_params *pParam);
-QDF_STATUS csr_msg_processor(struct mac_context *mac, void *pMsgBuf);
+QDF_STATUS csr_msg_processor(struct mac_context *mac, void *msg_buf);
 QDF_STATUS csr_open(struct mac_context *mac);
 QDF_STATUS csr_init_chan_list(struct mac_context *mac, uint8_t *alpha2);
 QDF_STATUS csr_close(struct mac_context *mac);
@@ -1092,7 +1092,7 @@ csr_rso_save_ap_to_scan_cache(struct mac_context *mac,
 			      struct roam_offload_synch_ind *roam_synch_ind,
 			      struct bss_description *bss_desc_ptr);
 
-void csr_process_ho_fail_ind(struct mac_context *mac, void *pMsgBuf);
+void csr_process_ho_fail_ind(struct mac_context *mac, void *msg_buf);
 #endif
 #ifdef FEATURE_WLAN_DIAG_SUPPORT_CSR
 void csr_roaming_report_diag_event(struct mac_context *mac_ctx,

core/sme/inc/sme_qos_internal.h

@@ -93,7 +93,7 @@ typedef struct {
 QDF_STATUS sme_qos_open(struct mac_context *mac);
 QDF_STATUS sme_qos_close(struct mac_context *mac);
 QDF_STATUS sme_qos_msg_processor(struct mac_context *mac, uint16_t msg_type,
-		void *pMsgBuf);
+		void *msg_buf);
 
 /*--------------------------------------------------------------------------
   Internal APIs for CSR

core/sme/inc/sme_rrm_api.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2014-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2014-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -38,14 +38,14 @@
 #include "sme_rrm_internal.h"
 
 QDF_STATUS sme_rrm_msg_processor(struct mac_context *mac, uint16_t msg_type,
-		void *pMsgBuf);
+		void *msg_buf);
 QDF_STATUS rrm_close(struct mac_context *mac);
 QDF_STATUS rrm_open(struct mac_context *mac);
 QDF_STATUS sme_rrm_neighbor_report_request(struct mac_context *mac,
 		uint8_t sessionId, tpRrmNeighborReq pNeighborReq,
 		tpRrmNeighborRspCallbackInfo callbackInfo);
 QDF_STATUS sme_rrm_process_beacon_report_req_ind(struct mac_context *mac,
-		void *pMsgBuf);
+		void *msg_buf);
 
 /**
  * rrm_start() - start the RRM module

core/sme/src/common/sme_api.c

@@ -65,13 +65,13 @@ static QDF_STATUS init_sme_cmd_list(struct mac_context *mac);
 static void sme_disconnect_connected_sessions(struct mac_context *mac);
 
 static QDF_STATUS sme_handle_generic_change_country_code(struct mac_context *mac,
-						  void *pMsgBuf);
+						  void *msg_buf);
 
 static QDF_STATUS sme_process_nss_update_resp(struct mac_context *mac, uint8_t *msg);
 
 /* Channel Change Response Indication Handler */
 static QDF_STATUS sme_process_channel_change_resp(struct mac_context *mac,
-					   uint16_t msg_type, void *pMsgBuf);
+					   uint16_t msg_type, void *msg_buf);
 
 static QDF_STATUS sme_stats_ext_event(struct mac_context *mac,
 				      struct stats_ext_event *msg);
@@ -5303,13 +5303,13 @@ void sme_set_cc_src(mac_handle_t mac_handle, enum country_src cc_src)
  */
 static QDF_STATUS
 sme_handle_generic_change_country_code(struct mac_context *mac_ctx,
-				       void *pMsgBuf)
+				       void *msg_buf)
 {
 	QDF_STATUS status = QDF_STATUS_SUCCESS;
 	v_REGDOMAIN_t reg_domain_id = 0;
 	bool user_ctry_priority =
 		mac_ctx->mlme_cfg->sap_cfg.country_code_priority;
-	tAniGenericChangeCountryCodeReq *msg = pMsgBuf;
+	tAniGenericChangeCountryCodeReq *msg = msg_buf;
 
 	if (SOURCE_11D != mac_ctx->reg_hint_src) {
 		if (SOURCE_DRIVER != mac_ctx->reg_hint_src) {
@@ -8855,12 +8855,12 @@ QDF_STATUS sme_roam_channel_change_req(mac_handle_t mac_handle,
  * Return QDF_STATUS
  */
 static QDF_STATUS sme_process_channel_change_resp(struct mac_context *mac,
-					   uint16_t msg_type, void *pMsgBuf)
+					   uint16_t msg_type, void *msg_buf)
 {
 	QDF_STATUS status = QDF_STATUS_SUCCESS;
 	struct csr_roam_info *roam_info;
 	eCsrRoamResult roamResult;
-	tpSwitchChannelParams pChnlParams = (tpSwitchChannelParams) pMsgBuf;
+	tpSwitchChannelParams pChnlParams = (tpSwitchChannelParams) msg_buf;
 	uint32_t SessionId = pChnlParams->peSessionId;
 
 	roam_info = qdf_mem_malloc(sizeof(*roam_info));

core/sme/src/csr/csr_api_roam.c

@@ -9812,23 +9812,23 @@ csr_roam_send_disconnect_done_indication(struct mac_context *mac_ctx,
 /**
  * csr_roaming_state_msg_processor() - process roaming messages
  * @mac:       mac global context
- * @pMsgBuf:    message buffer
+ * @msg_buf:    message buffer
  *
- * We need to be careful on whether to cast pMsgBuf (pSmeRsp) to other type of
+ * We need to be careful on whether to cast msg_buf (pSmeRsp) to other type of
  * strucutres. It depends on how the message is constructed. If the message is
- * sent by lim_send_sme_rsp, the pMsgBuf is only a generic response and can only
+ * sent by lim_send_sme_rsp, the msg_buf is only a generic response and can only
  * be used as pointer to tSirSmeRsp. For the messages where sender allocates
  * memory for specific structures, then it can be cast accordingly.
  *
  * Return: status of operation
  */
-void csr_roaming_state_msg_processor(struct mac_context *mac, void *pMsgBuf)
+void csr_roaming_state_msg_processor(struct mac_context *mac, void *msg_buf)
 {
 	tSirSmeRsp *pSmeRsp;
 	tSmeIbssPeerInd *pIbssPeerInd;
 	struct csr_roam_info *roam_info;
 
-	pSmeRsp = (tSirSmeRsp *) pMsgBuf;
+	pSmeRsp = (tSirSmeRsp *)msg_buf;
 	sme_debug("Message %d[0x%04X] received in substate %s",
 		pSmeRsp->messageType, pSmeRsp->messageType,
 		mac_trace_getcsr_roam_sub_state(
@@ -9911,7 +9911,7 @@ void csr_roaming_state_msg_processor(struct mac_context *mac, void *pMsgBuf)
 		break;
 	case eWNI_SME_GET_RSSI_REQ:
 	{
-		tAniGetRssiReq *pGetRssiReq = (tAniGetRssiReq *) pMsgBuf;
+		tAniGetRssiReq *pGetRssiReq = (tAniGetRssiReq *)msg_buf;
 
 		if (pGetRssiReq->rssiCallback)
 			((tCsrRssiCallback) pGetRssiReq->rssiCallback)
@@ -9949,9 +9949,9 @@ void csr_roaming_state_msg_processor(struct mac_context *mac, void *pMsgBuf)
 	}
 }
 
-void csr_roam_joined_state_msg_processor(struct mac_context *mac, void *pMsgBuf)
+void csr_roam_joined_state_msg_processor(struct mac_context *mac, void *msg_buf)
 {
-	tSirSmeRsp *pSirMsg = (tSirSmeRsp *) pMsgBuf;
+	tSirSmeRsp *pSirMsg = (tSirSmeRsp *)msg_buf;
 
 	switch (pSirMsg->messageType) {
 	case eWNI_SME_GET_STATISTICS_RSP:
@@ -9968,7 +9968,7 @@ void csr_roam_joined_state_msg_processor(struct mac_context *mac, void *pMsgBuf)
 
 		sme_debug("ASSOCIATION confirmation can be given to upper layer ");
 		pUpperLayerAssocCnf =
-			(tSirSmeAssocIndToUpperLayerCnf *) pMsgBuf;
+			(tSirSmeAssocIndToUpperLayerCnf *)msg_buf;
 		status = csr_roam_get_session_id_from_bssid(mac,
 							(struct qdf_mac_addr *)
 							   pUpperLayerAssocCnf->
@@ -20946,11 +20946,11 @@ void csr_roaming_report_diag_event(struct mac_context *mac_ctx,
  *        received from the firmware. It will trigger a disconnect on
  *        the session which the firmware reported a hand off failure
  * param  mac global structure
- * param  pMsgBuf - Contains the session ID for which the handler should apply
+ * param  msg_buf - Contains the session ID for which the handler should apply
  */
-void csr_process_ho_fail_ind(struct mac_context *mac_ctx, void *pMsgBuf)
+void csr_process_ho_fail_ind(struct mac_context *mac_ctx, void *msg_buf)
 {
-	struct handoff_failure_ind *pSmeHOFailInd = pMsgBuf;
+	struct handoff_failure_ind *pSmeHOFailInd = msg_buf;
 	uint32_t sessionId;
 
 	if (!pSmeHOFailInd) {

core/sme/src/csr/csr_inside_api.h

@@ -144,8 +144,9 @@ struct scan_result_list {
 enum csr_roam_state csr_roam_state_change(struct mac_context *mac,
 					  enum csr_roam_state NewRoamState,
 					  uint8_t sessionId);
-void csr_roaming_state_msg_processor(struct mac_context *mac, void *pMsgBuf);
-void csr_roam_joined_state_msg_processor(struct mac_context *mac, void *pMsgBuf);
+void csr_roaming_state_msg_processor(struct mac_context *mac, void *msg_buf);
+void csr_roam_joined_state_msg_processor(struct mac_context *mac,
+					 void *msg_buf);
 void csr_scan_callback(struct wlan_objmgr_vdev *vdev,
 				struct scan_event *event, void *arg);
 void csr_release_command_roam(struct mac_context *mac, tSmeCmd *pCommand);

core/sme/src/qos/sme_qos.c

@@ -332,11 +332,11 @@ static QDF_STATUS sme_qos_del_ts_req(struct mac_context *mac,
 			      uint8_t sessionId,
 			      enum qca_wlan_ac_type ac, uint8_t tspec_mask);
 static QDF_STATUS sme_qos_process_add_ts_rsp(struct mac_context *mac,
-						void *pMsgBuf);
+						void *msg_buf);
 static QDF_STATUS sme_qos_process_del_ts_ind(struct mac_context *mac,
-						void *pMsgBuf);
+						void *msg_buf);
 static QDF_STATUS sme_qos_process_del_ts_rsp(struct mac_context *mac,
-						void *pMsgBuf);
+						void *msg_buf);
 static QDF_STATUS sme_qos_process_assoc_complete_ev(struct mac_context *mac,
 					uint8_t sessionId, void *pEvent_info);
 static QDF_STATUS sme_qos_process_reassoc_req_ev(struct mac_context *mac,
@@ -361,7 +361,7 @@ static QDF_STATUS sme_qos_process_set_key_success_ind(struct mac_context *mac,
 					       uint8_t sessionId,
 						void *pEvent_info);
 static QDF_STATUS sme_qos_process_aggr_qos_rsp(struct mac_context *mac,
-						void *pMsgBuf);
+						void *msg_buf);
 static QDF_STATUS sme_qos_ft_aggr_qos_req(struct mac_context *mac, uint8_t
 					sessionId);
 static QDF_STATUS sme_qos_process_add_ts_success_rsp(struct mac_context *mac,
@@ -4045,15 +4045,16 @@ static QDF_STATUS sme_qos_del_ts_req(struct mac_context *mac,
 
 /*
  * sme_qos_process_add_ts_rsp() - Function to process the
- *  eWNI_SME_ADDTS_RSP came from PE
+ * eWNI_SME_ADDTS_RSP came from PE
  *
- * mac - Pointer to the global MAC parameter structure.
- * pMsgBuf - Pointer to the msg buffer came from PE.
+ * @mac - Pointer to the global MAC parameter structure.
+ * @msg_buf - Pointer to the msg buffer came from PE.
  * Return QDF_STATUS
  */
-static QDF_STATUS sme_qos_process_add_ts_rsp(struct mac_context *mac, void *pMsgBuf)
+static QDF_STATUS sme_qos_process_add_ts_rsp(struct mac_context *mac,
+					     void *msg_buf)
 {
-	tpSirAddtsRsp paddts_rsp = (tpSirAddtsRsp) pMsgBuf;
+	tpSirAddtsRsp paddts_rsp = (tpSirAddtsRsp) msg_buf;
 	struct sme_qos_sessioninfo *pSession;
 	uint8_t sessionId = paddts_rsp->sessionId;
 	QDF_STATUS status = QDF_STATUS_E_FAILURE;
@@ -4115,13 +4116,14 @@ static QDF_STATUS sme_qos_process_add_ts_rsp(struct mac_context *mac, void *pMsg
  *  eWNI_SME_DELTS_RSP came from PE
  *
  * mac - Pointer to the global MAC parameter structure.
- * pMsgBuf - Pointer to the msg buffer came from PE.
+ * msg_buf - Pointer to the msg buffer came from PE.
  *
  * Return QDF_STATUS
  */
-static QDF_STATUS sme_qos_process_del_ts_rsp(struct mac_context *mac, void *pMsgBuf)
+static
+QDF_STATUS sme_qos_process_del_ts_rsp(struct mac_context *mac, void *msg_buf)
 {
-	tpSirDeltsRsp pDeltsRsp = (tpSirDeltsRsp) pMsgBuf;
+	tpSirDeltsRsp pDeltsRsp = (tpSirDeltsRsp) msg_buf;
 	struct sme_qos_sessioninfo *pSession;
 	uint8_t sessionId = pDeltsRsp->sessionId;
 
@@ -4142,14 +4144,14 @@ static QDF_STATUS sme_qos_process_del_ts_rsp(struct mac_context *mac, void *pMsg
  * this AC about QoS release
  *
  * mac - Pointer to the global MAC parameter structure.
- * pMsgBuf - Pointer to the msg buffer came from PE.
+ * msg_buf - Pointer to the msg buffer came from PE.
  *
  * Return QDF_STATUS
  */
 static QDF_STATUS sme_qos_process_del_ts_ind(struct mac_context *mac,
-					     void *pMsgBuf)
+					     void *msg_buf)
 {
-	tpSirDeltsRsp pdeltsind = (tpSirDeltsRsp) pMsgBuf;
+	tpSirDeltsRsp pdeltsind = (tpSirDeltsRsp)msg_buf;
 	struct sme_qos_sessioninfo *pSession;
 	struct sme_qos_acinfo *pACInfo;
 	uint8_t sessionId = pdeltsind->sessionId;

core/sme/src/rrm/sme_rrm.c

@@ -987,7 +987,7 @@ static QDF_STATUS sme_rrm_fill_scan_channels(uint8_t *country,
 /**
  * sme_rrm_process_beacon_report_req_ind() -Process beacon report request
  * @mac:- Global Mac structure
- * @pMsgBuf:- a pointer to a buffer that maps to various structures base
+ * @msg_buf:- a pointer to a buffer that maps to various structures base
  *                  on the message type.The beginning of the buffer can always
  *                  map to tSirSmeRsp.
  *
@@ -997,9 +997,9 @@ static QDF_STATUS sme_rrm_fill_scan_channels(uint8_t *country,
  * Return : QDF_STATUS_SUCCESS - Validation is successful.
  */
 QDF_STATUS sme_rrm_process_beacon_report_req_ind(struct mac_context *mac,
-						void *pMsgBuf)
+						void *msg_buf)
 {
-	tpSirBeaconReportReqInd pBeaconReq = (tpSirBeaconReportReqInd) pMsgBuf;
+	tpSirBeaconReportReqInd pBeaconReq = (tpSirBeaconReportReqInd)msg_buf;
 	tpRrmSMEContext pSmeRrmContext = &mac->rrm.rrmSmeContext;
 	uint32_t len = 0, i = 0;
 	uint8_t country[WNI_CFG_COUNTRY_CODE_LEN];
@@ -1389,7 +1389,7 @@ static void rrm_store_neighbor_rpt_by_roam_score(struct mac_context *mac,
  * sme_rrm_process_neighbor_report() -Process the Neighbor report received
  *                                                     from PE
  * @mac - Global MAC structure
- * @pMsgBuf - a pointer to a buffer that maps to various structures base
+ * @msg_buf - a pointer to a buffer that maps to various structures base
  *                  on the message type.
  *                  The beginning of the buffer can always map to tSirSmeRsp.
  * This is called to process the Neighbor report received from PE.
@@ -1468,7 +1468,7 @@ end:
  * sme_rrm_msg_processor()-Process RRM message
  * @mac - Pointer to the global MAC parameter structure.
  * @msg_type - the type of msg passed by PE as defined in wni_api.h
- * @pMsgBuf - a pointer to a buffer that maps to various structures base
+ * @msg_buf - a pointer to a buffer that maps to various structures base
  *                  on the message type.
  *                  The beginning of the buffer can always map to tSirSmeRsp.
  * sme_process_msg() calls this function for the
@@ -1477,18 +1477,18 @@ end:
  * Return: QDF_STATUS_SUCCESS - Validation is successful.
  */
 QDF_STATUS sme_rrm_msg_processor(struct mac_context *mac, uint16_t msg_type,
-				 void *pMsgBuf)
+				 void *msg_buf)
 {
 	sme_debug("Msg = %d for RRM measurement", msg_type);
 
 	/* switch on the msg type & make the state transition accordingly */
 	switch (msg_type) {
 	case eWNI_SME_NEIGHBOR_REPORT_IND:
-		sme_rrm_process_neighbor_report(mac, pMsgBuf);
+		sme_rrm_process_neighbor_report(mac, msg_buf);
 		break;
 
 	case eWNI_SME_BEACON_REPORT_REQ_IND:
-		sme_rrm_process_beacon_report_req_ind(mac, pMsgBuf);
+		sme_rrm_process_beacon_report_req_ind(mac, msg_buf);
 		break;
 
 	default: