Browse Source

qcacmn: Remove redundant initialization of array indices

Remove redundant code where some array indices are initialized more
than once

Change-Id: I72414367dad92ccc14a8d0ba9f7660b29eaf8098
CRs-Fixed: 2216642
Akshay Kosigi 7 years ago
parent
commit
41da247986

+ 3 - 9
qdf/linux/src/qdf_trace.c

@@ -2544,7 +2544,7 @@ static void set_default_trace_levels(struct category_info *cinfo)
 		[QDF_MODULE_ID_POWER] = QDF_TRACE_LEVEL_NONE,
 		[QDF_MODULE_ID_STATE] = QDF_TRACE_LEVEL_NONE,
 		[QDF_MODULE_ID_OUTPUT] = QDF_TRACE_LEVEL_NONE,
-		[QDF_MODULE_ID_SCAN] = QDF_TRACE_LEVEL_NONE,
+		[QDF_MODULE_ID_SCAN] = QDF_TRACE_LEVEL_ERROR,
 		[QDF_MODULE_ID_AUTH] = QDF_TRACE_LEVEL_NONE,
 		[QDF_MODULE_ID_ASSOC] = QDF_TRACE_LEVEL_NONE,
 		[QDF_MODULE_ID_NODE] = QDF_TRACE_LEVEL_NONE,
@@ -2598,12 +2598,6 @@ static void set_default_trace_levels(struct category_info *cinfo)
 		[QDF_MODULE_ID_TARGET_IF] = QDF_TRACE_LEVEL_INFO,
 		[QDF_MODULE_ID_SCHEDULER] = QDF_TRACE_LEVEL_NONE,
 		[QDF_MODULE_ID_MGMT_TXRX] = QDF_TRACE_LEVEL_NONE,
-		[QDF_MODULE_ID_PMO] = QDF_TRACE_LEVEL_NONE,
-		[QDF_MODULE_ID_POLICY_MGR] = QDF_TRACE_LEVEL_NONE,
-		[QDF_MODULE_ID_NAN] = QDF_TRACE_LEVEL_NONE,
-		[QDF_MODULE_ID_P2P] = QDF_TRACE_LEVEL_NONE,
-		[QDF_MODULE_ID_OFFCHAN_TXRX] = QDF_TRACE_LEVEL_NONE,
-		[QDF_MODULE_ID_OBJ_MGR] = QDF_TRACE_LEVEL_ERROR,
 		[QDF_MODULE_ID_SERIALIZATION] = QDF_TRACE_LEVEL_NONE,
 		[QDF_MODULE_ID_PMO] = QDF_TRACE_LEVEL_NONE,
 		[QDF_MODULE_ID_P2P] = QDF_TRACE_LEVEL_NONE,
@@ -2615,7 +2609,7 @@ static void set_default_trace_levels(struct category_info *cinfo)
 		[QDF_MODULE_ID_OFFCHAN_TXRX] = QDF_TRACE_LEVEL_NONE,
 		[QDF_MODULE_ID_SON] = QDF_TRACE_LEVEL_NONE,
 		[QDF_MODULE_ID_SPECTRAL] = QDF_TRACE_LEVEL_NONE,
-		[QDF_MODULE_ID_OBJ_MGR] = QDF_TRACE_LEVEL_NONE,
+		[QDF_MODULE_ID_OBJ_MGR] = QDF_TRACE_LEVEL_FATAL,
 		[QDF_MODULE_ID_NSS] = QDF_TRACE_LEVEL_ERROR,
 		[QDF_MODULE_ID_ROAM_DEBUG] = QDF_TRACE_LEVEL_ERROR,
 		[QDF_MODULE_ID_CDP] = QDF_TRACE_LEVEL_NONE,
@@ -2626,7 +2620,7 @@ static void set_default_trace_levels(struct category_info *cinfo)
 		[QDF_MODULE_ID_EXTAP] = QDF_TRACE_LEVEL_NONE,
 		[QDF_MODULE_ID_FD] = QDF_TRACE_LEVEL_ERROR,
 		[QDF_MODULE_ID_OCB] = QDF_TRACE_LEVEL_ERROR,
-		[QDF_MODULE_ID_CONFIG] = QDF_TRACE_LEVEL_ERROR,
+		[QDF_MODULE_ID_IPA] = QDF_TRACE_LEVEL_NONE,
 		[QDF_MODULE_ID_CP_STATS] = QDF_TRACE_LEVEL_ERROR,
 		[QDF_MODULE_ID_ANY] = QDF_TRACE_LEVEL_NONE,
 	};

+ 2 - 2
umac/cmn_services/obj_mgr/src/wlan_objmgr_global_obj.c

@@ -775,11 +775,11 @@ void wlan_objmgr_print_ref_ids(qdf_atomic_t *id)
 	uint32_t i;
 	uint32_t pending_ref;
 
-	obj_mgr_err("Pending references of object");
+	obj_mgr_alert("Pending references of object");
 	for (i = 0; i < WLAN_REF_ID_MAX; i++) {
 		pending_ref = qdf_atomic_read(&id[i]);
 		if (pending_ref)
-			obj_mgr_err("%s -- %d",
+			obj_mgr_alert("%s -- %d",
 				string_from_dbgid(i), pending_ref);
 	}
 

+ 7 - 7
umac/cmn_services/obj_mgr/src/wlan_objmgr_psoc_obj.c

@@ -1869,7 +1869,7 @@ static void wlan_objmgr_psoc_peer_ref_print(struct wlan_objmgr_psoc *psoc,
 	vdev_id = wlan_vdev_get_id(wlan_peer_get_vdev(peer));
 	wlan_peer_obj_unlock(peer);
 
-	obj_mgr_err("Peer MAC is %02x:%02x:%02x:%02x:%02x:%02x state:%d vdev_id:%d",
+	obj_mgr_alert("Peer MAC:%02x:%02x:%02x:%02x:%02x:%02x state:%d vdev_id:%d",
 		  macaddr[0], macaddr[1], macaddr[2], macaddr[3],
 		  macaddr[4], macaddr[5], obj_state, vdev_id);
 	wlan_objmgr_print_ref_ids(peer->peer_objmgr.ref_id_dbg);
@@ -1886,7 +1886,7 @@ static void wlan_objmgr_psoc_vdev_ref_print(struct wlan_objmgr_psoc *psoc,
 	id = wlan_vdev_get_id(vdev);
 	obj_state =  vdev->obj_state;
 	wlan_vdev_obj_unlock(vdev);
-	obj_mgr_err("Vdev ID is %d, state %d", id, obj_state);
+	obj_mgr_alert("Vdev ID is %d, state %d", id, obj_state);
 
 	wlan_objmgr_print_ref_ids(vdev->vdev_objmgr.ref_id_dbg);
 }
@@ -1900,7 +1900,7 @@ static void wlan_objmgr_psoc_pdev_ref_print(struct wlan_objmgr_psoc *psoc,
 	wlan_pdev_obj_lock(pdev);
 	id = wlan_objmgr_pdev_get_pdev_id(pdev);
 	wlan_pdev_obj_unlock(pdev);
-	obj_mgr_err("pdev ID is %d", id);
+	obj_mgr_alert("pdev ID is %d", id);
 
 	wlan_objmgr_print_ref_ids(pdev->pdev_objmgr.ref_id_dbg);
 }
@@ -1908,17 +1908,17 @@ static void wlan_objmgr_psoc_pdev_ref_print(struct wlan_objmgr_psoc *psoc,
 QDF_STATUS wlan_objmgr_print_ref_all_objects_per_psoc(
 		struct wlan_objmgr_psoc *psoc)
 {
-	obj_mgr_err("Ref counts of PEER");
+	obj_mgr_alert("Ref counts of PEER");
 	wlan_objmgr_iterate_obj_list_all_noref(psoc, WLAN_PEER_OP,
 				wlan_objmgr_psoc_peer_ref_print, NULL);
-	obj_mgr_err("Ref counts of VDEV");
+	obj_mgr_alert("Ref counts of VDEV");
 	wlan_objmgr_iterate_obj_list_all_noref(psoc, WLAN_VDEV_OP,
 				wlan_objmgr_psoc_vdev_ref_print, NULL);
-	obj_mgr_err("Ref counts of PDEV");
+	obj_mgr_alert("Ref counts of PDEV");
 	wlan_objmgr_iterate_obj_list_all_noref(psoc, WLAN_PDEV_OP,
 				wlan_objmgr_psoc_pdev_ref_print, NULL);
 
-	obj_mgr_err(" Ref counts of PSOC");
+	obj_mgr_alert(" Ref counts of PSOC");
 	wlan_objmgr_print_ref_ids(psoc->soc_objmgr.ref_id_dbg);
 
 	return QDF_STATUS_SUCCESS;